[00:00:55] 10Citoid, 10VisualEditor, 10User-Ryasmeen, 10goodfirstbug: Add 'v' flag to twitter upstream in https://github.com/zotero/translators - https://phabricator.wikimedia.org/T78785 (10matmarex) 05Open>03Resolved Presumably this was fixed in 2017 by . (Please... [00:01:24] 10Citoid, 10VisualEditor: Strip trailing slashes in url field - https://phabricator.wikimedia.org/T93311 (10matmarex) [00:07:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018, 10goodfirstbug: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - https://phabricator.wikimedia.org/T72559 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [00:38:27] 10VisualEditor, 10VisualEditor-LanguageTool, 10User-Ryasmeen: rename this.$findResults in mw.languageToolAction - https://phabricator.wikimedia.org/T105268 (10matmarex) 05Open>03Resolved ext.LanguageToolAction.js was removed in {76aa7ee8f31b039a944be7482fbd6c74817ce6d0}. I don't see a property by this na... [00:38:32] 10VisualEditor, 10VisualEditor-LanguageTool, 10User-Ryasmeen: reconsider the use of this.surfaceModel in mw.languageToolAction - https://phabricator.wikimedia.org/T105269 (10matmarex) 05Open>03Resolved ext.LanguageToolAction.js was removed in {76aa7ee8f31b039a944be7482fbd6c74817ce6d0}. I don't see a prop... [00:38:37] 10VisualEditor, 10VisualEditor-LanguageTool, 10User-Ryasmeen, 10goodfirstbug: this.ignoredRulesIds doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105270 (10matmarex) 05Open>03Resolved ext.LanguageToolAction.js was removed in {76aa7ee8f31b039a944be7482fbd6c74817ce6... [00:38:42] 10VisualEditor, 10VisualEditor-LanguageTool, 10User-Ryasmeen, 10goodfirstbug: this.fragments doesn't seem to be used in mw.languageToolAction - https://phabricator.wikimedia.org/T105271 (10matmarex) 05Open>03Resolved ext.LanguageToolAction.js was removed in {76aa7ee8f31b039a944be7482fbd6c74817ce6d0}. I... [00:38:45] 10VisualEditor, 10VisualEditor-LanguageTool, 10User-Ryasmeen: suggestion variable initialization in mw.languageToolAction.prototype.processXML should use the dot notation - https://phabricator.wikimedia.org/T105272 (10matmarex) 05Open>03Resolved ext.LanguageToolAction.js was removed in {76aa7ee8f31b039a9... [00:50:06] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 10Tracking: Broken browser plugins cause cruft to be injected into the page (tracking) - https://phabricator.wikimedia.org/T54327 (10MGChecker) If you don't replace a tracking bug with anything, you lose a useful feature to navigate betwee... [01:26:59] 10VisualEditor, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Israel-Hackers, and 2 others: Using the language link tool in the sidebar when inside VisualEditor loses the edit without warning - https://phabricator.wikimedia.org/T64005 (10matmarex) 05Open>03Resolved I think this is no l... [02:02:21] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10Browser-Support-Apple-Safari, and 2 others: Blacklist mobile Safari's horrendous `webkit-fake-url ` nonsense on paste - https://phabricator.wikimedia.org/T118364 (10matmarex) 05Open>03declined a:03matmarex I think this is no... [03:06:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Technical-Debt: Tech debt: Clean up "minerva" folder theme in VE-mw - https://phabricator.wikimedia.org/T96704 (10matmarex) a:03matmarex I found this task while looking for easy tasks for GCI students (story points = 1), but the solution wasn't obvious, an... [03:07:04] (03PS1) 10Bartosz Dziewoński: Move styles that are not theme-wide out of themes/ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469158 (https://phabricator.wikimedia.org/T96704) [03:29:39] 10VisualEditor, 10Math, 10Need-volunteer, 10goodfirstbug: Buttons don't fit in math formula editing popup - https://phabricator.wikimedia.org/T205830 (10matmarex) Indeed the problem also affects language variant context menus. I just found T188823, I'll merge this task into it. [03:33:07] 10VisualEditor, 10I18n: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) [03:33:18] 10VisualEditor, 10I18n: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) [03:33:20] 10VisualEditor, 10Math, 10Need-volunteer, 10goodfirstbug: Buttons don't fit in math formula editing popup - https://phabricator.wikimedia.org/T205830 (10matmarex) [03:34:35] 10VisualEditor, 10I18n: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) [03:41:25] 10VisualEditor, 10Google-Code-in-2018, 10I18n: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [03:43:16] 10VisualEditor, 10Google-Code-in-2018, 10I18n: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10matmarex) [03:50:50] 10VisualEditor, 10Technical-Debt, 10User-Ryasmeen: Remove or deprecate unused ve.getHtmlAttributes and ve.getOpeningHtmlTag? - https://phabricator.wikimedia.org/T114770 (10matmarex) 05Open>03Resolved They have been removed in {972cde4b115c43b2a50965c29717e3439f4051a5}. [03:56:57] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10User-Ryasmeen: Templates that contain a colon in their names gain an extra colon while edited in VE - https://phabricator.wikimedia.org/T119805 (10matmarex) 05Open>03Resolved This seems to no longer be a problem. It was probably fixed by the patches f... [04:04:40] 10Citoid, 10VisualEditor, 10goodfirstbug: Remove line feed characters in title (and possible other fields?) - https://phabricator.wikimedia.org/T98902 (10matmarex) [04:04:43] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Citoid should down-convert odd whitespace (e.g. line feed characters) on inserting - https://phabricator.wikimedia.org/T126968 (10matmarex) [04:07:23] 10Citoid, 10VisualEditor, 10goodfirstbug: Remove line feed characters in title (and possible other fields?) - https://phabricator.wikimedia.org/T98902 (10matmarex) I've tried to reproduce this issue, but the URL in the task description (http://www.juntadeandalucia.es/presidencia/portavoz/gobierno/114816/susa... [04:12:20] 10Citoid, 10VisualEditor, 10goodfirstbug: Remove line feed characters in title (and possible other fields?) - https://phabricator.wikimedia.org/T98902 (10matmarex) I tested with a temporary page I hosted and this is still a problem. You can reproduce with a page containing this HTML: ``` Newline test<... [04:17:09] <wikibugs> 10VisualEditor, 10SyntaxHighlight: Make language identification for a code block is case insensitive in VE - https://phabricator.wikimedia.org/T125231 (10matmarex) This is still a problem, although less severe: the code block appears in VE and can be edited, but after opening the dialog, the language name is c... [04:21:47] <wikibugs> 10VisualEditor, 10SyntaxHighlight, 10Google-Code-in-2018: Make language identification for a code block is case insensitive in VE - https://phabricator.wikimedia.org/T125231 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [04:26:17] <wikibugs> 10VisualEditor, 10VisualEditor-DataModel, 10User-Ryasmeen: VisualEditor: Ref group does not get updated when the group name is changed from References List dialog - https://phabricator.wikimedia.org/T63396 (10matmarex) 05Open>03Resolved This appears fixed, although I have no idea which patch and when cou... [04:31:59] <wikibugs> 10VisualEditor, 10VisualEditor-EditingTools, 10Design, 10User-Ryasmeen: VisualEditor: Make it clear that invalid settings in the media dialog won't be set when "apply changes" button is clicks - https://phabricator.wikimedia.org/T62602 (10matmarex) 05Open>03Resolved This has been fixed in {20c4fbbc1e1f... [04:40:31] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it - https://phabricator.wikimedia.org/T74971 (10matmarex) This is still a problem. Typing in an invalid page title (... [04:40:43] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it - https://phabricator.wikimedia.org/T74971 (10matmarex) I would like to mentor this task... [04:44:17] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled - https://phabricator.wikimedia.org/T207719 (10matmarex) [04:44:33] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled - https://phabricator.wikimedia.org/T207719 (10matmarex) [04:45:05] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it - https://phabricator.wikimedia.org/T74971 (10matmarex) [04:45:08] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled - https://phabricator.wikimedia.org/T207719 (10matmarex) [04:59:17] <wikibugs> 10VisualEditor, 10Contributors-Team, 10Design, 10MobileFrontend (MobileFrontend Special Pages), and 4 others: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484 (10matmarex) 05Open>03Resolved I think there is no reason to keep this task open after nearly fiv... [05:00:37] <wikibugs> (03PS1) 10Samwilson: Ignore bang magic word in table syntax when guessing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/469162 (https://phabricator.wikimedia.org/T157029) [05:01:00] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-Disambiguator: In the "Page Settings" menu, "This is a disambiguation page" is not adequately explained to the user - https://phabricator.wikimedia.org/T187116 (10matmarex) I don't think this is a good task for the #easy tag,... [05:03:26] <wikibugs> 10TemplateData, 10VisualEditor, 10Google-Code-in-2018, 10goodfirstbug: Please strip leading spaces from the TemplateData GUI - https://phabricator.wikimedia.org/T177973 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [05:03:37] <wikibugs> 10VisualEditor, 10VisualEditor-Tables, 10Google-Code-in-2018, 10goodfirstbug: Edit visual editor table cell by pressing F2 - https://phabricator.wikimedia.org/T172042 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [05:09:36] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Slightly strange behaviour around removing image from gallery using VE (gallery dialog normalizes everything it touched) - https://phabricator.wikimedia.org/T207620 (10matmarex) [05:09:48] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Slightly strange behaviour around removing image from gallery using VE (gallery dialog normalizes everything it touched) - https://phabricator.wikimedia.org/T207620 (10matmarex) [05:11:51] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled - https://phabricator.wikimedia.org/T207719 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [05:43:37] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018, 10goodfirstbug: The font size of headings in the "Format" dropdown doesn't match the font size in the page content (in MonoBook skin) - https://phabricator.wikimedia.org/T72559 (10matmarex) [05:45:17] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018, 10goodfirstbug: The font size of headings in the "Format" dropdown doesn't match the font size in the page content (in MonoBook skin) - https://phabricator.wikimedia.org/T72559 (10matmarex) https://codein.withgoogle.com/dashboard/tasks/674521... [05:47:48] <wikibugs> 10VisualEditor, 10SyntaxHighlight, 10Google-Code-in-2018: Make language identification for a code block is case insensitive in VE - https://phabricator.wikimedia.org/T125231 (10matmarex) https://codein.withgoogle.com/dashboard/tasks/6009549489176576/ [05:49:52] <wikibugs> 10VisualEditor, 10VisualEditor-Tables, 10Google-Code-in-2018, 10goodfirstbug: Edit visual editor table cell by pressing F2 - https://phabricator.wikimedia.org/T172042 (10matmarex) https://codein.withgoogle.com/dashboard/tasks/5774941732470784/ [05:51:26] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: Make editing sortkeys easier in the Categories dialog by using the article title as the default value - https://phabricator.wikimedia.org/T145339 (10matmarex) [05:52:59] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: Make editing sortkeys easier in the Categories dialog by using the article title as the default value - https://phabricator.wikimedia.org/T145339 (10matmarex) https://codein.withgoogle.com/dashboard/tasks/6392453792792576/ [08:47:09] <wikibugs> 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193 (10Lionel_Scheepmans) 05duplicate>03Open p:05Triage>03High Hi, Visual Editor is still not in use on every namespaces of fr.wikiversity. The community de... [09:17:17] <wikibugs> 10Citoid: Enable citoid on fr.wikiversity - https://phabricator.wikimedia.org/T198191 (10Lionel_Scheepmans) p:05Normal>03High Thanks a lot for your help ! Actually, citdoid display woks on fr.wikiversity find and build the reference {F26726207} while it's works corectlly on fr.wikipedia with the same URL. {... [09:31:43] <wikibugs> 10VisualEditor: Extension of the Visual Editor namespaces on the French Wikiversity - https://phabricator.wikimedia.org/T126561 (10Urbanecm) [09:31:45] <wikibugs> 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193 (10Urbanecm) [09:37:07] <wikibugs> 10VisualEditor: Extension of the Visual Editor namespaces on the French Wikiversity to "Project" (ns102) - https://phabricator.wikimedia.org/T182669 (10Urbanecm) p:05High>03Triage Resetting priority back to Needs Triage. Please do not change it unless you plan to work on this task. Thanks! [09:37:16] <wikibugs> 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193 (10Urbanecm) @Lionel_Scheepmans Hi, this task was closed as "Duplicate of {T126561}". This task has the same scope like {T126561, so this task should be closed,... [09:37:36] <wikibugs> 10VisualEditor: Extension of the Visual Editor namespaces on the French Wikiversity to "Project" (ns102) - https://phabricator.wikimedia.org/T182669 (10Urbanecm) [09:37:38] <wikibugs> 10VisualEditor: Extension of the Visual Editor namespaces on the French Wikiversity - https://phabricator.wikimedia.org/T126561 (10Urbanecm) [09:58:10] <wikibugs> (03CR) 10Esanders: "Hmm - tests run fine locally, but are failing here. Will comment out for now as we test them in core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [09:59:11] <wikibugs> (03PS5) 10Esanders: Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [10:01:01] <wikibugs> (03CR) 10Esanders: Always run event logging code in debug mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) (owner: 10Esanders) [10:04:15] <wikibugs> (03PS4) 10Esanders: Always run event logging code in debug mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) [10:05:52] <wikibugs> (03CR) 10Esanders: [C: 032] Move styles that are not theme-wide out of themes/ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469158 (https://phabricator.wikimedia.org/T96704) (owner: 10Bartosz Dziewoński) [10:11:30] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [10:13:44] <wikibugs> 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193 (10Lionel_Scheepmans) >>! In T198193#4688237, @Urbanecm wrote: > @Lionel_Scheepmans Hi, this task was closed as "Duplicate of {T126561}". This task has the same... [10:28:34] <wikibugs> (03Merged) 10jenkins-bot: Move styles that are not theme-wide out of themes/ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469158 (https://phabricator.wikimedia.org/T96704) (owner: 10Bartosz Dziewoński) [10:31:44] <wikibugs> (03CR) 10jenkins-bot: Move styles that are not theme-wide out of themes/ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469158 (https://phabricator.wikimedia.org/T96704) (owner: 10Bartosz Dziewoński) [10:43:17] <wikibugs> (03PS6) 10Esanders: Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [10:51:21] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [11:08:44] <wikibugs> (03PS1) 10Esanders: ve.ce.Surface tests: Trim when asserting expected text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469188 [11:10:44] <wikibugs> (03CR) 10Divec: [C: 032] ve.ce.Surface tests: Trim when asserting expected text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469188 (owner: 10Esanders) [11:12:47] <wikibugs> (03Merged) 10jenkins-bot: ve.ce.Surface tests: Trim when asserting expected text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469188 (owner: 10Esanders) [11:15:32] <wikibugs> (03CR) 10jenkins-bot: ve.ce.Surface tests: Trim when asserting expected text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469188 (owner: 10Esanders) [11:40:38] <wikibugs> (03PS1) 10Esanders: DNM finally polyfill [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 [11:46:54] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] DNM finally polyfill [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 (owner: 10Esanders) [13:25:54] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it - https://phabricator.wikimedia.org/T74971 (10Aklapper) [13:26:39] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it - https://phabricator.wikimedia.org/T74971 (10Aklapper) https://codein.withgoogle.com/tas... [13:30:23] <wikibugs> 10TemplateData, 10VisualEditor, 10Google-Code-in-2018, 10goodfirstbug: Please strip leading spaces from the TemplateData GUI - https://phabricator.wikimedia.org/T177973 (10Aklapper) https://codein.withgoogle.com/tasks/5995431646461952/ [13:35:16] <wikibugs> 10VisualEditor, 10Google-Code-in-2018, 10I18n: Button in language variant node's context menu disappears when translated text is long - https://phabricator.wikimedia.org/T188823 (10Aklapper) https://codein.withgoogle.com/tasks/4959060886552576/ [13:37:59] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled - https://phabricator.wikimedia.org/T207719 (10Aklapper) [13:38:08] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled - https://phabricator.wikimedia.org/T207719 (10Aklapper) https://codein.withgoogle.com/tasks/4573690701283328/ [13:44:18] <wikibugs> (03CR) 10Anomie: "Code looks good, although I'd still recommend checking for mw.title objects in the Lua wrapper (see comment on PS1 line 5). Haven't tested" (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [14:09:13] <wikibugs> 10VisualEditor: VisualEditor does not support shared uploads - https://phabricator.wikimedia.org/T207752 (10Ascotmonth) [14:12:39] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018, 10goodfirstbug: The font size of headings in the "Format" dropdown doesn't match the font size in the page content (in MonoBook skin) - https://phabricator.wikimedia.org/T72559 (10Aklapper) [14:34:20] <wikibugs> (03PS5) 10Divec: Remove dedicated annotation operation types [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463048 (https://phabricator.wikimedia.org/T205535) [14:38:11] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10Patch-For-Review, and 2 others: Tech debt: Clean up "minerva" folder theme in VE-mw - https://phabricator.wikimedia.org/T96704 (10matmarex) 05Open>03Resolved [14:39:00] <wikibugs> (03PS38) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [14:39:15] <wikibugs> (03PS39) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [14:41:58] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [14:43:40] <wikibugs> (03PS40) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [16:08:12] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it - https://phabricator.wikimedia.org/T74971 (10matmarex) [16:11:00] <wikibugs> 10TemplateData, 10VisualEditor, 10Google-Code-in-2018, 10goodfirstbug: Please strip leading spaces from the "format" field in TemplateData GUI - https://phabricator.wikimedia.org/T177973 (10matmarex) [16:16:58] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018, 10goodfirstbug: The font size of headings in the "Format" dropdown doesn't match the font size in the page content (in MonoBook skin) - https://phabricator.wikimedia.org/T72559 (10matmarex) [16:31:27] <wikibugs> 10VisualEditor: VisualEditor does not support shared uploads - https://phabricator.wikimedia.org/T207752 (10Ascotmonth) MediaWiki version: 1.31.1 VisualEditor version: 0.1.0 (13a585a) [18:49:51] <wikibugs> (03PS7) 10Jforrester: Update VE core submodule to master (6c288b44f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) [19:03:47] <wikibugs> (03CR) 10Jforrester: [C: 032] "Finally." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [19:42:38] <wikibugs> (03Merged) 10jenkins-bot: Update VE core submodule to master (6c288b44f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [19:46:20] <wikibugs> (03CR) 10jenkins-bot: Update VE core submodule to master (6c288b44f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [19:54:27] <wikibugs> 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearArrowKeyDownHandler - https://phabricator.wikimedia.org/T207077 (10Jdforrester-WMF) Now at 91.89% (68/74). Is that good enough? [19:54:51] <wikibugs> 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearArrowKeyDownHandler - https://phabricator.wikimedia.org/T207077 (10Jdforrester-WMF) [19:55:54] <wikibugs> 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearDeleteKeyDownHandler - https://phabricator.wikimedia.org/T207078 (10Jdforrester-WMF) Now at 92.78% (90/97). Is that good enough? [19:56:34] <wikibugs> 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler - https://phabricator.wikimedia.org/T207079 (10Jdforrester-WMF) Now at 90.22% (83/92). Is that good enough? [19:59:24] <wikibugs> 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter - https://phabricator.wikimedia.org/T207080 (10Jdforrester-WMF) Now all at 100% statem... [20:00:41] <wikibugs> 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Investigation spike to add test coverage for ve.ce.FocusableNode - https://phabricator.wikimedia.org/T207083 (10Jdforrester-WMF) Now at 71.59% (194/271). Is that good enough? [20:43:14] <wikibugs> (03CR) 10DLynch: [C: 04-1] "Rebasing this over Roan's event-sampling patch has changed the impact of the patch. As-is, it'll always register the event logging handler" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) (owner: 10Esanders) [20:46:24] <wikibugs> (03CR) 10Catrope: "> Patch Set 4: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) (owner: 10Esanders) [20:46:55] <wikibugs> 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Investigation spike to add test coverage for ve.ce.FocusableNode - https://phabricator.wikimedia.org/T207083 (10matmarex) a:05matmarex>03Esanders (Looks like Ed has taken this over from me, I haven'... [20:47:01] <wikibugs> 10VisualEditor: Add flag to log tracking events to console - https://phabricator.wikimedia.org/T207796 (10DLynch) [20:58:20] <wikibugs> (03CR) 10DLynch: [C: 04-1] "In terms of distorting effects, I'd have thought it'd be better to have debug=1 suppress event-logging, given that it's probably a pretty " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) (owner: 10Esanders) [21:02:30] <wikibugs> (03PS5) 10Putnik: Lua method for TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) [21:04:53] <wikibugs> (03Abandoned) 10Jforrester: DNM finally polyfill [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 (owner: 10Esanders) [21:43:50] <wikibugs> 10VisualEditor: VisualEditor does not support shared uploads - https://phabricator.wikimedia.org/T207752 (10matmarex) We definitely support foreign files in other cases (e.g. on Wikipedia, you will get results from Commons), so I looked over the code to see why it wouldn't be the case here. (See [mediawiki/core]... [21:45:36] <wikibugs> (03Restored) 10Esanders: DNM finally polyfill [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 (owner: 10Esanders) [21:45:42] <wikibugs> (03PS2) 10Esanders: DNM finally polyfill [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 [21:49:46] <wikibugs> (03PS3) 10Esanders: DNM finally polyfill [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 [21:53:54] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/469296 (owner: 10L10n-bot) [21:58:37] <wikibugs> 10VisualEditor, 10VisualEditor-EditingTools, 10Design, 10User-Ryasmeen, 10Verified: VisualEditor: Make it clear that invalid settings in the media dialog won't be set when "apply changes" button is clicks - https://phabricator.wikimedia.org/T62602 (10Ryasmeen) [22:16:27] <wikibugs> (03PS4) 10Esanders: Add Promise.prototype.finally polyfill and restore failing tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 [22:19:34] <wikibugs> (03PS1) 10Esanders: Add missing ce.Selection tests from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469336 [22:22:49] <wikibugs> (03CR) 10Jforrester: [C: 032] Add Promise.prototype.finally polyfill and restore failing tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 (owner: 10Esanders) [22:28:54] <wikibugs> 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Can't drag a collapsed selection across a reference on mobile - https://phabricator.wikimedia.org/T204387 (10Esanders) See also T136840 [22:43:52] <wikibugs> (03CR) 10Jforrester: [C: 032] Add missing ce.Selection tests from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469336 (owner: 10Esanders) [22:54:12] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Readers-Web-Backlog (Design): Abort dialog in mobile editing should feature primary destructive button - https://phabricator.wikimedia.org/T192333 (10Esanders) We use this text in VE: {F26221761} Happy to tweak th... [23:25:32] <wikibugs> (03Merged) 10jenkins-bot: Add Promise.prototype.finally polyfill and restore failing tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 (owner: 10Esanders) [23:29:31] <wikibugs> (03CR) 10jenkins-bot: Add Promise.prototype.finally polyfill and restore failing tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469192 (owner: 10Esanders) [23:48:17] <wikibugs> (03Merged) 10jenkins-bot: Add missing ce.Selection tests from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469336 (owner: 10Esanders) [23:52:55] <wikibugs> (03CR) 10jenkins-bot: Add missing ce.Selection tests from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469336 (owner: 10Esanders)