[02:35:32] (03CR) 10VolkerE: "Why 0.05px and not 0.01?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462747 (owner: 10Esanders) [04:03:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Multimedia, and 4 others: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031 (10Aklapper) @Thedonquixotic : This task is resolved (see top bar). If something does not work for you, see ht... [06:44:26] 10VisualEditor: "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." - https://phabricator.wikimedia.org/T208189 (10Kerry_Raymond) [07:04:57] 10VisualEditor: Third-party browser add-on adds [javascript:] within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10Aklapper) [07:13:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470315 (owner: 10L10n-bot) [07:21:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Multimedia, and 4 others: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031 (10Thedonquixotic) @Aklapper Understood. [09:01:34] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Extension-MobileApp, and 2 others: Add ability to cite books by scanning their ISBN barcode in mobile app. - https://phabricator.wikimedia.org/T208134 (10Schnark) I myself am successfully using a JS compilation of zbar: https://github.com/Schnark... [10:20:57] (03CR) 10Esanders: Change#squash: Compact multiple transactions into one (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [10:22:14] (03CR) 10Esanders: [C: 04-1] "Range & Selection .clone methods were deliberately removed / not implemented because they are supposed to be immutable." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [10:48:56] (03CR) 10Esanders: [C: 032] Define localisation messages for File namespace edit tab in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467008 (https://phabricator.wikimedia.org/T206892) (owner: 10Bartosz Dziewoński) [10:49:00] (03CR) 10Esanders: [C: 032] Use the right localisation message for edit tab on Vector skin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467009 (https://phabricator.wikimedia.org/T206892) (owner: 10Bartosz Dziewoński) [10:49:04] (03CR) 10Esanders: [C: 032] Simplify handling of messages for section edit links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467010 (owner: 10Bartosz Dziewoński) [11:02:12] (03Merged) 10jenkins-bot: Define localisation messages for File namespace edit tab in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467008 (https://phabricator.wikimedia.org/T206892) (owner: 10Bartosz Dziewoński) [11:02:36] (03Merged) 10jenkins-bot: Use the right localisation message for edit tab on Vector skin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467009 (https://phabricator.wikimedia.org/T206892) (owner: 10Bartosz Dziewoński) [11:02:39] (03Merged) 10jenkins-bot: Simplify handling of messages for section edit links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467010 (owner: 10Bartosz Dziewoński) [11:05:19] (03CR) 10jenkins-bot: Define localisation messages for File namespace edit tab in visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467008 (https://phabricator.wikimedia.org/T206892) (owner: 10Bartosz Dziewoński) [11:07:58] (03CR) 10jenkins-bot: Use the right localisation message for edit tab on Vector skin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467009 (https://phabricator.wikimedia.org/T206892) (owner: 10Bartosz Dziewoński) [11:11:43] (03CR) 10jenkins-bot: Simplify handling of messages for section edit links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467010 (owner: 10Bartosz Dziewoński) [11:15:59] 10Citoid, 10Knowledge-Integrity, 10Wikidata, 10Epic: Add wikibase export format to citoid service - https://phabricator.wikimedia.org/T208213 (10Mvolz) p:05Triage>03Normal [11:16:16] 10Citoid, 10Knowledge-Integrity, 10Services, 10Wikidata, 10Epic: Add wikibase export format to citoid service - https://phabricator.wikimedia.org/T208213 (10Mvolz) [12:00:40] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-notice: Allow arbitrary search strings in citoid - https://phabricator.wikimedia.org/T198567 (10iamjessklein) +1 from me. [12:36:08] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-notice: Allow arbitrary search strings in citoid - https://phabricator.wikimedia.org/T198567 (10Mvolz) >>! In T198567#4702502, @iamjessklein wrote: > +1 from me. Thanks! [12:38:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Math calculations in infoboxes break horribly in VisualEditor source code previews - https://phabricator.wikimedia.org/T208160 (10TheDJ) 05Open>03Invalid This page gives the exact same results in Special:ExpandTemplates. This indicates the proble... [13:07:04] (03PS3) 10Esanders: Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) [13:11:29] (03CR) 10jerkins-bot: [V: 04-1] Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) (owner: 10Esanders) [13:13:25] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): [Regression pre-wmf.18] Toolbar does not get activated after pressing return - https://phabricator.wikimedia.org/T202359 (10Esanders) I can reproduce the browser tab crashing, alarmingly even with JS disabled: 1. Open a docum... [13:40:05] 10VisualEditor, 10VisualEditor-DataModel, 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Cannot read property 'shallowCloneFromRange' of null - https://phabricator.wikimedia.org/T202714 (10Petar.petkovic) a:03Petar.petkovic Error `Cannot read property 'shallowCloneFromRange'... [14:05:49] 10VisualEditor: EPIC: Synthesize + Share VE Brainstorms and Plan Next Steps - https://phabricator.wikimedia.org/T207519 (10marcella) [14:12:05] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): [Regression pre-wmf.18] Toolbar does not get activated after pressing return - https://phabricator.wikimedia.org/T202359 (10Esanders) Removing `display:inline-block` form the hiero seems to fix this *shrugs*. [14:20:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I left comments inline in the code (click on the file name "ve.ui.MWMetaDialog.js" above to view them)." (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [14:26:40] (03CR) 10Esanders: "handleObservedChanges isn't really covered by our test suites when it comes to selection changes :( hopefully we can fix that this quarter" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) (owner: 10Esanders) [14:32:51] 10VisualEditor-MediaWiki, 10MinervaNeue, 10Patch-For-Review, 10VisualEditor (Current work): Improve compatibility of desktop VisualEditor with desktop Minerva skin - https://phabricator.wikimedia.org/T208102 (10marcella) [14:46:00] 10Citoid, 10Knowledge-Integrity, 10Services, 10Wikidata, 10Epic: Add wikibase export format to citoid service - https://phabricator.wikimedia.org/T208213 (10Mvolz) [14:46:27] (03PS4) 10Esanders: Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) [14:54:25] 10VisualEditor, 10VisualEditor-DataModel: DM Selections should not cache document model data - https://phabricator.wikimedia.org/T208228 (10dchan) [14:55:51] (03PS2) 10DLynch: Analytics: track more things for Growth [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469631 (https://phabricator.wikimedia.org/T207802) [15:01:56] (03PS2) 10Esanders: Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) [15:04:58] (03CR) 10Divec: "Done (I also filed T208228 "DM Selections should not cache document model data", because in the context of manipulating transactions it is" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [15:05:14] (03PS45) 10Divec: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [15:06:02] 10VisualEditor: Request community input on interventions - https://phabricator.wikimedia.org/T208129 (10Whatamidoing-WMF) p:05Triage>03High [15:08:13] (03CR) 10Esanders: "This is really hard to write a test case for, because (1) what we are asserting is in the originalDomElements, not the model and (2) the v" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [15:08:17] (03CR) 10jerkins-bot: [V: 04-1] Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [15:21:53] (03PS3) 10DLynch: Analytics: track more things for Growth [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469631 (https://phabricator.wikimedia.org/T207802) [15:33:49] (03CR) 10jerkins-bot: [V: 04-1] Analytics: track more things for Growth [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469631 (https://phabricator.wikimedia.org/T207802) (owner: 10DLynch) [15:35:03] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469631 (https://phabricator.wikimedia.org/T207802) (owner: 10DLynch) [15:38:45] (03CR) 10Kosta Harlan: [C: 04-1] Update EventLogging code for Edit->Edit2 schema migration (035 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [15:42:06] (03CR) 10Kosta Harlan: [C: 04-1] Update EventLogging code for Edit->Edit2 schema migration (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [15:49:59] (03CR) 10Kosta Harlan: [C: 031] Update EventLogging code for Edit->Edit2 schema migration (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [15:51:22] (03CR) 10Kosta Harlan: [C: 04-1] Update EventLogging code for Edit->Edit2 schema migration (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [16:23:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Math calculations in infoboxes break horribly in VisualEditor source code previews - https://phabricator.wikimedia.org/T208160 (10TheDJ) Note, this is due to Template:For nowiki, used by Template:Infobox_number/range.. not sure why there is a transcl... [16:24:17] (03CR) 10Kosta Harlan: [C: 031] Update EventLogging code for Edit->Edit2 schema migration (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [16:43:14] 10VisualEditor: Add a citation in VE is a confusing workflow - https://phabricator.wikimedia.org/T208153 (10matmarex) [16:43:19] 10Citoid, 10VisualEditor, 10VisualEditor-EditingTools: Insert citations automatically after generating and show citation to edit it afterwards - https://phabricator.wikimedia.org/T173437 (10matmarex) [17:04:40] 10VisualEditor: "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." - https://phabricator.wikimedia.org/T208189 (10matmarex) If you see this error in the visual editor, that is very unexpected. We've had a problem recently (now fixed) where this error wa... [17:06:37] (03CR) 10Flutterish: "Apply changes" is now only enabled after making changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [17:21:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Apply changes" is now only enabled after making changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [17:47:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Apply changes" is now only enabled after making changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [18:07:18] (03PS2) 10Catrope: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) [18:09:41] (03PS2) 10Catrope: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) [18:20:22] (03PS3) 10Catrope: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) [18:20:24] 10VisualEditor: Vote on and Refine interventions and discuss technical response - https://phabricator.wikimedia.org/T208128 (10iamjessklein) @Whatamidoing-WMF can you link to the wiki where this share-out will happen? [18:20:32] (03CR) 10Catrope: "a" (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [18:21:25] (03PS1) 10Divec: Refactor ve.ce.*Selection#getDirectionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470449 (https://phabricator.wikimedia.org/T208228) [18:33:21] (03PS3) 10Flutterish: "Apply changes" is now only enabled after making changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) [18:38:11] (03PS4) 10Catrope: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) [18:38:18] (03PS3) 10Catrope: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) [18:38:34] (03CR) 10jerkins-bot: [V: 04-1] Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [18:38:36] (03CR) 10jerkins-bot: [V: 04-1] Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [18:39:54] (03CR) 10Catrope: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [18:40:19] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [19:02:30] (03CR) 10jerkins-bot: [V: 04-1] Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [19:05:03] (03CR) 10Kosta Harlan: [C: 032] Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [19:07:03] (03PS4) 10Catrope: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) [19:25:43] (03Merged) 10jenkins-bot: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/470068 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [19:35:31] (03PS1) 10Divec: [BREAKING CHANGE] Do not cache document model data in DM selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470456 (https://phabricator.wikimedia.org/T208228) [19:36:16] (03CR) 10Kosta Harlan: [C: 032] Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [19:54:20] (03PS1) 10Divec: Use changed ve.dm.Selection interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470460 (https://phabricator.wikimedia.org/T208228) [19:55:46] (03CR) 10Jforrester: [C: 032] Update .gitignore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470174 (owner: 10Divec) [19:59:44] (03Merged) 10jenkins-bot: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [20:00:23] (03Merged) 10jenkins-bot: Update .gitignore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470174 (owner: 10Divec) [20:02:39] (03CR) 10jenkins-bot: Update .gitignore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470174 (owner: 10Divec) [20:03:36] (03CR) 10jenkins-bot: Update EventLogging code for Edit->EditAttemptStep schema migration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470067 (https://phabricator.wikimedia.org/T207803) (owner: 10Catrope) [20:12:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thanks! I have one more big suggestion for the extractSettings() function, and some minor nit-picks." (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [20:12:13] (03CR) 10Bartosz Dziewoński: [C: 04-1] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [20:16:47] 10Citoid, 10Knowledge-Integrity, 10Wikidata, 10Core Platform Team Backlog (Watching / External), and 2 others: Add wikibase export format to citoid service - https://phabricator.wikimedia.org/T208213 (10mobrovac) +1 to the idea. We could then have ref import/export to/fro WB and WP and other utilities. Da... [20:24:36] (03CR) 10jerkins-bot: [V: 04-1] "Apply changes" is now only enabled after making changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [20:24:38] (03CR) 10Flutterish: "Apply changes" is now only enabled after making changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [20:26:25] (03CR) 10Jforrester: [C: 032] build: Updating mediawiki/phan-taint-check-plugin to 1.5.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469963 (owner: 10Umherirrender) [20:30:10] (03PS1) 10Divec: Use changed ve.dm.Selection interface [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/470463 (https://phabricator.wikimedia.org/T208228) [20:41:53] (03Merged) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.5.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469963 (owner: 10Umherirrender) [20:44:26] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.5.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469963 (owner: 10Umherirrender) [21:01:10] (03PS4) 10Flutterish: "Apply changes" is now only enabled after making changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) [21:04:15] (03PS5) 10Flutterish: "Apply changes" is now only enabled after making changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) [21:37:02] (03PS3) 10Esanders: Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) [21:38:37] (03CR) 10Esanders: "Circular dependency on Cite tests :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [21:41:50] (03CR) 10Esanders: "Cite fixed in I06177cb4428798f62b78f5dc48f545a6cb6884fc, but something will need to be V+2 manually." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [21:42:48] (03CR) 10Jforrester: [C: 032] Start showing warning for deprecated PHP entry point [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/470025 (owner: 10Umherirrender) [21:43:39] (03CR) 10jerkins-bot: [V: 04-1] Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [21:59:58] (03PS1) 10Jforrester: Update VE core submodule to master (0109dc726) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470508 [22:08:24] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (0109dc726) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470508 (owner: 10Jforrester) [22:20:09] (03PS6) 10Bartosz Dziewoński: "Apply changes" is now only enabled after making changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [22:20:17] (03CR) 10Jforrester: [V: 032 C: 032] Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [22:22:32] (03CR) 10Bartosz Dziewoński: "I made a few code style changes (in particular, fixing ESLint errors that would have prevented the patch from being merged)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [22:22:59] (03CR) 10jenkins-bot: Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [22:23:33] (03CR) 10Bartosz Dziewoński: "You can view the comparison of changes I made: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/470254/5..6/modules/ve" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [22:27:09] (03Merged) 10jenkins-bot: Start showing warning for deprecated PHP entry point [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/470025 (owner: 10Umherirrender) [22:39:11] (03CR) 10jenkins-bot: Start showing warning for deprecated PHP entry point [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/470025 (owner: 10Umherirrender) [22:46:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Okay, this is definitely the last round of review. Can you also move the function descriptions from the commit message to the documentatio" (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470254 (https://phabricator.wikimedia.org/T207719) (owner: 10Flutterish) [22:57:03] (03CR) 10Krinkle: "This broke CI for mediawiki/core and all extensions due to a broken assertion. Please fix or revert ASAP." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [22:57:50] (03CR) 10Jforrester: "> Patch Set 3:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [22:58:13] (03CR) 10Bartosz Dziewoński: "It will be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/470503 when that change finally merges." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [22:59:54] (03CR) 10Jforrester: [C: 031] Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) (owner: 10Esanders) [23:20:02] (03CR) 10Divec: [C: 032] Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) (owner: 10Esanders) [23:21:47] (03PS3) 10Divec: Unit tests for TransportServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470116 [23:22:26] (03PS1) 10Bartosz Dziewoński: ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470517 [23:22:28] (03PS1) 10Bartosz Dziewoński: .eslintrc: Enable and fix "max-statements-per-line": 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470518 [23:22:30] (03Merged) 10jenkins-bot: Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) (owner: 10Esanders) [23:22:32] (03PS1) 10Bartosz Dziewoński: .eslintrc: Enable and fix "max-statements-per-line": 1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470519 [23:24:34] (03CR) 10jerkins-bot: [V: 04-1] .eslintrc: Enable and fix "max-statements-per-line": 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470518 (owner: 10Bartosz Dziewoński) [23:24:49] (03CR) 10jenkins-bot: Use consistent method for finding nearest cursor offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463769 (https://phabricator.wikimedia.org/T202359) (owner: 10Esanders) [23:26:15] (03CR) 10Divec: [C: 032] ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470517 (owner: 10Bartosz Dziewoński) [23:27:19] (03PS5) 10Bartosz Dziewoński: [BREAKING CHANGE] Have ve.htmlMsg return a node array instead of jQuery collection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463368 (owner: 10Esanders) [23:27:49] (03CR) 10Bartosz Dziewoński: [C: 032] [BREAKING CHANGE] Have ve.htmlMsg return a node array instead of jQuery collection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463368 (owner: 10Esanders) [23:28:13] (03Merged) 10jenkins-bot: ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470517 (owner: 10Bartosz Dziewoński) [23:29:15] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (236effcd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) [23:30:14] (03CR) 10jenkins-bot: ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470517 (owner: 10Bartosz Dziewoński) [23:30:22] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (236effcd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) (owner: 10Bartosz Dziewoński) [23:31:29] (03CR) 10Bartosz Dziewoński: "Oh, the deepFreeze stuff adds new files" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) (owner: 10Bartosz Dziewoński) [23:31:55] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Have ve.htmlMsg return a node array instead of jQuery collection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463368 (owner: 10Esanders) [23:35:35] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (236effcd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) (owner: 10Bartosz Dziewoński) [23:35:41] (03CR) 10jenkins-bot: [BREAKING CHANGE] Have ve.htmlMsg return a node array instead of jQuery collection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463368 (owner: 10Esanders) [23:37:16] (03PS2) 10Bartosz Dziewoński: Update VE core submodule to master (236effcd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) [23:42:34] (03PS2) 10Bartosz Dziewoński: Update VE core submodule to master (c8e22de61) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470240 (owner: 10Esanders) [23:42:56] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (c8e22de61) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470240 (owner: 10Esanders) [23:47:31] (03PS2) 10Bartosz Dziewoński: .eslintrc: Enable and fix "max-statements-per-line": 1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470518 [23:49:24] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (236effcd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) (owner: 10Bartosz Dziewoński) [23:50:55] (03PS3) 10Bartosz Dziewoński: Update VE core submodule to master (236effcd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470522 (https://phabricator.wikimedia.org/T202359) [23:51:02] (03PS3) 10Bartosz Dziewoński: Update VE core submodule to master (c8e22de61) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470240 (owner: 10Esanders) [23:53:03] (03CR) 10Bartosz Dziewoński: [C: 031] "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [23:56:28] (03CR) 10Bartosz Dziewoński: [C: 032] "Transient failure" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457467 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński)