[00:19:30] 10VisualEditor: Adding link leads to jQuery.Deferred exception: startingSelection.getDocument is not a function TypeError: startingSelection.getDocument is not a function - https://phabricator.wikimedia.org/T208358 (10matmarex) [00:19:33] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10VisualEditor (Current work): JS fatal in VE from ve.ui.DesktopContext.prototype.updateDimensions - https://phabricator.wikimedia.org/T208366 (10matmarex) [00:21:11] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10VisualEditor (Current work): Exception when opening any dialog/inspector in VE - https://phabricator.wikimedia.org/T208347 (10matmarex) 05Open>03Resolved p:05High>03Unbreak! (I'm closing this task, contrary to our usual practice... [00:21:17] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10VisualEditor (Current work): JS fatal in VE from ve.ui.DesktopContext.prototype.updateDimensions - https://phabricator.wikimedia.org/T208366 (10matmarex) 05Open>03Resolved (I'm closing this task, contrary to our usual practice in VisualEditor, s... [01:46:17] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-Ryasmeen: VisualEditor: Upload-by-insertion of images via copy-paste - https://phabricator.wikimedia.org/T39932 (10matmarex) >>! In T39932#4708065, @Thedonquixotic wrote: > Hi @matmarex It does appear to work w... [01:46:23] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-Ryasmeen: VisualEditor: Upload-by-insertion of images via copy-paste - https://phabricator.wikimedia.org/T39932 (10matmarex) > See recording here: https://cloud.jackalope.tech/s/example (Here's the same, for f... [01:48:36] (03CR) 10Bartosz Dziewoński: "You complained on IRC that this was too easy… Can you do the same for the sortkey field of individual categories? ;) https://i.imgur.com/T" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470731 (https://phabricator.wikimedia.org/T145339) (owner: 10Bjornskjald) [03:28:20] (03PS1) 10Divec: WIP: [BREAKING CHANGE] Do not cache document model data in DM selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470740 (https://phabricator.wikimedia.org/T208228) [03:31:22] (03PS1) 10Divec: Remove same-document check when reapplying selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 [03:34:52] (03CR) 10Divec: Remove same-document check when reapplying selection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (owner: 10Divec) [04:11:32] (03PS1) 10Divec: Use changed ve.dm.Selection interface, if present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470747 (https://phabricator.wikimedia.org/T208228) [04:12:03] (03PS1) 10Divec: Use changed ve.dm.Selection interface, if present [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/470749 (https://phabricator.wikimedia.org/T208228) [06:29:55] (03PS4) 10Bjornskjald: Add using the article title as the default value for sorting in categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/470731 (https://phabricator.wikimedia.org/T145339) [09:48:16] (03CR) 10Esanders: Remove same-document check when reapplying selection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (owner: 10Divec) [10:10:02] (03PS2) 10Esanders: DesktopContext: Don't rely on selection#getDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (owner: 10Divec) [10:17:24] 10VisualEditor, 10Regression: Link inspector jumps after opening [regression] - https://phabricator.wikimedia.org/T208382 (10Esanders) [10:19:24] 10VisualEditor, 10Regression: Link inspector jumps after opening [regression] - https://phabricator.wikimedia.org/T208382 (10Esanders) Looks like I made a typo when fixing a source mode context-jump bug a few years ago: https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/318234/ `getDocument` inste... [10:21:27] (03PS3) 10Esanders: DesktopContext: Don't rely on selection#getDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (https://phabricator.wikimedia.org/T208228) (owner: 10Divec) [10:22:14] (03PS2) 10Esanders: WIP: [BREAKING CHANGE] Do not cache document model data in DM selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470740 (https://phabricator.wikimedia.org/T208228) (owner: 10Divec) [10:45:32] (03CR) 10Divec: [C: 032] DesktopContext: Don't rely on selection#getDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (https://phabricator.wikimedia.org/T208228) (owner: 10Divec) [10:47:30] (03Merged) 10jenkins-bot: DesktopContext: Don't rely on selection#getDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (https://phabricator.wikimedia.org/T208228) (owner: 10Divec) [10:50:31] (03CR) 10jenkins-bot: DesktopContext: Don't rely on selection#getDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/470741 (https://phabricator.wikimedia.org/T208228) (owner: 10Divec) [13:28:05] 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter - https://phabricator.wikimedia.org/T207080 (10Deskana) Can we add a screenshot here o... [13:28:45] 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler - https://phabricator.wikimedia.org/T207079 (10Deskana) Can we add some screenshots here of the new test coverage, so that it can be compar... [13:29:22] 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearDeleteKeyDownHandler - https://phabricator.wikimedia.org/T207078 (10Deskana) Can we add a screenshot here of the new test coverage, so that it can be compared... [13:29:31] 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearArrowKeyDownHandler - https://phabricator.wikimedia.org/T207077 (10Deskana) p:05Triage>03Normal Can we add a screenshot here of the new test coverage, so t... [13:35:32] 10VisualEditor, 10VisualEditor-ContentEditable, 10User-Ryasmeen: VisualEditor: Template:Listen (and similar sound files) doesn't render the TMH aspects correctly - https://phabricator.wikimedia.org/T52365 (10Deskana) [13:35:36] 10VisualEditor-MediaWiki, 10ContentTranslation, 10MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10VisualEditor (Current work): Handle