[00:11:50] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473139 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [01:11:11] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10VisualEditor (Current work): - https://phabricator.wikimedia.org/T204718 (10Ryasmeen) [01:11:14] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): - https://phabricator.wikimedia.org/T205564 (10Ryasmeen) [01:12:53] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Editing QA, and 2 others: Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Ryasmeen) [01:14:59] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Selection handles obscured after scrollCursorIntoView - https://phabricator.wikimedia.org/T204718 (10Ryasmeen) [01:16:57] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): External text with CRLF line endings breaks text processing in NWE - https://phabricator.wikimedia.org/T205564 (10Ryasmeen) [01:28:34] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 4 others: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10Isarra) I'm not sure what... [01:55:33] 10VisualEditor: [Regression pre-wmf.6] Adding a new image to an exiting gallery is not enabling the "Apply changes" button - https://phabricator.wikimedia.org/T209451 (10Ryasmeen) [01:58:45] 10VisualEditor: [Regression pre-wmf.6] Adding a new image to an existing gallery is not enabling the "Apply changes" button - https://phabricator.wikimedia.org/T209451 (10Ryasmeen) [02:01:09] 10VisualEditor: [Regression pre-wmf.6] Adding a new image to an existing gallery is not enabling the "Apply changes" button - https://phabricator.wikimedia.org/T209451 (10Ryasmeen) [02:28:32] 10VisualEditor, 10VisualEditor-MediaWiki-References: VE has problems with editing link - https://phabricator.wikimedia.org/T208981 (10Thryduulf) Actually, on both en and de Wikipedias there is a convert button if a URL is encased in a tag but not if it isn't - compare: * [[https://de.... [06:19:04] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473328 (owner: 10Libraryupgrader) [07:49:00] 10VisualEditor, 10MinervaNeue, 10Mobile, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): VisualEditor on mobile: Toolbar should be reduced in height - https://phabricator.wikimedia.org/T209015 (10Volker_E) > […] on target sizes Yes, we were there – in T101409. Let's compare with interaction element... [08:07:53] (03PS1) 10Divec: WIP: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 [08:10:56] (03CR) 10jerkins-bot: [V: 04-1] WIP: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (owner: 10Divec) [10:40:21] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads: WikiEditor toolbar shown twice on editing posts in threads - https://phabricator.wikimedia.org/T189029 (10TheDJ) The infuse is not related to this: LQT adds the toolbar config by itself en then wikiEditor does it a second time on its own: `... [11:58:23] 10VisualEditor, 10VisualEditor-MediaWiki-References: VE has problems with editing link - https://phabricator.wikimedia.org/T208981 (10Der_Keks) Okay but what's with this Version I edited without a convert option (Cite one): https://de.wikipedia.org/w/index.php?title=EBuLa&oldid=179684205&vea... [12:16:04] 10Citoid, 10VisualEditor: Allow arbitrary search strings in citoid from existing footnotes - https://phabricator.wikimedia.org/T208751 (10Mvolz) p:05Triage>03Normal a:05Mvolz>03None [12:25:40] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Updated TemplateData from transcluded items take a long time to show up - https://phabricator.wikimedia.org/T52372 (10Mvolz) [12:34:37] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Updated TemplateData from transcluded items take a long time to show up - https://phabricator.wikimedia.org/T52372 (10Mvolz) This is an ongoing issue. I was contacted today from a third party wiki wondering why their VE citation tool wasn't working, a... [12:39:44] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Petar.petkovic) [13:02:16] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Petar.petkovic) Using keyboard arrows can also lead to slug getting focus and accepting user input. [13:04:21] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Updated TemplateData from transcluded items take a long time to show up - https://phabricator.wikimedia.org/T52372 (10Mvolz) [13:11:14] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10matmarex) Can you reproduce this in VE too or only in CX? We fixed similar issues in VE recently (T201599). In my testing in VE, trying to put the text cursor inside the slugs corr... [13:16:41] 10VisualEditor, 10ContentTranslation: Blinking cursor as big as block template height - https://phabricator.wikimedia.org/T209484 (10Petar.petkovic) [13:16:59] 10VisualEditor, 10ContentTranslation: Blinking cursor as big as block template height - https://phabricator.wikimedia.org/T209484 (10Petar.petkovic) p:05Triage>03Low [13:20:47] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10matmarex) a:03matmarex Something goes funny with the section nodes in CX. [13:26:09] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Petar.petkovic) >>! In T209479#4746200, @matmarex wrote: > Can you reproduce this in VE too or only in CX? I am not able to reproduce in VE (without CX). Tried the same methods used... [13:28:20] (03CR) 10Esanders: [C: 04-2] "We should have a baseline of timing metrics on mobile before deploying." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [13:34:22] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10MobileFrontend, 10Product-Analytics, and 3 others: Mobile editors do not log timings for any Edit events - https://phabricator.wikimedia.org/T205166 (10Esanders) a:03DLynch [13:37:23] (03PS2) 10Esanders: Allow document state metadata to be stored without clearing HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472869 [14:04:49] (03CR) 10Esanders: [C: 04-1] "I think it would be better to track this from the client, as that is when we know for sure that the edit notice was actually displayed. Th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [14:05:59] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Pginer-WMF) Given that Content translation separates block elements in different sections, would it be an option to hide/remove the "insert paragraph" slugs completely from Content... [14:11:53] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Documentation, 10User-Ryasmeen: Historical visual differences beta feature information page needs updating to mention historical diffs as well as diffs in the editors - https://phabricator.wikimedia.org/T190706 (10Esanders) 05Open>03Resolved a:03Esanders... [14:11:55] 10VisualEditor-VisualDiffs, 10Beta-Feature, 10User-Ryasmeen, 10User-notice, and 2 others: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708 (10Esanders) [14:50:39] (03PS1) 10Esanders: Remove VETarget, use textSelection API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 [14:50:41] (03PS1) 10Esanders: Move editPage->editTemplatePage, create minimal editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) [14:50:46] (03CR) 10jerkins-bot: [V: 04-1] Remove VETarget, use textSelection API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [14:50:49] (03CR) 10jerkins-bot: [V: 04-1] Move editPage->editTemplatePage, create minimal editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) (owner: 10Esanders) [14:50:51] (03CR) 10jerkins-bot: [V: 04-1] Move editPage->editTemplatePage, create minimal editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) (owner: 10Esanders) [14:51:04] 10TemplateData, 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): TemplateData module is loaded too often - https://phabricator.wikimedia.org/T208765 (10Esanders) a:03Esanders [14:55:42] (03PS2) 10Esanders: Remove VETarget, use textSelection API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 [14:55:44] (03PS2) 10Esanders: Move editPage->editTemplatePage, create minimal editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) [15:10:32] 10VisualEditor, 10ContentTranslation: "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10matmarex) The issue is also reproducible in VE with HTML like `
`. [15:10:33] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Consider that slugs can be in nested nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473533 (https://phabricator.wikimedia.org/T209479) [15:11:07] 10VisualEditor-ContentEditable, 10ContentTranslation, 10Patch-For-Review, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10matmarex) [15:15:22] 10VisualEditor, 10ContentTranslation: Blinking cursor as big as block template height - https://phabricator.wikimedia.org/T209484 (10matmarex) I'm having trouble reproducing this, but I think this will also be fixed by my fix for T209479. It sounds similar to T177238 in VE. [15:15:29] 10VisualEditor, 10ContentTranslation: Blinking cursor as big as block template height - https://phabricator.wikimedia.org/T209484 (10matmarex) [15:15:32] 10VisualEditor-ContentEditable, 10ContentTranslation, 10Patch-For-Review, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10matmarex) [15:17:12] 10VisualEditor: VE is substing citation templates - https://phabricator.wikimedia.org/T209493 (10Izno) [15:21:05] 10VisualEditor, 10ContentTranslation: Blinking cursor as big as block template height - https://phabricator.wikimedia.org/T209484 (10Petar.petkovic) >>! In T209484#4746603, @matmarex wrote: > I'm having trouble reproducing this, but I think this will also be fixed by my fix for T209479. It sounds similar to T1... [15:22:59] 10VisualEditor-ContentEditable, 10ContentTranslation, 10Patch-For-Review, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10matmarex) >>! In T209479#4746381, @Pginer-WMF wrote: > Given that Content translation separates block elements... [15:41:32] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads: WikiEditor toolbar shown twice on editing posts in threads - https://phabricator.wikimedia.org/T189029 (10Kghbln) > The infuse is not related to this. Ah, ok, it's just what popped up prominently in console. > This issue is also race condition sensitive, wh... [15:53:09] 10VisualEditor: VE is substing citation templates - https://phabricator.wikimedia.org/T209493 (10Trappist_the_monk) discussion about this topic at [[ https://en.wikipedia.org/wiki/User_talk:Trappist_the_monk#Ownership_(psychology) | User talk:Trappist the monk#Ownership_(psychology) ]] [15:57:34] (03PS1) 10TheDJ: Toolbar: ignore modifications on readonly textarea [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 [15:58:49] 10VisualEditor: VE is substing citation templates - https://phabricator.wikimedia.org/T209493 (10Izno) [16:04:36] (03PS1) 10TheDJ: Toolbar: Add tiny hover effect to ooui icon buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473550 [16:06:54] (03CR) 10jerkins-bot: [V: 04-1] Toolbar: ignore modifications on readonly textarea [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (owner: 10TheDJ) [16:14:51] 10VisualEditor-ContentEditable, 10ContentTranslation, 10Patch-For-Review, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Pginer-WMF) >>! In T209479#4746642, @matmarex wrote: >>>! In T209479#4746381, @Pginer-WMF wrote: >> Given that... [16:24:16] 10VisualEditor-DataModel, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review, 10VisualEditor (Current work): DM Selections should not cache document model data - https://phabricator.wikimedia.org/T208228 (10matmarex) [16:27:17] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), and 2 others: Template parameter alias "pills" vertically truncated [regression] - https://phabricator.wikimedia.org/T208720 (10matmarex) > What template is this? Looks like https://en.w... [16:30:47] 10VisualEditor: Increase unit test coverage in ve.ce.GeneratedContentNode - https://phabricator.wikimedia.org/T207084 (10JTannerWMF) [16:31:12] 10VisualEditor-ContentLanguage, 10Growth-Team, 10StructuredDiscussions, 10I18n, and 4 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) [16:35:12] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10VisualEditor (Current work): Re-evaluate mobile editing for images - https://phabricator.wikimedia.org/T190885 (10matmarex) Based on comments from @Ryasmeen and @iamjessklein I am assuming this passed QA and design re... [16:35:43] 10VisualEditor, 10Editing Q1 2018-19 mobile improvements, 10Performance-Team (Radar): Pre-load VE code into memory to improve performance and speed - https://phabricator.wikimedia.org/T202720 (10JTannerWMF) [16:39:37] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Patch-For-Review, 10VisualEditor (Current work): WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10m... [16:40:27] (03CR) 10Jforrester: Remove VETarget, use textSelection API (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [16:41:32] (03CR) 10Jforrester: [C: 031] Move editPage->editTemplatePage, create minimal editTemplatePage [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) (owner: 10Esanders) [16:41:35] 10VisualEditor-MediaWiki, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10VisualEditor (Current work): WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10matmarex) [16:51:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: EPIC: Fix selection issues on mobile - https://phabricator.wikimedia.org/T209505 (10dchan) [17:00:10] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Android-Google-Chrome: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome - https://phabricator.wikimedia.org/T136840 (10dchan) [17:00:11] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: EPIC: Fix selection issues on mobile - https://phabricator.wikimedia.org/T209505 (10dchan) [17:00:13] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Editing QA, and 2 others: Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10dchan) [17:42:11] (03PS1) 10Jforrester: Update VE core submodule to master (b17770c7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473569 (https://phabricator.wikimedia.org/T209192) [18:52:13] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (b17770c7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473569 (https://phabricator.wikimedia.org/T209192) (owner: 10Jforrester) [18:52:45] 10VisualEditor-EditingTools, 10VisualEditor (Current work): Drop down for menu options appears to be jittering for Firefox - https://phabricator.wikimedia.org/T209192 (10matmarex) [18:55:00] (03PS2) 10TheDJ: Toolbar: ignore modifications on readonly textarea [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 [19:02:19] 10WikiEditor: Disable text manipulating buttons on read-only pages - https://phabricator.wikimedia.org/T188817 (10TheDJ) This is only if the editor was force loaded, by something else having a dependency on it. #mediawiki-extensions-codemirror indeed does this. I suspect that reftoolbar might as well.... WikiEd... [19:03:28] (03PS3) 10TheDJ: Toolbar: ignore modifications on readonly textarea [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (https://phabricator.wikimedia.org/T188817) [19:05:20] (03CR) 10Jforrester: [C: 031] "Can we actually make the toolbar buttons visually disabled too? Sorry to demand more, but…. :-)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (https://phabricator.wikimedia.org/T188817) (owner: 10TheDJ) [19:12:30] (03Merged) 10jenkins-bot: Update VE core submodule to master (b17770c7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473569 (https://phabricator.wikimedia.org/T209192) (owner: 10Jforrester) [19:13:50] (03PS1) 10Esanders: build: Update devDependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473583 [19:13:52] (03PS1) 10Esanders: eslint: Introduce wikimedia/qunit ruleset [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473584 [19:15:57] (03CR) 10jenkins-bot: Update VE core submodule to master (b17770c7e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473569 (https://phabricator.wikimedia.org/T209192) (owner: 10Jforrester) [19:36:57] (03CR) 10Esanders: Remove VETarget, use textSelection API (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [19:37:18] (03CR) 10Esanders: Remove VETarget, use textSelection API (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [19:37:50] (03CR) 10Jforrester: [C: 032] Remove VETarget, use textSelection API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [19:37:57] (03CR) 10Fomafix: [C: 031] Toolbar: ignore modifications on readonly textarea [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (https://phabricator.wikimedia.org/T188817) (owner: 10TheDJ) [19:38:02] (03CR) 10Jforrester: [C: 032] build: Update devDependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473583 (owner: 10Esanders) [19:38:46] (03CR) 10Jforrester: [C: 032] eslint: Introduce wikimedia/qunit ruleset [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473584 (owner: 10Esanders) [19:45:56] (03CR) 10Esanders: [C: 04-1] "Another case would be switching from source mode to visual mode mid-edit, that would make a call to this API and so double-count." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:52:36] (03PS2) 10VolkerE: Toolbar: Add tiny hover effect to ooui icon buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473550 (owner: 10TheDJ) [19:53:44] (03CR) 10VolkerE: [C: 032] "Sure. In a real designed process, this would have a little less than the active state, but so many things are not done perfectly here and " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473550 (owner: 10TheDJ) [19:54:30] (03Merged) 10jenkins-bot: Remove VETarget, use textSelection API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [19:57:18] (03CR) 10jenkins-bot: Remove VETarget, use textSelection API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473525 (owner: 10Esanders) [20:02:27] (03PS1) 10TheDJ: Modules: Protect against loading modules twice [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473594 (https://phabricator.wikimedia.org/T189029) [20:03:56] (03CR) 10Fomafix: "The hover effect shows that the buttons are effective smaller than the hover box." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473550 (owner: 10TheDJ) [20:12:29] (03Merged) 10jenkins-bot: Toolbar: Add tiny hover effect to ooui icon buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473550 (owner: 10TheDJ) [20:12:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: Research faking linear selections on mobile - https://phabricator.wikimedia.org/T209533 (10dchan) [20:16:38] (03PS1) 10Bartosz Dziewoński: ve.ui.MWGalleryDialog: Update "Apply" button when image added [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473600 (https://phabricator.wikimedia.org/T206534) [20:18:54] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads, 10Patch-For-Review: WikiEditor toolbar shown twice on editing posts in threads - https://phabricator.wikimedia.org/T189029 (10TheDJ) So.. the wikiEditor patch avoids the double load, and when backported to 1.31, 1.32 and 1.33 (yikes...) should fix this tick... [20:20:08] (03PS2) 10Bartosz Dziewoński: ve.ui.MWGalleryDialog: Update "Apply" button when image added [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473600 (https://phabricator.wikimedia.org/T206534) [20:21:21] (03PS3) 10Bartosz Dziewoński: ve.ui.MWGalleryDialog: Update "Apply" button when image added [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473600 (https://phabricator.wikimedia.org/T206534) [20:21:51] (03CR) 10jerkins-bot: [V: 04-1] Modules: Protect against loading modules twice [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473594 (https://phabricator.wikimedia.org/T189029) (owner: 10TheDJ) [20:22:32] 10VisualEditor-EditingTools, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10VisualEditor (Current work): The gallery dialog's Apply changes action is always enabled if there are images in the gallery - https://phabricator.wikimedia.org/T206534 (10matmarex) [20:22:42] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): [Regression pre-wmf.6] Adding a new image to an existing gallery is not enabling the "Apply changes" button - https://phabricator.wikimedia.org/T209451 (10matmarex) a:03matmarex [20:22:45] (03CR) 10TheDJ: ""Can we actually make the toolbar buttons visually disabled too"" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (https://phabricator.wikimedia.org/T188817) (owner: 10TheDJ) [20:23:27] (03CR) 10Jforrester: [C: 032] "Good enough reasoning for me." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (https://phabricator.wikimedia.org/T188817) (owner: 10TheDJ) [20:24:15] 10WikiEditor: Disable text manipulating buttons on read-only pages - https://phabricator.wikimedia.org/T188817 (10Jdforrester-WMF) With this change, the buttons are still enabled but don't work, which stops things being broken, at least. :-) [20:24:19] (03PS2) 10TheDJ: Modules: Protect against loading modules twice [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473594 (https://phabricator.wikimedia.org/T189029) [20:27:54] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads, 10Patch-For-Review: WikiEditor toolbar shown twice on editing posts in threads - https://phabricator.wikimedia.org/T189029 (10TheDJ) p:05Triage>03Normal a:03TheDJ [20:30:36] 10WikiEditor: Disable text manipulating buttons on read-only pages - https://phabricator.wikimedia.org/T188817 (10TheDJ) [20:35:49] 10WikiEditor: Disable text manipulating buttons on read-only pages - https://phabricator.wikimedia.org/T188817 (10Fomafix) A simple styling for disabled buttons is ` lang=css opacity: .5; ` [20:51:07] (03Merged) 10jenkins-bot: Toolbar: ignore modifications on readonly textarea [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473548 (https://phabricator.wikimedia.org/T188817) (owner: 10TheDJ) [20:52:41] (03CR) 10Jforrester: [C: 032] Modules: Protect against loading modules twice [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473594 (https://phabricator.wikimedia.org/T189029) (owner: 10TheDJ) [21:11:52] (03Merged) 10jenkins-bot: Modules: Protect against loading modules twice [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473594 (https://phabricator.wikimedia.org/T189029) (owner: 10TheDJ) [21:14:51] 10VisualEditor: Add ability to set a revision tag by passing a URL parameter to the Visual Editor - https://phabricator.wikimedia.org/T209132 (10matmarex) I didn't know either, so I investigated, and it looks like applying tags with your edit requires the 'applychangetags' user right, which is only granted to re... [21:19:45] 10VisualEditor-EditingTools, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10VisualEditor (Current work): The gallery dialog's Apply changes action is always enabled if there are images in the gallery - https://phabricator.wikimedia.org/T206534 (10Ryasmeen) Changing the te... [21:23:52] (03PS1) 10Jforrester: Modules: Protect against loading modules twice [extensions/WikiEditor] (REL1_32) - 10https://gerrit.wikimedia.org/r/473619 (https://phabricator.wikimedia.org/T189029) [21:24:04] (03CR) 10Jforrester: [C: 032] "This'll make rc.1. Yay." [extensions/WikiEditor] (REL1_32) - 10https://gerrit.wikimedia.org/r/473619 (https://phabricator.wikimedia.org/T189029) (owner: 10Jforrester) [21:25:24] (03PS1) 10Jforrester: Modules: Protect against loading modules twice [extensions/WikiEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/473620 (https://phabricator.wikimedia.org/T189029) [21:25:30] (03CR) 10Jforrester: [C: 032] Modules: Protect against loading modules twice [extensions/WikiEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/473620 (https://phabricator.wikimedia.org/T189029) (owner: 10Jforrester) [21:27:03] 10WikiEditor, 10MediaWiki-extensions-LiquidThreads, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): WikiEditor toolbar shown twice on editing posts in threads - https://phabricator.wikimedia.org/T189029 (10Jdforrester-WMF) 05Open>03Resolved >>! In T189029#4748039, @TheDJ wrote: > So.. the wikiEditor patch av... [21:40:37] (03Merged) 10jenkins-bot: Modules: Protect against loading modules twice [extensions/WikiEditor] (REL1_32) - 10https://gerrit.wikimedia.org/r/473619 (https://phabricator.wikimedia.org/T189029) (owner: 10Jforrester) [21:40:41] (03Merged) 10jenkins-bot: Modules: Protect against loading modules twice [extensions/WikiEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/473620 (https://phabricator.wikimedia.org/T189029) (owner: 10Jforrester) [21:54:39] 10VisualEditor: [Regression pre-wmf.6] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10Ryasmeen) [21:54:55] 10VisualEditor: [Regression pre-wmf.6] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10Ryasmeen) p:05Triage>03High [21:56:16] 10VisualEditor-EditingTools, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10VisualEditor (Current work): The gallery dialog's Apply changes action is always enabled if there are images in the gallery - https://phabricator.wikimedia.org/T206534 (10Ryasmeen) @matmarex: anot... [22:08:57] 10VisualEditor-EditingTools, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10VisualEditor (Current work): Drop down for menu options appears to be jittering for Firefox - https://phabricator.wikimedia.org/T209192 (10Ryasmeen) Fixed, thanks! [22:19:43] (03PS1) 10TheDJ: LinkDialog: fix size of background image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473634 (https://phabricator.wikimedia.org/T193480) [22:24:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Consider not escaping wikitext pasted into wikieditor - https://phabricator.wikimedia.org/T186348 (10TheDJ) [22:40:29] (03CR) 10Bartosz Dziewoński: [C: 032] LinkDialog: fix size of background image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473634 (https://phabricator.wikimedia.org/T193480) (owner: 10TheDJ) [22:48:23] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), and 2 others: Template parameter alias "pills" vertically truncated [regression] - https://phabricator.wikimedia.org/T208720 (10Ryasmeen) >>! In T208720#4746932, @matmarex wrote: >> What... [22:48:36] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Regression, and 2 others: Template parameter alias "pills" vertically truncated [regression] - https://phabricator.wikimedia.org/T208720 (10Ryasmeen) [22:59:13] (03Merged) 10jenkins-bot: LinkDialog: fix size of background image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/473634 (https://phabricator.wikimedia.org/T193480) (owner: 10TheDJ) [23:04:12] (03CR) 10Dmaza: "> Patch Set 1:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [23:12:11] 10WikiEditor, 10CSS, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): External link icon is cut off in the "Insert link" box - https://phabricator.wikimedia.org/T193480 (10matmarex) 05Open>03Resolved a:03TheDJ [23:22:36] 10VisualEditor: [Regression pre-wmf.6] "Publish Changes" button stays disabled while trying to re-edit a page on Firefox - https://phabricator.wikimedia.org/T209542 (10Ryasmeen) [23:59:25] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10matmarex) This is done fro...