[00:00:52] (03CR) 10jenkins-bot: build: Update devDependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473583 (owner: 10Esanders) [00:03:39] (03CR) 10jenkins-bot: Separate parameter aliases in the description table with spaces [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473948 (owner: 10Bartosz Dziewoński) [00:04:27] 10VisualEditor: Display template names without the "Generated from:" prefix in template inspectors - https://phabricator.wikimedia.org/T199923 (10matmarex) [00:04:29] 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): On mobile, template context menu doesn't show the name of the template - https://phabricator.wikimedia.org/T209610 (10matmarex) [00:06:27] (03CR) 10jenkins-bot: eslint: Introduce wikimedia/qunit ruleset [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473584 (owner: 10Esanders) [00:11:56] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473957 (https://phabricator.wikimedia.org/T209661) [02:23:16] (03CR) 10Divec: [C: 032] Revert "TargetWidget: 'change' on document transact, not surface history" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473852 (https://phabricator.wikimedia.org/T209648) (owner: 10Bartosz Dziewoński) [02:25:09] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Changing text in a TargetWidget does not enable dialog's "Apply" button (in media, gallery, reference dialog) until second keypress - https://phabricator.wikimedia.org/T209648 (10dchan) Oooh, thanks. Do we think the behaviour hap... [02:26:08] (03Merged) 10jenkins-bot: Revert "TargetWidget: 'change' on document transact, not surface history" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473852 (https://phabricator.wikimedia.org/T209648) (owner: 10Bartosz Dziewoński) [02:28:46] (03CR) 10jenkins-bot: Revert "TargetWidget: 'change' on document transact, not surface history" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473852 (https://phabricator.wikimedia.org/T209648) (owner: 10Bartosz Dziewoński) [03:54:27] (03PS2) 10Dmaza: Track when block notices are returned on the api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) [04:56:01] 10Cite, 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10santhosh) > Found this error while checking T208386. I used the leading paragraph... [06:42:23] 10Cite, 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10santhosh) > Need help from Cite extenion team to resolve this. +cc @Esanders, ne... [11:24:58] (03CR) 10Esanders: [C: 04-1] ve.ui.MWGalleryDialog: Improve modification checks (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473840 (https://phabricator.wikimedia.org/T206534) (owner: 10Bartosz Dziewoński) [12:00:22] 10Cite, 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Petar.petkovic) >>! In T203160#4752794, @santhosh wrote: >> Found this error whil... [12:43:49] 10VisualEditor, 10VisualEditor-MediaWiki-References: VE has problems with editing link - https://phabricator.wikimedia.org/T208981 (10Der_Keks) Okay, how you would edit that with VE by keeping the ref-names? If I cannot convert anything I need to delete the "old" Basicform reference. In this... [12:57:57] (03PS1) 10Esanders: Make jQuery.async loop synchronous [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474168 (https://phabricator.wikimedia.org/T209699) [13:01:19] 10VisualEditor, 10Vector, 10Browser-Support-Google-Chrome, 10Performance-Team (Radar), 10Upstream: Tab border disappeared between Edit and Edit Source tab - https://phabricator.wikimedia.org/T204766 (10matmarex) [13:52:23] 10WikiEditor: Put separate buttons on wikitext toolbar for single and double brackets - https://phabricator.wikimedia.org/T209487 (10Aklapper) 05stalled>03declined > Put back 2 one-click link buttons on the wikitext editing toolbar. There are no plans to expose random single elements as part of the top-leve... [15:15:44] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/474193 (owner: 10Libraryupgrader) [15:24:19] 10Citoid, 10Operations, 10Patch-For-Review, 10Service-deployment-requests, and 3 others: Deploy translation-server-v2 - https://phabricator.wikimedia.org/T201611 (10mobrovac) [15:57:00] 10VisualEditor, 10Readers-Web-Backlog, 10Design: Research Design Improvements to MobileFrontend Loading Overlay - https://phabricator.wikimedia.org/T209708 (10marcella) [15:57:15] 10VisualEditor, 10Readers-Web-Backlog, 10Design: Research Design Improvements to MobileFrontend Loading Overlay - https://phabricator.wikimedia.org/T209708 (10marcella) [16:31:25] 10Citoid, 10Patch-For-Review: Allow restbase url to be set directly in Citoid extension, overwriting the VE url. - https://phabricator.wikimedia.org/T202271 (10Mvolz) p:05Triage>03Normal [16:55:59] (03PS5) 10Esanders: Rename module editPage→editTemplatePage, create minimal new editPage module [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) [16:56:17] (03CR) 10Esanders: "oops, I checked for rebase conflicts on the long file, but not the short one." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) (owner: 10Esanders) [16:57:06] (03PS6) 10Esanders: Rename module editPage→editTemplatePage, create minimal new editPage module [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/473526 (https://phabricator.wikimedia.org/T208765) [17:03:19] (03CR) 10Esanders: "Do we need to be worried about performance, as this looks like a synchronous call to make the log. If the stats database is down or respon" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [17:09:11] (03PS2) 10Esanders: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:09:19] (03PS7) 10Esanders: WIP POC: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:09:26] (03CR) 10jerkins-bot: [V: 04-1] WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:09:52] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog (Tracking): Switching from VisualEditor to SourceEditor on Mobile frontend causes funkyness when trying to edit different section - https://phabricator.wikimedia.org/T209714 (10pmiazga) [17:15:04] (03CR) 10jerkins-bot: [V: 04-1] WIP POC: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:29:40] (03CR) 10Esanders: [C: 04-1] "I note that pressing CTRL+A throws an error" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [18:14:23] 10VisualEditor: Toolbar breaks when I focus on editable content after clicking omega character - https://phabricator.wikimedia.org/T208826 (10Jdlrobson) I found this confusing as I hadn't realised what had happened. Thinking back about my goals I was probably trying to select a character or focus the editing are... [18:47:06] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor doesn't filter out deprecated template parameters - https://phabricator.wikimedia.org/T207897 (10kaldari) [18:52:00] (03PS1) 10Tchanders: WIP Track when block notices are displayed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/474312 (https://phabricator.wikimedia.org/T209633) [19:10:14] (03CR) 10Dmaza: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:11:41] (03CR) 10Jforrester: [C: 032] Make jQuery.async loop synchronous [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474168 (https://phabricator.wikimedia.org/T209699) (owner: 10Esanders) [19:29:03] (03Merged) 10jenkins-bot: Make jQuery.async loop synchronous [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474168 (https://phabricator.wikimedia.org/T209699) (owner: 10Esanders) [20:19:32] hmm. [20:20:14] so the stock inserter of the dialogs mode is basically just a textfield dialog that add .... [20:20:22] i'm suggesting we remove the dialog.... [20:20:34] of WE2010 [20:27:47] thedj: I know it's pretty useless, but I'm a little change averse right now. :-) [20:40:35] (03PS1) 10TheDJ: remove old -khtml-box-sizing... [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474329 [20:48:55] Wow. -khtml?! [20:49:05] Hello, Safari c. 2009. [20:50:31] 10VisualEditor, 10VisualEditor-MediaWiki-References: VE has problems with editing link - https://phabricator.wikimedia.org/T208981 (10Thryduulf) You want to convert a reference without a template to one that uses a template. VE can do that, but //only// where the reference is originally defi... [20:51:13] (03PS1) 10TheDJ: Remove the dialog version of ref inserter [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474332 [21:06:15] 10WikiEditor: Callback actions are run when the toolbar is loaded, not when the tool button is clicked - https://phabricator.wikimedia.org/T26753 (10TheDJ) 05Open>03Resolved a:03TheDJ worksforme `lang=javascript action: { type: 'callback', execute: function () { console.log( "testing" ); } } ` [21:14:03] (03CR) 10Jforrester: [C: 032] "https://codesearch.wmflabs.org/deployed/?q=-khtml&i=nope&files=%5C.%5Bc%7Cle%5Dss&repos= Fun." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474329 (owner: 10TheDJ) [21:14:23] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing: Bug: When a Talk Page is Refreshed After Saving Edits, it Re-Enters Edit-Mode - https://phabricator.wikimedia.org/T195761 (10TheDJ) The video makes it clear that the user is WE2017 Sort of critical information. Could also... [21:18:03] 10WikiEditor, 10CodeEditor, 10CSS: Change or add new class for format group's of the Toolbar - https://phabricator.wikimedia.org/T191810 (10TheDJ) why is it very difficult ? selectors make this easy right ? I'd rather not introduce new classes unless we really need to. [21:25:38] 10WikiEditor: Loading ext.wikieditor.toolbar should not initialize it - https://phabricator.wikimedia.org/T36602 (10TheDJ) 05Open>03Invalid Since all the modules are unified now (T165112), this no longer seems like a relevant problem to me. [21:26:51] 10WikiEditor, 10CodeEditor, 10CSS: Change or add new class for format group's of the Toolbar - https://phabricator.wikimedia.org/T191810 (10Jdforrester-WMF) Specifically, `$( 'div.section-main div.group-format' )[ 0 ]` for the first and `$( 'div.section-advanced div.group-format' )[ 0 ]` for the second, or `... [21:34:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/474368 (owner: 10L10n-bot) [21:36:44] (03Merged) 10jenkins-bot: remove old -khtml-box-sizing... [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474329 (owner: 10TheDJ) [21:37:46] 10WikiEditor, 10ProofreadPage, 10Wikisource: Search and replace is totally broken when using it with ProofreadPage - https://phabricator.wikimedia.org/T183950 (10TheDJ) @Tpt so why is it overriding the getSelection anyway ? which tools is this trying to support ? Have we considered making the individual head... [21:39:02] James_F: ps. what's the history of https://phabricator.wikimedia.org/T165881 ? [21:39:25] * James_F looks. [21:40:10] Hmm. Does that get called too late to work? [21:40:42] well.. i couldn't find where this.specialCharacters is even being used... [21:40:54] That wouldn't help. :-D [21:41:13] exactly ;) [21:41:23] Oh. [21:41:24] ResourceLoaderSpecialCharacterDataModule::class [21:41:36] We probably broke it when we migrated it to be a data module? [21:42:25] mediawiki.language.specialCharacters is called directly rather than via mediawiki.language. [21:42:44] Old vague memories. [21:46:34] 10WikiEditor, 10CodeEditor, 10CSS: Change or add new class for format group's of the Toolbar - https://phabricator.wikimedia.org/T191810 (10Jdforrester-WMF) 05Open>03declined [22:03:29] 10VisualEditor, 10WikiEditor, 10MediaWiki-Page-editing: Let gadgets add items/groups to the special character list - https://phabricator.wikimedia.org/T165881 (10TheDJ) WikiEditor uses it as: ` latin: { labelMsg: 'special-characters-group-latin', layout: 'characters', characters: mw.language.specialCh... [22:07:34] 10WikiEditor, 10Browser-Support-Firefox: Ctrl + End should update the scroll position like Page down - https://phabricator.wikimedia.org/T127601 (10TheDJ) 05Open>03declined Browser/OS problem [22:09:18] (03CR) 10Aezell: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [23:06:18] (03CR) 10Dbarratt: Track when block notices are returned on the api (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/472342 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza)