[03:23:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: If a user adds a link to a disambiguation page in the mainspace, suggest changing the link - https://phabricator.wikimedia.org/T198936 (10Ankry) Sometimes links to disambiguation pages are intentional. Eg. in redirects for alternative spelling of some commo... [08:32:42] 10Citoid, 10Operations, 10Patch-For-Review, 10Service-deployment-requests, and 3 others: Deploy translation-server-v2 - https://phabricator.wikimedia.org/T201611 (10Mvolz) >>! In T201611#4755783, @akosiaris wrote: > This has now been deployed to the kubernetes staging cluster. > > ` > akosiaris@deploy100... [09:59:02] 10VisualEditor, 10VisualEditor-MediaWiki-References: VE has problems with editing link - https://phabricator.wikimedia.org/T208981 (10Der_Keks) Please try it again after i made this edit on your sandbox https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&diff=869398436&oldid=8... [14:01:30] 10WikiEditor: Put separate buttons on wikitext toolbar for single and double brackets - https://phabricator.wikimedia.org/T209487 (10Timeshifter) >>! In T209487#4755497, @TheDJ wrote: > Just to be clear, I still don't understand Timeshifter's problem. I checked your user contributions on English Wikipedia and s... [14:15:43] (03CR) 10Esanders: [C: 031] Search & Replace: Use actual global replace [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474483 (https://phabricator.wikimedia.org/T58228) (owner: 10TheDJ) [14:16:46] (03CR) 10Esanders: Search & Replace: Fix using replace as first action (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474461 (https://phabricator.wikimedia.org/T76750) (owner: 10TheDJ) [14:17:55] (03CR) 10Esanders: [C: 032] "LOL. I guess this missed all our searches for IE[0-9]!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474454 (owner: 10TheDJ) [14:18:53] (03CR) 10Esanders: [C: 032] LinkDialog: Switch to jquery.throttle-debounce plugin [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474457 (owner: 10TheDJ) [14:19:51] 10WikiEditor: Put separate buttons on wikitext toolbar for single and double brackets - https://phabricator.wikimedia.org/T209487 (10Aklapper) Please read T209487#4753667 again. It links to an explanation how you can adjust the toolbar to suit your needs. [14:25:02] (03CR) 10Esanders: [C: 032] "Technically we should move this to extensions/Cite too." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474332 (owner: 10TheDJ) [14:31:57] (03Merged) 10jenkins-bot: JS for ie-mac is not supported, so no need for this CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474454 (owner: 10TheDJ) [14:32:00] (03Merged) 10jenkins-bot: LinkDialog: Switch to jquery.throttle-debounce plugin [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474457 (owner: 10TheDJ) [14:34:23] 10WikiEditor, 10JavaScript: Remove button for from toolbar - https://phabricator.wikimedia.org/T40487 (10Aklapper) a:05Haritha28>03None [14:38:24] (03Merged) 10jenkins-bot: Remove the dialog version of ref inserter [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474332 (owner: 10TheDJ) [14:41:50] 10WikiEditor, 10JavaScript: Pressing ENTER on editbox should not submit the search form - https://phabricator.wikimedia.org/T41357 (10Aklapper) @Vishwaak: [No need to ask for permission.](https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Communicate_that_you_work_on_a_task) :) [Anything we can he... [14:51:25] (03PS1) 10Esanders: Workaround native selection bug for number inputs in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/474533 (https://phabricator.wikimedia.org/T209646) [15:10:20] (03PS1) 10Esanders: Make button padding clickable [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474534 [15:35:25] 10WikiEditor: Put separate buttons on wikitext toolbar for single and double brackets - https://phabricator.wikimedia.org/T209487 (10Timeshifter) >>! In T209487#4756415, @Aklapper wrote: > Please read T209487#4753667 again. It links to an explanation how you can adjust the toolbar to suit your needs. That is a... [16:15:45] (03PS1) 10Esanders: Only handle document selectionchange events when focussed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/474538 [16:53:54] (03PS2) 10Esanders: Workaround native selection bug for number inputs in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/474533 (https://phabricator.wikimedia.org/T209646) [19:48:41] (03PS1) 10Nouman: support recaptcha on visual editor [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 [20:01:02] (03CR) 10Fomafix: [C: 031] Make button padding clickable [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474534 (owner: 10Esanders) [21:09:43] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension): Support No CAPTCHA reCAPTCHA in VisualEditor - https://phabricator.wikimedia.org/T203478 (10Nouman) I've opened a change request for this functionality. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/474548/ [21:29:32] (03CR) 10Alex Monk: "You can't propose patches against a release branch directly like this, they need to go via master and then after merging there get cherry-" [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 (owner: 10Nouman) [21:34:11] (03CR) 10Alex Monk: [C: 04-1] "also it doesn't look like you attempted to follow the existing code style in this file" [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 (owner: 10Nouman) [21:41:22] (03CR) 10Alex Monk: [C: 04-1] support recaptcha on visual editor (033 comments) [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 (owner: 10Nouman) [21:51:18] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/474606 (owner: 10L10n-bot) [21:51:39] 10Editing-team, 10Editing QA: Make automatic edit summariy match the mw-headline tag's id on the desktop version - https://phabricator.wikimedia.org/T209796 (10Automatik) [22:01:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing: Bug: When a Talk Page is Refreshed After Saving Edits, it Re-Enters Edit-Mode - https://phabricator.wikimedia.org/T195761 (10Johnywhy) Will report back next time I try. [22:06:22] (03CR) 10Nouman: "Thank you for the promptness and info Alex. I tried to follow some code style, but planned to circle back and reformat. The intention arou" [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 (owner: 10Nouman) [22:15:50] (03CR) 10Esanders: "If you run 'npm install' then 'grunt eslint' it will show you the code style issues. There are also eslint plugins for most code editors t" [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 (owner: 10Nouman) [23:58:08] (03CR) 10Esanders: support recaptcha on visual editor (032 comments) [extensions/VisualEditor] (REL1_30) - 10https://gerrit.wikimedia.org/r/474548 (owner: 10Nouman)