[00:04:22] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Fix typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475923 (owner: 10Bartosz Dziewoński) [00:08:16] (03CR) 10jenkins-bot: ve.init.mw.ArticleTarget: Fix typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475923 (owner: 10Bartosz Dziewoński) [00:28:44] 10TemplateData, 10VisualEditor, 10Patch-For-Review: TemplateData's suggested parameters to add doesn't know that `{{{!}}` isn't a parameter but a special thing for MediaWiki - https://phabricator.wikimedia.org/T157029 (10Samwilson) a:03Samwilson [00:50:00] (03PS2) 10Samwilson: Ignore bang magic word in table syntax when guessing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/469162 (https://phabricator.wikimedia.org/T157029) [01:32:57] 10VisualEditor: Summary-links not correct - https://phabricator.wikimedia.org/T208978 (10matmarex) Just to clarify, this is only about this link in the diff/preview dialog, correct? (it indeed points to the wrong place) {F27316787} "API" is used by the API as a placeholder in some cases when the right title is... [01:41:20] 10VisualEditor: Summary-links not correct - https://phabricator.wikimedia.org/T208978 (10matmarex) I wasn't really planning to work on this, but after I found the bug, it took no time to fix… [01:41:25] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Improve handling of links in edit summary preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475935 (https://phabricator.wikimedia.org/T208978) [01:57:30] 10TemplateData, 10VisualEditor, 10Patch-For-Review: TemplateData's suggested parameters to add doesn't know that `{{{!}}` isn't a parameter but a special thing for MediaWiki - https://phabricator.wikimedia.org/T157029 (10Samwilson) Good point. I've updated the above patch to look for the three closing braces... [02:11:34] (03CR) 10Jforrester: [C: 032] ve.ui.MWSaveDialog: Improve handling of links in edit summary preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475935 (https://phabricator.wikimedia.org/T208978) (owner: 10Bartosz Dziewoński) [02:12:22] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Summary-links not correct - https://phabricator.wikimedia.org/T208978 (10Jdforrester-WMF) a:03matmarex [02:31:43] (03Merged) 10jenkins-bot: ve.ui.MWSaveDialog: Improve handling of links in edit summary preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475935 (https://phabricator.wikimedia.org/T208978) (owner: 10Bartosz Dziewoński) [02:34:13] (03CR) 10jenkins-bot: ve.ui.MWSaveDialog: Improve handling of links in edit summary preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475935 (https://phabricator.wikimedia.org/T208978) (owner: 10Bartosz Dziewoński) [03:13:24] 10VisualEditor-MediaWiki-Templates, 10VisualEditor (Current work): VisualEditor doesn't filter out deprecated template parameters - https://phabricator.wikimedia.org/T207897 (10matmarex) Note that VE is aware of deprecated parameters, but all it does is display a little message about it in the help menu: {F273... [03:36:08] 10VisualEditor-MediaWiki-References, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Verified, 10VisualEditor (Current work): The references list dialog's Apply changes action is always enabled - https://phabricator.wikimedia.org/T209660 (10Ryasmeen) [03:37:05] 10VisualEditor-MediaWiki-Media, 10Browser-Support-Firefox, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Verified, 10VisualEditor (Current work): Focussing an (e.g. Gallery→Options→Image height) crashes VE on Firefox - https://phabricator.wikimedia.org/T209646 (10Ryasmeen) [03:47:04] (03PS3) 10Samwilson: Ignore bang magic word in table syntax when guessing parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/469162 (https://phabricator.wikimedia.org/T157029) [03:51:14] (03CR) 10Samwilson: "This change is ready for review." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/469162 (https://phabricator.wikimedia.org/T157029) (owner: 10Samwilson) [04:38:49] 10WikiEditor, 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10UI-Standardization-Kanban: WikiEditor 2010 should use standard 'reference' icon instead of 'book' - https://phabricator.wikimedia.org/T202463 (10Volker_E) p:05Normal>03Triage [07:40:02] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398 (10matmarex) [07:40:07] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) [07:40:09] 10VisualEditor, 10VisualEditor-EditingTools:
tags on different line from content of blockquote results alienated content - https://phabricator.wikimedia.org/T86794 (10matmarex) [07:40:12] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) [07:40:56] 10VisualEditor, 10VisualEditor-EditingTools:
tags on different line from content of blockquote results alienated content - https://phabricator.wikimedia.org/T86794 (10matmarex) [07:41:00] 10VisualEditor, 10VisualEditor-EditingTools, 10Patch-For-Review: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) [07:41:53] 10VisualEditor, 10VisualEditor-MediaWiki: Character ↵ appears in multi-line
tags - https://phabricator.wikimedia.org/T120827 (10matmarex) [07:42:04] 10VisualEditor, 10VisualEditor-EditingTools:
tags on different line from content of blockquote results alienated content - https://phabricator.wikimedia.org/T86794 (10matmarex) [07:42:08] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398 (10matmarex) [07:47:49] 10VisualEditor, 10StructuredDiscussions: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
, not a
which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690 (10matmarex) [07:47:52] 10VisualEditor: VisualEditor hardly usable for talk and discussion pages - https://phabricator.wikimedia.org/T151854 (10matmarex) [07:51:10] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Turn structure dropdown into a "split button" with "make bulleted list" the primary action - https://phabricator.wikimedia.org/T68940 (10matmarex) >>! In T68940#720833, @TTO wrote: > [1] http://tinypic.com/r/52jl7p/8 Sorry, it's a disgusting video host... [07:51:24] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Turn structure dropdown into a "split button" with "make bulleted list" the primary action - https://phabricator.wikimedia.org/T68940 (10matmarex) [08:04:41] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) This has become a priority because of {T209162}. [08:20:47] (03PS1) 10Bartosz Dziewoński: Use ve.dm.SurfaceFragment#hasMatchingAncestor where possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475959 [08:20:48] (03PS1) 10Bartosz Dziewoński: ve.ui.FormatTool: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475960 [08:20:51] (03PS1) 10Bartosz Dziewoński: Make blockquote a non-content branch node, update tools and stuff accordingly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) [08:21:02] (03PS1) 10Bartosz Dziewoński: Update stuff for making blockquote a non-content branch node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) [08:21:29] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947 (10Tgr) Relevant Community Wishlist entry: https://met... [08:23:21] (03CR) 10jerkins-bot: [V: 04-1] Make blockquote a non-content branch node, update tools and stuff accordingly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [08:30:14] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) cc @iamjessklein The patch proposes moving the tool from "Format" to "... [08:30:27] (03CR) 10jerkins-bot: [V: 04-1] Update stuff for making blockquote a non-content branch node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [08:30:42] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) a:03matmarex [08:34:04] 10VisualEditor: [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10matmarex) a:05matmarex>03None I submitted a patch on T76426, which would also resolve this issue. (Let's discuss it there.) (Moving this task off the workboard in favor... [08:34:11] 10VisualEditor, 10VisualEditor-EditingTools:
tags on different line from content of blockquote results alienated content - https://phabricator.wikimedia.org/T86794 (10matmarex) I submitted a patch on T76426, which would also resolve this issue. (Let's discuss it there.) >>! In T86794#4005188, @S... [08:35:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398 (10matmarex) I submitted a patch on T76426, which would also resolve this issue. (Let's... [08:35:17] 10VisualEditor, 10VisualEditor-MediaWiki: Character ↵ appears in multi-line
tags - https://phabricator.wikimedia.org/T120827 (10matmarex) I submitted a patch on T76426, which would also resolve this issue. (Let's discuss it there.) [08:41:15] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10VisualEditor (Current work): Summary-links not correct - https://phabricator.wikimedia.org/T208978 (10Der_Keks) >>! In T208978#4776468, @matmarex wrote: > Just to clarify, this is only about this link in the diff/preview dialog, correct?... [09:15:01] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References: VisualEditor: Support editing citations defined within a template - https://phabricator.wikimedia.org/T52896 (10Pginer-WMF) This limitation has been reported several times in the context of [[ https://www.mediawiki.org/wiki/Con... [12:12:01] (03PS2) 10TheDJ: Make context available after being done with basic setup [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 [13:34:13] 10WikiEditor, 10MediaWiki-Page-editing: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10TheDJ) FYI, unlike skins, WikiEditor is not enabled by default: {F27318380} [13:38:43] 10WikiEditor, 10MediaWiki-Page-editing: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10Agabi10) >>! In T209217#4777452, @TheDJ wrote: > FYI, unlike skins, WikiEditor is not enabled by default Then it should probably be checked by default, but not merged into core. [13:43:51] (03CR) 10TheDJ: Make context available after being done with basic setup (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [13:46:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Commenting: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used - https://phabricator.wikimedia.org/T50274 (10Dvorapa) Proposed in [[https://meta.wikimedia.org/wiki/Community_Wishlist_... [14:01:01] 10Cite, 10TCB-Team, 10Accessibility, 10German-Community-Wishlist, and 4 others: Establish caret/arrow as jump mark for screen readers - https://phabricator.wikimedia.org/T206323 (10WMDE-Fisch) Again, can be tested on beta e.g. here: https://de.wikipedia.beta.wmflabs.org/wiki/Tacrin?purge=now ( cache might... [14:13:13] 10Cite, 10TCB-Team, 10WMDE-Design, 10Design: Find a better way to highligth letters then bold - https://phabricator.wikimedia.org/T210281 (10thiemowmde) I played around with a few styling options. The little "b" is what is relevant in the following examples. {F27318457 size=full} `lang=css .mw-cite-backlin... [14:39:36] (03CR) 10Esanders: [C: 032] ve.ui.FormatTool: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475960 (owner: 10Bartosz Dziewoński) [14:51:09] (03CR) 10Tpt: [C: 031] "Thanks!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [14:54:14] (03CR) 10Fomafix: [C: 04-1] Make context available after being done with basic setup (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [14:59:03] (03PS1) 10TheDJ: Search: Add option to search whole words [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476031 (https://phabricator.wikimedia.org/T24478) [15:01:08] (03CR) 10Esanders: [C: 032] "I filed T210505 as a follow-up to fix hasMatchingAncestor" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475959 (owner: 10Bartosz Dziewoński) [15:03:23] (03Merged) 10jenkins-bot: Use ve.dm.SurfaceFragment#hasMatchingAncestor where possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475959 (owner: 10Bartosz Dziewoński) [15:03:41] (03Merged) 10jenkins-bot: ve.ui.FormatTool: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475960 (owner: 10Bartosz Dziewoński) [15:04:27] (03PS2) 10TheDJ: Search: Add option to search whole words [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476031 (https://phabricator.wikimedia.org/T24478) [15:05:31] (03PS3) 10TheDJ: Make context available after being done with basic setup [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 [15:05:35] (03CR) 10jenkins-bot: Use ve.dm.SurfaceFragment#hasMatchingAncestor where possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475959 (owner: 10Bartosz Dziewoński) [15:09:10] (03CR) 10jenkins-bot: ve.ui.FormatTool: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475960 (owner: 10Bartosz Dziewoński) [15:11:14] (03CR) 10Esanders: "> Should the tool remain in the "Format" menu? Probably not" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [15:12:10] (03PS2) 10TheDJ: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 [15:14:11] 10VisualEditor, 10Technical-Debt: hasMatchingAncestor is the wrong check for list tools - https://phabricator.wikimedia.org/T210505 (10Esanders) [15:14:25] (03CR) 10Esanders: [C: 04-1] "Interaction-wise, we should implement the double-enter-to-break functionality that we have in lists, and possibly shift-tab too. Currently" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [15:20:31] 10WikiEditor, 10Patch-For-Review: Dialogs: Search and Replace : Suggesting to add "Match Word" option - https://phabricator.wikimedia.org/T24478 (10TheDJ) a:03TheDJ [15:25:28] (03CR) 10jerkins-bot: [V: 04-1] Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [15:31:08] (03CR) 10Fomafix: [C: 031] "Are there any workarounds that can removed now?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [16:13:53] (03PS3) 10TheDJ: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 [17:27:17] 10Cite, 10TCB-Team: Customized messages mess order of DOM elements up - https://phabricator.wikimedia.org/T210520 (10thiemowmde) [17:53:45] (03PS1) 10DLynch: Debug flag for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 [18:04:56] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476067 (owner: 10Esanders) [18:04:58] (03CR) 10jerkins-bot: [V: 04-1] Use mw.Title.wantSignaturesNamespace [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476068 (owner: 10Esanders) [18:09:10] (03CR) 10Jforrester: [C: 032] "…" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476068 (owner: 10Esanders) [18:11:01] 10VisualEditor: Visual Editor greys Publish Changes during the exit, unable to save changes - https://phabricator.wikimedia.org/T210221 (10matmarex) @Kerry_Raymond Thanks for reporting this. This might be the same issue as T209542 – apparently this happens after you save an edit in VE, then open VE again without... [18:12:21] (03PS2) 10DLynch: Debug flag for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 [18:24:59] (03Merged) 10jenkins-bot: Use mw.Title.wantSignaturesNamespace [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476068 (owner: 10Esanders) [18:42:01] (03CR) 10Esanders: Use mw.Title.wantSignaturesNamespace (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476064 (owner: 10Esanders) [18:42:53] (03PS2) 10Esanders: Use mw.Title.wantSignaturesNamespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476064 [18:43:31] 10Citoid, 10WikiCite, 10Wikidata: Add qid to citations from citoid other than those coming directly from qid or wikidata link - https://phabricator.wikimedia.org/T210529 (10Mvolz) [18:46:24] 10Citoid, 10WikiCite, 10Wikidata: Add qid to citations from citoid other than those coming directly from qid or wikidata link - https://phabricator.wikimedia.org/T210529 (10Mvolz) [18:49:40] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624 (10Mvolz) FYI there is a way to do this using scholia/wikidata if the author is in wikidata that generates wikitext. It does not use citoid.... [18:55:15] 10Citoid, 10WikiCite, 10Wikidata: Add qid to citations from citoid other than those coming directly from qid or wikidata link - https://phabricator.wikimedia.org/T210529 (10Mvolz) [19:06:16] (03CR) 10Esanders: [C: 04-1] Debug flag for tracking (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 (owner: 10DLynch) [19:08:24] 10Cite, 10TCB-Team: Highlighting does not work if span with mw-cite-backlink class is removed - https://phabricator.wikimedia.org/T210508 (10Anomie) It looks like your code also breaks on some changes to MediaWiki:Cite_references_link_many_format. Specifically, if all the formatting is inside the link instead... [19:09:08] (03CR) 10Jforrester: [C: 032] Use mw.Title.wantSignaturesNamespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476064 (owner: 10Esanders) [19:31:15] (03Merged) 10jenkins-bot: Use mw.Title.wantSignaturesNamespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476064 (owner: 10Esanders) [19:34:58] (03CR) 10jenkins-bot: Use mw.Title.wantSignaturesNamespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476064 (owner: 10Esanders) [20:03:27] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 10Tracking: Broken browser plugins cause cruft to be injected into the page (tracking) - https://phabricator.wikimedia.org/T54327 (10TheDJ) [20:03:29] 10VisualEditor, 10User-Ryasmeen: Third-party browser add-on adds [javascript:] within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10TheDJ) 05Invalid>03Resolved This seems incorrectly closed, as we [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Vis... [20:05:22] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 10Tracking: Broken browser plugins cause cruft to be injected into the page (tracking) - https://phabricator.wikimedia.org/T54327 (10TheDJ) [20:05:27] 10VisualEditor, 10User-Ryasmeen: Third-party browser add-on adds [javascript:] within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10TheDJ) 05Resolved>03Open [20:07:42] 10VisualEditor, 10User-Ryasmeen: Third-party browser add-on adds [javascript:] within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10TheDJ) Probably adding `a[href^="javascript:"]` to the filter list would do the job ? [20:08:25] (03CR) 10Esanders: [C: 031] "Nice" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [20:08:41] (03CR) 10Esanders: [C: 031] "Is there a task for this?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [20:10:59] (03PS3) 10DLynch: Debug flag for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 [20:11:13] (03PS1) 10TheDJ: Blacklist javascript links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476097 (https://phabricator.wikimedia.org/T200971) [21:04:09] 10WikiEditor, 10Patch-For-Review: Dialogs: Search and Replace : Suggesting to add "Match Word" option - https://phabricator.wikimedia.org/T24478 (10Jdforrester-WMF) [21:04:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I doubt this will fix T200971 entirely, but having links starting with "javascript:" blacklisted is (in my humble opinion) definitely the " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476097 (https://phabricator.wikimedia.org/T200971) (owner: 10TheDJ) [21:05:12] 10WikiEditor: Help Tab: Add Nowiki and Redirect to Help - https://phabricator.wikimedia.org/T25053 (10Jdforrester-WMF) [21:12:14] (03CR) 10Jforrester: [C: 032] Blacklist javascript links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476097 (https://phabricator.wikimedia.org/T200971) (owner: 10TheDJ) [21:13:04] 10VisualEditor-MediaWiki, 10User-Ryasmeen, 10VisualEditor (Current work): Third-party browser add-on adds [javascript:] within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10Jdforrester-WMF) a:03TheDJ [21:19:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476136 (owner: 10L10n-bot) [21:23:01] (03CR) 10TheDJ: "Not really. I actually started off on https://phabricator.wikimedia.org/T137541" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [21:24:55] 10VisualEditor: [Regression wmf.4] Old content shows up for a brief second after opening VE for an article - https://phabricator.wikimedia.org/T210547 (10Ryasmeen) [21:29:25] 10VisualEditor: [Regression wmf.4] Old content shows up for a brief second after opening VE for an article - https://phabricator.wikimedia.org/T210547 (10Ryasmeen) [21:35:51] (03CR) 10Esanders: [C: 032] Debug flag for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 (owner: 10DLynch) [21:37:41] (03Abandoned) 10Esanders: Always run event logging code path in debug mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) (owner: 10Esanders) [21:39:48] (03Merged) 10jenkins-bot: Blacklist javascript links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476097 (https://phabricator.wikimedia.org/T200971) (owner: 10TheDJ) [21:42:28] (03CR) 10jenkins-bot: Blacklist javascript links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476097 (https://phabricator.wikimedia.org/T200971) (owner: 10TheDJ) [21:44:09] (03CR) 10Esanders: [C: 031] "Seems like a big enough change." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [21:50:18] (03Merged) 10jenkins-bot: Debug flag for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 (owner: 10DLynch) [21:53:06] (03CR) 10jenkins-bot: Debug flag for tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476072 (owner: 10DLynch) [21:56:48] 10WikiEditor: WikiEditor: Don't load the editor for js/css pages (unless CodeEditor is enabled) - https://phabricator.wikimedia.org/T26041 (10TheDJ) 05Open>03Resolved a:03TheDJ Judging from the comments, this ticket was solved. WikiEditor is only added to pages that use wikitext content-model, or when ex... [22:04:33] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page - https://phabricator.wikimedia.org/T103772 (10TheDJ) >>! In T103772#3913636, @Seb35 wrote: > Could someone more knowlegeable in JS and Wik... [22:16:18] 10WikiEditor, 10Accessibility: WikiEditor: Provide some basic formatting and action keyboard shortcut commands - https://phabricator.wikimedia.org/T62928 (10TheDJ) I think it is very unlikely this will ever be added to #wikieditor, now that we have #visualeditor-mediawiki-2017wikitexteditor providing this func... [22:28:26] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/476160 [22:28:28] (03PS1) 10Esanders: Bump VE version requirement [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/476161 [22:35:55] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/476160 (owner: 10Esanders) [22:41:27] (03PS1) 10Esanders: eslint: Drop 'dot-notation' rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476165 (https://phabricator.wikimedia.org/T210552) [22:42:08] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/476160 (owner: 10Esanders) [22:42:18] (03PS1) 10Esanders: eslint: Drop 'dot-notation' rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476166 (https://phabricator.wikimedia.org/T210552) [22:45:16] 10WikiEditor: WikiEditor: Allow tooltips for characters - https://phabricator.wikimedia.org/T28571 (10TheDJ) This is actually possible: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.language/specialcharacters.json#L76 The problem is more that it would significantly explode the trans... [22:47:31] 10WikiEditor: WikiEditor: Allow tooltips for characters - https://phabricator.wikimedia.org/T28571 (10TheDJ) 05Open>03Resolved a:03TheDJ ndash, mdash and minus actually do have labels in WikiEditor {F27319819} {F27319818} [22:48:01] (03CR) 10Jforrester: [C: 032] eslint: Drop 'dot-notation' rule (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476165 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [22:48:09] (03CR) 10Jforrester: [C: 032] eslint: Drop 'dot-notation' rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476166 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [22:49:31] 10VisualEditor: Inconsistent scrolling behavior observed for Gallery dialog on Mobile - https://phabricator.wikimedia.org/T210555 (10Ryasmeen) [22:50:07] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476165 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [22:50:43] 10VisualEditor: Inconsistent scrolling behavior observed for Gallery dialog on Mobile - https://phabricator.wikimedia.org/T210555 (10Ryasmeen) [22:51:39] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Inserting a table in NWE should show a dialog (like WikiEditor) - https://phabricator.wikimedia.org/T209262 (10TheDJ) {F27319830} This is the design that #mediawiki-extensions-tinymce uses for this feature. [22:52:54] (03CR) 10Jforrester: [C: 032] Bump VE version requirement [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/476161 (owner: 10Esanders) [22:52:58] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476165 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [22:58:16] 10WikiEditor: "Enable navigable table of contents" editing preference inhibits Undo feature - https://phabricator.wikimedia.org/T40767 (10TheDJ) 05Open>03Invalid This labs feature of the original WikiEditor was removed from the extension quite some while ago. Ticket no longer valid. [23:01:04] spring cleaning... or something ;) [23:02:44] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476166 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [23:02:46] (03Merged) 10jenkins-bot: Bump VE version requirement [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/476161 (owner: 10Esanders) [23:05:17] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476166 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [23:06:44] 10Citoid: Use NDL API for ISBN/book data - https://phabricator.wikimedia.org/T192528 (10Mvolz) [23:07:21] 10VisualEditor: Can't scroll the viewport while typing in the caption field in Gallery>Images on mobile - https://phabricator.wikimedia.org/T210559 (10Ryasmeen) [23:10:39] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Editing QA, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 2 others: Improve gallery dialog for mobile visual editor - https://phabricator.wikimedia.org/T203477 (10Ryasmeen) Checked all the design changes. Looks good... [23:10:50] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Patch-For-Review, and 2 others: Improve gallery dialog for mobile visual editor - https://phabricator.wikimedia.org/T203477 (10Ryasmeen) [23:22:58] 10Editing-team, 10CharInsert, 10MediaWiki-Page-editing: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10TheDJ) [23:26:40] 10VisualEditor-EditingTools, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10VisualEditor (Current work): The gallery dialog's Apply changes action is always enabled if there are images in the gallery - https://phabricator.wikimedia.org/T206534 (10Ryasmeen) >>! In T206534#...