[00:08:46] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476612 (owner: 10Dmaza) [00:09:38] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476762 (https://phabricator.wikimedia.org/T209542) (owner: 10Bartosz Dziewoński) [00:14:56] (03Abandoned) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Stop when we fail to load metadata [extensions/VisualEditor] (wmf/1.33.0-wmf.4) - 10https://gerrit.wikimedia.org/r/476761 (https://phabricator.wikimedia.org/T209542) (owner: 10Bartosz Dziewoński) [00:24:14] 10VisualEditor: BUG: VE freezing when editing table - https://phabricator.wikimedia.org/T210798 (10atgo) I figured out how to reproduce exactly. It's holding "shift" and double clicking in a cell in a table, which is how I typically highlight. I can do the screencast if you'd like, let me know. [00:24:49] 10VisualEditor: BUG: VE freezing when editing table - https://phabricator.wikimedia.org/T210798 (10atgo) [00:29:29] (03Merged) 10jenkins-bot: Rename configs for tracking block notices on visual editor [extensions/VisualEditor] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476612 (owner: 10Dmaza) [00:29:34] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTarget: Stop when we fail to load metadata [extensions/VisualEditor] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476762 (https://phabricator.wikimedia.org/T209542) (owner: 10Bartosz Dziewoński) [00:30:02] 10VisualEditor: User Testing of Feature - https://phabricator.wikimedia.org/T209986 (10iamjessklein) Yes, I recommend user testing against against the current design. This feature should be A/B testable. The scenario for the test is: **When** I find part of an article that I want to edit and click the section... [00:30:05] 10VisualEditor: BUG: VE freezing when editing table - https://phabricator.wikimedia.org/T210798 (10matmarex) Thanks, I can reproduce now! It freezes in the for() loop in ve.dm.TableSelection.static.getTableMatrixCells(). Apparently `selectionOffsets.startCol` and `.startRow` are `-Infinity`, and `selectionOffse... [00:34:35] 10Editing-team, 10GeoCrumbs, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Wikimedia-production-error: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getPare... - https://phabricator.wikimedia.org/T210734 [00:43:19] 10VisualEditor, 10Design-Research, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog, 10Design: Perform comparative analysis of editing toolbar UIs - https://phabricator.wikimedia.org/T208738 (10iamjessklein) [00:43:23] 10VisualEditor: [Design EPIC]: Toolbar improvements - https://phabricator.wikimedia.org/T210632 (10iamjessklein) [00:45:35] I'm encountering lots of freezing in VisualEditor today [00:45:39] on mediawiki.org [00:45:46] it seems to relate to highlighting text [00:46:37] Luckily VE refreshes restore my edit but it's scary how much it's happening. (and doing so in both Firefox and Chrome) [00:46:57] i stand corrected.. i lost my current edit [00:57:10] jdlrobson: hard to make a guess without some details about what you're doing. editing tables? https://phabricator.wikimedia.org/T210798 [00:57:22] yup tables! [00:57:26] good guess :) [00:58:20] also completely unrelated MatmaRex but im sure you know and its driving me mad right now... 'tests/node-qunit/**/*.test.js' < how do i make that regex match a file in the folder tests/node-qunit/foo/bar/a.test.js [00:59:14] jdlrobson: pretty sure the table thing is not a new issue, so that's an incredible coincidence [00:59:34] unless all WMF people are editing tables with team goals right now [01:00:13] jdlrobson: restoring edits doesn't work if you inserted a reference :( https://phabricator.wikimedia.org/T208914 it's a simple bug actually, has a patch pending [01:00:50] jdlrobson: seems like that should match… no idea, shell globs are weird [01:01:14] (03PS4) 10Bartosz Dziewoński: ve.dm.Change: Avoid problems with internal-list-only transactions when guessing selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472176 (https://phabricator.wikimedia.org/T208914) [01:01:53] (03PS5) 10Bartosz Dziewoński: ve.dm.Change: Fix guessing selection for internal-list-only transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472176 (https://phabricator.wikimedia.org/T208914) [01:18:18] 10VisualEditor: [EPIC: Focus] Loading screen improvements - https://phabricator.wikimedia.org/T210626 (10iamjessklein) [01:21:15] 10VisualEditor: [Design EPIC]: Loading screen improvements - https://phabricator.wikimedia.org/T210631 (10iamjessklein) [09:09:53] 10Editing-team, 10CharInsert, 10MediaWiki-Page-editing: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10gh87) Don't you think this would affect users who have disabled the improved (2010) toolbars, which can load more slow... [10:46:51] (03PS4) 10Esanders: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) [10:52:04] (03PS5) 10Esanders: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) [11:02:12] 10Cite: Rfeerences are malformed - https://phabricator.wikimedia.org/T210831 (10jeblad) [11:04:11] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10Zoranzoki21) [11:06:53] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10jeblad) [11:45:49] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Zoranzoki21: Enable visual editor at fi.wikibooks.org - https://phabricator.wikimedia.org/T192135 (10Zoranzoki21) Status of this? [11:55:56] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10Aklapper) @jeblad: How is this a software bug and not vandalism if people remove `{{reflist}}`, `{{refbegin}}`, `{{refend}}` in https://en.wikipedia.org/w/index.php?title=Multi-factor_authentication&type=revision&diff=870905053&oldid... [12:01:19] (03PS1) 10Esanders: Enable jquery/no-show & jquery/no-hide rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476835 [12:01:59] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10jeblad) To quote myself > (The article contains errors, but that is an other case.) [12:10:24] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10Aklapper) Please explain which exact behavior you would have expected instead to display that revision ([expected outcome](https://www.mediawiki.org/wiki/How_to_report_a_bug)) and what exactly is "malformed" ([actual outcome](https:/... [12:20:55] 10Citoid, 10Operations, 10Services (watching), 10VisualEditor (Current work): Decreased internationalisation of automatic citations as a result of switch to new translation-server - https://phabricator.wikimedia.org/T210806 (10mobrovac) @Mvolz this sounds like a serious consequence for non-english projects... [12:22:44] (03PS2) 10Esanders: Enable jquery/no-show/hide/toggle rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476835 [12:27:07] (03PS1) 10Esanders: Enable jquery/no-show/hide/toggle rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476837 [12:27:32] (03PS3) 10Esanders: Enable jquery/no-(show/hide/toggle) rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476835 [12:27:46] (03PS2) 10Esanders: Enable jquery/no-(show/hide/toggle) rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476837 [14:12:42] 10Citoid, 10Patch-For-Review, 10VisualEditor (Current work): Allow restbase url to be set directly in Citoid extension, overwriting the VE url. - https://phabricator.wikimedia.org/T202271 (10Esanders) [14:23:16] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10jeblad) 05Open>03Invalid I don't want to waste time on this. [14:43:54] (03PS2) 10Bartosz Dziewoński: Audit target hooks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476517 (owner: 10Esanders) [14:51:40] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10Izno) >>! In T210831#4788695, @Aklapper wrote: > Please explain which exact behavior you would have expected instead to display that revision ([expected outcome](https://www.mediawiki.org/wiki/How_to_report_a_bug)) and what exactly i... [14:52:08] 10Cite: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML - https://phabricator.wikimedia.org/T148701 (10Izno) [14:52:10] 10Cite: References are malformed - https://phabricator.wikimedia.org/T210831 (10Izno) [15:05:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "'deactivationComplete' is fired twice when closing the editor on mobile" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476517 (owner: 10Esanders) [15:32:37] 10VisualEditor: VE is substing citation templates - https://phabricator.wikimedia.org/T209493 (10Trappist_the_monk) [[https://en.wikipedia.org/w/index.php?title=We_Are_the_Romans&diff=prev&oldid=871127518| This edit]] at //[[https://en.wikipedia.org/wiki/We_Are_the_Romans|We Are the Romans]]// was apparently mad... [16:53:22] (03PS1) 10Esanders: Guard against Target#teardown being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476896 [16:58:12] (03PS3) 10Esanders: Audit target hooks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476517 [16:58:14] (03PS1) 10Esanders: Guard against Target#teardown being called twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476898 [16:59:56] (03CR) 10Esanders: [C: 032] ve.ui.MWTransclusionDialog: Remove unneeded code re-setting insert label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476767 (owner: 10Bartosz Dziewoński) [17:02:23] (03CR) 10Esanders: [C: 032] ve.dm.Change: Fix guessing selection for internal-list-only transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472176 (https://phabricator.wikimedia.org/T208914) (owner: 10Bartosz Dziewoński) [17:04:17] (03Merged) 10jenkins-bot: ve.dm.Change: Fix guessing selection for internal-list-only transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472176 (https://phabricator.wikimedia.org/T208914) (owner: 10Bartosz Dziewoński) [17:08:01] (03CR) 10jenkins-bot: ve.dm.Change: Fix guessing selection for internal-list-only transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472176 (https://phabricator.wikimedia.org/T208914) (owner: 10Bartosz Dziewoński) [17:11:47] (03CR) 10jerkins-bot: [V: 04-1] Guard against Target#teardown being called twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476898 (owner: 10Esanders) [17:12:42] (03Merged) 10jenkins-bot: ve.ui.MWTransclusionDialog: Remove unneeded code re-setting insert label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476767 (owner: 10Bartosz Dziewoński) [17:15:03] (03CR) 10jenkins-bot: ve.ui.MWTransclusionDialog: Remove unneeded code re-setting insert label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476767 (owner: 10Bartosz Dziewoński) [18:23:21] 10VisualEditor, 10VisualEditor-Tables, 10Browser-Support-Firefox: Firefox sometimes times out when editing tables - https://phabricator.wikimedia.org/T210867 (10JMinor) [18:25:37] 10Editing-team, 10CharInsert, 10MediaWiki-Page-editing: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10TheDJ) @gh87 are you replying to me or to schnark ? [19:01:24] 10Editing-team, 10CharInsert, 10MediaWiki-Page-editing: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10gh87) That was toward those interested in this task, including you. [19:07:27] (03CR) 10Jforrester: [C: 032] Enable jquery/no-(show/hide/toggle) rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476835 (owner: 10Esanders) [19:07:32] (03CR) 10Jforrester: [C: 032] Enable jquery/no-(show/hide/toggle) rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476837 (owner: 10Esanders) [19:09:40] (03Merged) 10jenkins-bot: Enable jquery/no-(show/hide/toggle) rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476835 (owner: 10Esanders) [19:11:41] (03CR) 10jenkins-bot: Enable jquery/no-(show/hide/toggle) rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476835 (owner: 10Esanders) [19:15:46] 10Citoid: Bloomberg - Are you a robot? - https://phabricator.wikimedia.org/T210871 (10Izno) [19:38:50] (03Merged) 10jenkins-bot: Enable jquery/no-(show/hide/toggle) rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476837 (owner: 10Esanders) [19:41:29] (03CR) 10jenkins-bot: Enable jquery/no-(show/hide/toggle) rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476837 (owner: 10Esanders) [19:46:01] 10Citoid: Bloomberg - Are you a robot? - https://phabricator.wikimedia.org/T210871 (10jeblad) Tested on nowiki, same result [[ https://no.wikipedia.org/wiki/Bruker:Jeblad/test-ref-ldkfhjgb ]]. [20:20:26] (03CR) 10Jforrester: "AF and SB will both need to be CI-linked to VE in https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/zuul/paramete" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476589 (owner: 10Esanders) [20:21:01] (03CR) 10Jforrester: [C: 032] Use ve.deactivationComplete hook instead of ve.deactivate [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476506 (owner: 10Esanders) [20:27:29] (03Merged) 10jenkins-bot: Use ve.deactivationComplete hook instead of ve.deactivate [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476506 (owner: 10Esanders) [20:30:08] (03CR) 10jenkins-bot: Use ve.deactivationComplete hook instead of ve.deactivate [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476506 (owner: 10Esanders) [20:40:04] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Verified, 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10Ryasmeen) [21:12:58] 10VisualEditor: VE/NWE is failing to load on Beta cluster - https://phabricator.wikimedia.org/T210889 (10Ryasmeen) [21:17:40] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476511 (owner: 10Esanders) [21:28:34] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476511 (owner: 10Esanders) [21:34:26] (03CR) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476511 (owner: 10Esanders) [21:56:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476968 (owner: 10L10n-bot) [22:16:50] 10WikiEditor, 10MediaWiki-extensions-Page_Forms: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page - https://phabricator.wikimedia.org/T103772 (10CCicalese_WMF) @Kghbln, the patch to PageForms mentioned above has been merged. Could you pl... [22:43:03] (03CR) 10Jforrester: [C: 032] Create SaveErrorHandler class to better define structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476548 (owner: 10Esanders) [22:43:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/476961 (owner: 10L10n-bot) [22:45:27] (03CR) 10Jforrester: [C: 032] Guard against Target#teardown being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476896 (owner: 10Esanders) [22:47:25] (03PS2) 10Jforrester: [PULLTHROUGH] Update stuff for making blockquote a non-content branch node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [22:49:13] (03Merged) 10jenkins-bot: Guard against Target#teardown being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476896 (owner: 10Esanders) [22:51:14] (03CR) 10jenkins-bot: Guard against Target#teardown being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/476896 (owner: 10Esanders) [22:53:39] (03CR) 10jerkins-bot: [V: 04-1] [PULLTHROUGH] Update stuff for making blockquote a non-content branch node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [23:06:12] (03Merged) 10jenkins-bot: Create SaveErrorHandler class to better define structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476548 (owner: 10Esanders) [23:08:37] (03CR) 10jenkins-bot: Create SaveErrorHandler class to better define structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476548 (owner: 10Esanders) [23:22:44] (03CR) 10Jforrester: [C: 032] Search & Replace: Fix using replace as first action [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474461 (https://phabricator.wikimedia.org/T76750) (owner: 10TheDJ) [23:35:25] (03Merged) 10jenkins-bot: Search & Replace: Fix using replace as first action [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474461 (https://phabricator.wikimedia.org/T76750) (owner: 10TheDJ) [23:37:29] (03PS1) 10Jforrester: Update VE core submodule to master (52b89a9db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476999 (https://phabricator.wikimedia.org/T208914) [23:44:19] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (52b89a9db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476999 (https://phabricator.wikimedia.org/T208914) (owner: 10Jforrester) [23:51:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) [23:52:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) Sorry @phuedx, I don't know why you keep getting resubscribed. [23:54:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) [23:54:46] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (52b89a9db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476999 (https://phabricator.wikimedia.org/T208914) (owner: 10Jforrester) [23:55:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) Oh, I see, it's because his username was in the task description.