[00:07:55] (03Merged) 10jenkins-bot: trackSubscriber: Set timing property to a number, not an object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477434 (owner: 10Catrope) [00:11:44] (03CR) 10jenkins-bot: trackSubscriber: Set timing property to a number, not an object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477434 (owner: 10Catrope) [01:24:53] (03PS2) 10Bartosz Dziewoński: ve.ce.TableNode: Fix infinite loop when extending linear selection to table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) [04:26:09] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): VE/NWE is failing to load on Beta cluster - https://phabricator.wikimedia.org/T210889 (10matmarex) [09:00:25] (03PS2) 10Divec: WIP: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 [09:02:10] (03CR) 10jerkins-bot: [V: 04-1] WIP: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (owner: 10Divec) [09:49:09] 10Cite, 10TCB-Team, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10WMDE-QWERTY-Sprint-2018-11-20: Highlighting does not work if span with mw-cite-backlink class is removed - https://phabricator.wikimedia.org/T210508 (10thiemowmde) [10:10:03] 10Citoid, 10Operations, 10Services (watching), 10VisualEditor (Current work): Decreased internationalisation of automatic citations as a result of switch to new translation-server - https://phabricator.wikimedia.org/T210806 (10danstillman) We've implemented `Accept-Language` forwarding upstream. [10:35:08] 10Citoid, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Wikipedia pages parsed as website, not encyclopedia - https://phabricator.wikimedia.org/T211088 (10mobrovac) p:05Triage>03High [11:43:03] 10Citoid, 10Operations, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10mobrovac) 05Open>03Resolved Citoid in production has been switched to use Zotero v2. [14:19:39] 10Editing-team, 10Advanced Mobile Contributions, 10Discovery, 10MobileFrontend, 10Readers-Web-Backlog (Design): Search results on Mobile web don't include a red link to create a new article - https://phabricator.wikimedia.org/T211006 (10ovasileva) p:05Triage>03High @alexhollender - I think this is so... [14:25:47] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Citoid not communicating with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) p:05Triage>03Unbreak! [14:27:23] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Citoid not communicating with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) [14:31:55] 10Citoid, 10Operations, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Mvolz) 05Resolved>03Open [14:32:29] 10Citoid, 10Operations, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Mvolz) Re-opening due to T211114 [14:33:18] (03CR) 10Esanders: [C: 04-1] "tests?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) (owner: 10Bartosz Dziewoński) [14:35:01] (03CR) 10Esanders: [C: 032] build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477312 (owner: 10Jforrester) [14:59:09] (03Merged) 10jenkins-bot: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477312 (owner: 10Jforrester) [15:01:30] (03CR) 10jenkins-bot: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477312 (owner: 10Jforrester) [15:38:46] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Citoid not communicating with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Jdforrester-WMF) Looks fixed now? Though the date format returned is not ideal (see https://en.wikipedia.org/api/... [15:46:40] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Citoid not communicating with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) Yup looks fixed in the last hour :) [15:47:07] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Citoid not communicating with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) 05Open>03Resolved [15:47:13] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Mvolz) [15:48:22] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Citoid not communicating with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) Hmm but the qid one is still not working... [15:50:15] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Mvolz) [15:50:20] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Some regressions in production with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) 05Resolved>03Open p:05Unbreak!>03High [15:51:42] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Some regressions in production with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) p:05High>03Normal [16:32:11] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Some regressions in production with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) >>! In T211114#4797913, @Jdforrester-WMF wrote: > Looks fixed now? > > Though the date format return... [16:35:41] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): The new translation-server returns access date with the full time stamp; we should strip this - https://phabricator.wikimedia.org/T211127 (10Mvolz) p:05Triage>03Normal [16:43:24] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): The new translation-server returns access date with the full time stamp; we should strip this - https://phabricator.wikimedia.org/T211127 (10Mvolz) @Jdforrester-WMF Unfortunately I'm going to be on an aeroplane both today and tomorrow and... [16:43:39] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): The new translation-server returns access date with the full time stamp; we should strip this - https://phabricator.wikimedia.org/T211127 (10Mvolz) p:05Normal>03Unbreak! [16:56:51] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Some regressions in production with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10mobrovac) 05Open>03Resolved a:03akosiaris There was a communication problem both between Citoid and Zo... [16:56:55] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10mobrovac) [17:01:15] 10Citoid, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Wikipedia pages parsed as website, not encyclopedia - https://phabricator.wikimedia.org/T211088 (10mobrovac) 05Open>03Resolved This was due to Citoid not being able to communicate with Zotero. Fixed now. [20:01:06] (03PS3) 10Bartosz Dziewoński: ve.ce.TableNode: Fix infinite loop when extending linear selection to table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) [20:13:12] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): Some regressions in production with Zotero translation-server in production at all - https://phabricator.wikimedia.org/T211114 (10Mvolz) The qid issue is still ongoing; I suspect that Zotero is crashing with that request. [20:20:02] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (done), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Pchelolo) Seems like after this has been done the citation alerts started flapping much more then they used... [20:59:49] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10Neil_P._Quinn_WMF) [21:20:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477664 (owner: 10L10n-bot) [21:38:57] 10Citoid, 10Operations, 10Regression, 10VisualEditor (Current work): QIDs work locally but not in production with new translation-server - https://phabricator.wikimedia.org/T211148 (10Mvolz) p:05Triage>03Normal [22:33:25] (03PS1) 10Esanders: Update stylelint-config-wikimedia to 0.5.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/477691 [22:37:46] (03PS3) 10Esanders: Guard against Target#teardown being called twice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476898 [22:38:03] (03PS4) 10Esanders: Audit target hooks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476517 [22:38:43] 10Editing-team, 10VisualEditor, 10Contributors-Analysis, 10Product-Analytics: Review EditAttempStep validation failures in production - https://phabricator.wikimedia.org/T211156 (10Jdforrester-WMF) [22:38:49] (03Abandoned) 10Jforrester: Follow-up 6f1b6c85a: Set timing for 'abort' events again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477411 (owner: 10Jforrester) [22:39:55] (03PS4) 10Esanders: ve.ce.TableNode: Fix infinite loop when extending linear selection to table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) (owner: 10Bartosz Dziewoński) [22:40:09] (03CR) 10Esanders: [C: 032] ve.ce.TableNode: Fix infinite loop when extending linear selection to table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) (owner: 10Bartosz Dziewoński) [22:42:06] (03Merged) 10jenkins-bot: ve.ce.TableNode: Fix infinite loop when extending linear selection to table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) (owner: 10Bartosz Dziewoński) [22:43:45] (03PS1) 10Esanders: Enable jQuery/no-extend rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477692 [22:44:17] (03CR) 10Jforrester: [C: 032] Enable jQuery/no-extend rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477692 (owner: 10Esanders) [22:46:06] (03CR) 10jenkins-bot: ve.ce.TableNode: Fix infinite loop when extending linear selection to table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477420 (https://phabricator.wikimedia.org/T210798) (owner: 10Bartosz Dziewoński) [22:50:36] (03CR) 10Bartosz Dziewoński: [C: 032] Remove AbuseFilter & SpamBlacklist code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476589 (owner: 10Esanders) [22:50:50] (03CR) 10jerkins-bot: [V: 04-1] Audit target hooks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476517 (owner: 10Esanders) [22:51:58] (03PS2) 10Esanders: Enable jQuery/no-extend rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477692 [22:55:59] (03PS1) 10Esanders: Move ve.init.mw.saveErrorHandlerFactory and fix documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477694 [23:03:30] (03Merged) 10jenkins-bot: Remove AbuseFilter & SpamBlacklist code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476589 (owner: 10Esanders) [23:03:55] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Allow VE plugins to handle save errors generated by extensions - https://phabricator.wikimedia.org/T211157 (10matmarex) [23:05:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10ConfirmEdit (CAPTCHA extension), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs - https://phabricator.wikimedia.org/T136859 (10matmarex) [23:05:24] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Allow VE plugins to handle save errors generated by extensions - https://phabricator.wikimedia.org/T211157 (10matmarex) [23:06:01] (03CR) 10jenkins-bot: Remove AbuseFilter & SpamBlacklist code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/476589 (owner: 10Esanders) [23:08:34] 10VisualEditor-MediaWiki, 10Technical-Debt, 10VisualEditor (Current work): Allow VE plugins to handle save errors generated by extensions - https://phabricator.wikimedia.org/T211157 (10matmarex) I think the work on this was triggered by a third-party patch https://gerrit.wikimedia.org/r/c/mediawiki/extension... [23:08:45] (03CR) 10Jforrester: [C: 032] Update stylelint-config-wikimedia to 0.5.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/477691 (owner: 10Esanders) [23:14:53] 10VisualEditor-MediaWiki, 10Technical-Debt, 10VisualEditor (Current work): Allow VE plugins to handle save errors generated by extensions - https://phabricator.wikimedia.org/T211157 (10matmarex) Relevant patches, chronologically: //(patches in each row were dependent on each other and merged at the same time... [23:21:01] 10VisualEditor-MediaWiki, 10Technical-Debt, 10VisualEditor (Current work): Allow VE plugins to handle save errors generated by extensions - https://phabricator.wikimedia.org/T211157 (10matmarex) a:03Esanders [23:21:34] (03CR) 10Bartosz Dziewoński: [C: 032] Move ve.init.mw.saveErrorHandlerFactory and fix documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477694 (owner: 10Esanders) [23:22:14] (03Merged) 10jenkins-bot: Update stylelint-config-wikimedia to 0.5.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/477691 (owner: 10Esanders) [23:34:07] (03Merged) 10jenkins-bot: Move ve.init.mw.saveErrorHandlerFactory and fix documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477694 (owner: 10Esanders) [23:36:31] (03CR) 10jenkins-bot: Move ve.init.mw.saveErrorHandlerFactory and fix documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477694 (owner: 10Esanders) [23:49:00] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477692 (owner: 10Esanders) [23:49:21] (03CR) 10Jforrester: "Shall we just land this and fiddle later?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462747 (owner: 10Esanders) [23:51:04] (03Merged) 10jenkins-bot: Enable jQuery/no-extend rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477692 (owner: 10Esanders) [23:54:05] (03PS1) 10Jforrester: Update VE core submodule to master (0d3e1acfe) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/477706 (https://phabricator.wikimedia.org/T210798) [23:54:51] (03CR) 10jenkins-bot: Enable jQuery/no-extend rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/477692 (owner: 10Esanders)