[01:58:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10Growth-Team, 10Notifications, 10StructuredDiscussions: Now that you can ping people from an edit summary, Notifications should add StructuredDiscussion's "Mention" inspector into the VE/2017WTE publish dialog - https://phabricator.wikimedia.org/T209970 (10Nihari... [04:22:23] 10VisualEditor-ContentEditable, 10ContentTranslation, 10Verified, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Petar.petkovic) [07:11:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Improve param doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/481967 (owner: 10Umherirrender) [07:30:33] (03Merged) 10jenkins-bot: Improve param doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/481967 (owner: 10Umherirrender) [07:35:03] (03CR) 10jenkins-bot: Improve param doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/481967 (owner: 10Umherirrender) [08:16:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: NWE: Language links, indicators, and transcluded categories are missing in preview - https://phabricator.wikimedia.org/T153534 (10Schnark) >>! In T153534#4850590, @stjn wrote: >>>! In T153534#3740495, @Elitre wrote: >> Actually... [08:26:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10I18n: Change layout of edit saving dialog - https://phabricator.wikimedia.org/T212811 (10Schnark) [08:26:13] 10VisualEditor, 10VisualEditor-MediaWiki: Handle lengthy interface messages somehow without either truncating them or letting them take up more space - https://phabricator.wikimedia.org/T151313 (10Schnark) [09:26:27] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Zoranzoki21: Enable visual editor at fi.wikibooks.org - https://phabricator.wikimedia.org/T192135 (10Zache) Just pushing: Status of this? [09:50:07] 10VisualEditor, 10VisualEditor-MediaWiki: Handle lengthy interface messages somehow without either truncating them or letting them take up more space - https://phabricator.wikimedia.org/T151313 (10stjn) ‘Handling without truncating’ is a lot more complicated than you’d think. If you merged my task into your la... [09:53:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: NWE: Language links, indicators, and transcluded categories are missing in preview - https://phabricator.wikimedia.org/T153534 (10stjn) >>! In T153534#4851097, @Schnark wrote: > I do see categories in the 2017 wikitext editor pr... [10:51:36] (03CR) 10Esanders: [C: 04-1] ve.ce.Surface: Rearrange #findBlockSlug test to check other cases (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [10:54:36] edsanders: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/476769 [10:56:43] (03CR) 10Jforrester: [C: 03+2] Allow slugs to be suppressed based on context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478660 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [10:57:34] (03PS3) 10Esanders: Allow document state metadata to be stored without clearing HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472869 [10:58:41] (03Merged) 10jenkins-bot: Allow slugs to be suppressed based on context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478660 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [10:59:15] (03PS2) 10Jforrester: tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 [11:00:46] (03CR) 10jenkins-bot: Allow slugs to be suppressed based on context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/478660 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [11:01:09] (03CR) 10jerkins-bot: [V: 04-1] tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 (owner: 10Jforrester) [11:22:52] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10User-Ryasmeen: Provide the same version of Chrome/Chromium in Docker and Nodepool (or migrate qunit for extensions to Docker) - https://phabricator.wikimedia.org/T184102 (10Jdforrester-WMF) 05Open→03Resolved a:03hashar Declaring this Resolved v... [11:29:09] 10Editing-team, 10Contributors-Analysis, 10Product-Analytics, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10VisualEditor (Current work): Review EditAttemptStep validation failures in production - https://phabricator.wikimedia.org/T211156 (10Jdforrester-WMF) Sorry, the search you need to do is `eventloggi... [11:32:22] (03PS1) 10Jforrester: Update VE core submodule to master (018fdcb67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482006 (https://phabricator.wikimedia.org/T107745) [11:32:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Make textarea focusable (even editable?) from the get-go - https://phabricator.wikimedia.org/T212810 (10Esanders) 05Open→03Invalid If it is matmarex describes then there is nothing to be done here. [11:33:21] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (018fdcb67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482006 (https://phabricator.wikimedia.org/T107745) (owner: 10Jforrester) [11:57:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (018fdcb67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482006 (https://phabricator.wikimedia.org/T107745) (owner: 10Jforrester) [12:00:03] (03CR) 10jenkins-bot: Update VE core submodule to master (018fdcb67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482006 (https://phabricator.wikimedia.org/T107745) (owner: 10Jforrester) [12:01:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Make edit notices more visible in Visual Editor - https://phabricator.wikimedia.org/T212848 (10stjn) [12:03:05] (03PS3) 10Jforrester: ve.ce.Surface: Rearrange #findBlockSlug test to check other cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [12:04:52] (03CR) 10Jforrester: ve.ce.Surface: Rearrange #findBlockSlug test to check other cases (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [12:06:24] 10VisualEditor, 10VisualEditor-ContentEditable: Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities - https://phabricator.wikimedia.org/T107745 (10Jdforrester-WMF) [12:06:43] 10VisualEditor-ContentEditable, 10ContentTranslation, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Verified, 10VisualEditor (Current work): "Insert paragraph" slug receives input focus - https://phabricator.wikimedia.org/T209479 (10Jdforrester-WMF) [12:10:34] (03PS3) 10Jforrester: tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 [12:10:36] (03PS1) 10Jforrester: jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 [12:12:42] (03CR) 10jerkins-bot: [V: 04-1] tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 (owner: 10Jforrester) [12:12:44] (03CR) 10jerkins-bot: [V: 04-1] jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 (owner: 10Jforrester) [12:16:32] (03PS2) 10Jforrester: jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 [12:21:34] (03PS4) 10Jforrester: tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 [13:48:45] 10VisualEditor, 10VisualEditor-MediaWiki: Handle lengthy interface messages somehow without either truncating them or letting them take up more space - https://phabricator.wikimedia.org/T151313 (10Dvorapa) I agree, the modal dialog should be wider, some languages do have problems to fit in there [14:56:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Scroll can change when switching out temporary wikitext editor for full surface in NWE - https://phabricator.wikimedia.org/T212743 (10Esanders) [14:58:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Scroll can change when switching out temporary wikitext editor for full surface in NWE - https://phabricator.wikimedia.org/T212743 (10Esanders) p:05Triage→03Low We record the scroll offset and restore it when the temporary editor is replaced with... [14:59:41] 10VisualEditor, 10Parsoid: VisualEditor sometimes changes to - https://phabricator.wikimedia.org/T212342 (10Esanders) [15:13:51] (03PS1) 10Esanders: Default originalGalleryGroupItems to empty array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482037 (https://phabricator.wikimedia.org/T212809) [15:30:49] (03CR) 10Jforrester: [C: 03+2] Default originalGalleryGroupItems to empty array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482037 (https://phabricator.wikimedia.org/T212809) (owner: 10Esanders) [15:31:30] 10VisualEditor-MediaWiki-Media, 10VisualEditor (Current work): [Regression pre-wmf.8] Insert button stays disabled while trying to add a gallery - https://phabricator.wikimedia.org/T212809 (10Jdforrester-WMF) [15:44:44] (03Merged) 10jenkins-bot: Default originalGalleryGroupItems to empty array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482037 (https://phabricator.wikimedia.org/T212809) (owner: 10Esanders) [15:46:57] (03CR) 10jenkins-bot: Default originalGalleryGroupItems to empty array [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482037 (https://phabricator.wikimedia.org/T212809) (owner: 10Esanders) [15:48:47] edsanders: https://grafana.wikimedia.org/d/000000094/visualeditor-load-save?refresh=5m&orgId=1 [15:50:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482050 (owner: 10L10n-bot) [16:14:21] (03CR) 10Esanders: [C: 03+2] ve.ce.Surface: Rearrange #findBlockSlug test to check other cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [16:16:21] (03Merged) 10jenkins-bot: ve.ce.Surface: Rearrange #findBlockSlug test to check other cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [16:18:28] (03CR) 10jenkins-bot: ve.ce.Surface: Rearrange #findBlockSlug test to check other cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [16:19:42] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10User-Ryasmeen, 10VisualEditor (Current work): Third-party browser add-on adds [javascript:] within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10TheDJ) Now 0 on both. Can be closed as far... [16:27:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design, 10Patch-For-Review, 10TestMe: Make the CAPTCHA more visible when saving - https://phabricator.wikimedia.org/T72266 (10Esanders) |Before |After | {F27784473}|{F27784482} [16:27:42] (03CR) 10Esanders: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/479197 (https://phabricator.wikimedia.org/T72266) (owner: 10Esanders) [16:28:49] 10VisualEditor-MediaWiki, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Make the CAPTCHA more visible when saving - https://phabricator.wikimedia.org/T72266 (10Esanders) [16:34:04] (03CR) 10Jforrester: [C: 03+2] Move save error messages above save footer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/479197 (https://phabricator.wikimedia.org/T72266) (owner: 10Esanders) [16:55:43] (03Merged) 10jenkins-bot: Move save error messages above save footer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/479197 (https://phabricator.wikimedia.org/T72266) (owner: 10Esanders) [16:58:07] (03CR) 10jenkins-bot: Move save error messages above save footer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/479197 (https://phabricator.wikimedia.org/T72266) (owner: 10Esanders) [17:13:33] (03PS1) 10Esanders: Fix ref links in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482081 (https://phabricator.wikimedia.org/T212554) [17:37:40] 10VisualEditor-MediaWiki-Media, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10VisualEditor (Current work): [Regression pre-wmf.8] Insert button stays disabled while trying to add a gallery - https://phabricator.wikimedia.org/T212809 (10matmarex) My bad. Thanks for catching and fixing this! (The bug was in... [17:37:47] 10VisualEditor-MediaWiki-Media, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10VisualEditor (Current work): [Regression pre-wmf.12] Insert button stays disabled while trying to add a gallery - https://phabricator.wikimedia.org/T212809 (10matmarex) [17:45:25] 10VisualEditor-MediaWiki-References, 10VisualEditor (Current work): Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it - https://phabricator.wikimedia.org/T208981 (10JTannerWMF) [17:48:36] (03CR) 10Bartosz Dziewoński: ve.ce.Surface: Rearrange #findBlockSlug test to check other cases (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/481912 (owner: 10Bartosz Dziewoński) [18:27:11] 10VisualEditor, 10VisualEditor-MediaWiki: VE Page settings option for indexing/non-indexing does not communicate to user when the option cannot be applied - https://phabricator.wikimedia.org/T212458 (10Esanders) [18:27:21] 10VisualEditor, 10VisualEditor-MediaWiki: VE Page settings option for indexing/non-indexing does not communicate to user when the option cannot be applied - https://phabricator.wikimedia.org/T212458 (10Esanders) p:05Triage→03Low [18:36:03] (03PS1) 10Esanders: [WIP DNM] Selectively unwrap section tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482114 [18:37:18] (03CR) 10Esanders: [WIP DNM] Selectively unwrap section tags (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482114 (owner: 10Esanders) [19:10:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fix ref links in preview (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482081 (https://phabricator.wikimedia.org/T212554) (owner: 10Esanders) [19:53:10] (03PS1) 10VolkerE: Replace deprecated `setIndicatorTitle` with `setTitle` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482127 (https://phabricator.wikimedia.org/T76638) [20:06:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Scroll can change when switching out temporary wikitext editor for full surface in NWE - https://phabricator.wikimedia.org/T212743 (10stjn) One possible solution from an outsider’s viewpoint is not to set focus on the text field if the user is outsid... [20:23:18] (03PS10) 10Divec: WIP: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) [20:34:48] (03PS1) 10Bartosz Dziewoński: Call original MWReferenceContextItem#renderBody when overriding [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/482140 [20:36:54] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Patch-For-Review: VisualEditor should handle editing of duplicate references better - https://phabricator.wikimedia.org/T212609 (10matmarex) (I've been working on that patch for another task, but it is slightly related to this one) [20:38:52] 10VisualEditor-MediaWiki-References, 10Patch-For-Review, 10VisualEditor (Current work): Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it - https://phabricator.wikimedia.org/T208981 (10matmarex) That only improves the textual warnings, I'm st... [20:39:36] 10VisualEditor-MediaWiki-References, 10Patch-For-Review, 10VisualEditor (Current work): Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it - https://phabricator.wikimedia.org/T208981 (10matmarex) a:03matmarex [20:43:13] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace deprecated `setIndicatorTitle` with `setTitle` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482127 (https://phabricator.wikimedia.org/T76638) (owner: 10VolkerE) [20:50:35] (03PS1) 10Bartosz Dziewoński: Prevent block slugs from overlapping floated elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482147 (https://phabricator.wikimedia.org/T211844) [20:57:01] (03Merged) 10jenkins-bot: Replace deprecated `setIndicatorTitle` with `setTitle` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482127 (https://phabricator.wikimedia.org/T76638) (owner: 10VolkerE) [20:59:24] (03CR) 10jenkins-bot: Replace deprecated `setIndicatorTitle` with `setTitle` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482127 (https://phabricator.wikimedia.org/T76638) (owner: 10VolkerE) [21:12:08] (03PS3) 10Divec: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) [21:19:18] (03CR) 10jerkins-bot: [V: 04-1] WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [21:58:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482222 (owner: 10L10n-bot)