[00:47:42] (03CR) 10Krinkle: [C: 03+2] build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483206 (owner: 10Jforrester) [00:50:08] (03Merged) 10jenkins-bot: build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483206 (owner: 10Jforrester) [00:52:11] (03CR) 10jenkins-bot: build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483206 (owner: 10Jforrester) [01:22:14] (03PS2) 10Krinkle: build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:24:22] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:38:49] (03PS3) 10Krinkle: build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:43:25] (03CR) 10Jforrester: [C: 03+2] build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:43:39] (03CR) 10Jforrester: [C: 03+2] "(+1 to Timo's switch to Headless.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:45:09] (03Merged) 10jenkins-bot: build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:47:12] (03CR) 10jenkins-bot: build: Upgrade qunit from 2.8.0 to 2.9.1 to match MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483207 (owner: 10Jforrester) [01:59:24] (03PS3) 10Krinkle: jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 (owner: 10Jforrester) [01:59:43] (03CR) 10Krinkle: [C: 03+1] "Will land this one to test postmerge coverage." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 (owner: 10Jforrester) [02:01:47] (03CR) 10Krinkle: [C: 03+2] jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 (owner: 10Jforrester) [02:02:11] (03PS1) 10Jforrester: build: Commit package-lock.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483662 [02:03:23] (03Merged) 10jenkins-bot: jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 (owner: 10Jforrester) [02:05:01] (03CR) 10jenkins-bot: jsduck: Stop running jsduck for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482012 (owner: 10Jforrester) [02:20:06] (03PS1) 10Jforrester: Update VE core submodule to master (4398bb868) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 [02:33:24] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (4398bb868) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 (owner: 10Jforrester) [02:58:12] (03PS1) 10Krinkle: build: Update dev deps and build structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [02:58:17] (03PS2) 10Krinkle: build: Update dev deps and build structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [02:58:25] (03CR) 10jerkins-bot: [V: 04-1] build: Update dev deps and build structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:03:05] (03PS3) 10Krinkle: build: Update dev deps and build structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [03:04:22] (03CR) 10jerkins-bot: [V: 04-1] build: Update dev deps and build structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:09:34] (03CR) 10Krinkle: "recheck" [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:09:45] (03CR) 10jerkins-bot: [V: 04-1] build: Update dev deps and build structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:13:57] (03PS4) 10Krinkle: build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [03:14:20] (03CR) 10jerkins-bot: [V: 04-1] build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:22:53] (03PS5) 10Krinkle: build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [03:23:17] (03CR) 10jerkins-bot: [V: 04-1] build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:33:30] (03PS6) 10Krinkle: build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [03:33:53] (03CR) 10jerkins-bot: [V: 04-1] build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [03:34:38] (03PS7) 10Krinkle: build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [03:35:01] (03CR) 10jerkins-bot: [V: 04-1] build: Commit package-lock.json file and remove npmignore file [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [04:48:42] (03PS8) 10Krinkle: build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [04:49:04] (03PS9) 10Krinkle: build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [04:49:27] (03CR) 10jerkins-bot: [V: 04-1] build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [04:56:23] (03PS10) 10Krinkle: build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 [05:52:21] (03CR) 10Jforrester: [C: 03+2] build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [05:53:09] (03Merged) 10jenkins-bot: build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [05:53:38] (03CR) 10jenkins-bot: build: Update dev deps and structure [unicodejs] - 10https://gerrit.wikimedia.org/r/483668 (owner: 10Krinkle) [08:10:40] 10VisualEditor, 10Serbian-Sites, 10User-Ryasmeen: Language-appropriate icons for italic and bold for Serbian language - https://phabricator.wikimedia.org/T95761 (10Liuxinyu970226) [08:41:01] 10VisualEditor, 10VisualEditor-VisualDiffs: Feconsider URL changes done by Visual Diff - https://phabricator.wikimedia.org/T213522 (10Schnark) [08:41:14] 10VisualEditor, 10VisualEditor-VisualDiffs: Reconsider URL changes done by Visual Diff - https://phabricator.wikimedia.org/T213522 (10Schnark) [10:05:10] 10VisualEditor, 10VisualEditor-MediaWiki: Adding a category to a page without any categories doesn't show up until saving - https://phabricator.wikimedia.org/T213528 (10Schnark) [10:21:26] 10WikiEditor, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10OOUI (OOUI-0.30.0): Provide localized Bold and Italic icons for Urdu - https://phabricator.wikimedia.org/T196208 (10MuhammadShuaib) Icons are now appeared on Urdu wikipedia but do not look attractive as their size is too small and umnecessary space... [11:39:55] 10Cite, 10TCB-Team, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Need-volunteer, and 2 others: Cite silently ignores all parameters in with more than two parameters - https://phabricator.wikimedia.org/T211576 (10WMDE-Fisch) [13:41:50] (03CR) 10Esanders: [C: 04-1] "jsduck failures :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 (owner: 10Jforrester) [14:21:38] (03CR) 10Esanders: [C: 03+1] MWTemplateTitleInputWidget: Filter out templates named '…/doc' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483205 (https://phabricator.wikimedia.org/T54448) (owner: 10Jforrester) [14:27:26] 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): On mobile, template context menu doesn't show the name of the template - https://phabricator.wikimedia.org/T209610 (10Esanders) I think the desktop version should have more verbose description, in some... [14:29:27] (03CR) 10Esanders: [C: 04-1] "See bug" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473821 (https://phabricator.wikimedia.org/T209610) (owner: 10Bartosz Dziewoński) [14:29:59] (03PS1) 10Esanders: MobileContext: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483769 [14:36:23] 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): On mobile, template context menu doesn't show the name of the template - https://phabricator.wikimedia.org/T209610 (10Esanders) It would also be nice to show templatedata descriptions in the context wh... [14:41:21] 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): On mobile, template context menu doesn't show the name of the template - https://phabricator.wikimedia.org/T209610 (10Esanders) Compare with the dialog, which doesn't show the word "Template" anywhere:... [15:29:32] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Support for early community input on proposed mobile interventions - https://phabricator.wikimedia.org/T206549 (10Elitre) [15:30:06] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10Elitre) [15:40:39] (03CR) 10Jforrester: [C: 03+2] MobileContext: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483769 (owner: 10Esanders) [15:42:18] (03Merged) 10jenkins-bot: MobileContext: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483769 (owner: 10Esanders) [15:43:53] (03CR) 10jenkins-bot: MobileContext: Remove unused property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483769 (owner: 10Esanders) [16:16:34] (03PS2) 10Jforrester: Update VE core submodule to master (4398bb868) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 [16:34:27] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (4398bb868) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 (owner: 10Jforrester) [16:50:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (4398bb868) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 (owner: 10Jforrester) [16:54:15] (03CR) 10jenkins-bot: Update VE core submodule to master (4398bb868) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483665 (owner: 10Jforrester) [17:23:21] edsanders: MatmaRex: just subscribed you to https://phabricator.wikimedia.org/T213544 [19:35:55] (03PS1) 10Umherirrender: Use RecentChange::getAttribute instead of property access [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483834 [19:38:53] (03CR) 10Jforrester: [C: 03+2] Use RecentChange::getAttribute instead of property access [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483834 (owner: 10Umherirrender) [20:01:16] (03Merged) 10jenkins-bot: Use RecentChange::getAttribute instead of property access [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483834 (owner: 10Umherirrender) [20:04:11] (03CR) 10jenkins-bot: Use RecentChange::getAttribute instead of property access [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483834 (owner: 10Umherirrender) [21:50:14] 10VisualEditor, 10Editing Design : Isolate Section Editing: Determine New Workflows - https://phabricator.wikimedia.org/T209984 (10iamjessklein) I agree with @Neil_P._Quinn_WMF and actually documented this as an issue in the ticket on the prototype itself. T213429 This is an expected affordance and in fact, I... [22:10:21] 10VisualEditor, 10Editing Design : Isolate Section Editing: Determine New Workflows - https://phabricator.wikimedia.org/T209984 (10Esanders) @Neil_P._Quinn_WMF Yeah I mentioned before some controls to change back to full editing after entering section editing, or load in additional sections one at a time. With... [22:29:51] edsanders: no idea why it doesn't work, but my patch doesn't result in providing flagged -citation icons [22:29:56] :( [22:30:14] (03PS2) 10Esanders: build: Commit package-lock.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483662 (owner: 10Jforrester) [22:31:27] (03CR) 10Esanders: [C: 03+2] build: Commit package-lock.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483662 (owner: 10Jforrester) [22:32:56] (03Merged) 10jenkins-bot: build: Commit package-lock.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483662 (owner: 10Jforrester) [22:34:47] (03CR) 10jenkins-bot: build: Commit package-lock.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/483662 (owner: 10Jforrester) [23:03:26] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Verified, 10VisualEditor (Current work): Summary-links not correct - https://phabricator.wikimedia.org/T208978 (10Ryasmeen)