[01:41:10] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10matmarex) > In any case, could you also investigate the second part of my comment there about VE losing the id attribute in some scenarios? I managed... [01:41:44] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10VisualEditor (Current work): VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10matmarex) p:05Triage→03Unbreak! (Wikitext corruption → UBN) [01:42:08] (03CR) 10Bartosz Dziewoński: "Caused T213922" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/481894 (https://phabricator.wikimedia.org/T207325) (owner: 10Esanders) [01:42:18] (03PS1) 10Bartosz Dziewoński: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/484820 (https://phabricator.wikimedia.org/T213922) [01:47:21] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10Patch-For-Review, 10VisualEditor (Current work): VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10matmarex) >>! In T213922#4886360, @ssastry wrote: >>>! In T213922#4886149, @matmarex wrote: >> @ssastry Note that... [01:49:24] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10Patch-For-Review, 10VisualEditor (Current work): VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10matmarex) I filed a separate task for the minor Parsoid issue noted by Subbu: {T213995} [03:13:52] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in template data GUI editor - https://phabricator.wikimedia.org/T208305 (10srishakatux) @Mvolz Would you be interested in mentoring this project for #gsoc2019 or #outreachy18? [[ https://www.mediawiki.org/wiki/Google_Summe... [03:16:58] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Extension-MobileApp, and 2 others: Add ability to cite books by scanning their ISBN barcode in mobile app. - https://phabricator.wikimedia.org/T208134 (10srishakatux) Would any of the task subscribers be interested in mentoring this project for #... [06:13:48] (03PS1) 10VolkerE: Re-introduce: Replace deprecated `setIndicatorTitle` with `setTitle` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/484850 (https://phabricator.wikimedia.org/T76638) [08:20:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/484961 (owner: 10L10n-bot) [08:45:46] 10VisualEditor, 10VisualEditor-LanguageTool, 10ContentTranslation: Support correction of spelling, grammar and style errors in Content Translation - https://phabricator.wikimedia.org/T186404 (10Rsneha) Thanks for sharing this useful information, i also suggest to use this [[ https://grammarchecker.net/online... [08:52:02] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10Patch-For-Review, 10User-notice, 10VisualEditor (Current work): VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10Trizek-WMF) [10:00:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/484986 (owner: 10L10n-bot) [12:36:56] (03CR) 10Esanders: [C: 03+2] Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/484820 (https://phabricator.wikimedia.org/T213922) (owner: 10Bartosz Dziewoński) [12:54:59] (03Merged) 10jenkins-bot: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/484820 (https://phabricator.wikimedia.org/T213922) (owner: 10Bartosz Dziewoński) [12:56:58] (03CR) 10jenkins-bot: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/484820 (https://phabricator.wikimedia.org/T213922) (owner: 10Bartosz Dziewoński) [12:58:31] (03PS1) 10Esanders: Don't preserve all HTML attributes on transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/485024 (https://phabricator.wikimedia.org/T207325) [13:09:05] 10Citoid, 10VisualEditor: Better UI flow for PDFs - https://phabricator.wikimedia.org/T214038 (10Mvolz) [13:20:48] (03PS2) 10Esanders: Only preserve data-parsoid/RESTBase ID on transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/485024 (https://phabricator.wikimedia.org/T207325) [13:28:51] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Translate: $data->paramOrder is null on translatable pages - https://phabricator.wikimedia.org/T213953 (10Nikerabbit) I have a hunch that TemplateData relies on some behavior that for some reason is suppressed on translatable pages, but I would be happy... [13:40:34] 10VisualEditor, 10translatewiki.net, 10I18n: New lines and diff not displayed in Visual Editor compared to old editor - https://phabricator.wikimedia.org/T214040 (10Wladek92) [13:45:02] 10VisualEditor, 10translatewiki.net, 10I18n: New lines and diff not displayed in Visual Editor compared to old editor - https://phabricator.wikimedia.org/T214040 (10Nikerabbit) Can you clarify what do you mean with old editor? From my point of view the only fully-featured translation interface is Special:Tra... [13:54:38] 10VisualEditor, 10translatewiki.net, 10I18n: New lines and diff not displayed in Visual Editor compared to old editor - https://phabricator.wikimedia.org/T214040 (10Wladek92) Link: https://translatewiki.net/w/i.php?title=Special:Translate&showMessage=phabricator-diffusion-0f50f5cdbad0a3e2&group=phabricator-p... [13:55:41] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Editing QA, and 2 others: Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Esanders) It looks like this floating context became standard... [14:02:09] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Editing QA, and 2 others: Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Esanders) > we can consider if we need a different fix for ol... [14:12:03] (03PS1) 10Esanders: Only fix context menu position when Android >= 6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/485032 (https://phabricator.wikimedia.org/T202723) [16:10:17] edsanders, MatmaRex: Do you want to hot-deploy https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/484820 to prod? [16:10:48] James_F: i was going to swat it [16:11:19] Kk, will leave with you. [16:11:46] Or I could just deploy it now? It's a prod corruption issue… [16:14:10] James_F: fine by me as well, if you can [16:14:23] Kk. [16:14:32] (03PS1) 10Jforrester: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/485048 (https://phabricator.wikimedia.org/T213922) [16:14:39] (03CR) 10Jforrester: [C: 03+2] Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/485048 (https://phabricator.wikimedia.org/T213922) (owner: 10Jforrester) [16:15:02] Let's hot-deploy just to wmf.13? [16:19:40] James_F: i was going to do wmf.12 as well, it's still a few hours to the train. but i can do it during swat [16:20:06] OK, wmf.12 too. [16:20:26] (03PS1) 10Jforrester: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.12) - 10https://gerrit.wikimedia.org/r/485049 (https://phabricator.wikimedia.org/T213922) [16:20:26] (03CR) 10Jforrester: [C: 03+2] Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.12) - 10https://gerrit.wikimedia.org/r/485049 (https://phabricator.wikimedia.org/T213922) (owner: 10Jforrester) [16:26:50] thanks [16:31:08] (03CR) 10jerkins-bot: [V: 04-1] Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/485048 (https://phabricator.wikimedia.org/T213922) (owner: 10Jforrester) [16:33:57] (03Merged) 10jenkins-bot: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.12) - 10https://gerrit.wikimedia.org/r/485049 (https://phabricator.wikimedia.org/T213922) (owner: 10Jforrester) [16:34:44] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/VisualEditor] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/485048 (https://phabricator.wikimedia.org/T213922) (owner: 10Jforrester) [16:41:32] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Translate, 10Wikimedia-production-error: $data->paramOrder is null on translatable pages - https://phabricator.wikimedia.org/T213953 (10matmarex) [16:48:08] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), and 2 others: Transclusion dialog should not suggest documentation sub pages as templates - https://phabricator.wikimedia.org/T54448 (10Johan) Is this done and will be deployed next... [16:53:16] 10VisualEditor: Middle-clicking links in inspectors removes elements (related to Linux middle-click to paste?) - https://phabricator.wikimedia.org/T213253 (10JTannerWMF) We will further investigate [16:53:29] (03Merged) 10jenkins-bot: Revert "Don't preserveHtmlAttributes on transclusion nodes" [extensions/VisualEditor] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/485048 (https://phabricator.wikimedia.org/T213922) (owner: 10Jforrester) [16:54:14] (03CR) 10DLynch: [C: 03+2] Only fix context menu position when Android >= 6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/485032 (https://phabricator.wikimedia.org/T202723) (owner: 10Esanders) [16:56:36] (03Merged) 10jenkins-bot: Only fix context menu position when Android >= 6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/485032 (https://phabricator.wikimedia.org/T202723) (owner: 10Esanders) [16:57:48] (03CR) 10jenkins-bot: Only fix context menu position when Android >= 6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/485032 (https://phabricator.wikimedia.org/T202723) (owner: 10Esanders) [17:00:17] MatmaRex: All done. [17:02:57] James_F: thanks! sorry, i was in a meeting [17:03:40] No worries. :-) [17:07:08] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10Patch-For-Review, and 2 others: VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10matmarex) @Jdforrester-WMF deployed the patches. The issue should now be fixed on all... [17:12:21] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10User-notice, 10VisualEditor (Current work): VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10Jdforrester-WMF) [17:19:30] (03CR) 10Esanders: [C: 04-1] "> You can replace a reference that is only used once." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/483337 (https://phabricator.wikimedia.org/T71498) (owner: 10Bartosz Dziewoński) [17:22:22] (03CR) 10Esanders: [C: 04-1] "If you split out a mobile-only change I'll merge that, but if we are going to change Desktop we should consider other options first." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473821 (https://phabricator.wikimedia.org/T209610) (owner: 10Bartosz Dziewoński) [17:52:40] (03PS3) 10Esanders: Fix ref links in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482081 (https://phabricator.wikimedia.org/T212554) [17:53:14] (03PS4) 10Esanders: Fix fragment links in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482081 (https://phabricator.wikimedia.org/T212554) [17:59:59] 10VisualEditor, 10MinervaNeue, 10Readers-Web-Backlog, 10Mobile: Issues with switching between editors when wikitext editor is default - https://phabricator.wikimedia.org/T213883 (10Jdlrobson) I believe this falls under the editing team, since the button is created by VisualEditor. @Esanders please correct... [18:00:13] (03CR) 10DLynch: [C: 04-1] Fix fragment links in preview (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/482081 (https://phabricator.wikimedia.org/T212554) (owner: 10Esanders) [19:16:11] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), and 2 others: Transclusion dialog should not suggest documentation sub pages as templates - https://phabricator.wikimedia.org/T54448 (10Jdforrester-WMF) >>! In T54448#4888682, @Johan... [19:17:01] (03CR) 10Jforrester: "> Patch Set 3:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483205 (https://phabricator.wikimedia.org/T54448) (owner: 10Jforrester) [19:22:26] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10Patch-For-Review, 10VisualEditor (Current work): Custom VE error handling for AbuseFilter etc. is not enabled on mobile - https://phabricator.wikimedia.org/T213774 (10Esanders) Oy that "targets" property.... [19:23:35] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10User-notice, 10VisualEditor (Current work): VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10matmarex) The issue was introduced in wmf.12, so it affected edits made... [19:32:44] 10VisualEditor, 10Parsoid: Splitting a paragraph duplicated it - https://phabricator.wikimedia.org/T203112 (10matmarex) This is still reproducible on that page. Looks like we send HTML like this to Parsoid: `lang=html

In examining this question by gender, we can observe some differences. We canno... [19:50:54] 10VisualEditor, 10Parsoid: Splitting a paragraph duplicated it - https://phabricator.wikimedia.org/T203112 (10Esanders) I think this is deliberate when we split nodes, so that wikitext formatting is preserved (not an issue for paragraphs, but for headings/table cells/lists etc.) [19:53:48] 10VisualEditor, 10Collection, 10Parsoid: Leaving out 'prefix' option breaks Visual Editor when Collection extension is installed - https://phabricator.wikimedia.org/T213900 (10matmarex) Does the VisualEditor issue only happen when Collection is installed? I must say I have no idea how they are even related.... [19:54:14] 10VisualEditor, 10Collection, 10Parsoid, 10RESTBase: Leaving out 'prefix' option breaks Visual Editor when Collection extension is installed - https://phabricator.wikimedia.org/T213900 (10matmarex) [19:58:21] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Translate, 10Wikimedia-production-error: $data->paramOrder is null on translatable pages - https://phabricator.wikimedia.org/T213953 (10matmarex) Related to {4aaa9dfcf8a113aae73fc20f53cf0c9fa6d7a50c}? [20:04:29] (03CR) 10Esanders: "It would also be nice to upstream this back to mw.widgets at some point, so removing the hard dependency on TemplateData would be nice." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483205 (https://phabricator.wikimedia.org/T54448) (owner: 10Jforrester) [20:08:00] (03PS4) 10Jforrester: MWTemplateTitleInputWidget: Filter out templates named '…/doc' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483205 (https://phabricator.wikimedia.org/T54448) [20:14:11] (03CR) 10jerkins-bot: [V: 04-1] MWTemplateTitleInputWidget: Filter out templates named '…/doc' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/483205 (https://phabricator.wikimedia.org/T54448) (owner: 10Jforrester) [22:11:18] (03CR) 10Bartosz Dziewoński: "Correct, but you can't "just edit it" if you want to generate the citation with Citoid." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/483337 (https://phabricator.wikimedia.org/T71498) (owner: 10Bartosz Dziewoński) [22:12:22] 10VisualEditor, 10MobileFrontend: Consider adding a button to let users edit the whole page in MobileFrontend - https://phabricator.wikimedia.org/T203151 (10iamjessklein) [22:12:24] 10VisualEditor, 10Editing Design : [Design EPIC]: Isolate Section Editing - https://phabricator.wikimedia.org/T209974 (10iamjessklein) [22:20:16] 10VisualEditor, 10Collection, 10Parsoid, 10RESTBase: Leaving out 'prefix' option breaks Visual Editor when Collection extension is installed - https://phabricator.wikimedia.org/T213900 (10Arlolra) > I must say I have no idea how they are even related. At one point, the Collection extension used #offlineco... [22:33:03] (03CR) 10Jforrester: [C: 03+1] ui.AnnotationInspector: tweak selection after adding annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/482673 (https://phabricator.wikimedia.org/T211236) (owner: 10DLynch) [23:05:29] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Translate, 10Wikimedia-production-error: $data->paramOrder is null on translatable pages - https://phabricator.wikimedia.org/T213953 (10Tacsipacsi) Maybe. But the odd thing is that it works on a non-translatable page, so it somehow magically gets back... [23:22:37] 10Citoid: Problem with encoding in Citoid - generation of reference from certain websites - https://phabricator.wikimedia.org/T212490 (10zhaofengli) An example would be http://nna-leb.gov.lb/ar/show-report/371/, from which Citoid extracts metadata containing UTF-8 replacement characters. ` [ { "key": "U5U...