[02:55:10] 10TemplateData, 10VisualEditor, 10MediaWiki-API: PHP fatal error from action=templatedata API: Argument 1 passed to ApiResult::setIndexedTagName() must be an instance of array, null given - https://phabricator.wikimedia.org/T214254 (10Evad37) [05:39:03] 10TemplateData, 10VisualEditor, 10MediaWiki-API: PHP fatal error from action=templatedata API: Argument 1 passed to ApiResult::setIndexedTagName() must be an instance of array, null given - https://phabricator.wikimedia.org/T214254 (10Dvorapa) Seems like T213953 to me [07:36:37] 10TemplateData, 10VisualEditor, 10MediaWiki-API: PHP fatal error from action=templatedata API: Argument 1 passed to ApiResult::setIndexedTagName() must be an instance of array, null given - https://phabricator.wikimedia.org/T214254 (10Evad37) Yeah, looks like its probably another manifestation of the same error [07:38:01] 10TemplateData, 10VisualEditor, 10MediaWiki-API: PHP fatal error from action=templatedata API: Argument 1 passed to ApiResult::setIndexedTagName() must be an instance of array, null given - https://phabricator.wikimedia.org/T214254 (10Evad37) [07:38:05] 10TemplateData, 10VisualEditor, 10Wikimedia-production-error: $data->paramOrder is null on translatable pages - https://phabricator.wikimedia.org/T213953 (10Evad37) [07:40:47] 10TemplateData, 10VisualEditor, 10Wikimedia-production-error: $data->paramOrder is null on translatable pages - https://phabricator.wikimedia.org/T213953 (10Evad37) From the merged task: > A GET request for https://en.wikipedia.org/w/api.php?action=templatedata&format=json&titles=Template%3AWikiProject%20In... [07:45:20] 10TemplateData, 10VisualEditor, 10MediaWiki-API, 10Wikimedia-production-error: $data->paramOrder is null on pages edited since MediaWiki 1.33/wmf.13 was deployed - https://phabricator.wikimedia.org/T213953 (10Evad37) [08:21:45] 10TemplateData, 10VisualEditor, 10MediaWiki-API, 10Wikimedia-production-error: $data->paramOrder is null on pages edited since MediaWiki 1.33/wmf.13 was deployed - https://phabricator.wikimedia.org/T213953 (10Evad37) Although it also isn't working for [[https://en.wikipedia.org/w/api.php?action=templatedat... [08:44:12] 10TemplateData, 10VisualEditor, 10MediaWiki-API, 10Wikimedia-production-error: $data->paramOrder is null on pages edited since MediaWiki 1.33/wmf.13 was deployed - https://phabricator.wikimedia.org/T213953 (10Krinkle) p:05Triage→03Unbreak! [15:40:12] 10TemplateData, 10VisualEditor, 10MediaWiki-API, 10Wikimedia-production-error: $data->paramOrder is null on pages edited since MediaWiki 1.33/wmf.13 was deployed - https://phabricator.wikimedia.org/T213953 (10Anomie) >>! In T213953#4890005, @matmarex wrote: > Related to {4aaa9dfcf8a113aae73fc20f53cf0c9fa6d... [15:49:22] (03PS1) 10Anomie: ApiTemplateData: Check for $data->paramOrder being unset [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485492 (https://phabricator.wikimedia.org/T213953) [15:51:27] (03CR) 10Anomie: "If anyone wants a unit test here, feel free to amend or followup to add one. There currently aren't any tests at all for ApiTemplateData." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485492 (https://phabricator.wikimedia.org/T213953) (owner: 10Anomie) [15:58:48] 10VisualEditor: An extra blank line added below when editing a paragraph - https://phabricator.wikimedia.org/T212812 (10valhallasw) 05Stalled→03Open Hi @Inaki-LL , thank you for reporting this. I'm moving this task to the VisualEditor project; I think the maintainers of that project should be able to determi... [19:40:08] (03PS8) 10John Erling Blad: Lua method for TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [19:58:11] (03CR) 10John Erling Blad: "I believe that should close all remaining comments." (0323 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [20:05:35] (03CR) 10John Erling Blad: [C: 03+1] "Tried to keep as much as possible from Putniks changeset, so now it should be slightly refactored, but better to do that after an initial " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [20:12:11] (03CR) 10John Erling Blad: "Forgot one, a file header on the PHP-file." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [20:15:29] (03CR) 10John Erling Blad: "Leftover…" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [20:33:32] (03PS1) 10Fomafix: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 [22:13:21] 10VisualEditor-ContentEditable, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10Patch-For-Review, and 4 others: [Regression pre-wmf.18] Toolbar does not get activated after pressing return - https://phabricator.wikimedia.org/T202359 (10Peachey88)