[03:05:41] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Israel-Hackers, 10Patch-For-Review: Provide a Lua method mw.templatedata.load() - https://phabricator.wikimedia.org/T107119 (10jeblad) 05Open→03Stalled Perhaps if someone else does the followup. [03:31:11] (03PS1) 10Bartosz Dziewoński: ve.ui.FindAndReplaceDialog: Debounce calls to save user options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487548 (https://phabricator.wikimedia.org/T214963) [03:39:30] (03CR) 10Jforrester: [C: 03+2] ve.ui.FindAndReplaceDialog: Debounce calls to save user options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487548 (https://phabricator.wikimedia.org/T214963) (owner: 10Bartosz Dziewoński) [03:40:58] (03Merged) 10jenkins-bot: ve.ui.FindAndReplaceDialog: Debounce calls to save user options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487548 (https://phabricator.wikimedia.org/T214963) (owner: 10Bartosz Dziewoński) [03:43:06] (03CR) 10jenkins-bot: ve.ui.FindAndReplaceDialog: Debounce calls to save user options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487548 (https://phabricator.wikimedia.org/T214963) (owner: 10Bartosz Dziewoński) [03:46:23] (03PS1) 10Jforrester: Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) [03:48:13] (03CR) 10Tchanders: [C: 03+2] Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [03:53:11] (03PS1) 10Bartosz Dziewoński: ve.ui.MWGalleryDialog: Allow normal tools in gallery captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487550 (https://phabricator.wikimedia.org/T187958) [03:59:33] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:04:10] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:06:29] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.MWGalleryDialog: Allow normal tools in gallery captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487550 (https://phabricator.wikimedia.org/T187958) (owner: 10Bartosz Dziewoński) [04:07:23] (03PS2) 10Jforrester: Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) [04:07:25] (03PS1) 10Jforrester: MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487551 [04:12:37] (03PS1) 10Jforrester: ve.ui.FindAndReplaceDialog: Debounce calls to save user options [VisualEditor/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487553 (https://phabricator.wikimedia.org/T214963) [04:13:22] (03CR) 10Jforrester: [C: 03+2] "Hot-deploying." [VisualEditor/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487553 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:14:44] MatmaRex: You're wonderful, but you should be partying, not workin. :-) [04:21:01] i'm just taking a break [04:21:06] James_F: how about you, huh? [04:21:25] I'm deploying code to fix production, I've got an excuse. ;-) [04:22:47] 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10User-notice, 10VisualEditor (Current work): Transclusion dialog should not suggest documentation sub pages as templates - https://phabricator.wikimedia.org/T54448 (10Jdforrester-WMF) [04:23:03] (03CR) 10Jforrester: [C: 03+2] "…" [VisualEditor/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487553 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:27:59] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) [04:28:23] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:28:42] (03CR) 10Jforrester: [C: 03+2] MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487551 (owner: 10Jforrester) [04:28:52] (03CR) 10Jforrester: [C: 03+2] "Per Thalia." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:30:51] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:35:50] 10VisualEditor, 10Continuous-Integration-Config: VE sub-module not running jobs on wmf/ branches? - https://phabricator.wikimedia.org/T215089 (10Jdforrester-WMF) [04:37:36] 10VisualEditor, 10Continuous-Integration-Config: VE sub-module not running jobs on wmf/ branches? - https://phabricator.wikimedia.org/T215089 (10Jdforrester-WMF) In cherry-picking https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/487553 I C+2'ed it twice but it never entered the zuul runner; I was h... [04:38:35] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:42:49] (03Merged) 10jenkins-bot: MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487551 (owner: 10Jforrester) [04:42:52] (03Merged) 10jenkins-bot: Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:44:06] (03PS1) 10Jforrester: MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487559 [04:44:11] (03CR) 10Jforrester: [C: 03+2] MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487559 (owner: 10Jforrester) [04:44:20] (03PS2) 10Jforrester: Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) [04:44:32] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:44:48] (03CR) 10jenkins-bot: MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487551 (owner: 10Jforrester) [04:45:54] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487550 (https://phabricator.wikimedia.org/T187958) (owner: 10Bartosz Dziewoński) [04:46:34] (03CR) 10jenkins-bot: Update VE core submodule to master (3c1c8429d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487549 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [04:51:09] (03PS1) 10Jforrester: mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487560 (https://phabricator.wikimedia.org/T214963) [04:52:09] (03CR) 10jerkins-bot: [V: 04-1] MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487559 (owner: 10Jforrester) [04:52:20] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [05:00:35] (03CR) 10jerkins-bot: [V: 04-1] MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487559 (owner: 10Jforrester) [05:00:36] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [05:02:36] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487559 (owner: 10Jforrester) [05:02:40] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [05:20:44] (03Merged) 10jenkins-bot: MWMediaTransferHandler: Fix new eslint warning from unused global [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487559 (owner: 10Jforrester) [05:37:00] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.33.0-wmf.14 HEAD (a4a87905) [extensions/VisualEditor] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/487554 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [07:24:00] How to update the reference adding feature on diffrent wiki like the way english wiki is behaving [07:25:36] On other wiki it show a box and generates cite automatically. But on orwiki it only show two options to add reference and to reuse a reference [07:27:06] gyan: see here: https://www.mediawiki.org/wiki/Citoid/Enabling_Citoid_on_your_wiki#Step_2:_Configure_Citoid [07:30:18] ok [07:44:09] I have gone through this. Citoid is working for source editor but not on visual editor in my case. [07:53:13] I have imported the latest templates from en wiki and it's working now [16:15:44] (03CR) 10Fomafix: Preload tablesorter styles by module 'jquery.tablesorter.styles' (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [16:16:15] (03PS2) 10Fomafix: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 [19:01:09] (03PS1) 10Esanders: build: Update eslint-config-wikimedia to 0.10.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487593 [19:03:00] (03PS1) 10Esanders: build: Update eslint-config-wikimedia to 0.10.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487594 [19:52:03] (03PS1) 10D3r1ck01: Fix PHPDoc comments to the canonical format (@param [Type] [name]) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487602 [19:55:32] (03PS1) 10D3r1ck01: Remove unused private method from VisualEditorHooks class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487604 [19:56:34] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487602 (owner: 10D3r1ck01) [19:56:47] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487604 (owner: 10D3r1ck01) [20:01:30] (03CR) 10jerkins-bot: [V: 04-1] Remove unused private method from VisualEditorHooks class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487604 (owner: 10D3r1ck01) [20:03:45] (03CR) 10Umherirrender: [C: 03+2] Fix PHPDoc comments to the canonical format (@param [Type] [name]) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487602 (owner: 10D3r1ck01) [20:04:37] (03PS1) 10D3r1ck01: Remove "return true" legacy behavior from hook handler functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487608 [20:12:07] (03Abandoned) 10D3r1ck01: Remove unused private method from VisualEditorHooks class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487604 (owner: 10D3r1ck01) [20:17:51] (03PS1) 10D3r1ck01: Remove "return true" legacy behavior from hook handler functions [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/487609 [20:22:11] (03PS2) 10D3r1ck01: Remove "return true" legacy behavior from hook handler functions [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/487609 [20:25:23] (03Merged) 10jenkins-bot: Fix PHPDoc comments to the canonical format (@param [Type] [name]) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487602 (owner: 10D3r1ck01) [20:43:16] (03CR) 10jenkins-bot: Fix PHPDoc comments to the canonical format (@param [Type] [name]) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487602 (owner: 10D3r1ck01) [20:44:58] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Israel-Hackers, 10Patch-For-Review: Provide a Lua method mw.templatedata.load() - https://phabricator.wikimedia.org/T107119 (10stjn) 05Stalled→03Open @jeblad: can you explain your reasoning? Just because no one finished the patch,... [20:45:53] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487608 (owner: 10D3r1ck01) [20:55:45] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/487609 (owner: 10D3r1ck01) [21:25:10] (03CR) 10Jforrester: [C: 03+2] build: Update eslint-config-wikimedia to 0.10.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487593 (owner: 10Esanders) [21:26:39] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487593 (owner: 10Esanders) [21:27:01] (03CR) 10Jforrester: [C: 03+2] build: Update eslint-config-wikimedia to 0.10.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487594 (owner: 10Esanders) [21:28:06] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/487593 (owner: 10Esanders) [21:31:08] (03CR) 10Jforrester: "I'd rather we raise the support requirements explicitly." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [21:33:36] (03CR) 10Fomafix: "MediaWiki 1.33 is not a hard requirement for this change." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [21:39:36] (03CR) 10Jforrester: "Yes, it is. This code will fail tests when run with REL1_32 because it depends on the jquery.tablesorter.styles module that doesn't exist." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [21:44:26] (03CR) 10Fomafix: "I see no runtime error or warning when addModuleStyle'ing an not existing module." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [21:45:00] (03CR) 10Jforrester: "Correct. The error is at test run time." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [21:45:29] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487594 (owner: 10Esanders) [21:47:28] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487594 (owner: 10Esanders) [21:59:13] (03CR) 10Fomafix: "The "requires" attribute in extension.json is a runtime requirement. Here is 1.33 not needed and therefor I did not set it." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [22:23:14] (03CR) 10Jforrester: [C: 03+2] Remove "return true" legacy behavior from hook handler functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487608 (owner: 10D3r1ck01) [22:23:17] (03CR) 10Jforrester: [C: 03+2] Remove "return true" legacy behavior from hook handler functions [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/487609 (owner: 10D3r1ck01) [22:37:27] (03Merged) 10jenkins-bot: Remove "return true" legacy behavior from hook handler functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487608 (owner: 10D3r1ck01) [22:37:29] (03Merged) 10jenkins-bot: Remove "return true" legacy behavior from hook handler functions [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/487609 (owner: 10D3r1ck01) [22:39:34] (03CR) 10jenkins-bot: Remove "return true" legacy behavior from hook handler functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487608 (owner: 10D3r1ck01)