[00:16:03] 10VisualEditor-EditingTools, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Verified, 10VisualEditor (Current work): After changing a link target, the link is selected such that typing will delete the link - https://phabricator.wikimedia.org/T211236 (10Ryasmeen) [00:46:24] 10VisualEditor: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null" - https://phabricator.wikimedia.org/T215367 (10Ryasmeen) [01:27:12] (03PS1) 10Esanders: build: Update eslint-config-wikimedia 0.10.1 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/488212 [01:34:59] (03CR) 10Jforrester: [C: 03+2] build: Update eslint-config-wikimedia 0.10.1 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/488212 (owner: 10Esanders) [01:49:13] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia 0.10.1 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/488212 (owner: 10Esanders) [03:37:44] (03PS2) 10Bartosz Dziewoński: [DO NOT MERGE] Artificial loading delay for testing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/486412 (https://phabricator.wikimedia.org/T210630) [03:37:46] (03PS1) 10Bartosz Dziewoński: DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488228 [03:37:48] (03PS1) 10Bartosz Dziewoński: DesktopArticleTarget: Fix position of progress bar if editor is reloaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488229 [03:37:50] (03PS1) 10Bartosz Dziewoński: DesktopArticleTarget: Make the progress bar into a reusable widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) [03:41:31] (03CR) 10Bartosz Dziewoński: "Used in https://gerrit.wikimedia.org/r/486408" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [03:52:43] (03CR) 10jerkins-bot: [V: 04-1] [DO NOT MERGE] Artificial loading delay for testing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/486412 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [03:53:10] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: Make the progress bar into a reusable widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [05:00:05] (03PS16) 10Divec: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) [05:34:40] (03PS15) 10Divec: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) [05:35:00] (03CR) 10jerkins-bot: [V: 04-1] WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [08:40:49] 10Citoid, 10Patch-For-Review, 10User-Sebastian_Berlin-WMSE, 10WMSE-Development-Support-2019 (Citoid library for SVWP): Missing fields in response - https://phabricator.wikimedia.org/T211275 (10Sebastian_Berlin-WMSE) 05Open→03Resolved a:03Sebastian_Berlin-WMSE The general problem seems to be fixed now... [10:07:05] 10VisualEditor, 10Regression: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null" - https://phabricator.wikimedia.org/T215367 (10Peachey88) [10:49:39] 10VisualEditor: Blockquote elements are not editable any longer - https://phabricator.wikimedia.org/T215400 (10TheDJ) [10:51:24] 10VisualEditor: [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10TheDJ) [10:51:26] 10VisualEditor: Blockquote elements are not editable any longer - https://phabricator.wikimedia.org/T215400 (10TheDJ) [12:50:45] 10VisualEditor, 10MobileFrontend: Exception when switching from mobile VE to wikitext: "Uncaught TypeError: e is not a constructor" - https://phabricator.wikimedia.org/T215408 (10matmarex) [12:51:15] 10VisualEditor, 10Regression: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null" - https://phabricator.wikimedia.org/T215367 (10matmarex) I can't reproduce this. Does it still happen for you? If so, can you copy-past... [12:53:14] 10VisualEditor, 10MobileFrontend: Exception when switching from mobile VE to wikitext: "Uncaught TypeError: e is not a constructor" - https://phabricator.wikimedia.org/T215408 (10matmarex) a:03matmarex Caused by d13353879a30c79095c54b904987898650a27f8c (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/M... [12:54:00] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review: Exception when switching from mobile VE to wikitext: "Uncaught TypeError: e is not a constructor" - https://phabricator.wikimedia.org/T215408 (10matmarex) This will need to be backported to 1.33.0-wmf.16. [13:06:05] 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 10Epic, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), and 2 others: VE should translate ... into ... - https://phabricator.wikimedia.org/T93081 (10MarkAHershberger) Thank you so much, @osorio-juan-microsoft !... [16:06:30] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Exception when switching from mobile VE to wikitext: "Uncaught TypeError: e is not a constructor" - https://phabricator.wikimedia.org/T215408 (10Jdlrobson) Bug was caused by me during refac... [16:22:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Epic, 10Technical-Debt: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186 (10matmarex) [16:22:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, 10MobileFrontend, 10Technical-Debt: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559 (10matmarex) 05Open→03Declined I think this would not be helpful at this point, especial... [16:47:48] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Load page content in parallel with VE code on Mobile with ArticleTargetLoader - https://phabricator.wikimedia.org/T209052 (10matmarex) Scheduled for SWAT: https:... [17:09:02] (03PS17) 10Esanders: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:14:36] (03CR) 10Esanders: [C: 04-1] Support only surfacing part of the document (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:54:48] 10VisualEditor, 10Regression: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null" - https://phabricator.wikimedia.org/T215367 (10Etonkovidova) Go to any page (e.g. https://m.mediawiki.org/w/index.php?title=User:Etonko... [18:33:17] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488262 (owner: 10Libraryupgrader) [18:33:21] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488262 (owner: 10Libraryupgrader) [18:36:38] 10VisualEditor, 10Regression: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null" - https://phabricator.wikimedia.org/T215367 (10matmarex) I reproduced this accidentally but I'm not sure how. I will poke at it a bit m... [19:01:06] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488262 (owner: 10Libraryupgrader) [20:32:39] (03PS18) 10Esanders: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [20:34:41] (03CR) 10Esanders: "I'm a little concerned about the overloading of "root". We already have a .root property on ve.Node which means something different." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [20:40:21] 10VisualEditor, 10Regression: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null" - https://phabricator.wikimedia.org/T215367 (10matmarex) Okay, steps to reproduce: 1. Be on a wmf.14 wiki (currently mediawiki.org is... [20:42:58] (03PS16) 10Esanders: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [20:50:30] (03CR) 10jerkins-bot: [V: 04-1] WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [21:15:46] (03CR) 10Esanders: [C: 03+2] DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488228 (owner: 10Bartosz Dziewoński) [21:16:03] (03CR) 10Esanders: [C: 03+2] DesktopArticleTarget: Fix position of progress bar if editor is reloaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488229 (owner: 10Bartosz Dziewoński) [21:17:37] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Make the progress bar into a reusable widget (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [21:20:05] (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Make the progress bar into a reusable widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [21:20:45] (03PS2) 10Bartosz Dziewoński: DesktopArticleTarget: Make the progress bar into a reusable widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) [21:20:55] (03CR) 10Bartosz Dziewoński: DesktopArticleTarget: Make the progress bar into a reusable widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [21:28:42] (03CR) 10Esanders: [C: 03+1] "I think I was reading setSession. In which case it looks like other than API calls, all we do is update in-memory, not localStorage or ses" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487560 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [21:29:18] (03CR) 10Esanders: [C: 03+2] mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487560 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [21:31:12] (03Merged) 10jenkins-bot: DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488228 (owner: 10Bartosz Dziewoński) [21:31:35] (03Merged) 10jenkins-bot: DesktopArticleTarget: Fix position of progress bar if editor is reloaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488229 (owner: 10Bartosz Dziewoński) [21:34:04] (03CR) 10jenkins-bot: DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488228 (owner: 10Bartosz Dziewoński) [21:36:03] (03CR) 10jenkins-bot: DesktopArticleTarget: Fix position of progress bar if editor is reloaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488229 (owner: 10Bartosz Dziewoński) [21:37:57] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTransclusionContextItem: Use the right class name in override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488580 (https://phabricator.wikimedia.org/T209610) [21:38:25] edsanders: ooops https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/488580 [21:39:13] edsanders: if you're working on lint stuff… having something to prevent mistakes like this or like https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/488230/1/modules/ve-mw/init/ve.init.mw.ProgressBarWidget.js#22 would be great [21:39:38] (03CR) 10Esanders: [C: 03+2] ve.ui.MWTransclusionContextItem: Use the right class name in override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488580 (https://phabricator.wikimedia.org/T209610) (owner: 10Bartosz Dziewoński) [21:39:55] does that need to be backported? [21:40:19] MatmaRex: those were all picked up by eslint... [21:40:37] well, except for the wrong function name [21:40:44] yeah, the function name [21:41:00] (sorry about the others, i didn't notice it got a V-1 from jenkins) [21:41:06] edsanders: yes. i will backport [21:41:29] https://eslint.org/docs/rules/func-name-matching [21:41:30] i'm also doing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/488523 [21:42:20] not quite what we want but a good starting point [21:43:41] (03Merged) 10jenkins-bot: mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487560 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [21:45:51] (03CR) 10jenkins-bot: mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/487560 (https://phabricator.wikimedia.org/T214963) (owner: 10Jforrester) [21:53:16] (03PS1) 10Esanders: Fix function name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488585 [21:53:42] (03Merged) 10jenkins-bot: ve.ui.MWTransclusionContextItem: Use the right class name in override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488580 (https://phabricator.wikimedia.org/T209610) (owner: 10Bartosz Dziewoński) [21:54:33] (03PS1) 10Esanders: Fix function name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488586 [21:55:58] (03CR) 10jenkins-bot: ve.ui.MWTransclusionContextItem: Use the right class name in override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488580 (https://phabricator.wikimedia.org/T209610) (owner: 10Bartosz Dziewoński) [22:11:19] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTransclusionContextItem: Use the right class name in override [extensions/VisualEditor] (wmf/1.33.0-wmf.16) - 10https://gerrit.wikimedia.org/r/488592 (https://phabricator.wikimedia.org/T209610) [22:18:13] (03CR) 10Jforrester: [C: 03+2] Fix function name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488586 (owner: 10Esanders) [22:18:27] MatmaRex: https://github.com/eslint/eslint/issues/11360 [22:19:44] (03CR) 10Esanders: [C: 03+2] DesktopArticleTarget: Make the progress bar into a reusable widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [22:20:05] edsanders: neat [22:20:39] they're quite tough with their triage, so it might get declined [22:20:41] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix function name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488585 (owner: 10Esanders) [22:22:16] (03Merged) 10jenkins-bot: Fix function name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488585 (owner: 10Esanders) [22:23:44] (03CR) 10jenkins-bot: Fix function name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488585 (owner: 10Esanders) [22:25:10] MatmaRex: crazily they added a "never" option to that rule - that makes no sense to me [22:26:53] hmm [22:27:40] maybe it was supposed to entirely prevent naming functions that are assigned to properties, rather than preventing naming them identically to said properties? i could see how someone might like the former convention, but the latter (current) indeed makes no sense, heh [22:28:36] no, it's just about the names not matching - to prevent naming at all you use https://eslint.org/docs/rules/func-names [22:31:00] request: "Is there a way we could modify this rule to _forbid_ name matching? I prefer to never have the function name match the variable, so that it's very very explicit that the function body uses the name, not the containing variable, to self-reference." [22:36:23] (03Merged) 10jenkins-bot: Fix function name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488586 (owner: 10Esanders) [22:37:30] (03Merged) 10jenkins-bot: DesktopArticleTarget: Make the progress bar into a reusable widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [22:38:28] (03CR) 10jenkins-bot: Fix function name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488586 (owner: 10Esanders) [22:40:34] (03CR) 10jenkins-bot: DesktopArticleTarget: Make the progress bar into a reusable widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488230 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [22:53:43] (03PS1) 10Esanders: Create VisualEditorPreferredEditorOnMobile config option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488603 [23:08:33] (03Abandoned) 10Esanders: Create VisualEditorPreferredEditorOnMobile config option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488603 (owner: 10Esanders) [23:34:02] 10VisualEditor, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements: Snapshot: usage of common editing features - https://phabricator.wikimedia.org/T202133 (10Esanders) Can we also get the data long tail of smaller features?