[00:08:29] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Support for early community input on proposed mobile interventions - https://phabricator.wikimedia.org/T206549 (10Whatamidoing-WMF) The first project was identified and is being built. It will be ready for testing "soon", but I think that handling... [00:22:31] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10Whatamidoing-WMF) At the request of the team, I've also [[https://zh-yue.wikipedia.org/wiki/User_talk:Deryck_Chan#Mobile_editing|contacted]] @deryck... [00:25:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?) - https://phabricator.wikimedia.org/T210569 (10Whatamidoing-WMF) https://www.mediawiki.org/wiki/VisualEditor/Portal/Keyboard_shortcuts has a list,... [00:41:05] (03PS1) 10Jforrester: Update VE core submodule to master (a5437289b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489111 [00:55:45] (03CR) 10Chunliang Lyu: "Would you kindly review the change? Thanks!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488650 (owner: 10Chunliang Lyu) [01:05:41] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Note that this is unused in the default configuration, and I don't think we're planning to enable it again. But I'd be happy to merge this" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488650 (owner: 10Chunliang Lyu) [01:05:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488650 (owner: 10Chunliang Lyu) [01:11:56] (03PS5) 10Chunliang Lyu: Fix TypeError in MWTocWidget.initFromMetaList [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488650 [01:13:45] (03PS6) 10Chunliang Lyu: Fix TypeError in MWTocWidget.initFromMetaList [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488650 [01:17:41] (03CR) 10Chunliang Lyu: "Patch updated, thanks." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/488650 (owner: 10Chunliang Lyu) [01:36:28] 10VisualEditor, 10UI-Standardization, 10Design, 10Patch-For-Review, 10UI-Standardization-Kanban: VE's image type dropdown icon of media dialog need to be aligned to icon guidelines - https://phabricator.wikimedia.org/T206729 (10Volker_E) I don't have too strong of an opinion here, but we also feature 'ma... [01:38:35] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (a5437289b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489111 (owner: 10Jforrester) [01:57:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (a5437289b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489111 (owner: 10Jforrester) [01:59:22] (03CR) 10jenkins-bot: Update VE core submodule to master (a5437289b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489111 (owner: 10Jforrester) [03:37:42] (03CR) 10Krinkle: "I'd recommend testing locally Chrome/Firefox/Safari (possibly via browserstack if not on Mac), and verify it still has the same phases. Mi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489015 (owner: 10Bartosz Dziewoński) [10:18:47] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10deryckchan) @Whatamidoing-WMF : Deryck here. Am up for trying it myself and inviting other Cantonese Wikipedia editors to take part. What should I do? [13:01:17] 10VisualEditor: Can’t scroll to bottom of link dialog on iOS mobile VE while keyboard is open - https://phabricator.wikimedia.org/T215604 (10matmarex) a:03matmarex This is the same kind of issue as T210559. Turns out I only fixed it for some dialogs. [13:12:13] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Support for early community input on proposed mobile interventions - https://phabricator.wikimedia.org/T206549 (10Elitre) I'm trying to understand who is managing this now that would later be able to provide an evaluation on your work, and on which... [14:37:30] (03CR) 10Esanders: [C: 04-1] ve.ce.Surface: handles clipboard images with HTML (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488993 (https://phabricator.wikimedia.org/T208631) (owner: 10Juan Osorio (Microsoft)) [14:37:54] (03CR) 10Esanders: [C: 04-1] "need to rename "root"" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [14:39:16] 10VisualEditor, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10Patch-For-Review, 10User-Ryasmeen: Help panel: textarea not visible when editing in VE mode on mobile - https://phabricator.wikimedia.org/T212967 (10matmarex) [14:44:16] 10VisualEditor, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10Patch-For-Review, 10User-Ryasmeen: Help panel: textarea not visible when editing in VE mode on mobile - https://phabricator.wikimedia.org/T212967 (10matmarex) > @alexhollender Would you mind filing a separate task for t... [15:00:22] (03PS19) 10Divec: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) [15:01:59] (03CR) 10Divec: "root -> attachedRoot done" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [15:05:10] (03PS17) 10Divec: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) [15:13:24] (03CR) 10jerkins-bot: [V: 04-1] WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [15:16:03] (03PS1) 10Esanders: Return teardownPromise from Target#destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489229 [15:40:55] (03PS1) 10Esanders: Remove teardown hacks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489238 [16:23:16] (03PS3) 10Juan Osorio (Microsoft): ve.ce.Surface: handles clipboard images with HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488993 (https://phabricator.wikimedia.org/T208631) [16:24:53] (03CR) 10Juan Osorio (Microsoft): ">" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488993 (https://phabricator.wikimedia.org/T208631) (owner: 10Juan Osorio (Microsoft)) [16:53:07] 10VisualEditor, 10AbuseFilter, 10Editing Design , 10Readers-Web-Backlog (Tracking): User experience of AbuseFilter edit failure could be greatly improved. - https://phabricator.wikimedia.org/T215361 (10Esanders) Note that in VE we recently moved all the handling of save errors into their respective extensi... [16:57:45] (03CR) 10Esanders: [C: 04-1] Support only surfacing part of the document (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:13:19] (03CR) 10Divec: Support only surfacing part of the document (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [17:17:31] (03PS20) 10Divec: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) [17:56:59] 10VisualEditor, 10CommRel-Specialists-Support (Jan-Mar-2019): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10Whatamidoing-WMF) Thanks for the quick reply, Deryck. I think that the first useful thing that you can do is to try the visual editor on a mobile d... [18:49:36] 10VisualEditor, 10MediaWiki-Commenting, 10MediaWiki-Interface: Edit summary box should be a multiline input - https://phabricator.wikimedia.org/T99944 (10Krinkle) [18:49:48] 10VisualEditor, 10MediaWiki-Commenting, 10MediaWiki-Interface: Edit summary box should be a multiline input - https://phabricator.wikimedia.org/T99944 (10Krinkle) [19:11:04] (03PS1) 10Esanders: Remove deprecated surface.disable/enable aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489293 [19:11:06] (03PS1) 10Esanders: Remove surface model disable/enable calls from inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489294 [19:11:08] (03PS1) 10Esanders: Abstract out #isEditable from FragmentInspector#getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489295 [19:11:10] (03PS1) 10Esanders: Remove duplication of action in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489296 [19:11:12] (03PS1) 10Esanders: WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) [19:13:57] (03CR) 10jerkins-bot: [V: 04-1] WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [19:13:59] (03CR) 10jerkins-bot: [V: 04-1] Abstract out #isEditable from FragmentInspector#getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489295 (owner: 10Esanders) [19:14:10] (03CR) 10jerkins-bot: [V: 04-1] Remove duplication of action in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489296 (owner: 10Esanders) [19:17:39] (03PS2) 10Esanders: WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) [19:19:56] (03CR) 10jerkins-bot: [V: 04-1] WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [19:33:39] (03PS21) 10Esanders: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:35:14] (03CR) 10Esanders: [C: 03+2] "Fixed some rebase errors and made backwards-compatible" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:35:42] (03CR) 10jerkins-bot: [V: 04-1] Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:36:51] (03CR) 10jerkins-bot: [V: 04-1] Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:41:27] (03PS18) 10Esanders: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:41:43] (03PS19) 10Esanders: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:45:26] (03PS22) 10Esanders: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:45:32] (03CR) 10jerkins-bot: [V: 04-1] WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:45:34] (03CR) 10Esanders: [C: 03+2] Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:47:09] (03Merged) 10jenkins-bot: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [19:48:40] (03CR) 10jenkins-bot: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [20:19:59] 10TemplateData, 10VisualEditor, 10Technical-Debt: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958 (10Krinkle) [20:20:03] 10TemplateData, 10VisualEditor, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10User-Ryasmeen: TemplateData: Normalisation should not assume paramOrder - https://phabricator.wikimedia.org/T138200 (10Krinkle) 05Open→03Resolved a:03Krinkle [21:13:18] (03PS1) 10Jforrester: Update VE core submodule to master (b629aa8b1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489319 (https://phabricator.wikimedia.org/T76541) [21:13:38] (03PS20) 10Jforrester: WIP Support only surfacing part of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440809 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [21:38:11] 10VisualEditor, 10VisualEditor-DataModel: Split TreeModifier into a tree diff generator and tree diff applier - https://phabricator.wikimedia.org/T215567 (10Catrope) > except that within ContentBranchNodes, the offset is the linearized offset of the position. I assume this means that, given linmod `[ {type: '... [22:29:58] 10VisualEditor, 10VisualEditor-DataModel: Split TreeModifier into a tree diff generator and tree diff applier - https://phabricator.wikimedia.org/T215567 (10dchan) Oh, good point – yes, that is correct. [22:38:11] (03CR) 10Catrope: "What Timo said. I don't remember why any of these things are here, so if you can confirm (carefully) that removing these things doesn't ch" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489015 (owner: 10Bartosz Dziewoński) [23:20:48] (03PS2) 10Esanders: Return teardownPromise from Target#destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489229 [23:20:50] (03PS2) 10Esanders: Remove teardown hacks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489238 [23:20:52] (03PS2) 10Esanders: Remove deprecated surface.disable/enable aliases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489293 [23:20:54] (03PS2) 10Esanders: Remove surface model disable/enable calls from inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489294 [23:20:56] (03PS2) 10Esanders: Abstract out #isEditable from FragmentInspector#getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489295 [23:20:58] (03PS2) 10Esanders: Remove duplication of action in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489296 [23:21:00] (03PS3) 10Esanders: WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) [23:23:52] (03CR) 10jerkins-bot: [V: 04-1] WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [23:24:01] (03CR) 10jerkins-bot: [V: 04-1] Abstract out #isEditable from FragmentInspector#getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489295 (owner: 10Esanders) [23:24:17] (03CR) 10jerkins-bot: [V: 04-1] Remove duplication of action in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489296 (owner: 10Esanders) [23:35:12] (03PS3) 10Esanders: Abstract out #isEditable from FragmentInspector#getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489295 [23:35:14] (03PS3) 10Esanders: Remove duplication of action in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489296 [23:35:16] (03PS4) 10Esanders: WIP Replace surface disable with readonly mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142)