[07:30:44] 10Citoid: Tamu.edu DOI is not correctly recognized by Citoid - https://phabricator.wikimedia.org/T215755 (10JEumerus) [09:04:52] 10VisualEditor, 10Wikibase-Containers, 10Wikidata: Visual editor should be available by default in the Docker-compose setup for Wikibase - https://phabricator.wikimedia.org/T205011 (10Addshore) p:05Triage→03Low [10:07:40] 10Citoid: Tamu.edu DOI is not correctly recognized by Citoid - https://phabricator.wikimedia.org/T215755 (10Mvolz) This will probably be fixed once https://gerrit.wikimedia.org/r/#/c/mediawiki/services/citoid/+/486861/ is deployed. [10:08:22] 10Citoid: Tamu.edu DOI is not correctly recognized by Citoid - https://phabricator.wikimedia.org/T215755 (10Mvolz) [10:08:24] 10Citoid, 10Patch-For-Review: Taylor & Francis DOI is not correctly recognized by Citoid - https://phabricator.wikimedia.org/T214766 (10Mvolz) [10:09:14] 10Citoid, 10Regression: DOIs with unscrapeable pages are not merged with other metadata - https://phabricator.wikimedia.org/T214766 (10Mvolz) [10:11:39] 10Citoid, 10Regression: DOIs with unscrapeable pages are not merged with other metadata - https://phabricator.wikimedia.org/T214766 (10Mvolz) FYI this is a regression caused by T197242. The issue is that a lot of scraping that used to be done by citoid is now done by zotero, but we were handing zotero just the... [10:36:06] 10Citoid, 10Regression: DOIs with unscrapeable pages are not merged with crossref / repository metadata - https://phabricator.wikimedia.org/T214766 (10Mvolz) [10:54:37] 10TemplateData, 10VisualEditor, 10Outreach-Programs-Projects: Support 'maps' parameter in template data GUI editor - https://phabricator.wikimedia.org/T208305 (10Mvolz) cc @Mooeypoo ? [12:54:52] (03PS1) 10Esanders: Convert if-block to while-block for repeated annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489673 (https://phabricator.wikimedia.org/T215741) [12:58:56] 10VisualEditor-CopyPaste, 10Patch-For-Review, 10VisualEditor (Current work): Pasting in an link from Google-translated content throws an exception - https://phabricator.wikimedia.org/T215741 (10Esanders) [15:56:19] 10VisualEditor, 10Editing Design : [Design EPIC]: Loading screen improvements - https://phabricator.wikimedia.org/T210631 (10iamjessklein) [15:57:22] 10VisualEditor, 10Editing Design : [Design EPIC]: Loading screen improvements - https://phabricator.wikimedia.org/T210631 (10iamjessklein) [16:05:27] 10VisualEditor-EditingTools, 10Editing Design , 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10iamjessklein) Process question - is this something that we sh... [16:15:34] (03CR) 10Jforrester: [C: 03+2] Convert if-block to while-block for repeated annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489673 (https://phabricator.wikimedia.org/T215741) (owner: 10Esanders) [16:17:11] (03Merged) 10jenkins-bot: Convert if-block to while-block for repeated annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489673 (https://phabricator.wikimedia.org/T215741) (owner: 10Esanders) [16:18:33] (03CR) 10jenkins-bot: Convert if-block to while-block for repeated annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489673 (https://phabricator.wikimedia.org/T215741) (owner: 10Esanders) [16:38:31] (03CR) 10Jforrester: [C: 03+2] build: Update eslint-config-wikimedia to 0.10.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/489478 (owner: 10Esanders) [16:43:37] (03PS1) 10Jforrester: Update VE core submodule to master (121f78425) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489730 (https://phabricator.wikimedia.org/T215741) [17:02:13] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/489478 (owner: 10Esanders) [17:06:10] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/489478 (owner: 10Esanders) [18:19:33] 10VisualEditor, 10Product-Analytics: Dashboard EditSchema timing metrics - https://phabricator.wikimedia.org/T209705 (10Neil_P._Quinn_WMF) [18:19:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10Performance: Analyze impact of parallel loading of page content and mobile visual editor code - https://phabricator.wikimedia.org/T214450 (10Neil_P._Quinn_WMF) [18:22:58] 10VisualEditor, 10Contributors-Analysis, 10Product-Analytics: Show Rummana how to query EventLogging databases using Hive - https://phabricator.wikimedia.org/T211949 (10Neil_P._Quinn_WMF) [18:47:45] (03PS2) 10Esanders: Some implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 [18:47:47] (03PS2) 10Esanders: Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) [18:53:08] (03CR) 10jerkins-bot: [V: 04-1] Some implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [18:53:28] (03CR) 10jerkins-bot: [V: 04-1] Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [19:23:19] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (121f78425) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489730 (https://phabricator.wikimedia.org/T215741) (owner: 10Jforrester) [19:40:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (121f78425) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489730 (https://phabricator.wikimedia.org/T215741) (owner: 10Jforrester) [19:42:42] (03CR) 10jenkins-bot: Update VE core submodule to master (121f78425) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489730 (https://phabricator.wikimedia.org/T215741) (owner: 10Jforrester) [21:35:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489880 (owner: 10L10n-bot) [21:44:51] (03PS1) 10Esanders: Add back deprecated alias 'root' of 'attachedRoot' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489896 [21:56:11] (03PS1) 10Esanders: Fix updatePlaceholder to use attachedRoot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489898 [22:01:38] (03CR) 10Jforrester: [C: 03+2] Add back deprecated alias 'root' of 'attachedRoot' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489896 (owner: 10Esanders) [22:03:40] (03Merged) 10jenkins-bot: Add back deprecated alias 'root' of 'attachedRoot' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489896 (owner: 10Esanders) [22:05:13] (03CR) 10jenkins-bot: Add back deprecated alias 'root' of 'attachedRoot' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489896 (owner: 10Esanders) [22:05:44] (03PS1) 10Jforrester: Update VE core submodule to master (3df16c6ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489901 [22:06:08] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (3df16c6ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489901 (owner: 10Jforrester) [22:18:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/489870 (owner: 10L10n-bot) [22:25:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (3df16c6ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489901 (owner: 10Jforrester) [22:27:12] (03CR) 10jenkins-bot: Update VE core submodule to master (3df16c6ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489901 (owner: 10Jforrester) [22:46:16] (03CR) 10Jforrester: [C: 03+2] Fix updatePlaceholder to use attachedRoot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489898 (owner: 10Esanders) [22:48:01] (03Merged) 10jenkins-bot: Fix updatePlaceholder to use attachedRoot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489898 (owner: 10Esanders) [22:49:33] (03CR) 10jenkins-bot: Fix updatePlaceholder to use attachedRoot [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489898 (owner: 10Esanders) [22:49:56] (03PS10) 10Jforrester: Replace surface disable with read-only mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [22:58:30] (03PS4) 10Jforrester: ve.ce.Surface: handles clipboard images with HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/488993 (https://phabricator.wikimedia.org/T208631) (owner: 10Juan Osorio (Microsoft)) [22:58:46] (03PS5) 10Jforrester: tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 [22:59:01] (03PS4) 10Jforrester: Allow document state metadata to be stored without clearing HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/472869 (owner: 10Esanders) [22:59:47] (03CR) 10jerkins-bot: [V: 04-1] tests: Add some tests for Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469489 (owner: 10Jforrester) [22:59:57] (03PS5) 10Jforrester: Revert "Comment out broken test after Chrome upgrade" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/401764 [23:02:00] (03CR) 10jerkins-bot: [V: 04-1] Revert "Comment out broken test after Chrome upgrade" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/401764 (owner: 10Jforrester) [23:10:43] MatmaRex: edsanders: coming from working on Special:Login to OOUI: https://phabricator.wikimedia.org/T145674#4945693 – your thoughts please [23:27:05] i commented [23:28:12] MatmaRex: The insights I wanted, although I hoped for something else :P [23:28:54] MatmaRex: so it seems to be a useful idea to add a real 'error' variant to OOUI if I read the differentiation correctly [23:29:40] Right now I intended merging 'error' and 'warning' in next patch in OOUI [23:29:42] oh, you mean the color variant / flag? [23:29:47] hm [23:30:07] I mean the color variant should be just a result of experience/code necessities [23:30:13] your comment makes sense: [23:30:23] we actually use the "warning"-colored icon for the error messages, which is also confusing due to the naming [23:32:05] Volker_E: i think there is only one other place where this variant/flag is used: the icon next to "applicaiton/pdf" on pages like https://commons.wikimedia.org/wiki/File:Elektrina07-08_Kychot.pdf [23:32:30] don't think of it as "warning", just think of it as "orange" [23:32:48] your comment of 'errors have to be corrected by the user before a form can be submitted, while notices/warnings do not' [23:33:16] MatmaRex: In general, it's for a client-side warning that isn't necessarily fatal, unlike a server-side warning which is. [23:33:34] MatmaRex: I think that's a reasonable and consistent intentional split. [23:34:00] uhh [23:34:08] the mish-mash of error and warning right now is deeply dissatisfying and the cost of adding a variant with only one or two icons (why does 'tag' feature 'warning'??) is acceptably low [23:34:12] we use that icon with that color for the fatal errors though :) [23:34:17] James_F: & [23:34:20] James_F: ^ [23:34:47] MatmaRex: Well, you should go fix that mis-use, then. ;-) [23:34:54] meh [23:34:58] * James_F laughs. [23:35:04] Or not, if you don't care. [23:35:11] anyway, i'm working on something else right now, please work it out, you two [23:35:12] …we should [23:35:16] haha [23:35:16] :> [23:36:41] anyone a hint on the warning 'tag'?