[00:02:56] (03CR) 10Esanders: "needs a grunt build to update eg-iframe.html" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/491537 (owner: 10Esanders) [00:05:44] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (2951e9378) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/491537 (owner: 10Esanders) [00:13:47] (03PS4) 10Bartosz Dziewoński: Update VE core submodule to master (2951e9378) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/491537 (owner: 10Esanders) [00:14:01] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (2951e9378) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/491537 (owner: 10Esanders) [00:31:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (2951e9378) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/491537 (owner: 10Esanders) [00:33:53] (03CR) 10jenkins-bot: Update VE core submodule to master (2951e9378) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/491537 (owner: 10Esanders) [01:23:37] 10VisualEditor-MediaWiki, 10MinervaNeue, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), 10VisualEditor (Current work): Improve compatibility of desktop VisualEditor with desktop Minerva skin - https://phabricator.wikimedia.org/T208102 (10matmarex) [01:59:23] 10VisualEditor: Ordered lists look broken in mobile VE - https://phabricator.wikimedia.org/T216792 (10matmarex) [01:59:37] 10VisualEditor: Ordered lists look broken in mobile VE - https://phabricator.wikimedia.org/T216792 (10matmarex) [01:59:39] 10VisualEditor-MediaWiki, 10MinervaNeue, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), 10VisualEditor (Current work): Improve compatibility of desktop VisualEditor with desktop Minerva skin - https://phabricator.wikimedia.org/T208102 (10matmarex) [01:59:46] 10VisualEditor: Ordered lists look broken in mobile VE - https://phabricator.wikimedia.org/T216792 (10matmarex) [02:06:59] (03PS16) 10Bartosz Dziewoński: Replace surface disable with read-only mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [02:10:05] (03PS6) 10Bartosz Dziewoński: Implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [02:11:24] (03CR) 10Bartosz Dziewoński: "PS6: Rebased (conflict with I5a294705eed1760e2d4dde33934d2ffb12e29525 in ve.ui.MWTemplateDialog.js)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [02:11:27] (03PS6) 10Bartosz Dziewoński: Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [02:15:20] (03CR) 10jerkins-bot: [V: 04-1] Implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [02:17:18] (03CR) 10jerkins-bot: [V: 04-1] Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [04:10:54] 10Cite, 10VisualEditor, 10Parsoid: VE is "substing" citation templates (when copying a reference defined within template-generated reflist) - https://phabricator.wikimedia.org/T209493 (10Whatamidoing-WMF) Another instance of this was reported by @Lfstevens: https://www.mediawiki.org/wiki/Topic:Uulh8h1z2mufk... [05:05:32] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Can't cut, copy, or delete templates (probably all similar nodes) in mobile-visual editor from the keyboard - https://phabricator.wikimedia.org/T216648 (10matmarex) In mobile VE, we render a fake selection for these nodes rather than a "native" selection, becaus... [05:05:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements: Investigate ways to improve the copy-pasting workflow on mobile - https://phabricator.wikimedia.org/T204239 (10matmarex) [05:05:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10matmarex) [05:37:42] (03CR) 10Bartosz Dziewoński: "I reviewed MediaWiki extensions looking for uses of surface.setDisabled() etc. We will need fixes for ContentTranslation and Flow." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [05:40:40] (03CR) 10Bartosz Dziewoński: "Nice, how do you open the editor though? Looks like the only way is by going to OWE first and then using the switch widget on the toolbar." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [06:12:45] (03CR) 10Bartosz Dziewoński: "The actual patch here is pretty cool :o One curious problem I noticed is that pressing Enter on the keyboard advances the cursor by one po" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [07:38:58] (03PS1) 10Setian: Swap the link-rtl.png and link-ltr.png files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492253 (https://phabricator.wikimedia.org/T216617) [07:39:00] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492253 (https://phabricator.wikimedia.org/T216617) (owner: 10Setian) [07:42:52] 10VisualEditor, 10Patch-For-Review, 10good first bug: Visual Editor educational popup about links has LTR and RTL versions of the image in reverse - https://phabricator.wikimedia.org/T216617 (10Setian) Just curious, is the RTL version actually used anywhere? I ran a Catfish search and didn't see it in any of... [07:55:44] 10VisualEditor, 10Patch-For-Review, 10good first bug: Visual Editor educational popup about links has LTR and RTL versions of the image in reverse - https://phabricator.wikimedia.org/T216617 (10Pginer-WMF) >>! In T216617#4974901, @Setian wrote: > Just curious, is the RTL version actually used anywhere? I ran... [10:36:54] 10VisualEditor, 10User-Ryasmeen: After an Edit is Saved, screen should scroll back to where user was editing - https://phabricator.wikimedia.org/T216618 (10Aklapper) >>! In T216618#4968848, @iamjessklein wrote: > this is a dupe of https://phabricator.wikimedia.org/T213120 Marking as duplicate via {nav name=Ed... [10:37:02] 10VisualEditor, 10User-Ryasmeen: After an Edit is Saved, screen should scroll back to where user was editing - https://phabricator.wikimedia.org/T216618 (10Aklapper) [10:37:08] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Restore section hash fragment after section editing in mobile VE - https://phabricator.wikimedia.org/T213120 (10Aklapper) [10:44:13] Hi. I've been attempting to install VisualEditor onto my company's private Wiki, and it seems to be falling over at the last hurdle. Running Wikimedia 1.32, Parsoid 0.10, PHP 7.3. Basically when I click Edit, it loads to around 75% and then nothing further happens. I can see Parsoid running in the console responding to the request without any errors, and no error codes are being thrown up by the page as far as I can s [10:44:35] It's running on XAMPP on Windows, so finding help with it has been difficult. Lots of people having the same issue but can't find a resolution that works...Can anyone help? [10:53:16] 10TemplateData, 10VisualEditor: VE shuffles the order of template parameters in template dialog - https://phabricator.wikimedia.org/T216808 (10Dvorapa) [10:54:06] 10TemplateData, 10VisualEditor: VE shuffles the order of template parameters in template dialog - https://phabricator.wikimedia.org/T216808 (10Dvorapa) [10:55:24] 10TemplateData, 10VisualEditor: VE shuffles the order of template parameters in template dialog - https://phabricator.wikimedia.org/T216808 (10Dvorapa) [10:59:34] 10VisualEditor-ContentEditable, 10Browser-Support-Firefox, 10VisualEditor (Current work): Can't select across block images in Firefox - https://phabricator.wikimedia.org/T214976 (10Schnark) Removing the following CSS seems to fix the issue, though it will probably break something else: `lang=css .ve-ce-focus... [11:01:03] 10TemplateData, 10VisualEditor: VE shuffles the order of template parameters in template dialog - https://phabricator.wikimedia.org/T216808 (10Dvorapa) [11:01:58] 10TemplateData, 10VisualEditor: VE shuffles the order of template parameters in template dialog - https://phabricator.wikimedia.org/T216808 (10Dvorapa) [12:47:44] 10Citoid, 10VisualEditor: Prompt for page number(s) for compatible cite sources (e.g. book, journal) - https://phabricator.wikimedia.org/T216817 (10Esanders) [12:47:55] 10Citoid: Extract page from Google Books in Citoid - https://phabricator.wikimedia.org/T160848 (10Esanders) Related: T216817 [12:57:12] 10Citoid, 10VisualEditor: Prompt for page number(s) for compatible cite sources (e.g. book, journal) - https://phabricator.wikimedia.org/T216817 (10Esanders) Something like: {F28263440,size=full} [14:56:31] (03PS17) 10Esanders: Replace surface disable with read-only mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) [14:57:09] (03CR) 10Esanders: "CX patch updated. Fixed the 'Enter' glitch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [14:58:43] (03PS18) 10Esanders: Replace surface disable with read-only mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) [15:26:52] (03PS2) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove some unnecessary toolbar setup code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489015 [15:28:33] (03CR) 10Bartosz Dziewoński: "Thanks. This appears to work just the same as before." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489015 (owner: 10Bartosz Dziewoński) [15:32:11] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget: Remove some unnecessary toolbar setup code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489015 (owner: 10Bartosz Dziewoński) [16:43:51] (03PS6) 10Esanders: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) [16:54:27] (03CR) 10jerkins-bot: [V: 04-1] Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [17:11:03] (03PS1) 10Bartosz Dziewoński: ve.dm.MWGalleryImageNode: Update for Parsoid changes to "broken" images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492351 [17:11:58] (03CR) 10Bartosz Dziewoński: "This is just a quick fix so that the editor doesn't crash when loading. Maybe we should review this code more closely at some point." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492351 (owner: 10Bartosz Dziewoński) [17:15:13] (03CR) 10Subramanya Sastry: "Added arlo since he worked on this made the changes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492351 (owner: 10Bartosz Dziewoński) [17:50:00] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Citoid should magically see that a source has already been used in a reference on this page and re-use it (or warn me to do so) rather than creating a new reference to the same source - https://phabricator.wikimedia.org/T126488 (10Whatamidoing-WMF... [17:52:30] 10VisualEditor: VisualEditor crashes while trying to load a page - https://phabricator.wikimedia.org/T216844 (10Whatamidoing-WMF) [17:54:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Performance: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization - https://phabricator.wikimedia.org/T209078 (10Esanders) [17:55:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Performance: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization - https://phabricator.wikimedia.org/T209078 (10Esanders) It looks like a lot of this slowdown comes from building the red-link c... [17:55:54] (03PS1) 10Esanders: ApiVisualEditor: Remove red-link cache warming [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492358 (https://phabricator.wikimedia.org/T64803) [17:59:57] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide a way to move pages through interacting with the displayed title - https://phabricator.wikimedia.org/T74665 (10Whatamidoing-WMF) This is a perennial request from inexperienced editors. See, e.g., https://www.mediawiki.org/wiki/Topic:Uuooxecko4mfm... [18:16:04] (03CR) 10Bartosz Dziewoński: [C: 03+2] "This is super neat. I especially like how it has a sensible fallback for code that doesn't know about readonly mode. I noticed a few more " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [18:16:28] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor: Provide a "view VE" mode / disable editing for protected pages - https://phabricator.wikimedia.org/T53547 (10matmarex) [18:16:56] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor: Provide a "view VE" mode / disable editing for protected pages - https://phabricator.wikimedia.org/T53547 (10matmarex) [18:17:27] (03Merged) 10jenkins-bot: Replace surface disable with read-only mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [18:18:48] (03CR) 10jenkins-bot: Replace surface disable with read-only mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/489297 (https://phabricator.wikimedia.org/T210142) (owner: 10Esanders) [18:20:27] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (541222565) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492360 (https://phabricator.wikimedia.org/T210142) [18:20:53] (03PS7) 10Bartosz Dziewoński: Implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [18:33:26] (03PS7) 10Esanders: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) [18:39:45] (03CR) 10jerkins-bot: [V: 04-1] Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [18:40:45] (03CR) 10Bartosz Dziewoński: [C: 03+2] Implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [18:40:51] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (541222565) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492360 (https://phabricator.wikimedia.org/T210142) (owner: 10Bartosz Dziewoński) [18:56:39] (03PS8) 10Esanders: Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) [18:56:42] (03PS1) 10Esanders: ApiVisualEditor: Separate out templatesUsed from metadata [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492366 (https://phabricator.wikimedia.org/T209078) [18:57:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (541222565) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492360 (https://phabricator.wikimedia.org/T210142) (owner: 10Bartosz Dziewoński) [18:57:40] (03Merged) 10jenkins-bot: Implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [18:59:28] (03CR) 10jenkins-bot: Update VE core submodule to master (541222565) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492360 (https://phabricator.wikimedia.org/T210142) (owner: 10Bartosz Dziewoński) [19:02:19] (03CR) 10jenkins-bot: Implementations for read-only mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489415 (owner: 10Esanders) [19:04:35] (03CR) 10jerkins-bot: [V: 04-1] Separate document HTML promise from edit metadata promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/473198 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [19:05:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Performance: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization - https://phabricator.wikimedia.org/T209078 (10Esanders) The two later patches may make the metadata requests fast enough that t... [19:08:54] (03CR) 10Esanders: "Yes, we should do that as a follow-up...." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [19:09:25] (03PS7) 10Esanders: Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) [19:12:08] (03CR) 10Bartosz Dziewoński: [C: 03+2] Add support for read-only mode [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/491456 (owner: 10Esanders) [19:17:27] 10TemplateData, 10VisualEditor: TemplateData GUI editor should allow you to set the 'inherits' property - https://phabricator.wikimedia.org/T216847 (10Whatamidoing-WMF) [19:45:42] 10VisualEditor: VisualEditor crashes while trying to load a page - https://phabricator.wikimedia.org/T216844 (10matmarex) [19:45:59] (03Merged) 10jenkins-bot: Add support for read-only mode [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/491456 (owner: 10Esanders) [19:47:29] 10VisualEditor: VisualEditor crashes while trying to load a page - https://phabricator.wikimedia.org/T216844 (10matmarex) I couldn't reproduce this. I don't get the error. (Tested with Firefox, since the error backtrace looks like it's from Firefox.) From the error backtrace, it would seem that one of the galle... [20:19:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Hm, okay, let's release it in this sneaky way, and think about integrating it later…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [20:22:51] (03CR) 10Esanders: [C: 03+1] ve.dm.MWGalleryImageNode: Update for Parsoid changes to "broken" images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492351 (owner: 10Bartosz Dziewoński) [20:30:12] (03CR) 10Bartosz Dziewoński: [C: 03+2] Swap the link-rtl.png and link-ltr.png files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492253 (https://phabricator.wikimedia.org/T216617) (owner: 10Setian) [20:30:52] 10VisualEditor, 10Patch-For-Review, 10good first bug: Visual Editor educational popup about links has LTR and RTL versions of the image in reverse - https://phabricator.wikimedia.org/T216617 (10matmarex) Funny, they have been swapped ever since we added them in 2015… https://gerrit.wikimedia.org/r/c/mediawik... [20:41:32] (03Merged) 10jenkins-bot: Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [20:43:52] (03CR) 10jenkins-bot: Load VE in read-only mode on protected pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489416 (https://phabricator.wikimedia.org/T53547) (owner: 10Esanders) [20:49:12] (03Merged) 10jenkins-bot: Swap the link-rtl.png and link-ltr.png files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492253 (https://phabricator.wikimedia.org/T216617) (owner: 10Setian) [20:50:57] (03CR) 10jenkins-bot: Swap the link-rtl.png and link-ltr.png files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492253 (https://phabricator.wikimedia.org/T216617) (owner: 10Setian) [20:54:40] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor: Provide a "view VE" mode / disable editing for protected pages - https://phabricator.wikimedia.org/T53547 (10matmarex) Read-only VE is now available, but rather sneaky. You can only access it by switching from old wiki... [20:56:12] (03PS6) 10Bartosz Dziewoński: Remove special handling for category and file pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441509 (https://phabricator.wikimedia.org/T139191) [20:58:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Categories: VisualEditor makes redlinked category index pages inacessible - https://phabricator.wikimedia.org/T139191 (10matmarex) [20:58:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Let me visit a red-linked page without opening the editor - https://phabricator.wikimedia.org/T211379 (10matmarex) [20:58:49] 10VisualEditor, 10VisualEditor-MediaWiki: Users are requesting a "Cancel and exit without saving" option - https://phabricator.wikimedia.org/T85470 (10matmarex) [20:58:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Let me visit a red-linked page without opening the editor - https://phabricator.wikimedia.org/T211379 (10matmarex) [20:59:38] (03PS7) 10Bartosz Dziewoński: Remove special handling for category and file pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441509 (https://phabricator.wikimedia.org/T194068) [21:00:08] (03CR) 10Bartosz Dziewoński: "Can we go ahead with this?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441509 (https://phabricator.wikimedia.org/T194068) (owner: 10Bartosz Dziewoński) [21:03:38] (03PS3) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Remove some unnecessary toolbar setup code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/489015 [21:14:38] 10VisualEditor, 10Operations, 10Parsoid, 10RESTBase, and 5 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) We have logged some VE requests on the RB side, and it turns out we cannot rely on the session ID to be present in the request. VE does send it,... [21:27:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I don't understand this patch. If scrolling hides the context menu, then we shouldn't have to scroll past the context menu?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460331 (https://phabricator.wikimedia.org/T202723) (owner: 10Esanders) [21:50:41] (03PS1) 10Bartosz Dziewoński: ve.ui.DiffElement: Don't always target links to new window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/492395 [21:51:37] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Target links in visual diff to new window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492397 [21:51:39] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Fix fragment links in visual diff too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492398 (https://phabricator.wikimedia.org/T212554) [21:52:26] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.DiffElement: Don't always target links to new window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/492395 (owner: 10Bartosz Dziewoński) [21:56:10] (03PS2) 10Bartosz Dziewoński: ve.ui.DiffElement: Don't always target links to new window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/492395 [23:35:19] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Verified, 10VisualEditor (Current work): "Broken images" not working on mobile VE - https://phabricator.wikimedia.org/T216267 (10Ryasmeen) [23:55:52] (03CR) 10Catrope: [C: 03+1] ApiVisualEditor: Remove red-link cache warming [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492358 (https://phabricator.wikimedia.org/T64803) (owner: 10Esanders)