[00:00:13] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 10VisualEditor (Current work): Analyse load time performance of FA-length pages on mobile - https://phabricator.wikimedia.org/T206228 (10Krinkle) >>! In T64803#4976635, @Esanders uploaded a patch: > [mediawiki/extensions... [00:00:17] (03CR) 10Krinkle: [C: 03+1] "See also https://phabricator.wikimedia.org/T206228#4977367" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492358 (https://phabricator.wikimedia.org/T64803) (owner: 10Esanders) [00:00:24] (03CR) 10Catrope: "Fair enough. However, the support comment is wrong anyway because the code in question doesn't run in Firefox. In the commit message of Ib" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/490140 (owner: 10Catrope) [00:05:42] (03PS2) 10Catrope: ve.transformStyleAttributes: Update browser bug workaround comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/490140 [00:13:24] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), 10Patch-For-Review, and 2 others: VE mobile has extra padding on wide screens - https://phabricator.wikimedia.org/T215694 (10Ryasmeen) [00:24:57] (03CR) 10Krinkle: ApiVisualEditor: Separate out templatesUsed from metadata (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492366 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [09:22:02] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor: Provide a "view VE" mode / disable editing for protected pages - https://phabricator.wikimedia.org/T53547 (10Schnark) >>! In T53547#4977107, @matmarex wrote: > You can onl... [10:20:02] (03CR) 10Jforrester: [C: 03+2] ApiVisualEditor: Remove red-link cache warming [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492358 (https://phabricator.wikimedia.org/T64803) (owner: 10Esanders) [10:23:21] (03PS2) 10Jforrester: ApiVisualEditor: Separate out templatesUsed from metadata [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492366 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [10:23:44] (03CR) 10Jforrester: [C: 03+1] ApiVisualEditor: Separate out templatesUsed from metadata (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492366 (https://phabricator.wikimedia.org/T209078) (owner: 10Esanders) [10:26:58] (03CR) 10Jforrester: [C: 03+2] ve.transformStyleAttributes: Update browser bug workaround comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/490140 (owner: 10Catrope) [10:28:22] (03Merged) 10jenkins-bot: ve.transformStyleAttributes: Update browser bug workaround comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/490140 (owner: 10Catrope) [10:29:39] (03CR) 10jenkins-bot: ve.transformStyleAttributes: Update browser bug workaround comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/490140 (owner: 10Catrope) [10:36:58] (03Merged) 10jenkins-bot: ApiVisualEditor: Remove red-link cache warming [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492358 (https://phabricator.wikimedia.org/T64803) (owner: 10Esanders) [10:39:13] (03CR) 10jenkins-bot: ApiVisualEditor: Remove red-link cache warming [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492358 (https://phabricator.wikimedia.org/T64803) (owner: 10Esanders) [10:45:04] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10VisualEditor (Current work): VisualEditor: Provide a "view VE" mode / disable editing for protected pages - https://phabricator.wikimedia.org/T53547 (10Petar.petkovic) [11:45:34] 10VisualEditor, 10VisualEditor-ContentEditable, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps): Editing maps in VE - the marker area needs some adjustments - https://phabricator.wikimedia.org/T191582 (10Petar.petkovic) [11:49:16] 10VisualEditor, 10Maps (Kartographer), 10User-Ryasmeen: [beta cluster] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. - https://phabricator.wikimedia.org/T194440 (10Petar.petkovic) [11:50:39] 10VisualEditor, 10Growth-Team, 10StructuredDiscussions, 10User-Ryasmeen: [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972 (10Petar.petkovic) [11:51:16] 10VisualEditor, 10VisualEditor-ContentEditable: Change cursor from 'text' to 'pointer' for links when CTRL is pressed - https://phabricator.wikimedia.org/T216879 (10Esanders) [11:52:22] 10VisualEditor, 10Contributors-Team, 10Readers-Web-Backlog, 10MinervaNeue (Desktop), 10User-Ryasmeen: Impossible to edit pages without sections on Minerva skin (including all pages in desktop Minerva) - https://phabricator.wikimedia.org/T157995 (10Petar.petkovic) [14:35:30] 10VisualEditor: Deleting and restoring table can cause errors with merged cells - https://phabricator.wikimedia.org/T216884 (10Urbanecm) [14:38:06] 10VisualEditor: Deleting and restoring table can cause errors with merged cells - https://phabricator.wikimedia.org/T216884 (10Urbanecm) This was reported to me by email by User:David V.@cswiki. [16:20:39] 10Editing-team, 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10Verified, 10VisualEditor (Current work): CAPTCHAs are no longer served to mobile users, causing a generic error instead - https://phabricator.wikimedia.org/T215101 (10Daimona) Is there anything left to do? [16:20:59] (03PS1) 10Esanders: Use cursor:pointer for ctrl+click on links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/492482 (https://phabricator.wikimedia.org/T216879) [16:23:06] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Change cursor from 'text' to 'pointer' for links when CTRL is pressed - https://phabricator.wikimedia.org/T216879 (10Esanders) [16:35:33] 10WikiEditor, 10Documentation: MediaWiki Extension WikiEditor README File typo - https://phabricator.wikimedia.org/T216889 (10Reedy) >there is no function wfLoadExtensions() my wiki crashed when I copied and pasted the code into LocalSettings.php Yes there is, but that is not how to call it - https://github.c... [16:37:06] (03PS1) 10Reedy: Update README [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/492483 (https://phabricator.wikimedia.org/T216889) [16:40:02] 10WikiEditor, 10Documentation, 10Patch-For-Review: MediaWiki Extension WikiEditor README File typo - https://phabricator.wikimedia.org/T216889 (10Ingoschmied) Hello Reedy, Got it, thank you. But then the README still contains an error on line 8. The first argument to the function should be a single element... [16:41:45] 10WikiEditor, 10Documentation, 10Patch-For-Review: MediaWiki Extension WikiEditor README File typo - https://phabricator.wikimedia.org/T216889 (10Reedy) >>! In T216889#4978316, @Ingoschmied wrote: > Got it, thank you. But then the README still contains an error on line 8. The first argument to the function s... [16:45:09] 10WikiEditor, 10Documentation, 10Patch-For-Review: MediaWiki Extension WikiEditor README File typo - https://phabricator.wikimedia.org/T216889 (10Ingoschmied) My first time doing anything in Phabricator, just set up my first wiki using MediaWiki…total noob. Thanks for your help, take care! [17:37:08] (03CR) 10Fomafix: [C: 03+2] Update README [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/492483 (https://phabricator.wikimedia.org/T216889) (owner: 10Reedy) [17:57:02] (03Merged) 10jenkins-bot: Update README [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/492483 (https://phabricator.wikimedia.org/T216889) (owner: 10Reedy) [18:05:58] (03CR) 10Esanders: [C: 03+2] ve.ui.MWSaveDialog: Fix fragment links in visual diff too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492398 (https://phabricator.wikimedia.org/T212554) (owner: 10Bartosz Dziewoński) [18:10:11] (03CR) 10Esanders: [C: 03+2] ve.ui.MWSaveDialog: Target links in visual diff to new window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492397 (owner: 10Bartosz Dziewoński) [18:21:20] (03Merged) 10jenkins-bot: ve.ui.MWSaveDialog: Target links in visual diff to new window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492397 (owner: 10Bartosz Dziewoński) [18:23:02] (03CR) 10jenkins-bot: ve.ui.MWSaveDialog: Target links in visual diff to new window [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492397 (owner: 10Bartosz Dziewoński) [18:26:08] (03Merged) 10jenkins-bot: ve.ui.MWSaveDialog: Fix fragment links in visual diff too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492398 (https://phabricator.wikimedia.org/T212554) (owner: 10Bartosz Dziewoński) [18:28:07] (03CR) 10jenkins-bot: ve.ui.MWSaveDialog: Fix fragment links in visual diff too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/492398 (https://phabricator.wikimedia.org/T212554) (owner: 10Bartosz Dziewoński) [18:31:12] 10WikiEditor, 10Documentation, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26): MediaWiki Extension WikiEditor README File typo - https://phabricator.wikimedia.org/T216889 (10Fomafix) 05Open→03Resolved a:03Reedy [20:22:46] 10VisualEditor: VisualEditor crashes while trying to load a page - https://phabricator.wikimedia.org/T216844 (10rugk) Yes, Firefox. I could again reproduce it with the site the user gave in the discussion. Again console: ` 21:07:31.676 Request to access cookie or storage on “https://upload.wikimedia.org/wikip... [20:25:31] 10VisualEditor-MediaWiki-Templates, 10Parsoid, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10User-notice, and 2 others: VE removes all new lines when editing a template - https://phabricator.wikimedia.org/T213922 (10Framawiki) Is this bug completely solved, and can be closed? [21:06:43] 10VisualEditor, 10User-Tgr: VisualEditor makes it easy to create partially linked words, when the user expects a fully linked one - https://phabricator.wikimedia.org/T128060 (10Tgr) [21:06:57] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 10User-Tgr: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947 (10Tgr)