[00:08:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10Performance: Analyze impact of parallel loading of page content and mobile visual editor code - https://phabricator.wikimedia.org/T214450 (10ppelberg) [00:08:31] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Load page content in parallel with VE code on Mobile with ArticleTargetLoader - https://phabricator.wikimedia.org/T209052 (10ppelberg) 05Open→03Resolved @Esa... [00:08:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10Performance: Analyze impact of parallel loading of page content and mobile visual editor code - https://phabricator.wikimedia.org/T214450 (10ppelberg) [00:08:49] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Load page content in parallel with VE code on Mobile with ArticleTargetLoader - https://phabricator.wikimedia.org/T209052 (10ppelberg) 05Resolved→03Open [08:15:00] (03PS1) 10Jforrester: Update VE core submodule to master (b132cc707) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) [08:26:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Be able to choose a specific wikitext editor when switching to source mode - https://phabricator.wikimedia.org/T217857 (10Schnark) Technically, this is possible, and I do so in my script https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veCode.js (s... [08:39:23] 10VisualEditor, 10ContentTranslation: Keyboard shortcuts open link inspector - https://phabricator.wikimedia.org/T217880 (10Petar.petkovic) [08:39:49] 10VisualEditor, 10ContentTranslation, 10Regression: Keyboard shortcuts open link inspector - https://phabricator.wikimedia.org/T217880 (10Petar.petkovic) [08:40:08] 10VisualEditor, 10ContentTranslation, 10Regression: Keyboard shortcuts open link inspector in read-only mode - https://phabricator.wikimedia.org/T217880 (10Petar.petkovic) [12:56:36] (03PS3) 10Esanders: Suppress slugs between floated images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478661 (https://phabricator.wikimedia.org/T107745) [12:57:30] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities - https://phabricator.wikimedia.org/T107745 (10Esanders) [12:58:36] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (b132cc707) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) (owner: 10Jforrester) [13:01:51] (03CR) 10jerkins-bot: [V: 04-1] Suppress slugs between floated images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478661 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [13:12:54] (03PS1) 10Esanders: Follow-up I74d1dbc6: Use isNew instead of isEditing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) [13:13:05] (03CR) 10jerkins-bot: [V: 04-1] Follow-up I74d1dbc6: Use isNew instead of isEditing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) (owner: 10Esanders) [13:13:51] (03PS2) 10Esanders: Follow-up I74d1dbc6: Use isNew instead of isEditing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) [13:14:50] (03CR) 10Esanders: "Let's include Idffc4c9f4e7275445181bd38adf388cfa2f7663a" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) (owner: 10Jforrester) [13:15:09] (03CR) 10Esanders: "Follow-up: Idffc4c9f4e7275445181bd38adf388cfa2f7663a" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/494145 (https://phabricator.wikimedia.org/T217454) (owner: 10Esanders) [13:40:58] (03CR) 10Petar.petkovic: "Is this supposed to also fix T217880?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) (owner: 10Esanders) [14:00:09] (03CR) 10Jforrester: [C: 03+2] Follow-up I74d1dbc6: Use isNew instead of isEditing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) (owner: 10Esanders) [14:01:28] (03Merged) 10jenkins-bot: Follow-up I74d1dbc6: Use isNew instead of isEditing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) (owner: 10Esanders) [14:02:44] (03CR) 10jenkins-bot: Follow-up I74d1dbc6: Use isNew instead of isEditing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495212 (https://phabricator.wikimedia.org/T217454) (owner: 10Esanders) [15:07:00] 10Editing-team, 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-Scribunto: phpunit drops dead on some extension tests - https://phabricator.wikimedia.org/T217384 (10Anomie) >>! In T217384#5010061, @Smalyshev wrote: > This time the log is produced and ends with: > > ` > PHPUnitCommand] Start... [16:00:22] (03PS2) 10Jforrester: Update VE core submodule to master (da38da984) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) [16:01:01] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (da38da984) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) (owner: 10Jforrester) [16:14:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (da38da984) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) (owner: 10Jforrester) [16:16:16] (03CR) 10jenkins-bot: Update VE core submodule to master (da38da984) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495187 (https://phabricator.wikimedia.org/T217454) (owner: 10Jforrester) [16:30:38] 10Editing-team, 10Advanced Mobile Contributions, 10Discovery, 10MobileFrontend, 10Readers-Web-Backlog (Design): Search results on Mobile web don't include a red link to create a new article - https://phabricator.wikimedia.org/T211006 (10alexhollender) [16:31:17] 10Editing-team, 10Advanced Mobile Contributions, 10Discovery, 10MobileFrontend, 10Readers-Web-Backlog (Design): Search results on Mobile web don't include a red link to create a new article - https://phabricator.wikimedia.org/T211006 (10alexhollender) I've just added some updated designs to the task desc... [18:24:20] (03PS1) 10Esanders: Add test coverage for FragmentInspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495276 [18:24:22] (03PS1) 10Esanders: Refactor AnnotationInspector for readability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/495277 [18:33:06] 10VisualEditor, 10ContentTranslation, 10Regression: Keyboard shortcuts open link inspector in read-only mode - https://phabricator.wikimedia.org/T217880 (10Esanders) Fixed in https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/495212/ [18:39:30] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Load page content in parallel with VE code on Mobile with ArticleTargetLoader - https://phabricator.wikimedia.org/T209052 (10Esanders) Yes, this part is resolved. [19:25:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [edit] link showing inside the mobile visual editor - https://phabricator.wikimedia.org/T217915 (10Whatamidoing-WMF) [20:22:11] 10VisualEditor: Data loss during entry while using VE - https://phabricator.wikimedia.org/T217847 (10WikimeSteve) FWIW I discovered that my understanding of the time stamps in the History may have been wrong. It appears that when an edit is made, we see a new condition of the page as it exists now column with ti... [20:30:53] (03CR) 10Legoktm: [C: 03+2] Fix return type of ApiVisualEditorEdit::saveWikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/493765 (owner: 10Umherirrender) [20:50:06] (03Merged) 10jenkins-bot: Fix return type of ApiVisualEditorEdit::saveWikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/493765 (owner: 10Umherirrender) [20:52:08] (03CR) 10jenkins-bot: Fix return type of ApiVisualEditorEdit::saveWikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/493765 (owner: 10Umherirrender) [20:57:41] (03PS9) 10Esanders: WIP DEMO barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) [20:57:43] (03PS1) 10Esanders: build: Update eslint-config-wikimedia to 0.11.0 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/495311 [20:57:45] (03PS1) 10Esanders: Add AUTHORS.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/495312 [21:03:00] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, and 3 others: Rename or remove 'View.$' - https://phabricator.wikimedia.org/T216264 (10matmarex) The task says we want to remove View.$, but so far we have only deprecated it. Do we want to h... [21:22:33] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [edit] link showing inside the mobile visual editor - https://phabricator.wikimedia.org/T217915 (10matmarex) This does not occur on most pages. I have divined that you see this on https://m.mediawiki.org/wiki/Editor#/editor/0, and it indeed happens on that page.... [21:46:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495389 (owner: 10L10n-bot) [22:35:10] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Load page content in parallel with VE code on Mobile with ArticleTargetLoader - https://phabricator.wikimedia.org/T209052 (10ppelberg) Ok, cool – thanks, @Esanders [22:35:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10Performance: Analyze impact of parallel loading of page content and mobile visual editor code - https://phabricator.wikimedia.org/T214450 (10ppelberg) [22:35:28] 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Load page content in parallel with VE code on Mobile with ArticleTargetLoader - https://phabricator.wikimedia.org/T209052 (10ppelberg) 05Open→03Resolved [22:39:36] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTargetLoader: Better document `pageName` parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495407 (https://phabricator.wikimedia.org/T217826) [22:58:39] (03CR) 10Esanders: [C: 03+2] "We should switch to using a title object." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495407 (https://phabricator.wikimedia.org/T217826) (owner: 10Bartosz Dziewoński) [23:04:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/495380 (owner: 10L10n-bot) [23:28:53] (03Merged) 10jenkins-bot: ve.init.mw.ArticleTargetLoader: Better document `pageName` parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495407 (https://phabricator.wikimedia.org/T217826) (owner: 10Bartosz Dziewoński) [23:30:54] (03CR) 10jenkins-bot: ve.init.mw.ArticleTargetLoader: Better document `pageName` parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/495407 (https://phabricator.wikimedia.org/T217826) (owner: 10Bartosz Dziewoński) [23:35:06] 10VisualEditor: Starting line number changes to 1 inside a code block when you reopen it - https://phabricator.wikimedia.org/T217930 (10Ryasmeen) [23:50:00] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Update eslint-config-wikimedia to 0.11.0 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/495311 (owner: 10Esanders) [23:50:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] Add AUTHORS.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/495312 (owner: 10Esanders) [23:56:05] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.11.0 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/495311 (owner: 10Esanders) [23:56:07] (03Merged) 10jenkins-bot: Add AUTHORS.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/495312 (owner: 10Esanders)