[00:02:36] (03CR) 10jerkins-bot: [V: 04-1] build: Un-commit package-lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498267 (https://phabricator.wikimedia.org/T215562) (owner: 10Jforrester) [00:40:42] (03CR) 10Jforrester: [C: 03+2] "CI should now be fixed; we've reverted the jsduck job to the node6/npm3 stack." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/497482 (https://phabricator.wikimedia.org/T218429) (owner: 10Bartosz Dziewoński) [00:41:23] (03Abandoned) 10Jforrester: build: Un-commit package-lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498267 (https://phabricator.wikimedia.org/T215562) (owner: 10Jforrester) [00:42:00] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog): CI outage for mediawiki/extensions/VisualEditor – job "mwext-node10-rundoc-docker" always fails and we can't merge code due to repo configuration - https://phabricator.wikimedia.org/T218963 (10Jdforrester-WMF) a:0... [00:44:38] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10User-Ryasmeen: CI outage for mediawiki/extensions/VisualEditor – job "mwext-node10-rundoc-docker" always fails and we can't merge code due to repo configuration - https://phabricator.wikimedia.org/T218963 (10Jdf... [00:51:19] 10Editing-team, 10MassMessage, 10Wikimedia-production-error: Invalid parameter for message "logentry-massmessage-failure" - https://phabricator.wikimedia.org/T93110 (10Krinkle) 05Open→03Resolved a:03Krinkle [00:57:28] (03Merged) 10jenkins-bot: MobileArticleTarget: Remove broken iOS override for #scrollToHeading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/497482 (https://phabricator.wikimedia.org/T218429) (owner: 10Bartosz Dziewoński) [00:57:32] (03Merged) 10jenkins-bot: MobileArticleTarget: Remove padding below the surface on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/497483 (https://phabricator.wikimedia.org/T217769) (owner: 10Bartosz Dziewoński) [00:59:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (af9089ac5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498198 (https://phabricator.wikimedia.org/T218635) (owner: 10Bartosz Dziewoński) [01:02:28] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [01:03:02] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [01:03:05] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498257 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [01:03:09] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478661 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [01:03:16] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498077 (https://phabricator.wikimedia.org/T218851) (owner: 10Esanders) [01:14:32] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [01:17:10] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [01:25:25] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.MobileArticleTarget: Keep toolbar always in view (restore old approach) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498257 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [05:05:09] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10ppelberg) >>! In T218414#5046036, @Whatamidoing-WMF wrote: > I've added this to #user-noti... [05:11:38] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10ppelberg) [06:35:15] (03CR) 10Fomafix: "The modules of the CodeMirror library has size of 285 KB and the modules of the upload dialog has with a size 240 KB nearly the same size." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/497073 (owner: 10Fomafix) [11:03:54] (03PS1) 10Divec: Filibuster: display backward selections differently from forward ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498345 [12:08:52] (03CR) 10Fomafix: "I fix the multiple API requests with meta=userinfo&uiprop=groups|rights in I4446dcbe36769e3df3069dc86bd91f933976ff1e." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/497073 (owner: 10Fomafix) [12:14:15] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Technical-Debt, 10VisualEditor (Current work): Bits of WikiEditor UI being shown when following red link in WTE2017 - https://phabricator.wikimedia.org/T211898 (10Liuxinyu970226) not only for redlinks, but also for some wikis, when editing templates. e.g. {F2844... [15:30:06] (03CR) 10Jforrester: ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [15:38:50] 10VisualEditor: VisualEditor fails when switching back-and-forth between visual and wikitext modes on a third-party wiki - https://phabricator.wikimedia.org/T218590 (10TheROFL98) I've checked the RESTbase Docs in [[ https://wiki.therofl98.co/api/rest_v1/ ]] and tested conversion from HTML to Wikitext. When I inp... [16:09:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design, 10Editing Design : Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181 (10iamjessklein) I've iterated a bit in freehand and here's my latest proposal: {F28443955 width=300} **N... [16:29:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design, 10Editing Design : Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181 (10Esanders) Minor nitpicks for when we implement: * The text looks like it might be bold, it probably shou... [16:31:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design, 10Editing Design : Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181 (10Esanders) Side note: we've historically used a gif for that loading spinner, but we could just as easily... [16:44:23] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10alexhollender) Related to this topic: it seems like we'd benefit (both on iOS and Android)... [17:10:40] (03CR) 10Esanders: [C: 04-1] "Per James" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [17:41:46] 10VisualEditor, 10VisualEditor-MediaWiki: Add a bucket field to Schema:VisualEditorFeatureUse - https://phabricator.wikimedia.org/T219016 (10Esanders) [18:13:11] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping on screen to move the cursor causes the page to scroll up (in Firefox on Android) - https://phabricator.wikimedia.org/T196839 (10marcella) [18:13:25] 10VisualEditor, 10VisualEditor-MediaWiki: Support bucketing in VE analytics - https://phabricator.wikimedia.org/T219018 (10Esanders) [18:13:36] 10VisualEditor, 10VisualEditor-MediaWiki: Support bucketing in VE analytics - https://phabricator.wikimedia.org/T219018 (10Esanders) [18:13:38] 10VisualEditor, 10VisualEditor-MediaWiki: Add a bucket field to Schema:VisualEditorFeatureUse - https://phabricator.wikimedia.org/T219016 (10Esanders) [18:13:59] 10VisualEditor, 10VisualEditor-MediaWiki: Add a bucket field to Schema:VisualEditorFeatureUse - https://phabricator.wikimedia.org/T219016 (10Esanders) [18:14:30] 10VisualEditor, 10VisualEditor-MediaWiki: Add a bucket field to Schema:EditAttemptStep - https://phabricator.wikimedia.org/T219019 (10Esanders) [18:14:39] 10VisualEditor, 10VisualEditor-MediaWiki: Support bucketing in VE analytics - https://phabricator.wikimedia.org/T219018 (10Esanders) [18:14:41] 10VisualEditor, 10VisualEditor-MediaWiki: Add a bucket field to Schema:EditAttemptStep - https://phabricator.wikimedia.org/T219019 (10Esanders) [18:17:36] 10VisualEditor, 10VisualEditor-MediaWiki: Create API for setting 'bucket' in VE analytics - https://phabricator.wikimedia.org/T219021 (10Esanders) [18:30:16] (03PS2) 10Esanders: ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [18:30:45] (03CR) 10Esanders: [C: 03+1] "Fixed jsduck errors." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [18:31:51] (03CR) 10Jforrester: [C: 03+2] ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [18:32:23] (03PS2) 10Esanders: ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [18:33:01] 10Editing-team, 10VisualEditor, 10ImageMap, 10PHP 7.2 support, 10Wikimedia-production-error: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10aezell) a:03aezell I'm taking a look at this bug. Seemed like an easy one to tackle on a Friday... [18:33:10] (03CR) 10Esanders: [C: 04-2] "Looks like we aren't going to use this for the time being at least." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498257 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [18:40:36] (03CR) 10Bartosz Dziewoński: "The MobileFrontend change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/498234 must also be merged at the same ti" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [18:45:02] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10User-Ryasmeen: CI outage for mediawiki/extensions/VisualEditor – job "mwext-node10-rundoc-docker" always fails and we can't merge code due to repo configuration - https://phabricator.wikimedia.org/T218963 (10mat... [18:49:11] 10VisualEditor, 10MediaWiki-Page-editing, 10Regression: Bug (regression): both source editor and VisualEditor force piped-link creation - https://phabricator.wikimedia.org/T219023 (10MarcoAurelio) [18:50:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Design, 10Editing Design : VisualEditor loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181 (10Esanders) [18:51:12] 10VisualEditor, 10MediaWiki-Page-editing, 10Regression: Bug (regression): both source editor and VisualEditor force piped-link creation - https://phabricator.wikimedia.org/T219023 (10Aklapper) 05Open→03Stalled 1. I go to https://www.mediawiki.org/w/index.php?title=VisualEditor:Test&veaction=edit to get t... [18:54:15] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Merge in downstream code from MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [18:58:16] (03CR) 10Esanders: [C: 04-1] ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [18:58:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update OOUI to v0.31.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498131 (owner: 10Jforrester) [19:00:48] (03Merged) 10jenkins-bot: Update OOUI to v0.31.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498131 (owner: 10Jforrester) [19:03:06] 10Editing-team, 10VisualEditor, 10ImageMap, 10PHP 7.2 support, and 2 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10aezell) That patch fails a CI security check with this error: `Calling method \Xml::element() in \ImageMap::render... [19:03:16] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10VisualEditor (Current work): Close Section Editing User Test running on MediaWiki - https://phabricator.wikimedia.org/T217801 (10Esanders) [19:03:21] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Patch-For-Review, 10VisualEditor (Current work): Deploy mobile section editing to the next set of wikis (listed in the description) - https://phabricator.wikimedia.org/T218939 (10Esanders) [19:03:23] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Browser-Support-Apple-Safari, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 2 others: Excessive white space at the end of article/section on iOS - https://phabricator.wikimedia.org/T217769 (10Esanders) [19:03:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing: [Section Editing] Research Performance Time SPIKE - https://phabricator.wikimedia.org/T217564 (10Esanders) [19:03:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing: [Section Editing] New feature request: add sections while editing - https://phabricator.wikimedia.org/T217563 (10Esanders) [19:03:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Regression: [Regression wmf.19] Adding a new section does not scroll to the bottom of the page anymore - https://phabricator.wikimedia.org/T217269 (10Esanders) [19:03:41] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10VisualEditor (Current work): Execute Section Editing User Testing Plan - https://phabricator.wikimedia.org/T217291 (10Esanders) [19:03:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Regression: [Regression wmf.19] Adding a new section shows the heading of the section on top of the TOC momentarily when section edit link is disabled - https://phabricator.wikimedia.org/T217198 (10Esanders) [19:03:46] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10VisualEditor (Current work): When section editing, do not build whole CE tree - https://phabricator.wikimedia.org/T215717 (10Esanders) [19:03:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing: Section Editing: Pre-Deployment QA - https://phabricator.wikimedia.org/T215908 (10Esanders) [19:03:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing: [Engineering EPIC]: Isolate Section Editing - https://phabricator.wikimedia.org/T209987 (10Esanders) [19:12:04] 10Editing-team, 10VisualEditor, 10ImageMap, 10PHP 7.2 support, and 2 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10aezell) Upon further examination, it's possible this bug only presents for `poly` maps. There is code to protect ag... [19:36:54] (03PS1) 10Jforrester: Update VE core submodule to master (d79dbfc9c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498456 [19:44:17] 10VisualEditor, 10MediaWiki-Page-editing, 10Regression: Bug (regression): both source editor and VisualEditor force piped-link creation - https://phabricator.wikimedia.org/T219023 (10SUM1) Just realised it may be only occurring with articles that have spaces in their name. [19:55:31] 10Editing-team, 10VisualEditor, 10ImageMap, 10PHP 7.2 support, and 2 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10aezell) I pushed a new patch that works much better and passes Jenkins. Now, instead of defaulting to zero, we war... [20:02:07] 10VisualEditor, 10MediaWiki-Page-editing, 10Regression: Bug (regression): both source editor and VisualEditor force piped-link creation - https://phabricator.wikimedia.org/T219023 (10SUM1) This bug affects Wikipedia, Wikimedia, Wiktionary and probably other WMF websites (but the MediaWiki website itself seem... [20:20:55] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10ppelberg) ###Context >>! In T218414#5045850, @ppelberg wrote: > ###Next steps > [ ] When... [20:37:40] 10VisualEditor, 10MediaWiki-Page-editing, 10Parsoid, 10Regression: Bug (regression): both source editor and VisualEditor force piped-link creation - https://phabricator.wikimedia.org/T219023 (10Jdforrester-WMF) 05Stalled→03Open I can confirm those production steps. I think this is a Parsoid bug: ` lan... [20:43:50] 10VisualEditor: [Pre-deployment bug] Long pressing on a text to select it while the keyboard is open makes the browser unresponsive - https://phabricator.wikimedia.org/T219034 (10Ryasmeen) [20:45:17] 10VisualEditor, 10MediaWiki-Page-editing, 10Parsoid, 10Regression: Bug (regression): both source editor and VisualEditor force piped-link creation - https://phabricator.wikimedia.org/T219023 (10SUM1) [20:47:31] 10VisualEditor, 10ContentTranslation: CX2: Vieweing reference card produces - "Cannot read property 'element' of null TypeError" - https://phabricator.wikimedia.org/T219035 (10Etonkovidova) [20:47:51] 10VisualEditor, 10ContentTranslation: CX2: Vieweing reference card produces "Cannot read property 'element' of null TypeError" - https://phabricator.wikimedia.org/T219035 (10Etonkovidova) [20:48:02] 10VisualEditor, 10ContentTranslation: CX2: Viewing reference card produces "Cannot read property 'element' of null TypeError" - https://phabricator.wikimedia.org/T219035 (10Etonkovidova) [20:58:23] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10Ryasmeen) Started testing on prototype: Noticing couple of things. Listing them below. @... [21:23:14] 10VisualEditor, 10MediaWiki-Page-editing, 10Parsoid, 10Regression: Source editor and VisualEditor force piped-link creation for links when using lower-case first character and more than one word - https://phabricator.wikimedia.org/T219023 (10Aklapper) [22:42:24] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 3 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Krinkle) 05Open→03Resolved [23:17:20] 10VisualEditor: [Regression pre-wmf.23] Can't save any edit using Mobile VE both on desktop and mobile device - https://phabricator.wikimedia.org/T219041 (10Ryasmeen) [23:17:46] 10VisualEditor: [Regression pre-wmf.23] Can't save any edit using Mobile VE both on desktop and mobile device - https://phabricator.wikimedia.org/T219041 (10Ryasmeen) p:05Triage→03Unbreak! Raising it as an UBN. We should fix it before Tuesday. [23:32:55] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10User-Ryasmeen: CI outage for mediawiki/extensions/VisualEditor – job "mwext-node10-rundoc-docker" always fails and we can't merge code due to repo configuration - https://phabricator.wikimedia.org/T218963 (10has... [23:57:06] 10VisualEditor: [Regression pre-wmf.23] On mobile VE, clicking on close button blanks the page and doesn't navigate to readmode - https://phabricator.wikimedia.org/T219043 (10Ryasmeen)