[00:00:11] (03PS3) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) [00:08:26] (03CR) 10Bartosz Dziewoński: "PS2 fixes Ed's comments, and also fixes the broken behavior when scrolled to the end of the page (unfortunately our friend padding-bottom " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [00:54:48] 10VisualEditor: [Pre-deployment bug] Long pressing on a text to select it while the keyboard is open makes the browser unresponsive - https://phabricator.wikimedia.org/T219034 (10matmarex) I can't reproduce this. Video: {F28447425} I am not sure what you mean by "long press on a text to select it". Am I doing... [02:26:07] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10matmarex) >>! In T218414#5049514, @Ryasmeen wrote: > 1. The general header stays visible w... [02:36:49] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10matmarex) I noticed an issue with the patch where if you scrolled almost to the end of the... [02:45:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] "This is a bit icky because we also read wgVisualEditorConfig.enableVisualSectionEditing in MobileFrontend, in extensions/MobileFrontend/sr" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498077 (https://phabricator.wikimedia.org/T218851) (owner: 10Esanders) [02:52:09] (03PS1) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Remove unused method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498522 [02:56:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (d79dbfc9c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498456 (owner: 10Jforrester) [02:59:25] (03Merged) 10jenkins-bot: Introduce a 'mobile-ab' config option for section editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498077 (https://phabricator.wikimedia.org/T218851) (owner: 10Esanders) [03:01:09] (03CR) 10jenkins-bot: Introduce a 'mobile-ab' config option for section editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498077 (https://phabricator.wikimedia.org/T218851) (owner: 10Esanders) [03:09:46] (03Merged) 10jenkins-bot: Update VE core submodule to master (d79dbfc9c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498456 (owner: 10Jforrester) [03:11:54] (03CR) 10jenkins-bot: Update VE core submodule to master (d79dbfc9c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498456 (owner: 10Jforrester) [03:38:28] (03PS1) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Restore missing methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498523 (https://phabricator.wikimedia.org/T219041) [03:41:20] (03CR) 10Bartosz Dziewoński: "I lost some methods. Follow-up: https://gerrit.wikimedia.org/r/498523" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498235 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [03:42:38] (03PS2) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Restore missing methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498523 (https://phabricator.wikimedia.org/T218946) [03:50:02] (03PS3) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Restore missing methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498523 (https://phabricator.wikimedia.org/T218946) [04:19:09] (03CR) 10Jforrester: [C: 03+2] ve.init.mw.MobileArticleTarget: Restore missing methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498523 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [04:19:47] (03CR) 10Jforrester: [C: 03+2] ve.init.mw.MobileArticleTarget: Remove unused method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498522 (owner: 10Bartosz Dziewoński) [04:37:04] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Restore missing methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498523 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [04:37:48] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Remove unused method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498522 (owner: 10Bartosz Dziewoński) [04:39:10] (03CR) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Restore missing methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498523 (https://phabricator.wikimedia.org/T218946) (owner: 10Bartosz Dziewoński) [04:41:01] (03CR) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Remove unused method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498522 (owner: 10Bartosz Dziewoński) [08:13:32] (03PS1) 10Divec: WIP: Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) [09:28:14] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/498610 (owner: 10L10n-bot) [09:31:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498620 (owner: 10L10n-bot) [09:38:59] 10VisualEditor, 10I18n: VisualEditor should use its own message for the "Edit" tab - https://phabricator.wikimedia.org/T219056 (10Daimona) [11:57:06] (03CR) 10Esanders: [C: 03+2] ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [12:07:30] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10Esanders) [12:10:30] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [12:14:06] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10Esanders) >>! In T218414#5048560, @alexhollender wrote: > Related to this... [12:15:04] (03CR) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498256 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [12:19:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Design, 10Editing Design : VisualEditor loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181 (10iamjessklein) @Esanders * Good call on spinner+message reading as one, but pr... [13:23:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Cursor pushed off screen when focussing first line in iOS - https://phabricator.wikimedia.org/T219066 (10Esanders) [13:24:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Cursor pushed off screen when focussing first line in iOS - https://phabricator.wikimedia.org/T219066 (10Esanders) [13:41:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Firefox: Paste doesn't work in Firefox 66 in WTE17 in section edit - https://phabricator.wikimedia.org/T219067 (10Izno) [13:41:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Firefox: Paste doesn't work in Firefox 66 in WTE17 in section edit - https://phabricator.wikimedia.org/T219067 (10Izno) [13:55:16] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Unwanted scrolling when opening and closing toolbar after scrolling down on iOS - https://phabricator.wikimedia.org/T219068 (10Esanders) [14:01:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Firefox: Paste doesn't work in Firefox 66 in WTE17 in section edit - https://phabricator.wikimedia.org/T219067 (10Izno) 05Open→03Invalid Ah nope, Internet fart. Pasting worked fine just now. [14:18:33] (03Abandoned) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Keep toolbar always in view (restore old approach) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/498257 (https://phabricator.wikimedia.org/T218414) (owner: 10Bartosz Dziewoński) [14:28:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Unwanted scrolling when opening and closing toolbar after scrolling down on iOS - https://phabricator.wikimedia.org/T219068 (10matmarex) [14:28:42] 10VisualEditor: In mobile VE, using the "Format" menu causes the page to scroll up by ~half the screen every time (iOS only?) - https://phabricator.wikimedia.org/T218650 (10matmarex) [14:46:28] (03PS1) 10Bartosz Dziewoński: ve.ui.Surface: Maybe fix #scrollCursorIntoView for iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498650 (https://phabricator.wikimedia.org/T218650) [15:13:54] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/498610 (owner: 10L10n-bot) [15:28:01] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/498610 (owner: 10L10n-bot) [18:09:24] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10VisualEditor (Current work), 10Wikimedia-production-error: PHP Warning: Illegal string offset 'lang' from ApiVisualEditor.php - https://phabricator.wikimedia.org/T218464 (10Jdforrester-WMF) 05Open→03Resolved Last new occurrence in... [19:32:39] 10VisualEditor, 10MediaWiki-Page-editing, 10Parsoid, 10Patch-For-Review, 10Regression: Source editor and VisualEditor force piped-link creation for links when using lower-case first character and more than one word - https://phabricator.wikimedia.org/T219023 (10Jdforrester-WMF) a:03ssastry [19:55:13] (03CR) 10Esanders: "Does this trigger a scroll on every selection change? Does that make the copy/paste context harder to open?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498650 (https://phabricator.wikimedia.org/T218650) (owner: 10Bartosz Dziewoński) [22:00:53] 10Cite, 10WikiEditor: Add the "cite magazines" citation template to RefToolbar 2.0 on Wikipedia's Edit pages - https://phabricator.wikimedia.org/T219083 (10Ylevental) [22:02:07] 10Cite, 10WikiEditor: Add the "cite magazines" citation template to RefToolbar 2.0 on Wikipedia's Edit pages - https://phabricator.wikimedia.org/T219083 (10Ylevental)