[00:05:52] (03Merged) 10jenkins-bot: Respect user preference for default thumbnail size while editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499330 (https://phabricator.wikimedia.org/T69047) (owner: 10Bartosz Dziewoński) [00:07:33] (03CR) 10jenkins-bot: Respect user preference for default thumbnail size while editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499330 (https://phabricator.wikimedia.org/T69047) (owner: 10Bartosz Dziewoński) [10:27:49] (03CR) 10D3r1ck01: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/499108 (owner: 10L10n-bot) [11:01:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/499108 (owner: 10L10n-bot) [11:07:57] (03CR) 10D3r1ck01: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/498610 (owner: 10L10n-bot) [11:24:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/498610 (owner: 10L10n-bot) [11:48:26] 10VisualEditor, 10MinervaNeue, 10Readers-Web-Backlog: Differences between read mode and edit mode on mobile: some headings shifted by 1px up or down - https://phabricator.wikimedia.org/T218437 (10ovasileva) p:05Triage→03Normal @alexhollender - any additional thoughts on priority here? [12:44:14] 10VisualEditor, 10MinervaNeue, 10Readers-Web-Backlog (Design): Differences between read mode and edit mode on mobile: inconsistent underlines under top-level heading - https://phabricator.wikimedia.org/T218436 (10alexhollender) >>! In T218436#5060432, @matmarex wrote: > I find it inconvenient from a UX persp... [12:44:56] 10VisualEditor-MediaWiki, 10MobileFrontend, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 2 others: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS - https://phabricator.wikimedia.org/T218414 (10JTannerWMF) Hey @Ryasmeen we discussed this in Triage and determined... [12:56:42] 10Citoid, 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Insert citations automatically after generating and show citation to edit it afterwards - https://phabricator.wikimedia.org/T173437 (10Esanders) Regardless of potential workflow changes I think this ^^ is a worthwhile... [14:34:40] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Patch-For-Review, 10VisualEditor (Current work): Deploy mobile section editing to the next set of wikis (listed in the description) - https://phabricator.wikimedia.org/T218939 (10ppelberg) [14:56:42] (03CR) 10Esanders: [C: 04-1] MobileArticleTarget: When saving a section don't trust current page markup (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [15:18:46] (03PS2) 10DLynch: MobileArticleTarget: When saving a section don't trust current page markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) [15:23:58] (03CR) 10DLynch: "Yeah, I just couldn't see anything cheaper that would work as well. I did toy with a fragment-parameter (#section=7, etc) that the mobile " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [15:47:01] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Patch-For-Review, 10VisualEditor (Current work): Deploy mobile section editing to the next set of wikis (listed in the description) - https://phabricator.wikimedia.org/T218939 (10DLynch) It's making a patch for the [mediawiki-config repo](https://gerrit... [16:52:41] 10VisualEditor, 10Readers-Web-Backlog, 10Patch-For-Review: Mobile editor updates browser URL incorrectly if you click back with unsaved edits - https://phabricator.wikimedia.org/T218809 (10ovasileva) [16:56:58] (03CR) 10Esanders: [C: 03+2] MobileArticleTarget: When saving a section don't trust current page markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [16:58:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Performance: Update page dynamically after save on mobile - https://phabricator.wikimedia.org/T219420 (10Esanders) [16:59:05] (03PS3) 10Esanders: MobileArticleTarget: When saving a section don't trust current page markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [16:59:18] (03CR) 10Esanders: [C: 03+2] "Added task number to comment" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [17:01:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Performance: Update page dynamically after save on mobile - https://phabricator.wikimedia.org/T219420 (10Esanders) [17:16:20] (03Merged) 10jenkins-bot: MobileArticleTarget: When saving a section don't trust current page markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [17:28:42] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Performance: Update page dynamically after save on mobile - https://phabricator.wikimedia.org/T219420 (10Esanders) CC @Jdlrobson what would be the best way to apply MF transforms to an API call? [17:28:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping on screen to move the cursor causes the page to scroll up (in Firefox on Android) - https://phabricator.wikimedia.org/T196839 (10kaldari) @Nickps, @Neil_P._Quinn_WMF - Can either of y... [17:36:29] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update OOUI to v0.31.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/499351 (owner: 10Jforrester) [17:38:26] (03Merged) 10jenkins-bot: Update OOUI to v0.31.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/499351 (owner: 10Jforrester) [17:39:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Performance: Update page dynamically after save on mobile - https://phabricator.wikimedia.org/T219420 (10Esanders) [17:52:26] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Performance: Update page dynamically after save on mobile - https://phabricator.wikimedia.org/T219420 (10DLynch) `MobileFrontend.hooks.php` has `onOutputPageBeforeHTML` which does a relatively simple set of things to the content. [17:58:26] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Performance: Update page dynamically after save on mobile - https://phabricator.wikimedia.org/T219420 (10Jdlrobson) Hmm. That's a tricky one. MobileFrontends' formatter expects PHP parser HTML as an input and is internal to MobileFrontend... [18:06:52] 10VisualEditor, 10MinervaNeue, 10Editing Design , 10Readers-Web-Backlog (Design): Differences between read mode and edit mode on mobile: inconsistent underlines under top-level heading - https://phabricator.wikimedia.org/T218436 (10JTannerWMF) [18:12:30] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Neil_P._Quinn_WMF) [18:17:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Neil_P._Quinn_WMF) [18:21:09] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Neil_P._Quinn_WMF) >>! In T196839#50... [18:29:47] (03CR) 10jenkins-bot: MobileArticleTarget: When saving a section don't trust current page markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499259 (https://phabricator.wikimedia.org/T213120) (owner: 10DLynch) [18:32:29] 10VisualEditor-EditingTools, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10VisualEditor (Current work): VisualEditor: Image should not change size when going from read to edit - https://phabricator.wikimedia.org/T69047 (10Jdforrester-WMF) [18:41:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Esanders) As with all Firefox mobile... [18:49:09] (03CR) 10jenkins-bot: Update OOUI to v0.31.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/499351 (owner: 10Jforrester) [19:04:40] 10VisualEditor: Mobile VisualEditor should always show a close button - https://phabricator.wikimedia.org/T218787 (10matmarex) We definitely discussed this internally before, but I can't find an exact duplicate task… maybe we never filed one. Task T113638 is close though. [19:05:08] (03PS1) 10Aaron Schulz: Clean up serialization cache code a bit and add more metrics [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499570 [19:05:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Ryasmeen) Is it possible that @Neil_... [19:14:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Neil_P._Quinn_WMF) [19:17:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10Ryasmeen) >>! In T219200#5058450, @JTannerWMF wrote: > We will see how this behaves post production Hey @JTannerWMF , did we decide that... [19:36:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10matmarex) I have no idea what could be causing this, and I have not been able to reproduce even once on my device (iPhone SE running iOS... [19:53:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10Ryasmeen) @Matmarex: Could you try this one more time following these steps: 1. Go to this page using iOS Safari: https://test.m.wikiped... [20:11:04] 10Cite, 10Math: Many articles containing UNIQ--postMath-00000001-QINU - https://phabricator.wikimedia.org/T138453 (10Physikerwelt) [20:16:13] 10Cite, 10Math: Many articles containing UNIQ--postMath-00000001-QINU - https://phabricator.wikimedia.org/T138453 (10Physikerwelt) Might also be related to T127787 [20:19:33] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Cursor pushed off screen when focussing first line in iOS - https://phabricator.wikimedia.org/T219066 (10matmarex) a:03matmarex Safari scrolls to the wrong position. Here's a standalone example that exhibits the same behavior, and a recording: {F28487945} {... [20:35:50] (03CR) 10Krinkle: Clean up serialization cache code a bit and add more metrics (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499570 (owner: 10Aaron Schulz) [20:38:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Esanders) It's happening for me in p... [20:41:17] (03CR) 10Krinkle: [C: 04-1] Clean up serialization cache code a bit and add more metrics [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499570 (owner: 10Aaron Schulz) [20:41:21] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Patch-For-Review, 10VisualEditor (Current work): Deploy mobile section editing to the next set of wikis (listed in the description) - https://phabricator.wikimedia.org/T218939 (10Esanders) @DLynch I've already written the patch, see above ^^ [20:45:38] (03PS1) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Improve iOS Safari by moving 'padding-top' for toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499590 (https://phabricator.wikimedia.org/T219066) [20:47:37] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Cursor pushed off screen when focussing first line in iOS - https://phabricator.wikimedia.org/T219066 (10matmarex) [20:57:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10matmarex) I really wish that it wouldn't work fine for me. {F28488530} {F28488533} [20:58:43] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.MobileArticleTarget: Improve iOS Safari by moving 'padding-top' for toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499590 (https://phabricator.wikimedia.org/T219066) (owner: 10Bartosz Dziewoński) [21:00:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10matmarex) @Esanders @DLynch Can either of you reproduce and try to debug it? [21:00:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10Ryasmeen) :( @matmarex: I see that you had the page loaded from before on the other tab, did you refresh and load it fresh? >>! In T2... [21:03:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10matmarex) I just tried refreshing before opening the editor and got the same result. [21:04:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Neil_P._Quinn_WMF) >>! In T196839#50... [21:05:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE - https://phabricator.wikimedia.org/T219200 (10ppelberg) p:05Triage→03Normal Thank you for following down the rabbit hole, @Ryasmeen; I've been able to reproduce the regression on... [21:06:23] (03PS2) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Improve iOS Safari by moving 'padding-top' for toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499590 (https://phabricator.wikimedia.org/T219066) [21:18:53] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10Verified, 10VisualEditor (Current work): Dialogs in iOS mobile VE can't be scrolled - https://phabricator.wikimedia.org/T218062 (10Ryasmeen) [21:36:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499653 (owner: 10L10n-bot) [21:47:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10InternetArchiveBot (v2.0): Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10Neil_P._Quinn_WMF) a:03Cyberpower678 [21:47:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10Neil_P._Quinn_WMF) a:05Cyberpower678→03None [21:54:57] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10Patch-For-Review, 10VisualEditor (Current work): Deploy mobile section editing to the next set of wikis (listed in the description) - https://phabricator.wikimedia.org/T218939 (10DLynch) Ugh, reading things before responding to them. Terrible. [22:06:25] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10User-Ryasmeen, and 2 others: Restore section hash fragment after section editing in mobile VE - https://phabricator.wikimedia.org/T213120 (10Jdforrester-WMF) [22:15:58] 10VisualEditor: [EPIC: Affordances] Toolbar improvements - https://phabricator.wikimedia.org/T210627 (10matmarex) Looks like we filed a duplicate task to track this work: T211255 – I'll close this one, since we've been using the other. Sorry! [22:16:07] 10VisualEditor: [EPIC: Affordances] Toolbar improvements - https://phabricator.wikimedia.org/T210627 (10matmarex) [22:16:11] 10VisualEditor, 10Editing Design : [EPIC] Toolbar Improvements for mobile VE users - https://phabricator.wikimedia.org/T211255 (10matmarex) [22:16:35] 10VisualEditor, 10Editing Design : [EPIC] Toolbar Improvements for mobile VE users - https://phabricator.wikimedia.org/T211255 (10matmarex) [22:16:37] 10VisualEditor: [EPIC: Affordances] Toolbar improvements - https://phabricator.wikimedia.org/T210627 (10matmarex) [22:16:39] 10VisualEditor: [Design EPIC]: Toolbar improvements - https://phabricator.wikimedia.org/T210632 (10matmarex) [22:16:46] 10VisualEditor, 10Editing Design : [EPIC] Toolbar Improvements for mobile VE users - https://phabricator.wikimedia.org/T211255 (10matmarex) [22:16:48] 10VisualEditor: [EPIC: Affordances] Toolbar improvements - https://phabricator.wikimedia.org/T210627 (10matmarex) [22:16:50] 10VisualEditor: [Engineering EPIC]: Toolbar improvements - https://phabricator.wikimedia.org/T210633 (10matmarex) [22:20:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/499646 (owner: 10L10n-bot)