[05:06:01] 10VisualEditor, 10Section Editing: Ensure Section Editing is live on remaining wikis - https://phabricator.wikimedia.org/T219950 (10JJMC89) [05:26:50] 10VisualEditor, 10Section Editing: Ensure Section Editing is live on remaining wikis - https://phabricator.wikimedia.org/T219950 (10ppelberg) [06:06:34] 10VisualEditor, 10Section Editing: Ensure Section Editing is live on remaining wikis - https://phabricator.wikimedia.org/T219950 (10ppelberg) ###Wikis tested | 2-April @Esanders confirmed [Section Editing](https://phabricator.wikimedia.org/T209987) is present under the conditions outlined in ***Expected Behav... [06:07:59] 10VisualEditor, 10Section Editing: Ensure Section Editing is live on remaining wikis - https://phabricator.wikimedia.org/T219950 (10ppelberg) [06:08:25] 10VisualEditor, 10Section Editing: Ensure Section Editing is live on remaining wikis - https://phabricator.wikimedia.org/T219950 (10ppelberg) [06:50:01] (03PS2) 10Divec: WIP: Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) [06:51:59] (03CR) 10Divec: "I cannot find a case where this breaks an IME on Android, Ubuntu or Windows. Still need to check iOS and MacOS more thoroughly (both Safar" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) (owner: 10Divec) [08:48:34] (03PS5) 10Mvolz: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) [11:10:10] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10TheDJ) We should probably update parser tests for this though, considering we are deviati... [11:45:25] 10WikiEditor: Caps lock remained on when editing wiki text on iOS and "2010 wiki text editor" enabled - https://phabricator.wikimedia.org/T219480 (10Zppix) [11:45:48] 10WikiEditor: Caps lock remained on when editing wiki text on iOS and "2010 wiki text editor" enabled - https://phabricator.wikimedia.org/T219480 (10Zppix) Updated title to reflect that it affects iOS devices as a whole as i can confirm as mentioned before it happens on iPhone [11:59:12] 10Citoid, 10Patch-For-Review: Rename 'citefromid' to Citoid - https://phabricator.wikimedia.org/T219512 (10Esanders) [12:20:37] (03PS2) 10Esanders: Rename 'citefromid' to 'citoid' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500845 (https://phabricator.wikimedia.org/T219512) [12:20:53] (03PS6) 10Esanders: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [12:20:55] (03PS1) 10Esanders: Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 [12:20:57] (03PS1) 10Esanders: Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 [12:22:11] (03CR) 10Esanders: [C: 03+1] "Separated from I6f01a5d1, originally by Mvolz." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 (owner: 10Esanders) [12:22:16] (03CR) 10Esanders: "Separated from I6f01a5d1, originally by Mvolz." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 (owner: 10Esanders) [12:23:37] (03CR) 10Esanders: [C: 03+1] "* Separated unrelated changes into parent commits." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [12:24:51] (03CR) 10jerkins-bot: [V: 04-1] Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 (owner: 10Esanders) [12:24:53] (03CR) 10jerkins-bot: [V: 04-1] Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 (owner: 10Esanders) [12:26:00] (03PS7) 10Esanders: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [12:26:02] (03PS1) 10Esanders: Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 [12:28:57] (03CR) 10jerkins-bot: [V: 04-1] Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 (owner: 10Esanders) [12:49:54] (03PS2) 10Esanders: Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 [12:49:56] (03PS2) 10Esanders: Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 [12:49:58] (03PS2) 10Esanders: Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 [12:50:00] (03PS8) 10Esanders: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [12:50:53] (03CR) 10Esanders: [C: 03+2] trackSubscriber: don't populate all fields, to make validation happy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500491 (https://phabricator.wikimedia.org/T218163) (owner: 10DLynch) [13:15:31] (03CR) 10Mvolz: "Does this deregister it even if the automatic tab is enabled?" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/499799 (https://phabricator.wikimedia.org/T219510) (owner: 10Esanders) [13:18:21] (03Merged) 10jenkins-bot: trackSubscriber: don't populate all fields, to make validation happy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500491 (https://phabricator.wikimedia.org/T218163) (owner: 10DLynch) [13:20:31] (03CR) 10jenkins-bot: trackSubscriber: don't populate all fields, to make validation happy [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500491 (https://phabricator.wikimedia.org/T218163) (owner: 10DLynch) [14:30:43] (03CR) 10Esanders: [C: 03+1] Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 (owner: 10Esanders) [14:30:49] (03CR) 10Esanders: [C: 03+1] Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 (owner: 10Esanders) [14:47:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, and 2 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10Esanders) a:03Esanders [14:51:14] 10VisualEditor, 10Operations, 10Parsoid, 10RESTBase, and 5 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10Pchelolo) [14:59:20] (03CR) 10Mvolz: "So I just checked this and yes, this disables citoid when the automatic tab is correctly configured, but there are no cite tools configure" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/499799 (https://phabricator.wikimedia.org/T219510) (owner: 10Esanders) [15:07:10] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp " 10Citoid, 10Operations, 10Wikimedia-Logstash, 10service-runner, and 2 others: Move citoid logging to new logging pipeline - https://phabricator.wikimedia.org/T219919 (10mobrovac) p:05Triage→03Normal [15:34:51] (03PS1) 10Mvolz: Keep citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) [15:35:51] (03PS2) 10Mvolz: Keep citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) [15:41:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, and 2 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10Esanders) NB that when switching from visual section editing to source mode we will have to fal... [15:43:50] (03CR) 10DLynch: [C: 03+2] Suppress slugs between floated images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478661 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [15:44:17] (03PS1) 10Esanders: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) [15:44:42] (03PS2) 10Esanders: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) [15:44:58] (03CR) 10Jforrester: [C: 03+2] Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 (owner: 10Esanders) [15:45:02] (03CR) 10Jforrester: [C: 03+2] Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 (owner: 10Esanders) [15:45:06] (03CR) 10Jforrester: [C: 03+2] Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 (owner: 10Esanders) [15:45:26] (03CR) 10jerkins-bot: [V: 04-1] Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [15:45:50] (03CR) 10DLynch: [C: 03+2] Remove blur/focus event listeners from DesktopContext. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500744 (owner: 10Esanders) [15:46:55] (03CR) 10DLynch: [C: 03+2] Redraw deactivated linear selections on 'position' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500798 (https://phabricator.wikimedia.org/T219916) (owner: 10Esanders) [15:47:22] (03Merged) 10jenkins-bot: Remove blur/focus event listeners from DesktopContext. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500744 (owner: 10Esanders) [15:48:22] (03Merged) 10jenkins-bot: Redraw deactivated linear selections on 'position' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500798 (https://phabricator.wikimedia.org/T219916) (owner: 10Esanders) [15:48:52] (03CR) 10jenkins-bot: Remove blur/focus event listeners from DesktopContext. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500744 (owner: 10Esanders) [15:49:43] (03CR) 10jenkins-bot: Redraw deactivated linear selections on 'position' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500798 (https://phabricator.wikimedia.org/T219916) (owner: 10Esanders) [15:50:24] 10VisualEditor: Drop confirm dialogs when switching between VE and 2010 wikitext editor with changes - https://phabricator.wikimedia.org/T220007 (10Esanders) [15:53:30] 10VisualEditor: Drop confirm dialogs when switching between VE and 2010 wikitext editor with changes - https://phabricator.wikimedia.org/T220007 (10Esanders) The original thinking behind this was (1) we previously had a dialog before mid-edit switching was implemented that warned you that data was going to be di... [15:56:07] 10VisualEditor, 10good first bug: Add icon(s) for audiovisual media (music / movie) to the cite tool css classes - https://phabricator.wikimedia.org/T220009 (10Mvolz) [15:56:22] 10VisualEditor, 10good first bug: Add icon(s) for audiovisual media (music / movie) to the cite tool css classes - https://phabricator.wikimedia.org/T220009 (10Mvolz) p:05Triage→03Lowest [15:59:11] (03Merged) 10jenkins-bot: Suppress slugs between floated images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478661 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [15:59:13] (03CR) 10jerkins-bot: [V: 04-1] Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 (owner: 10Esanders) [15:59:15] (03CR) 10jerkins-bot: [V: 04-1] Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 (owner: 10Esanders) [15:59:17] (03CR) 10jerkins-bot: [V: 04-1] Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 (owner: 10Esanders) [16:00:05] 10VisualEditor, 10good first bug: Add icon(s) for audiovisual media (music / movie) to the cite tool css classes - https://phabricator.wikimedia.org/T220009 (10Mvolz) [16:01:12] (03CR) 10jenkins-bot: Suppress slugs between floated images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/478661 (https://phabricator.wikimedia.org/T107745) (owner: 10Esanders) [16:03:11] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOUI, 10Patch-For-Review: BookletLayout is unusable on mobile - https://phabricator.wikimedia.org/T209912 (10marcella) [16:03:36] (03CR) 10Mvolz: "I've found an example of a Wikipedia where deploying the previous change without this fix will disable citoid, so I think it should be che" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [16:11:08] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Backlog (Later), 10Services (designing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10Pchelolo) [16:13:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10Esanders) [16:28:39] (03PS3) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) [16:30:36] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp " (03CR) 10Mvolz: [C: 04-1] "On second thought, now this disables it if the automatic tab isn't configured period, which isn't good either." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [16:46:41] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp " (03CR) 10Mvolz: [C: 03+1] "NVM, that was the previous behaviour anyway... we can follow up in future changes." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [17:40:37] (03CR) 10Esanders: "Does auto do anything useful if there are no cite types to map to??" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [17:44:25] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10ppelberg) [17:47:06] 10VisualEditor, 10MobileFrontend: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823 (10Trizek-WMF) https://en.m.wikipedia.org/w/index.php?title=I_Will_Always_Love_You&action=edit redirects to https://en.m.wikipedia.org/w/index.php?title=I_Will_Always_Love_You#/ed... [17:47:46] (03CR) 10Esanders: "Also we should do this on top of the rename or it will be a nightmare to rebase..." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [17:53:01] (03CR) 10Mvolz: "No, it doesn't do anything if there is nothing to map to. The only useful thing then would be the re-use tab." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [17:55:09] (03CR) 10Mvolz: "Sorry, that second sentence was incomprehensible. The 'map' is independent of the cite tools (ve.ui.mwCitationTools)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [17:59:52] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (5c8fd26b8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) [18:01:29] (03CR) 10Jforrester: [C: 03+1] Make deactivated selections grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/500745 (https://phabricator.wikimedia.org/T219829) (owner: 10Esanders) [18:01:32] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (5c8fd26b8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) (owner: 10Bartosz Dziewoński) [18:01:39] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to master (5c8fd26b8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) (owner: 10Bartosz Dziewoński) [18:01:50] * James_F tsks MatmaRex. [18:02:06] * MatmaRex hides [18:06:02] (03PS3) 10Esanders: Keep citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:14:27] (03PS4) 10Esanders: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:21:28] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (5c8fd26b8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) (owner: 10Bartosz Dziewoński) [18:24:25] (03PS5) 10Esanders: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:26:07] (03CR) 10Jforrester: [C: 03+2] "CI flaked because gerrit was temporarily down for an upgrade." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) (owner: 10Bartosz Dziewoński) [18:26:20] (03CR) 10Mvolz: Keep Citoid enabled if automatic tab is configured (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:26:45] (03CR) 10Esanders: "Ok, so the new logic is:" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:27:15] (03CR) 10Esanders: Keep Citoid enabled if automatic tab is configured (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:27:56] (03CR) 10jerkins-bot: [V: 04-1] Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:28:42] (03PS6) 10Esanders: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:31:58] (03CR) 10Mvolz: [C: 03+1] "LGTM, will test." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [18:32:56] (03PS3) 10Esanders: Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 [18:32:58] (03PS3) 10Esanders: Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 [18:33:00] (03PS3) 10Esanders: Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 [18:33:02] (03PS9) 10Esanders: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [18:34:08] (03PS3) 10Krinkle: Avoid keeping excess keys from storeInSerializationCache() in cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499846 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [18:34:32] (03CR) 10Krinkle: [C: 03+2] "LGTM, but don't now the interaction too well. I suppose no-one really does, so let's just try. We'll fix it if anything breaks :) Feel fre" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499846 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [18:42:08] (03PS7) 10Mvolz: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T98618) [18:47:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (5c8fd26b8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) (owner: 10Bartosz Dziewoński) [18:50:31] (03CR) 10Mvolz: [C: 04-1] "I don't know why, but when I test this current version, citoid is disabled when cite tools is disabled and automatic enabled. (?)" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T98618) (owner: 10Mvolz) [19:03:34] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp " (03CR) 10jenkins-bot: Update VE core submodule to master (5c8fd26b8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501020 (https://phabricator.wikimedia.org/T219916) (owner: 10Bartosz Dziewoński) [19:06:10] (03Merged) 10jenkins-bot: Avoid keeping excess keys from storeInSerializationCache() in cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499846 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [19:08:41] (03CR) 10jenkins-bot: Avoid keeping excess keys from storeInSerializationCache() in cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499846 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [19:10:55] 10VisualEditor-ContentEditable, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10VisualEditor (Current work): Deactivated selection out of position when window resized - https://phabricator.wikimedia.org/T219916 (10Jdforrester-WMF) [19:28:32] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp " (03PS1) 10Bartosz Dziewoński: Remove support for page title "hrefPrefix" other than './' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) [19:41:00] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp ">! In T219510#5082803, @dduvall wrote: > @Mvolz I'm currently holding... [19:42:20] 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp " 10Citoid, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Patch-For-Review, 10VisualEditor (Current work): Citoid should only usurp ">! In T219510#5082854, @Mvolz wrote: >>>! In T219510#5082803, @dduv... [19:45:39] (03CR) 10jerkins-bot: [V: 04-1] Remove support for page title "hrefPrefix" other than './' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) (owner: 10Bartosz Dziewoński) [19:51:18] (03CR) 10Jforrester: "Roan agrees that we've not needed this for many years, since Parsoid started outputting the same base href for all pages." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) (owner: 10Bartosz Dziewoński) [20:09:40] (03CR) 10Bartosz Dziewoński: "Tests are failing because of Cite tests, which I'm updating in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/501041 (it cur" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) (owner: 10Bartosz Dziewoński) [20:10:08] (03PS2) 10Bartosz Dziewoński: Remove support for page title "hrefPrefix" other than './' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) [20:30:40] (03CR) 10Jforrester: [C: 03+2] "Force merged the dependency in Cite. Aren't circular dependencies lovely?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) (owner: 10Bartosz Dziewoński) [20:31:11] MatmaRex: I took advantage of the gate-and-submit queue being open so it won't break the world for a lot of users. [20:31:41] well, i'm glad that at least Cite still allows force-merges [20:33:36] MatmaRex: Everything allows force-merges if you have the rights, but yes. It's on my list of things we need to fix. [20:49:24] 10VisualEditor: Visual editor (source editing mode) should always present edit summary box before saving - https://phabricator.wikimedia.org/T220042 (10AxelBoldt) [20:49:47] (03Merged) 10jenkins-bot: Remove support for page title "hrefPrefix" other than './' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) (owner: 10Bartosz Dziewoński) [20:51:35] (03CR) 10jenkins-bot: Remove support for page title "hrefPrefix" other than './' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501040 (https://phabricator.wikimedia.org/T206357) (owner: 10Bartosz Dziewoński) [21:00:53] James_F: Everything except VisualEditor :) Tyler recently asked me why that was customized [21:04:53] RoanKattouw: And a few other repos. Blame Krinkle. [21:05:56] (03PS4) 10Esanders: Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 [21:06:01] (03PS4) 10Esanders: Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 [21:06:06] (03PS4) 10Esanders: Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 [21:06:13] (03PS10) 10Esanders: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [21:13:24] (03CR) 10Esanders: "I accidentally committed a test required param that is never present." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T98618) (owner: 10Mvolz) [21:19:37] (03PS8) 10Esanders: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [21:19:39] (03PS5) 10Esanders: Remove unused i18n message 'citoid-520-error' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500937 [21:19:41] (03PS5) 10Esanders: Add 'QID' to search label [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500938 [21:19:43] (03PS5) 10Esanders: Commit package-lock.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500939 [21:19:45] (03PS11) 10Esanders: Rename 'citefromid' to 'citoid' - requires changes on wiki [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [21:19:47] (03PS1) 10Esanders: Use single Citoid tool even when 'automatic' not configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/501062 (https://phabricator.wikimedia.org/T98618) [21:26:30] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10ppelberg) [21:32:48] (03CR) 10Bartosz Dziewoński: [C: 03+1] Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [21:39:08] (03PS12) 10Esanders: WIP DEMO barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) [21:41:20] 10VisualEditor, 10MediaWiki-Page-protection, 10MobileFrontend, 10Readers-Web-Backlog (Tracking): MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end - https://phabricator.wikimedia.org/T219848 (10Jdlrobson) I'm guessing this is a bug for VisualEditor project but let me know... [21:54:41] (03CR) 10Mvolz: [C: 04-1] Keep Citoid enabled if automatic tab is configured (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [21:56:57] (03PS9) 10Mvolz: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) [22:00:07] (03CR) 10Mvolz: [C: 03+1] "tested, works, I think this is finally done. (famous last words.)" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [23:00:40] (03CR) 10Esanders: [C: 03+2] Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [23:07:12] 10VisualEditor, 10Product-Analytics: Analyze impact of section editing in the mobile visual editor - https://phabricator.wikimedia.org/T211239 (10ppelberg) [23:08:34] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10ppelberg) [23:08:43] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10User-Ryasmeen, 10VisualEditor (Current work): Deploy mobile section editing to the next set of wikis (listed in the description) - https://phabricator.wikimedia.org/T218939 (10ppelberg) 05Open→03Resolved [23:17:00] 10VisualEditor-MediaWiki-Mobile, 10Verified, 10Verified-in-Phase0, 10Verified-in-Phase2, 10VisualEditor (Current work): Selection lags behind scroll on iPhone - https://phabricator.wikimedia.org/T217798 (10ppelberg) ###Fix demonstrated https://youtu.be/BOax_Z4RxlI* --- //Posting in case we decide to c... [23:17:43] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: EPIC: Fix selection issues on mobile - https://phabricator.wikimedia.org/T209505 (10ppelberg) [23:17:47] 10VisualEditor-MediaWiki-Mobile, 10Verified, 10Verified-in-Phase0, 10Verified-in-Phase2, 10VisualEditor (Current work): Selection lags behind scroll on iPhone - https://phabricator.wikimedia.org/T217798 (10ppelberg) 05Open→03Resolved a:03ppelberg [23:22:13] (03Merged) 10jenkins-bot: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [23:24:35] (03CR) 10jenkins-bot: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500979 (https://phabricator.wikimedia.org/T219510) (owner: 10Mvolz) [23:34:14] (03PS1) 10Jforrester: Keep Citoid enabled if automatic tab is configured [extensions/Citoid] (wmf/1.33.0-wmf.24) - 10https://gerrit.wikimedia.org/r/501114 (https://phabricator.wikimedia.org/T219510)