[00:59:47] 10Cite, 10Browser-Tests, 10Wikimedia-production-error (Shared Build Failure): Flaky wdio test "Cite backlinks clickable up arrow is hidden" - https://phabricator.wikimedia.org/T220318 (10Krinkle) [01:00:45] 10Cite, 10Browser-Tests, 10Wikimedia-production-error (Shared Build Failure): Flaky wdio test "Cite backlinks clickable up arrow is hidden" - https://phabricator.wikimedia.org/T220318 (10Krinkle) p:05Triage→03High Ping @WMDE-Fisch: * {3c855ea4cd0ac787dc9b1eabe8a63ee25c1ccd8a} * {T217767} * 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Do not let the visual mode break tables - https://phabricator.wikimedia.org/T220319 (10Whatamidoing-WMF) [02:26:34] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: The visual editor only broke part of the table - https://phabricator.wikimedia.org/T220320 (10Whatamidoing-WMF) [04:38:56] 10VisualEditor: Instrumentation - https://phabricator.wikimedia.org/T209988 (10Neil_P._Quinn_WMF) [06:50:30] (03PS1) 10Divec: Move filibuster initialization to ve.debug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502151 [07:12:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/502103 (owner: 10L10n-bot) [07:30:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502142 (owner: 10L10n-bot) [09:09:46] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10zeljkofilipin) @Jdlrobson if you're blocked on this by #re... [11:05:11] (03CR) 10Esanders: [C: 03+2] Move filibuster initialization to ve.debug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502151 (owner: 10Divec) [11:06:54] (03Merged) 10jenkins-bot: Move filibuster initialization to ve.debug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502151 (owner: 10Divec) [11:08:03] (03PS2) 10Esanders: ve.ce.Selection: Introduce getSelectionFocusRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501665 [11:08:05] (03PS2) 10Esanders: Distinguish between $scrollContainer and $scrollListener [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501667 [11:08:07] (03PS2) 10Esanders: Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) [11:08:35] (03CR) 10jenkins-bot: Move filibuster initialization to ve.debug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502151 (owner: 10Divec) [11:09:28] (03CR) 10Esanders: "Sure. We have an iOS selector so we can scope it to that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500547 (https://phabricator.wikimedia.org/T109508) (owner: 10Esanders) [11:09:42] (03CR) 10jerkins-bot: [V: 04-1] Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) (owner: 10Esanders) [11:16:38] (03PS2) 10Esanders: Give mobile document a min height based on 100vh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500547 (https://phabricator.wikimedia.org/T109508) [11:18:15] (03PS1) 10Esanders: 'scrollCursorIntoView' -> 'scrollSelectionIntoView' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502197 [11:20:20] (03PS2) 10Esanders: EditSummaryWidget: Disable pending animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501572 [11:22:13] (03PS14) 10Esanders: WIP DEMO barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) [11:27:05] (03CR) 10jerkins-bot: [V: 04-1] Give mobile document a min height based on 100vh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500547 (https://phabricator.wikimedia.org/T109508) (owner: 10Esanders) [11:53:50] (03PS8) 10Esanders: Mixin NailedAnnotation to Comment/LanguageAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 [11:55:28] (03CR) 10jerkins-bot: [V: 04-1] Mixin NailedAnnotation to Comment/LanguageAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 (owner: 10Esanders) [12:30:33] (03PS3) 10Esanders: Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) [12:32:00] (03CR) 10jerkins-bot: [V: 04-1] Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) (owner: 10Esanders) [12:32:41] (03PS3) 10Esanders: Give mobile document a min height based on 100vh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500547 (https://phabricator.wikimedia.org/T109508) [13:19:58] (03PS15) 10Esanders: WIP DEMO barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) [13:23:33] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10User-notice: Add ability to cite books by scanning their ISBN barcode in mobile web - https://phabricator.wikimedia.org/T216775 (10Esanders) @Mvolz I've pushed this change to the test server. [13:42:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design: EPIC: Re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10iamjessklein) [13:43:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Epic: EPIC: Re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10iamjessklein) [13:52:08] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Epic: Wireframe contextual input user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10iamjessklein) [13:53:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design: Re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10iamjessklein) [13:54:26] 10VisualEditor, 10Editing Design: [EPIC] Toolbar Improvements for mobile VE users - https://phabricator.wikimedia.org/T211255 (10iamjessklein) [15:01:46] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Do not let the visual mode break tables - https://phabricator.wikimedia.org/T220319 (10ssastry) p:05Triage→03Low The problematic edit that started these problems is [[https://en.wikipedia.org/w/index.php?title=MicroMasters&type=revision&diff=873678343&old... [15:10:18] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Do not let the visual mode break tables - https://phabricator.wikimedia.org/T220319 (10ssastry) https://en.wikipedia.org/w/index.php?title=User:SSastry_(WMF)/VE_Test/Sandbox&oldid=891530736 has source that can be used to reproduce the problem. Note that the H... [15:16:24] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Do not let the visual mode break tables - https://phabricator.wikimedia.org/T220319 (10ssastry) >>! In T220319#5094041, @ssastry wrote: > https://en.wikipedia.org/w/index.php?title=User:SSastry_(WMF)/VE_Test/Sandbox&oldid=891530736 has source that can be used... [15:22:10] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: The visual editor only broke part of the table - https://phabricator.wikimedia.org/T220320 (10ssastry) 05Open→03Declined It only "broke part of the table" is part of the design of Parsoid's html -> wt conversion code. By design, Parsoid tries to convert o... [15:22:59] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid-Edit-Support: Do not let the visual mode break tables - https://phabricator.wikimedia.org/T220319 (10ssastry) [15:23:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502236 (owner: 10L10n-bot) [15:23:38] (03CR) 10DLynch: [C: 03+2] Use nullSelectionOnBlur=false for ArticleTargets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500757 (https://phabricator.wikimedia.org/T208826) (owner: 10Esanders) [15:45:55] (03CR) 10jerkins-bot: [V: 04-1] Use nullSelectionOnBlur=false for ArticleTargets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500757 (https://phabricator.wikimedia.org/T208826) (owner: 10Esanders) [16:09:12] 10VisualEditor: Allow selection of the text in the Visual Editor reference inspector - https://phabricator.wikimedia.org/T220090 (10DLynch) Until T208826 is done, this would have some side-effects, as removing the selection from within the text would immediately close the context popup. Once that ticket is done... [16:23:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Working on some unit tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [16:58:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Epic: Wireframe contextual input user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10iamjessklein) [16:58:47] (03CR) 10Divec: [C: 04-1] "We should add some documentation explaining how we intend this to work with regards to nested blockquotes. (I'm not sure what the answer i" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [18:11:35] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Esanders) @Ryasmeen can you test this i... [18:14:45] (03CR) 10Jforrester: [C: 03+2] LanguageInputWidget: Set value on 'closing' not 'closed' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501997 (owner: 10Esanders) [18:16:39] (03Merged) 10jenkins-bot: LanguageInputWidget: Set value on 'closing' not 'closed' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501997 (owner: 10Esanders) [18:18:03] (03CR) 10jenkins-bot: LanguageInputWidget: Set value on 'closing' not 'closed' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501997 (owner: 10Esanders) [18:26:03] (03CR) 10Esanders: [C: 03+2] ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499959 (https://phabricator.wikimedia.org/T219200) (owner: 10Bartosz Dziewoński) [18:37:20] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499959 (https://phabricator.wikimedia.org/T219200) (owner: 10Bartosz Dziewoński) [18:38:37] 10VisualEditor-MediaWiki-Mobile, 10Regression, 10VisualEditor (Current work): [regression] Delete buttons missing from mobile contexts - https://phabricator.wikimedia.org/T220438 (10Esanders) [18:39:39] (03PS1) 10Esanders: LinearContextItem: Fix typo in isDeletable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502302 (https://phabricator.wikimedia.org/T220438) [18:40:13] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): [regression] Delete buttons missing from mobile contexts - https://phabricator.wikimedia.org/T220438 (10Esanders) Was caused by a typo in the read-only mode code that we added a few weeks ago. [18:41:29] (03CR) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499959 (https://phabricator.wikimedia.org/T219200) (owner: 10Bartosz Dziewoński) [18:43:13] (03CR) 10Jforrester: [C: 03+2] LinearContextItem: Fix typo in isDeletable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502302 (https://phabricator.wikimedia.org/T220438) (owner: 10Esanders) [18:45:10] (03Merged) 10jenkins-bot: LinearContextItem: Fix typo in isDeletable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502302 (https://phabricator.wikimedia.org/T220438) (owner: 10Esanders) [18:46:34] (03CR) 10jenkins-bot: LinearContextItem: Fix typo in isDeletable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502302 (https://phabricator.wikimedia.org/T220438) (owner: 10Esanders) [18:56:54] (03PS1) 10Jforrester: Update VE core submodule to master (3cfdc4311) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502310 (https://phabricator.wikimedia.org/T220438) [19:07:10] 10VisualEditor: Allow selection of the text in the Visual Editor reference inspector - https://phabricator.wikimedia.org/T220090 (10Esanders) Note that T208826 doesn't turn this on for all editor modes, specifically just single article editing (but not Flow or CX). [19:13:57] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (3cfdc4311) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502310 (https://phabricator.wikimedia.org/T220438) (owner: 10Jforrester) [19:20:05] 10VisualEditor: Moving focus from an inspector to outside the document does not blur the document - https://phabricator.wikimedia.org/T220439 (10Esanders) [19:20:19] 10VisualEditor: Allow selection of the text in the Visual Editor reference inspector - https://phabricator.wikimedia.org/T220090 (10Esanders) See also T220439 [19:22:39] (03PS1) 10Esanders: Make context's contents selectable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502317 (https://phabricator.wikimedia.org/T220090) [19:24:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (3cfdc4311) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502310 (https://phabricator.wikimedia.org/T220438) (owner: 10Jforrester) [19:26:27] (03CR) 10jenkins-bot: Update VE core submodule to master (3cfdc4311) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502310 (https://phabricator.wikimedia.org/T220438) (owner: 10Jforrester) [19:35:45] (03PS1) 10Umherirrender: Add phan [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/502325 [19:36:30] (03CR) 10Umherirrender: "check experimental" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/502325 (owner: 10Umherirrender) [19:49:21] 10VisualEditor-MediaWiki-Mobile, 10Regression, 10VisualEditor (Current work): [regression] Delete buttons missing from mobile contexts - https://phabricator.wikimedia.org/T220438 (10Jdforrester-WMF) [19:49:37] 10VisualEditor: Moving focus from an inspector to outside the document does not blur the document - https://phabricator.wikimedia.org/T220439 (10Esanders) This is going to be quite hard to fix. Any events blur/mousedown that fire while the inspector is open could be non-document-blurring events because by a sub-... [19:50:57] (03PS7) 10Bartosz Dziewoński: Make blockquote a non-content branch node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) [19:51:30] (03PS10) 10Bartosz Dziewoński: Update VE core submodule to master (6ef839e5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) [19:51:41] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (6ef839e5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [20:01:40] (03CR) 10Bartosz Dziewoński: "@Divec PS7 adds some unit tests which should help clarify how I intend this to work. Basically, if the selection is entirely contained in " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/475961 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [20:36:34] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10User-Ryasmeen, and 2 others: Restore section hash fragment after section editing in mobile VE - https://phabricator.wikimedia.org/T213120 (10Ryasmeen) ok, this time it's real. Still seeing this on bn.wiki. He... [20:44:58] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Patch-For-Review, 10VisualEditor (Current work): Avoid wgVisualEditorToolbarScrollOffset data export on page views - https://phabricator.wikimedia.org/T220158 (10matmarex) [22:07:42] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) I have done exactly that. We are not blocked on... [23:01:51] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) Here's a concrete example, the first browser te... [23:14:29] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10ppelberg) [23:23:16] 10VisualEditor, 10Operations, 10Parsoid, 10RESTBase, and 5 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) [23:47:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste: Pasted external links are not converted to hyperlinks with VisualEditor - https://phabricator.wikimedia.org/T220462 (10mingle) [23:48:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste: Pasted external links are not converted to hyperlinks with VisualEditor - https://phabricator.wikimedia.org/T220462 (10mingle)