[00:00:05] (03PS5) 10Jforrester: Update VE core submodule to master (f039957f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502558 (owner: 10Esanders) [00:00:57] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to master (f039957f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502558 (owner: 10Esanders) [00:15:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (f039957f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502558 (owner: 10Esanders) [00:16:18] (03CR) 10jenkins-bot: Update VE core submodule to master (f039957f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502558 (owner: 10Esanders) [01:57:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10ppelberg) >>! In T196839#5068268, @p... [01:59:00] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10Mobile, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10ppelberg) [03:18:53] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10Mobile, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Neil_P._Quinn_WMF) >>! In T196839#5099862,... [07:28:19] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/502731 (owner: 10L10n-bot) [07:39:44] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/502731 (owner: 10L10n-bot) [07:52:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502739 (owner: 10L10n-bot) [08:11:34] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Templates: Links generated by templates inaccessible while editing - https://phabricator.wikimedia.org/T220584 (10Schnark) [08:40:51] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Updated TemplateData from transcluded items take a long time to show up - https://phabricator.wikimedia.org/T52372 (10Pginer-WMF) Content translation relies in templateData to transfer templates across languages. In particular, templateData is used to... [08:43:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/502731 (owner: 10L10n-bot) [15:37:10] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10Mobile, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Esanders) It's slightly higher among edito... [15:49:59] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Kipod) legit maps on many wikis are still broken. i believe this story should be reopened... [15:50:35] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Kipod) 05Resolved→03Open [15:52:58] (03CR) 10DLynch: [C: 03+2] ve.ce.Selection: Introduce getSelectionFocusRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501665 (owner: 10Esanders) [15:54:21] (03Merged) 10jenkins-bot: ve.ce.Selection: Introduce getSelectionFocusRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501665 (owner: 10Esanders) [15:55:59] (03CR) 10jenkins-bot: ve.ce.Selection: Introduce getSelectionFocusRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501665 (owner: 10Esanders) [16:24:13] 10VisualEditor, 10VisualEditor-ContentEditable: Right click to delete across paragraphs in Firefox results in no model transaction - https://phabricator.wikimedia.org/T220629 (10Esanders) [16:32:10] 10VisualEditor, 10VisualEditor-ContentEditable: Right click to delete across paragraphs in Firefox results in no model transaction - https://phabricator.wikimedia.org/T220629 (10matmarex) [16:52:55] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Cirdan) p:05Normal→03Unbreak! This appears to have been deployed again. Users in dewi... [16:54:51] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10Esanders) [16:56:44] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10aezell) @Cirdan Do you have any examples? I'm looking at https://de.wikipedia.org/wiki/Ba... [16:57:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: Selection experiment: Deactivate selection on scroll past viewport - https://phabricator.wikimedia.org/T220634 (10Esanders) [17:54:19] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Jonesey95) Here's a link to a broken page: https://en.wikipedia.org/w/index.php?title=Tem... [17:59:21] (03PS1) 10Jforrester: Update VE core submodule to master (e323decf6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502846 [18:18:50] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10iamjessklein) [18:21:39] 10Citoid, 10VisualEditor: Sometimes an ISBN turns up wrapped in nowiki-tags - https://phabricator.wikimedia.org/T219627 (10matmarex) I argued for this to be put in "Needs Discussion/Analysis" rather than "Freezer", but on a closer look, I agree with Ed – I'm not sure if this case is worth investigating. I thin... [18:38:22] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Cirdan) p:05Unbreak!→03High >>! In T217087#5101795, @aezell wrote: > @Cirdan Do you h... [18:51:16] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): External text with CRLF line endings breaks text processing in NWE - https://phabricator.wikimedia.org/T205564 (10Ryasmeen) [18:53:13] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10Mobile, and 2 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Esanders) Turns out this is a pure browser... [18:53:44] (03PS1) 10Esanders: Firefox Mobile: Prevent scrolling after mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502851 (https://phabricator.wikimedia.org/T196839) [18:56:27] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10Mobile, and 3 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10Esanders) The above patch continuously res... [19:22:51] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10matmarex) a:03matmarex [19:52:09] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Add sanity check against loading content in wrong mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502871 (https://phabricator.wikimedia.org/T219457) [19:52:11] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Validate 'veaction' parameter against available modes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502872 (https://phabricator.wikimedia.org/T219457) [20:03:05] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10TheDJ) Negative numbers were [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/I... [20:15:34] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10aezell) Based on the patch and its commit message, I believe the author was following the... [20:37:12] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Diff view goes empty while switching back Visual diff to wikitext diff - https://phabricator.wikimedia.org/T219680 (10matmarex) a:03matmarex [20:56:17] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Work around review panel disappearing on iOS Safari [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502891 (https://phabricator.wikimedia.org/T219680) [21:05:31] (03PS1) 10Esanders: Re-use previousSelection when re-activating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502895 (https://phabricator.wikimedia.org/T220633) [21:05:33] (03PS1) 10Esanders: Don't reactivate after opening tools/windows on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502896 (https://phabricator.wikimedia.org/T220633) [21:16:56] (03PS4) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) [21:28:44] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid, 10StructuredDiscussions, and 4 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247 (10Isarra) Can someone clarify for me if this is why ParserOptions::setWrapOutputClass() no longer takes 'false' as an... [21:28:48] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński) [21:44:06] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid, 10StructuredDiscussions, and 4 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247 (10Isarra) And if this is why, this is the relevant patch that this is causing problems for: https://gerrit.wikimedia.o... [21:51:32] (03PS1) 10Esanders: Fix mobile done/tick button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502906 [22:09:20] 10VisualEditor, 10MediaWiki-Page-editing, 10MinervaNeue (Tracking): On a desktop web browser, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors - https://phabricator.wikimedia.org/T190989 (10matmarex) >>! In T190989#5060219, @gh87 wrote: > Nevertheless, a... [22:12:27] 10VisualEditor, 10MobileFrontend: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823 (10matmarex) These are the interfaces you should see (when using any edit link): ### When you're using the mobile site: | Reading mode | Wikitext editor | Visual editor | | {F2... [22:32:12] 10VisualEditor, 10MediaWiki-Page-protection, 10MobileFrontend, 10Readers-Web-Backlog (Tracking): MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end - https://phabricator.wikimedia.org/T219848 (10matmarex) >>! In T219848#5083247, @Jdlrobson wrote: > I'm guessing this is a b... [22:34:27] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Kipod) >>! In T217087#5102461, @aezell wrote: > Based on the patch and its commit message... [22:35:04] 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-protection: Visual editor and 2017 wikitext editor mishandle cascading protection - https://phabricator.wikimedia.org/T217217 (10matmarex) Note that there is an error message: {F28606003} But in spite of that, th... [22:40:39] (03PS5) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) [22:56:05] 10Editing-team, 10VisualEditor, 10ImageMap, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 5 others: Error "A non well formed numeric value encountered" (from ImageMap) - https://phabricator.wikimedia.org/T217087 (10Kipod) >>! In T217087#5101989, @Jonesey95 wrote: > Here's a link to a broken page: > http... [22:57:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think this is a good change, but the experience of the dialog closing, then nothing happening for a moment, and then a new dialog openin" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/497073 (owner: 10Fomafix)