[00:22:10] 10VisualEditor, 10Editing Design: [EPIC] Toolbar improvements - https://phabricator.wikimedia.org/T211255 (10ppelberg) [00:24:48] 10VisualEditor, 10Editing Design: [EPIC] Toolbar improvements - https://phabricator.wikimedia.org/T211255 (10ppelberg) [00:35:40] 10VisualEditor-MediaWiki-Mobile, 10jQuery-Client, 10Browser-Support-Firefox, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), and 2 others: VisualEditor gives warning on Firefox for Android - https://phabricator.wikimedia.org/T101483 (10ppelberg) 05Open→03Resolved [00:36:40] 10VisualEditor-DataModel, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10VisualEditor (Current work): Loss of 'alt' texts when manipulating image presentation form - https://phabricator.wikimedia.org/T216285 (10ppelberg) 05Open→03Resolved [00:45:18] 10VisualEditor-VisualDiffs, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10Regression, 10Verified, 10VisualEditor (Current work): [regression] Historical visual diffs not unwrapping section tags - https://phabricator.wikimedia.org/T217752 (10ppelberg) 05Open→03Resolved [04:12:33] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Non-latin URL fragments don't reliably get scrolled to - https://phabricator.wikimedia.org/T220513 (10Jdlrobson) Looks like this is being managed as part of editing team workflow so adding VisualEditor tag. [04:28:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile VisualEditor provides no warning of blocked status - https://phabricator.wikimedia.org/T221400 (10ppelberg) >>! In T221400#5124721, @kaldari wrote: > No,VE specifically told me that I was blocked after trying to save my edit (rather than saying "Error: Ed... [08:38:05] 10Editing-team, 10Contributors-Team, 10MediaWiki-API, 10Wikimedia-production-error: MovePage::move contention on cebwiki - https://phabricator.wikimedia.org/T221595 (10jcrespo) [08:44:49] 10Editing-team, 10Contributors-Team, 10MediaWiki-API, 10Wikimedia-production-error: MovePage::move contention on cebwiki - https://phabricator.wikimedia.org/T221595 (10jcrespo) [09:20:32] 10VisualEditor: HTML of edit page downloaded twice - https://phabricator.wikimedia.org/T221600 (10Schnark) [09:28:37] 10VisualEditor-DataModel, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10VisualEditor (Current work): Loss of 'alt' texts when manipulating image presentation form - https://phabricator.wikimedia.org/T216285 (10FellTiger) Thanks for fixing @DLynch ! [09:49:50] (03CR) 10Esanders: "I'll just amend that on the day it gets deployed." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [11:28:34] (03CR) 10Mvolz: [C: 03+2] Rename 'citefromid' to 'citoid' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [11:32:31] (03Merged) 10jenkins-bot: Rename 'citefromid' to 'citoid' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [11:33:22] (03CR) 10jenkins-bot: Rename 'citefromid' to 'citoid' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/500732 (https://phabricator.wikimedia.org/T219512) (owner: 10Mvolz) [13:54:07] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Mvolz) [14:16:51] 10Citoid, 10VisualEditor, 10Parsoid: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) [14:17:30] 10Citoid, 10VisualEditor, 10Parsoid: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) Could be a Parsoid <> Lua interaction? I think `{{PAGENAME}]` works fine when rendering those templates, so the title is definite... [14:20:57] 10Citoid, 10VisualEditor, 10Parsoid: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) Hang on, the method is getting the full wikitext content of the page. It's probably expected that it returns null when the page d... [14:21:05] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) [14:29:14] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) 05Open→03Invalid On-wiki issue with Lua module. Fixed there. [14:31:15] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 10 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) In https://gerrit.wikimedia.org/r/#/c/mediawik... [14:32:08] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Mvolz) Thanks! [15:07:48] (03PS16) 10Esanders: Barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) [15:08:21] (03CR) 10Esanders: [C: 04-1] "Pending deployment plan." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) (owner: 10Esanders) [15:09:21] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Trappist_the_monk) Not sure I believe that. In the simple create-a-new-article-with-the-wikisource-editor test that I described at [[ https://en.wikipe... [15:11:54] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile VisualEditor provides no warning of blocked status - https://phabricator.wikimedia.org/T221400 (10JTannerWMF) When should this happen relative to our other work @Esanders [15:13:03] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Non-latin URL fragments don't reliably get scrolled to - https://phabricator.wikimedia.org/T220513 (10JTannerWMF) Hey @Jdlrobson you are correct we are going to work on this. [15:13:38] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Non-latin URL fragments don't reliably get scrolled to - https://phabricator.wikimedia.org/T220513 (10JTannerWMF) a:03DLynch [15:14:02] 10VisualEditor: [Epic] Produce Section Editing + Loading Overlay Report - https://phabricator.wikimedia.org/T221327 (10JTannerWMF) [15:15:45] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) > (there is no saved version of a page that has never been saved) This is precisely the problem. To preview a page in the classic wikitext ed... [15:17:51] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): [Regression pre-wmf.2] Switching back from the diff panel to the save form on mobile VE makes the form go empty - https://phabricator.wikimedia.org/T221289 (10JTannerWMF) @matmarex will look at this [15:18:37] (03CR) 10DLynch: [C: 03+2] Update VE core submodule to master (7cd15cfe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [15:20:46] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10JTannerWMF) [15:20:59] 10VisualEditor: [Epic] Build an audience for Q4 work - https://phabricator.wikimedia.org/T221340 (10ppelberg) [15:21:52] 10VisualEditor, 10Browser-Support-Internet-Explorer: Visualeditor/Parsoid in Internet Explorer scrambles Texts when typing into new table cells - https://phabricator.wikimedia.org/T220984 (10matmarex) [15:22:50] 10VisualEditor, 10Browser-Support-Internet-Explorer: Visualeditor in Internet Explorer scrambles Texts when typing into new table cells - https://phabricator.wikimedia.org/T220984 (10matmarex) [15:28:18] 10VisualEditor, 10Browser-Support-Internet-Explorer: Visualeditor in Internet Explorer scrambles Texts when typing into new table cells - https://phabricator.wikimedia.org/T220984 (10JTannerWMF) We will investigate this next Sprint and put the solution here if it isn't a quick fix. If it is something that will... [15:29:08] (03PS1) 10Dmaza: Remove block notice tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505795 (https://phabricator.wikimedia.org/T193768) [15:31:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (7cd15cfe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [15:32:41] (03PS2) 10Dmaza: Remove block notice tracking [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505795 (https://phabricator.wikimedia.org/T214214) [15:33:01] (03CR) 10jenkins-bot: Update VE core submodule to master (7cd15cfe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/475962 (https://phabricator.wikimedia.org/T76426) (owner: 10Bartosz Dziewoński) [15:34:23] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10JTa... [15:45:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Pasting problems in the mobile visual editor - https://phabricator.wikimedia.org/T221039 (10JTannerWMF) We will investigate this [15:52:09] 10VisualEditor: Gboard voice typing not working in mobile VE - https://phabricator.wikimedia.org/T220868 (10JTannerWMF) When we evaluate work for our target wikis we will return to this. [15:52:42] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10Esanders) Template:Chembox has block formatting in TemplateData, so this shouldn't be converting to inline. Tagging Parsoid. [15:55:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Refreshing a source page in the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled) - https://phabricator.wikimedia.org/T190765 (10JTannerWMF) We will revisit this task as @matmarex mentioned above. [15:56:37] 10VisualEditor, 10MobileFrontend: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823 (10JTannerWMF) Hey @Trizek-WMF we just need you to respond to what you believe should be happening. [15:56:44] 10VisualEditor: [Epic] Build an audience for Q4 work - https://phabricator.wikimedia.org/T221340 (10ppelberg) [15:57:03] 10VisualEditor: VE mobile default: community outreach - https://phabricator.wikimedia.org/T221200 (10ppelberg) [15:57:57] 10VisualEditor: VE mobile default: community outreach - https://phabricator.wikimedia.org/T221200 (10ppelberg) [15:59:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: EPIC: Fix selection issues on mobile - https://phabricator.wikimedia.org/T209505 (10ppelberg) [15:59:32] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: Selection experiment: Deactivate selection on scroll past viewport - https://phabricator.wikimedia.org/T220634 (10ppelberg) [16:01:14] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: When I meta-click on a template, let me open the Template: page in another tab - https://phabricator.wikimedia.org/T221029 (10matmarex) I agree with Ed that we shouldn't make the template itself a link. But we could put a link to the template description page... [16:10:13] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 10 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10hashar) >>! In T199939#5130664, @Jdlrobson wrote: > In ht... [16:11:45] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 10 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10hashar) Adding Minerva is T202030 [16:13:12] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10matmarex) Looks like Chembox templatedata is actually messed up. If you look closely at https://en.wikipedia.org/wiki/Template:Chembox/doc, the TOC has t... [16:25:46] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10matmarex) I made this edit: https://en.wikipedia.org/w/index.php?title=Template:Cascite/doc&diff=prev&oldid=893794177&diffmode=source and purged https://... [16:32:08] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Pasting tables from Google sheets pollutes the document with data-sheets- attributes - https://phabricator.wikimedia.org/T221668 (10Esanders) [16:45:16] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Error `Cannot read property 'getScrollContainer' of null` when saving on mobile - https://phabricator.wikimedia.org/T221669 (10DLynch) [16:52:13] (03PS1) 10DLynch: toggleMobileGlobalOverlay: check whether the target exists before using it [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505822 (https://phabricator.wikimedia.org/T221669) [16:59:33] (03CR) 10DLynch: "Alternately, could just return early if ve.init.target isn't there. But there are some lingering body classes, so it seems better to clean" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505822 (https://phabricator.wikimedia.org/T221669) (owner: 10DLynch) [17:29:51] 10Citoid, 10CX-cxserver, 10Graphoid, 10Mathoid, and 10 others: Make services swagger specs standard compliant - https://phabricator.wikimedia.org/T218217 (10Mholloway) @MSantos I think we do want to go up to OpenAPI 3; that's actually in progress right now for RESTBase and friends (T218218). [17:37:31] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: When I meta-click on a template, let me open the Template: page in another tab - https://phabricator.wikimedia.org/T221029 (10Whatamidoing-WMF) Putting a link in the context menu would probably be an adequate alternative. It feels more discoverable, too. [17:39:42] 10VisualEditor: [Epic] Build an audience for Q4 work - https://phabricator.wikimedia.org/T221340 (10Whatamidoing-WMF) We also need to sort out the target/focus wikis, to have a really good plan for what to do. Ideally, we'll be reaching out mostly to active mobile users on those wikis. [17:44:00] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Trappist_the_monk) Are you saying that what editors see while editing, is a facsimile and not a true preview of the article? It would seem so. When ch... [17:54:51] 10Editing-team, 10Graphs, 10Regression: 404 error for some geoshape maps - https://phabricator.wikimedia.org/T220469 (10Sunpriat2) [17:55:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Some third-party wikis allow hotlinked images, but these aren't shown in preview - https://phabricator.wikimedia.org/T221684 (10Whatamidoing-WMF) [18:03:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Some third-party wikis allow hotlinked images, but these aren't shown in preview - https://phabricator.wikimedia.org/T221684 (10Esanders) Sounds like a Parsoid issue. [18:04:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: #REDIRECT[[Link]] is invisible when Previewing - https://phabricator.wikimedia.org/T221686 (10Whatamidoing-WMF) [18:09:16] (03PS1) 10Bartosz Dziewoński: ve.ui.DebugBar: Fix Filibuster button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505852 [18:10:18] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.DebugBar: Fix Filibuster button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505852 (owner: 10Bartosz Dziewoński) [18:11:07] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10User-notice: Add ability to cite books by scanning their ISBN barcode in mobile web - https://phabricator.wikimedia.org/T216775 (10Mvolz) >>! In T216775#5093447, @Esanders wrote: > @Mvolz I've pushed this change to the test... [18:13:42] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Backlog (Later), 10Services (designing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10Mholloway) No blockers from Readers Engineering to deprecating/removi... [18:13:46] (03CR) 10Bartosz Dziewoński: [C: 03+2] "I couldn't reproduce the error, but this seems reasonable." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505822 (https://phabricator.wikimedia.org/T221669) (owner: 10DLynch) [18:15:14] (03Merged) 10jenkins-bot: toggleMobileGlobalOverlay: check whether the target exists before using it [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505822 (https://phabricator.wikimedia.org/T221669) (owner: 10DLynch) [18:16:36] (03CR) 10jenkins-bot: toggleMobileGlobalOverlay: check whether the target exists before using it [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505822 (https://phabricator.wikimedia.org/T221669) (owner: 10DLynch) [18:20:47] (03PS2) 10Bartosz Dziewoński: ve.ui.DebugBar: Fix Filibuster button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505852 [18:29:53] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Esanders) Yes, VE edits a representation of the document that is is not fully re-rendered by the parser until it is saved. [18:34:42] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): [Regression pre-wmf.2] Switching back from the diff panel to the save form on mobile VE makes the form go empty - https://phabricator.wikimedia.org/T221289 (10matmarex) > 1. Open mobile VE > 2. Make an Edit and tap on "Publish" > 3. Tap on "Revi... [18:34:56] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): [Regression pre-wmf.2] Switching back from the diff panel to the save form on mobile VE makes the form go empty - https://phabricator.wikimedia.org/T221289 (10matmarex) a:03matmarex [18:34:56] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505860 (https://phabricator.wikimedia.org/T221289) [18:41:00] 10Citoid, 10VisualEditor: mw.title.getCurrentTitle():getContent() is undef when creating new page in VE preview - https://phabricator.wikimedia.org/T221625 (10Trappist_the_monk) thank you. [18:41:10] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Some third-party wikis allow hotlinked images, but these aren't shown in preview - https://phabricator.wikimedia.org/T221684 (10cscott) Dup of {T127884}. [18:44:56] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Pasting tables from Google sheets pollutes the document with data-sheets- attributes - https://phabricator.wikimedia.org/T221668 (10Esanders) I think this is a regression caused by out paste rules refactor: https://gerrit.wikimedia.org/r/#/c/me... [18:49:55] (03PS1) 10Esanders: Restore external paste sanitization of DOM elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505865 (https://phabricator.wikimedia.org/T221668) [18:51:19] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 10Patch-For-Review: Pasting tables from Google sheets pollutes the document with data-sheets- attributes - https://phabricator.wikimedia.org/T221668 (10Esanders) p:05Triage→03Unbreak! This is potentially polluting the wikis with lots of u... [18:51:40] (03CR) 10Esanders: "This should be backported." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505865 (https://phabricator.wikimedia.org/T221668) (owner: 10Esanders) [19:09:23] (03CR) 10Bartosz Dziewoński: [C: 03+2] Restore external paste sanitization of DOM elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505865 (https://phabricator.wikimedia.org/T221668) (owner: 10Esanders) [19:32:31] 10VisualEditor, 10Editing Design: [EPIC] Toolbar improvements - https://phabricator.wikimedia.org/T211255 (10matmarex) [19:32:49] 10VisualEditor: Consider moving the blockquote tool to another section of the toolbar - https://phabricator.wikimedia.org/T221692 (10matmarex) [19:33:16] 10VisualEditor: Consider moving the blockquote tool to another section of the toolbar - https://phabricator.wikimedia.org/T221692 (10matmarex) I believe we decided to consider this as part of (or after) the toolbar work from T211255, but if that's not the case, please move this elsewhere (@iamjessklein). [19:34:21] 10VisualEditor-EditingTools, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) >>! In T76426#5086359, @ma... [19:45:27] (03PS1) 10Aaron Schulz: Use PageEditStash services instead of static methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505891 [19:50:44] 10VisualEditor-EditingTools, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are - https://phabricator.wikimedia.org/T76426 (10matmarex) QA note: please also check... [19:51:25] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 4 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) [19:52:02] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Backlog (Later), 10Services (designing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10Pchelolo) Seems like we have a consensus on the backend. @Esanders co... [20:00:44] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10DePiep) Preventing multiple templatedata sections being transcluded is a good solution (good catch). I have adjusted the documentation set to prevent thi... [20:02:13] 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 10Patch-For-Review, 10VisualEditor (Current work): Pasting tables from Google sheets pollutes the document with data-sheets- attributes - https://phabricator.wikimedia.org/T221668 (10Esanders) [20:48:01] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/505932 (owner: 10L10n-bot) [20:48:28] 10VisualEditor: [Regression pre-wmf.2] The context menu for categories is appearing transparent - https://phabricator.wikimedia.org/T221705 (10Ryasmeen) [20:56:51] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive. Syntax error fixed on translatewiki.net" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/505932 (owner: 10L10n-bot) [21:01:50] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: When I meta-click on a template, let me open the Template: page in another tab - https://phabricator.wikimedia.org/T221029 (10Esanders) This is less trivial to implement because templates can be generated from multiple parts (e.g. {{start table}}, ...) [21:02:43] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Fix preview of redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506002 (https://phabricator.wikimedia.org/T221686) [21:07:59] 10VisualEditor: HTML of edit page downloaded twice - https://phabricator.wikimedia.org/T221600 (10Esanders) Interesting. I think I used #null in that library to avoid a 404 request to /null, thinking that #null would not trigger another network request. [21:17:28] 10VisualEditor: [Regression pre-wmf.2] The context menu for categories is appearing transparent - https://phabricator.wikimedia.org/T221705 (10matmarex) Curiously, this is caused by the `filter: drop-shadow(0 2px 1px rgba(0,0,0,0.3));` rule added in OOUI per T220248. [21:22:16] 10VisualEditor: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active - https://phabricator.wikimedia.org/T221716 (10matmarex) [21:27:49] (03CR) 10Jforrester: [C: 03+1] Restore re-activation hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505633 (https://phabricator.wikimedia.org/T221291) (owner: 10Esanders) [21:32:11] 10VisualEditor: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active - https://phabricator.wikimedia.org/T221716 (10matmarex) Bisect blames {24cb70bae03fef8399664d03149322d54b940968} → {4e32f62c373f87978e25e11655e98f8165f5d52b} That commit removed a bunch of code ad... [21:32:26] (03CR) 10Bartosz Dziewoński: "Are the changes in ve.ui.AnnotationInspector intentional? They look unrelated to the rest and caused T221716." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/502895 (https://phabricator.wikimedia.org/T220633) (owner: 10Esanders) [21:52:01] (03PS1) 10Esanders: Update RangeFix 0.2.6 -> 0.2.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506011 (https://phabricator.wikimedia.org/T221600) [21:53:18] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl+Space/Opt+Space to insert a non-breaking space (NBSP) - https://phabricator.wikimedia.org/T53045 (10Frigory) @Nnemo: +1 for Ctrl-Shift-Space which also works on LibreOffice. >>! In T53045#1244827, @Nnemo wrote: > # « The safe places for french... [21:55:00] (03CR) 10Jforrester: [C: 03+2] Update RangeFix 0.2.6 -> 0.2.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506011 (https://phabricator.wikimedia.org/T221600) (owner: 10Esanders) [21:56:51] (03Merged) 10jenkins-bot: Update RangeFix 0.2.6 -> 0.2.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506011 (https://phabricator.wikimedia.org/T221600) (owner: 10Esanders) [21:58:33] (03CR) 10jenkins-bot: Update RangeFix 0.2.6 -> 0.2.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506011 (https://phabricator.wikimedia.org/T221600) (owner: 10Esanders) [21:59:03] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10matmarex) [21:59:05] 10VisualEditor: [Epic] Make VE the default mobile editor on 3 wikis - https://phabricator.wikimedia.org/T221185 (10matmarex) [21:59:08] 10VisualEditor, 10MobileFrontend, 10SpamBlacklist: Spam links trigger unknown error on mobile - https://phabricator.wikimedia.org/T167078 (10matmarex) [22:01:58] (03CR) 10Esanders: [C: 03+2] "Recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505865 (https://phabricator.wikimedia.org/T221668) (owner: 10Esanders) [22:03:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] Restore re-activation hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505633 (https://phabricator.wikimedia.org/T221291) (owner: 10Esanders) [22:03:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/505932 (owner: 10L10n-bot) [22:04:46] (03Merged) 10jenkins-bot: Restore re-activation hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505633 (https://phabricator.wikimedia.org/T221291) (owner: 10Esanders) [22:06:10] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl+Space/Opt+Space to insert a non-breaking space (NBSP) - https://phabricator.wikimedia.org/T53045 (10Frigory) I have a related remark. Even though the editor does not provide itself a keyboard shortcut to insert no-break spaces, your keyboard la... [22:06:14] (03CR) 10jenkins-bot: Restore re-activation hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505633 (https://phabricator.wikimedia.org/T221291) (owner: 10Esanders) [22:10:57] 10VisualEditor, 10Browser-Support-Apple-Safari: iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard - https://phabricator.wikimedia.org/T221723 (10matmarex) [22:12:37] 10VisualEditor, 10Browser-Support-Apple-Safari: iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard - https://phabricator.wikimedia.org/T221723 (10matmarex) This is because of the context menu appearing and scrolling the document: {T96289}. Note that the issue is not current... [22:12:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) [22:12:54] 10VisualEditor, 10Browser-Support-Apple-Safari: iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard - https://phabricator.wikimedia.org/T221723 (10matmarex) [22:13:24] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10VisualEditor (Current work): Mobile visual editor scrolls to the top of the page after adding a link in iOS Safari - https://phabricator.wikimedia.org/T218635 (10matmarex) I filed... [22:37:20] (03Merged) 10jenkins-bot: Restore external paste sanitization of DOM elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505865 (https://phabricator.wikimedia.org/T221668) (owner: 10Esanders) [22:37:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/505985 (owner: 10L10n-bot) [22:39:06] (03CR) 10jenkins-bot: Restore external paste sanitization of DOM elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505865 (https://phabricator.wikimedia.org/T221668) (owner: 10Esanders) [22:39:56] 10VisualEditor: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active - https://phabricator.wikimedia.org/T221716 (10DLynch) Heh. Amusingly (?) I remember explicitly testing that post-link stuff, and completely missing that the context behavior had changed because I w... [22:40:19] (03PS1) 10Jforrester: Restore external paste sanitization of DOM elements [extensions/VisualEditor] (wmf/1.34.0-wmf.1) - 10https://gerrit.wikimedia.org/r/506022 (https://phabricator.wikimedia.org/T221668) [22:40:35] (03PS1) 10Jforrester: Update VE core submodule to master (ac38ec869) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506023 (https://phabricator.wikimedia.org/T221291) [22:57:56] (03CR) 10Jforrester: [C: 03+2] ve.ui.DebugBar: Fix Filibuster button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505852 (owner: 10Bartosz Dziewoński) [22:59:18] (03Merged) 10jenkins-bot: ve.ui.DebugBar: Fix Filibuster button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505852 (owner: 10Bartosz Dziewoński) [22:59:44] (03CR) 10Jforrester: [C: 03+2] Restore external paste sanitization of DOM elements [extensions/VisualEditor] (wmf/1.34.0-wmf.1) - 10https://gerrit.wikimedia.org/r/506022 (https://phabricator.wikimedia.org/T221668) (owner: 10Jforrester) [23:00:46] (03CR) 10jenkins-bot: ve.ui.DebugBar: Fix Filibuster button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505852 (owner: 10Bartosz Dziewoński) [23:06:21] (03CR) 10Jforrester: [C: 03+1] (De)activate table selection on context menu toggle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/505631 (https://phabricator.wikimedia.org/T221286) (owner: 10Esanders) [23:15:49] (03Merged) 10jenkins-bot: Restore external paste sanitization of DOM elements [extensions/VisualEditor] (wmf/1.34.0-wmf.1) - 10https://gerrit.wikimedia.org/r/506022 (https://phabricator.wikimedia.org/T221668) (owner: 10Jforrester) [23:22:13] 10VisualEditor: [Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221247 (10Neil_P._Quinn_WMF) [23:23:55] 10VisualEditor: Edit cards: instrument existing "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221306 (10Neil_P._Quinn_WMF) [23:23:58] 10VisualEditor: Edit cards: instrument revised "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221305 (10Neil_P._Quinn_WMF) [23:24:00] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10Neil_P._Quinn_WMF) [23:24:02] 10VisualEditor: Edit card: confirm instrumentation for existing VE linking flow - https://phabricator.wikimedia.org/T221254 (10Neil_P._Quinn_WMF) [23:24:04] 10VisualEditor: Edit card: implement workflow instrumentation - https://phabricator.wikimedia.org/T221252 (10Neil_P._Quinn_WMF) [23:24:06] 10VisualEditor: Edit card: get legal approval for workflow instrumentation - https://phabricator.wikimedia.org/T221250 (10Neil_P._Quinn_WMF) [23:24:08] 10VisualEditor: Edit cards: instrument revised "adding/modifying links" flow - https://phabricator.wikimedia.org/T221249 (10Neil_P._Quinn_WMF) [23:24:10] 10VisualEditor: Edit cards: create measurement specifications and experiment plan - https://phabricator.wikimedia.org/T221246 (10Neil_P._Quinn_WMF) [23:24:42] 10VisualEditor: Edit cards: instrument existing "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221306 (10Neil_P._Quinn_WMF) [23:24:44] 10VisualEditor: Edit cards: instrument revised "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221305 (10Neil_P._Quinn_WMF) [23:24:46] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10Neil_P._Quinn_WMF) [23:24:48] 10VisualEditor: Edit card: confirm instrumentation for existing VE linking flow - https://phabricator.wikimedia.org/T221254 (10Neil_P._Quinn_WMF) [23:24:50] 10VisualEditor: Edit card: implement workflow instrumentation - https://phabricator.wikimedia.org/T221252 (10Neil_P._Quinn_WMF) [23:24:53] 10VisualEditor: Edit card: get legal approval for workflow instrumentation - https://phabricator.wikimedia.org/T221250 (10Neil_P._Quinn_WMF) [23:24:56] 10VisualEditor: Edit cards: instrument revised "adding/modifying links" flow - https://phabricator.wikimedia.org/T221249 (10Neil_P._Quinn_WMF) [23:24:58] 10VisualEditor: Edit cards: create measurement specifications and experiment plan - https://phabricator.wikimedia.org/T221246 (10Neil_P._Quinn_WMF) [23:25:58] 10VisualEditor: Edit cards: create measurement specifications and experiment plan - https://phabricator.wikimedia.org/T221246 (10Neil_P._Quinn_WMF) [23:26:03] 10VisualEditor: [Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221247 (10Neil_P._Quinn_WMF)