[00:11:23] 10VisualEditor: [Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221247 (10ppelberg) [00:24:24] 10VisualEditor: [Epic] Make VE the default mobile editor on 3 wikis - https://phabricator.wikimedia.org/T221185 (10ppelberg) [00:29:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 3 others: [Regression pre-wmf.2] The context menu for categories is appearing transparent - https://phabricator.wikimedia.org/T221705 (10Ryasmeen) [00:53:20] 10VisualEditor: [Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221247 (10ppelberg) [00:56:21] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10ppelberg) In order to ensure we have enough [1] data to compare the revised, "structured," edit workflow to the existing edit workflow, instrumentation of the existing needs to be live and... [01:07:54] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10ppelberg) [01:08:13] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10ppelberg) [01:10:59] 10VisualEditor: Edit cards: instrument existing "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221306 (10ppelberg) In order to ensure we have "enough data" [1] to compare the revised "structured" edit workflow to the existing edit workflow, instrumentation of the existing needs to be live... [01:11:33] 10VisualEditor: Edit cards: instrument existing "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221306 (10ppelberg) [01:39:31] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, and 2 others: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've... - https://phabricator.wikimedia.org/T50274 [02:45:22] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 4 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) Stashing now uses the simple, binary key-value bucket. Next step is to actually switch the main content bucket(s). [05:08:52] 10Cite, 10VisualEditor, 10ContentTranslation, 10Language-Team (Language-2019-April-June): References in the source article opened with a generic dialog instead of specific form - https://phabricator.wikimedia.org/T221241 (10santhosh) [05:33:52] 10VisualEditor: Communicate Editing Team's FY18-19 progress - https://phabricator.wikimedia.org/T221820 (10ppelberg) [07:17:20] 10Cite, 10VisualEditor, 10ContentTranslation, 10Language-Team (Language-2019-April-June): References in the source article opened with a generic dialog instead of specific form - https://phabricator.wikimedia.org/T221241 (10Pginer-WMF) >>! In T221241#5136581, @santhosh wrote: > @Esanders Instead of specifi... [07:18:44] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Doing), 10Services (doing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10mobrovac) Thank you for the info, @Esanders . I propose we deprecate and r... [08:03:29] 10VisualEditor-ContentEditable, 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), and 2 others: CX2: Spellcheck and IME appearing for source sections - https://phabricator.wikimedia.org/T217740 (10Pginer-WMF) 05Open→03Resolved [09:33:59] (03PS6) 10Mvolz: Use single Citoid tool even when 'automatic' not configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/501062 (https://phabricator.wikimedia.org/T98618) (owner: 10Esanders) [09:34:53] (03PS7) 10Mvolz: Use single Citoid tool even when 'automatic' not configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/501062 (https://phabricator.wikimedia.org/T98618) (owner: 10Esanders) [09:40:10] (03CR) 10Mvolz: [C: 03+2] Use single Citoid tool even when 'automatic' not configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/501062 (https://phabricator.wikimedia.org/T98618) (owner: 10Esanders) [09:45:05] (03PS5) 10Mvolz: [WIP] Remove dependancy on VE, add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) [09:47:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Remove dependancy on VE, add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) (owner: 10Mvolz) [09:47:58] (03Merged) 10jenkins-bot: Use single Citoid tool even when 'automatic' not configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/501062 (https://phabricator.wikimedia.org/T98618) (owner: 10Esanders) [09:50:38] (03CR) 10jenkins-bot: Use single Citoid tool even when 'automatic' not configured [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/501062 (https://phabricator.wikimedia.org/T98618) (owner: 10Esanders) [12:00:57] (03PS1) 10Esanders: CitoidTool: Remove label property [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/506394 [12:01:18] (03PS5) 10Esanders: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) [12:42:03] (03CR) 10Jforrester: [C: 03+2] CitoidTool: Remove label property [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/506394 (owner: 10Esanders) [12:44:37] (03CR) 10Jforrester: [C: 03+1] Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [12:51:16] 10VisualEditor: [Design EPIC]: Toolbar improvements - https://phabricator.wikimedia.org/T210632 (10iamjessklein) [12:53:02] (03Merged) 10jenkins-bot: CitoidTool: Remove label property [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/506394 (owner: 10Esanders) [12:54:11] (03CR) 10jenkins-bot: CitoidTool: Remove label property [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/506394 (owner: 10Esanders) [13:01:35] (03PS6) 10Esanders: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) [13:08:46] (03CR) 10jerkins-bot: [V: 04-1] Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [13:35:34] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10Esanders) a:03Esanders [13:56:08] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Show anon editor warning in VE - https://phabricator.wikimedia.org/T221854 (10Esanders) [13:58:11] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Don't show anon editor warning when switching - https://phabricator.wikimedia.org/T221855 (10Esanders) [14:32:08] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Show block notice in mobile VE - https://phabricator.wikimedia.org/T221400 (10Esanders) [14:32:21] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show anon editor warning in mobile VE - https://phabricator.wikimedia.org/T221854 (10Esanders) [14:32:32] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Don't show anon editor warning after switching on Mobile - https://phabricator.wikimedia.org/T221855 (10Esanders) [15:24:58] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notice in mobile VE - https://phabricator.wikimedia.org/T221400 (10Esanders) a:03Esanders [15:46:15] 10VisualEditor: Publish rationale on MediaWiki - https://phabricator.wikimedia.org/T221867 (10ppelberg) [15:46:28] 10VisualEditor: [Epic] Make VE the default mobile editor on 3 wikis - https://phabricator.wikimedia.org/T221185 (10ppelberg) [15:46:30] 10VisualEditor: Publish rationale on MediaWiki - https://phabricator.wikimedia.org/T221867 (10ppelberg) [15:48:42] 10VisualEditor: Create project page on MediaWiki - https://phabricator.wikimedia.org/T221867 (10ppelberg) [15:49:46] 10VisualEditor: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active - https://phabricator.wikimedia.org/T221716 (10Esanders) I don't think that was a rebase error, but I was specifically testing that case, so odd that I broke it. Will have a look.. [15:51:24] 10VisualEditor: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active - https://phabricator.wikimedia.org/T221716 (10Esanders) Ok, the code I put in `ve.ce.Surface.prototype.activate` covered the case where you edit a link (which is what I tested), but when you insert... [16:00:37] 10VisualEditor: [Epic] Create Editing Team's FY18-19 EOY report - https://phabricator.wikimedia.org/T221820 (10ppelberg) [16:53:17] 10VisualEditor: [Epic] Build an audience for Q4 work - https://phabricator.wikimedia.org/T221340 (10ppelberg) >>! In T221340#5131857, @Whatamidoing-WMF wrote: > We also need to sort out the target/focus wikis... Definitely, @whatamidoing-WMF. The thinking around the target/focus wikis for this quarter is happen... [17:35:20] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Doing), 10Services (doing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10bearND) [17:35:36] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Doing), 10Services (doing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10bearND) +1 to "DOM subtree editing" from me as well. [17:58:45] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [18:36:54] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [19:09:08] (03PS1) 10Bartosz Dziewoński: DesktopArticleTarget: Remove changing document opacity when switching to WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506529 [19:10:09] (03CR) 10Bartosz Dziewoński: "I split off removing the opacity stuff to a separate commit https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/506529 , " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [19:10:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Split off from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/500982" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506529 (owner: 10Bartosz Dziewoński) [19:11:28] (03PS4) 10Bartosz Dziewoński: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [19:11:45] (03CR) 10jerkins-bot: [V: 04-1] Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [19:11:57] (03PS5) 10Bartosz Dziewoński: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [19:12:22] (03CR) 10jerkins-bot: [V: 04-1] Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [19:25:00] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Seems good to go after the dependency is merged, with the change I proposed there. Looks sane and everything works fine as far as I can te" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [19:25:34] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: Remove changing document opacity when switching to WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506529 (owner: 10Bartosz Dziewoński) [19:39:35] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): [Regression pre-wmf.2] Switching back from the diff panel to the save form on mobile VE makes the form go empty - https://phabricator.wikimedia.org/T221289 (10Ryasmeen) @matmarex:... [19:47:49] 10Editing-team, 10Contributors-Team, 10MediaWiki-API, 10MediaWiki-Special-pages, 10Wikimedia-production-error: MovePage::move contention on cebwiki - https://phabricator.wikimedia.org/T221595 (10Anomie) I don't see anything in the API that seems like it would result in deadlocks here, so I'm going to mov... [20:05:21] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10Whatamidoing-WMF) [20:25:43] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10matmarex) I suspect I broke this by fixing T219457 – if you had new wikitext editor enabled, such links would open the visual editor's HTML in the wikitext editor, which was crazy. If the visual... [20:37:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign submit dialog / diff view to show changes alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10Esanders) Well, we have visual diffs now... [20:39:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10Esanders) [20:52:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10Esanders) Something along these lines: {F28776015,width=400} [20:56:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] Allow switching from mobile visual to mobile source mode with data (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [20:56:16] (03PS6) 10Bartosz Dziewoński: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [20:56:34] (03CR) 10Bartosz Dziewoński: [C: 03+2] Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [20:59:01] (03Merged) 10jenkins-bot: DesktopArticleTarget: Remove changing document opacity when switching to WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506529 (owner: 10Bartosz Dziewoński) [21:00:52] (03CR) 10jenkins-bot: DesktopArticleTarget: Remove changing document opacity when switching to WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506529 (owner: 10Bartosz Dziewoński) [21:19:52] 10VisualEditor: [Regression pre-wmf.2] Uncaught TypeError: selection.containsCell is not a function appears when clicking on a cell after a delete row/column operation - https://phabricator.wikimedia.org/T221901 (10Ryasmeen) [21:26:02] (03Merged) 10jenkins-bot: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [21:27:39] (03CR) 10jenkins-bot: Allow switching from mobile visual to mobile source mode with data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500982 (https://phabricator.wikimedia.org/T128422) (owner: 10Esanders) [21:40:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-VisualDiffs: Visual diff showing too much context in section editing mode - https://phabricator.wikimedia.org/T221903 (10Esanders) [21:41:11] (03PS1) 10Esanders: ve.dm.VisualDiff: Allow sub-trees to be diffed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506555 [21:43:47] (03PS2) 10Esanders: ve.dm.VisualDiff: Allow sub-trees to be diffed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506555 (https://phabricator.wikimedia.org/T221903) [21:44:10] (03PS1) 10Esanders: Only diff
contents in section editing mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506556 (https://phabricator.wikimedia.org/T221903) [21:45:15] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Visual diff showing too much context in section editing mode - https://phabricator.wikimedia.org/T221903 (10Esanders) a:03Esanders [21:49:57] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Visual diff showing too much context in section editing mode - https://phabricator.wikimedia.org/T221903 (10Esanders) [21:59:26] (03PS1) 10Esanders: Check selection is a TableSelection before looking for cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506560 (https://phabricator.wikimedia.org/T221901) [22:02:38] (03PS1) 10Esanders: Demo: Set nullSelectionOnBlur when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506562 [22:16:12] (03PS5) 10Esanders: Section switch from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) [22:16:14] (03PS4) 10Esanders: Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 [22:16:16] (03PS3) 10Esanders: WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) [22:18:40] (03CR) 10jerkins-bot: [V: 04-1] Section switch from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [22:18:46] (03CR) 10jerkins-bot: [V: 04-1] Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (owner: 10Esanders) [22:18:52] (03CR) 10jerkins-bot: [V: 04-1] WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [22:27:39] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10Morten_Haan) Some wikis have talk pages in their project namespaces therefore is wouldn't be a good idea to enable the visual editor in the whole Wikipedia namespace. [22:29:29] 10Editing-team, 10Contributors-Team, 10MediaWiki-API, 10MediaWiki-Special-pages, 10Wikimedia-production-error: MovePage::move contention on cebwiki - https://phabricator.wikimedia.org/T221595 (10jcrespo) I suggest to close this rather than keep it around if someone already checkit. No reason to keep a ba... [22:33:24] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10Esanders) [22:37:35] 10VisualEditor: Deploy visual section editing on Desktop - https://phabricator.wikimedia.org/T221908 (10Esanders) [23:03:09] (03CR) 10Bartosz Dziewoński: "This sounds scary but vague – what exactly does it fix?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (owner: 10Esanders) [23:03:56] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10PerfektesChaos) Oh, yeah, there are thousands of talks; almost 5000 daily candidates for deletion, and village pumps and various help desks and some 10.000 archives of talks. A bit sophisticated... [23:04:36] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, 10MobileFrontend, and 4 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10matmarex) The patches merged so far implement switching from visual to wikitext, but not in t...