[01:21:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10MediaWiki-Categories, 10Design: Visual diff doesn't show changes to categories - https://phabricator.wikimedia.org/T161290 (10Whatamidoing-WMF) [07:15:42] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10Luke081515) I would propose that a systemmessage in MediaWiki Namespace gets created, where admins can list pages, where users are allowed to use VE, even if the namespace is "blacklisted", so kin... [07:36:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Trying to use `veaction=edit` on a talk page loads the source editor and puts the page's HTML in the edit window - https://phabricator.wikimedia.org/T176099 (10Schnark) [07:36:25] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10Schnark) [07:39:31] 10VisualEditor: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons (or other strange behaviour) - https://phabricator.wikimedia.org/T176125 (10Schnark) The originally reported issue isn't really a duplicate of T219457, but after merging T1994... [07:39:42] 10VisualEditor: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons (or other strange behaviour) - https://phabricator.wikimedia.org/T176125 (10Schnark) [07:39:50] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10Schnark) [08:14:39] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10PerfektesChaos) Blacklisting pageids could be a hard job, since there are more than 10.000 pages in talk structure on German Wikipedia project namespace. Whitelisting by individual decision per W... [11:01:06] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10Gestumblindi) >>! In T221892#5138827, @matmarex wrote: > I suspect I broke this by fixing T219457 – if you had new wikitext editor enabled, such links would open the visual editor's HTML in the wi... [12:28:45] (03PS5) 10Esanders: Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) [12:32:08] (03CR) 10jerkins-bot: [V: 04-1] Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) (owner: 10Esanders) [13:43:05] (03PS1) 10Esanders: Remove focus code from LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506669 [13:43:06] (03PS1) 10Esanders: WindowAction: Don't re-activate surface until teardown complete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506670 [13:43:08] (03PS1) 10Esanders: Update activeAnnotations when applying new annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506671 (https://phabricator.wikimedia.org/T221716) [15:26:42] (03CR) 10Esanders: [C: 04-1] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński) [15:34:14] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove tests/phan/issue from .gitignore [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/505437 (owner: 10Umherirrender) [15:37:28] (03CR) 10Esanders: "`this.section = null` takes us back to full document editing when going from VE to wikitext (which is necessary), but we only need to do t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (owner: 10Esanders) [15:59:03] (03Merged) 10jenkins-bot: Remove tests/phan/issue from .gitignore [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/505437 (owner: 10Umherirrender) [16:05:00] (03PS5) 10Esanders: Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 [16:05:02] (03PS4) 10Esanders: WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) [16:05:04] (03CR) 10Esanders: "Actually, this is for VE -> 2017WTE (section)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (owner: 10Esanders) [16:05:28] (03CR) 10Esanders: "PS5 fixes this case for the old wikitext editor too, as well as some other cleanups." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (owner: 10Esanders) [16:07:26] (03CR) 10jerkins-bot: [V: 04-1] Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (owner: 10Esanders) [16:07:28] (03CR) 10jerkins-bot: [V: 04-1] WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [18:01:42] 10VisualEditor: Switching from a VE section edit to wikitext goes to full document, even if no changes have been made - https://phabricator.wikimedia.org/T221981 (10Esanders) [18:02:13] (03PS6) 10Esanders: Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) [18:02:15] (03PS5) 10Esanders: WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) [18:03:43] 10VisualEditor, 10Patch-For-Review: Switching from a VE section edit to wikitext goes to full document, even if no changes have been made - https://phabricator.wikimedia.org/T221981 (10Esanders) [18:07:57] (03CR) 10jerkins-bot: [V: 04-1] WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [18:18:25] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10matmarex) Thank... [18:20:00] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML - https://phabricator.wikimedia.org/T219457 (10matmarex) [18:36:12] 10VisualEditor: &veaction=edit no longer overrides namespace settings - https://phabricator.wikimedia.org/T221892 (10matmarex) I don't want us to end up implementing a complex system of whitelists and blacklists, also because it would be a maintenance burden for us, but mostly because it would make on-wiki confi... [18:39:37] 10VisualEditor: &veaction=edit no longer overrides namespace settings (can't edit global sandbox page using VE) - https://phabricator.wikimedia.org/T221892 (10matmarex) [18:42:40] (03CR) 10Bartosz Dziewoński: WindowAction: Don't re-activate surface until teardown complete (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506670 (owner: 10Esanders) [18:46:39] (03CR) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński) [18:54:27] (03PS6) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) [18:54:39] (03PS7) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) [18:55:56] (03CR) 10Bartosz Dziewoński: "(The IDs were indeed added in I3330f3ccc8226605f44745befc34dcfcc7c474d8)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński) [19:15:03] (03PS3) 10D3r1ck01: Replace usage of deprecated ConfigFactory::getDefaultInstance() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 [20:28:01] 10VisualEditor, 10Accessibility: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10Whatamidoing-WMF) [20:33:51] 10VisualEditor, 10Editing Design: Confusing re-use of 'quotes' icon in Find & Replace dialog - https://phabricator.wikimedia.org/T221997 (10Volker_E) [20:34:29] (03CR) 10Esanders: [C: 03+2] ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński) [20:40:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/506768 (owner: 10L10n-bot) [20:48:49] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński) [21:17:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506824 (owner: 10L10n-bot) [21:19:07] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/499321 (https://phabricator.wikimedia.org/T208102) (owner: 10Bartosz Dziewoński)