[01:00:05] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10Shenme) Would the above attempted fix have been implemented over on Wikipedia yet? I note this edit today (Apr 29) https://en.wikipedia.org/w/index.php?t... [01:11:36] (03CR) 10Jforrester: [C: 03+2] Don't allow merging cells that aren't editable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506907 (https://phabricator.wikimedia.org/T222039) (owner: 10Esanders) [01:13:02] (03Merged) 10jenkins-bot: Don't allow merging cells that aren't editable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506907 (https://phabricator.wikimedia.org/T222039) (owner: 10Esanders) [01:14:20] (03CR) 10jenkins-bot: Don't allow merging cells that aren't editable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506907 (https://phabricator.wikimedia.org/T222039) (owner: 10Esanders) [10:11:36] 10VisualEditor, 10Editing Design: Confusing re-use of 'quotes' icon in Find & Replace dialog - https://phabricator.wikimedia.org/T221997 (10Schnark) Via Google Image search I found: * [[https://www.maxqda.com/help-max18/lexical-search/search-in-the-four-main-windows|An icon depicting "abc"]] * [[https://www.th... [10:21:28] 10VisualEditor, 10User-Ryasmeen: VisualEditor suggested edit summary overrides keyboard shortcut to publish edit - https://phabricator.wikimedia.org/T222030 (10Deskana) Excellent. Thanks @Esanders! [12:09:47] (03PS7) 10Esanders: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) [12:12:26] (03PS8) 10Esanders: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) [12:58:28] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10Esanders) >>! In T220930#5142688, @Shenme wrote: > Would the above attempted fix have been implemented over on Wikipedia yet? I note this edit today (Apr... [13:41:08] 10VisualEditor: [Epic] Mobile VE usability Issues - https://phabricator.wikimedia.org/T221328 (10marcella) [13:41:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOUI, 10Browser-Support-Apple-Safari: Scrolling a ProcessDialog scrolls the page behind on iOS Safari - https://phabricator.wikimedia.org/T212159 (10marcella) [13:41:41] 10VisualEditor: [Epic] Mobile VE usability Issues - https://phabricator.wikimedia.org/T221328 (10marcella) [13:42:12] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE: Consider providing a visible or larger area for CE when editing an empty page/creating a new page - https://phabricator.wikimedia.org/T109508 (10marcell... [13:42:16] 10VisualEditor: [Epic] Mobile VE usability Issues - https://phabricator.wikimedia.org/T221328 (10marcella) [13:44:52] 10VisualEditor: [Epic] Mobile VE usability Issues - https://phabricator.wikimedia.org/T221328 (10marcella) [13:44:58] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Android-Google-Chrome, 10VisualEditor (Current work): Backspace across paragraphs is broken on mobile VE (Android Chrome) - https://phabricator.wikimedia.org/T202719 (10marcella) [13:45:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: EPIC: Fix selection issues on mobile - https://phabricator.wikimedia.org/T209505 (10marcella) [13:48:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10marcella) [13:48:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome: Page zooms slightly when focusing document on iPhone Chrome - https://phabricator.wikimedia.org/T216446 (10marcella) [13:48:42] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile table editing should default to cell contents - https://phabricator.wikimedia.org/T211240 (10marcella) [13:48:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10marcella) [13:48:51] 10VisualEditor: [Epic] Mobile VE usability Issues - https://phabricator.wikimedia.org/T221328 (10marcella) [13:48:53] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, and 5 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10marcella) [13:48:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-protection, 10MobileFrontend, and 3 others: Lack of next steps for new users on mobile devices when attempting to edit a protected page - https://phabricator.wikimedia.org/T206829 (10marcella) [13:51:59] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE: Consider providing a visible or larger area for CE when editing an empty page/creating a new page - https://phabricator.wikimedia.org/T109508 (10marcell... [13:52:17] 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 10VisualEditor (Current work): On Android Chrome, Thai text selections next to a link can collapse unexpectedly - https://phabricator.wikimedia.org/T203555 (10marcella) p:05Triage→03High [13:52:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Selection can appear on top of toolbar - https://phabricator.wikimedia.org/T217797 (10marcella) p:05Triage→03High [13:52:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Android-Google-Chrome: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome - https://phabricator.wikimedia.org/T136840 (10marcella) p:05Low→03High [13:53:06] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: Research faking linear selections on mobile - https://phabricator.wikimedia.org/T209533 (10marcella) p:05Triage→03High [13:53:20] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Can't drag a collapsed selection across a reference on mobile - https://phabricator.wikimedia.org/T204387 (10marcella) p:05Triage→03High [13:53:40] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10marcella) p:05Normal→03High [13:54:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10marcella) p:05Low→03Normal [13:54:48] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome: Page zooms slightly when focusing document on iPhone Chrome - https://phabricator.wikimedia.org/T216446 (10marcella) p:05Triage→03Normal [13:55:32] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile table editing should default to cell contents - https://phabricator.wikimedia.org/T211240 (10marcella) p:05Triage→03Normal [13:55:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10marcella) p:05Triage→03Normal [13:59:55] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notice in mobile VE - https://phabricator.wikimedia.org/T221400 (10Esanders) [13:59:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10Esanders) [14:00:42] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notice in mobile VE - https://phabricator.wikimedia.org/T221400 (10Esanders) Acutally @Tchanders beat us to this by 5 months! Merging into the original task. [14:02:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10Esanders) >>! In T209599#4835756, @matmarex wrote: > This is actually not a big problem because if you're blocked, then th... [14:02:14] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10Esanders) [14:02:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10Esanders) [14:02:42] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10Esanders) [14:04:40] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10Esanders) [14:04:42] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10Esanders) [14:04:47] 10VisualEditor: [Epic] Make VE the default mobile editor on 3 wikis - https://phabricator.wikimedia.org/T221185 (10Esanders) [14:04:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10Esanders) [14:04:56] (03CR) 10Jforrester: [C: 03+2] Demo: Set nullSelectionOnBlur when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506562 (owner: 10Esanders) [14:05:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10Esanders) [14:05:08] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show anon editor warning in mobile VE - https://phabricator.wikimedia.org/T221854 (10Esanders) [14:05:18] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10Esanders) [14:05:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10Esanders) [14:05:22] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Don't show anon editor warning after switching on Mobile - https://phabricator.wikimedia.org/T221855 (10Esanders) [14:05:25] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10Esanders) [14:05:28] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show anon editor warning in mobile VE - https://phabricator.wikimedia.org/T221854 (10Esanders) [14:05:52] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10Esanders) [14:06:06] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notice in mobile VE - https://phabricator.wikimedia.org/T221400 (10Esanders) [14:06:15] 10VisualEditor: [Epic] Make VE the default mobile editor on 3 wikis - https://phabricator.wikimedia.org/T221185 (10Esanders) [14:06:19] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VE mobile default: share MobileFrontend's login/block notices with VE - https://phabricator.wikimedia.org/T221190 (10Esanders) [14:06:35] (03PS4) 10D3r1ck01: Replace usage of deprecated ConfigFactory::getDefaultInstance() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 [14:06:43] (03Merged) 10jenkins-bot: Demo: Set nullSelectionOnBlur when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506562 (owner: 10Esanders) [14:07:54] (03CR) 10D3r1ck01: "Thanks for your review. Feedback applied." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 (owner: 10D3r1ck01) [14:08:07] (03CR) 10jenkins-bot: Demo: Set nullSelectionOnBlur when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506562 (owner: 10Esanders) [14:14:39] 10VisualEditor: [Epic] Mobile VE usability Issues - https://phabricator.wikimedia.org/T221328 (10ppelberg) [14:48:36] (03PS3) 10Esanders: Local/SessionStorage refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506162 [14:49:06] (03CR) 10Esanders: "MW patch: If855ee33b0993788cc159d8c3acf03070e6a9566" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506162 (owner: 10Esanders) [14:56:50] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10Esanders) a:03Esanders [14:57:58] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Don't show anon editor warning after switching on Mobile - https://phabricator.wikimedia.org/T221855 (10Esanders) a:05Esanders→03None [14:58:10] 10VisualEditor: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10Esanders) [14:58:42] 10VisualEditor, 10GrowthExperiments-Help panel, 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: "Get help with editing" button hides other components of the visual editor - https://phabricator.wikimedia.org/T219966 (10Esanders) [15:03:24] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Pasting problems in the mobile visual editor - https://phabricator.wikimedia.org/T221039 (10Esanders) 05Open→03Stalled I can't reproduce this, would need more details from the user on what steps they took. [15:04:28] 10VisualEditor, 10VisualEditor-ContentEditable: Right click to delete across paragraphs in Firefox results in no model transaction - https://phabricator.wikimedia.org/T220629 (10Esanders) @dchan Do you have a MutationObserver task we can link this to? [15:10:47] 10VisualEditor, 10Editing Design: Confusing re-use of 'quotes' icon in Find & Replace dialog - https://phabricator.wikimedia.org/T221997 (10Volker_E) Just to repeat, the whole word icon in Sublime Text screenshot above is the begin/end quotes, icon #3. For a moment I thought it's the last one, the box. I als... [15:14:47] 10VisualEditor, 10Browser-Support-Internet-Explorer: Visualeditor in Internet Explorer scrambles Texts when typing into new table cells - https://phabricator.wikimedia.org/T220984 (10Esanders) The problem appears to occur whenever you type into a table cell without entering it first (i.e. when the cell is sele... [15:44:47] 10VisualEditor: [Epic] Build an audience for Q4 work - https://phabricator.wikimedia.org/T221340 (10Whatamidoing-WMF) p:05Triage→03Normal [16:30:03] 10VisualEditor: Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10Esanders) [16:37:39] 10VisualEditor: Use OOUI icons in media dialog - https://phabricator.wikimedia.org/T222084 (10Esanders) [16:41:28] (03PS6) 10Esanders: WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) [16:42:52] (03PS1) 10Esanders: MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222079) [16:48:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10UI-Standardization: VE's media selector is using old local icons instead of the standardised ones: - https://phabricator.wikimedia.org/T222086 (10Jdforrester-WMF) [16:48:26] (03PS2) 10Jforrester: MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [16:48:37] (03CR) 10Jforrester: [C: 03+2] MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [16:49:06] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10UI-Standardization, 10Patch-For-Review, 10VisualEditor (Current work): VE's media selector is using old local icons instead of the standardised ones: - https://phabricator.wikimedia.org/T222086 (10Jdforrester-WMF) [16:56:05] (03CR) 10jerkins-bot: [V: 04-1] MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [16:56:17] (03CR) 10jerkins-bot: [V: 04-1] MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [16:57:18] (03CR) 10Jforrester: [C: 03+2] Improve rendering of audio files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506923 (https://phabricator.wikimedia.org/T206022) (owner: 10Esanders) [16:57:51] 10VisualEditor-Media, 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Audio file embeds have messed up thumbnails in VisualEditor - https://phabricator.wikimedia.org/T206022 (10Jdforrester-WMF) a:03Esanders [16:59:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Seems to work." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506671 (https://phabricator.wikimedia.org/T221716) (owner: 10Esanders) [16:59:31] (03CR) 10Bartosz Dziewoński: [C: 03+2] WindowAction: Don't re-activate surface until teardown complete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506670 (owner: 10Esanders) [16:59:33] (03CR) 10Bartosz Dziewoński: [C: 03+2] Remove focus code from LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506669 (owner: 10Esanders) [17:00:37] (03PS3) 10Jforrester: MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [17:01:25] (03Merged) 10jenkins-bot: Remove focus code from LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506669 (owner: 10Esanders) [17:01:27] (03Merged) 10jenkins-bot: WindowAction: Don't re-activate surface until teardown complete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506670 (owner: 10Esanders) [17:01:29] (03Merged) 10jenkins-bot: Update activeAnnotations when applying new annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506671 (https://phabricator.wikimedia.org/T221716) (owner: 10Esanders) [17:02:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10Jdforrester-WMF) [17:02:56] (03CR) 10jenkins-bot: WindowAction: Don't re-activate surface until teardown complete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506670 (owner: 10Esanders) [17:02:59] (03CR) 10jenkins-bot: Update activeAnnotations when applying new annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506671 (https://phabricator.wikimedia.org/T221716) (owner: 10Esanders) [17:03:09] (03CR) 10jenkins-bot: Remove focus code from LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/506669 (owner: 10Esanders) [17:09:53] (03Merged) 10jenkins-bot: Improve rendering of audio files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506923 (https://phabricator.wikimedia.org/T206022) (owner: 10Esanders) [17:11:36] (03CR) 10jenkins-bot: Improve rendering of audio files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506923 (https://phabricator.wikimedia.org/T206022) (owner: 10Esanders) [17:24:03] (03CR) 10Jforrester: [C: 03+2] MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [17:38:25] (03CR) 10Bartosz Dziewoński: "-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506923 (https://phabricator.wikimedia.org/T206022) (owner: 10Esanders) [17:38:59] 10VisualEditor-Media, 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Audio file embeds have messed up thumbnails in VisualEditor - https://phabricator.wikimedia.org/T206022 (10matmarex) Issues with the patch: * The MediaWiki-generated fake thumbnail is not suppressed * The same treatment is needed... [17:39:01] (03Merged) 10jenkins-bot: MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [17:40:44] (03CR) 10Jforrester: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506923 (https://phabricator.wikimedia.org/T206022) (owner: 10Esanders) [17:40:49] (03CR) 10Bartosz Dziewoński: "-1" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/506923 (https://phabricator.wikimedia.org/T206022) (owner: 10Esanders) [17:42:43] (03PS1) 10Jforrester: Update VE core submodule to master (36e90285e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507091 (https://phabricator.wikimedia.org/T221716) [17:46:17] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (36e90285e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507091 (https://phabricator.wikimedia.org/T221716) (owner: 10Jforrester) [18:02:13] (03Merged) 10jenkins-bot: Update VE core submodule to master (36e90285e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507091 (https://phabricator.wikimedia.org/T221716) (owner: 10Jforrester) [18:07:18] 10VisualEditor-Media, 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): Audio file embeds have messed up thumbnails in VisualEditor - https://phabricator.wikimedia.org/T206022 (10Esanders) >>! In T206022#5144402, @matmarex wrote: > Issues with the patch: >... [18:14:26] (03CR) 10VolkerE: [C: 03+1] MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [18:17:03] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10UI-Standardization, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: VE's media selector is using old local icons instead of the standardised ones: - https://phabricator.wikimedia.org/T222086 (10Volker_E) 05Open→03Resolved [18:17:14] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10UI-Standardization, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): VE's media selector is using old local icons instead of the standardised ones: - https://phabricator.wikimedia.org/T222086 (10Volker_E) [18:18:09] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10UI-Standardization, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): VE's media selector is using old local icons instead of the standardised ones: - https://phabricator.wikimedia.org/T222086 (10Volker_E) [18:18:17] 10VisualEditor, 10UI-Standardization, 10Design, 10Patch-For-Review, 10UI-Standardization-Kanban: VE's image type dropdown icon of media dialog need to be aligned to icon guidelines - https://phabricator.wikimedia.org/T206729 (10Volker_E) [18:18:43] 10VisualEditor, 10UI-Standardization, 10Design, 10UI-Standardization-Kanban, 10User-Ryasmeen: VE's image type dropdown icon of media dialog need to be aligned to icon guidelines - https://phabricator.wikimedia.org/T206729 (10Volker_E) 05Open→03Resolved [18:21:59] 10VisualEditor-Links, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active - https://phabricator.wikimedia.org/T221716 (10Jdforrester-WMF) [18:22:12] 10VisualEditor-Tables, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): Trying to merge template-generated table cells throws an exception - https://phabricator.wikimedia.org/T222039 (10Jdforrester-WMF) [18:39:13] (03CR) 10jenkins-bot: MediaDialog: Use new icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507063 (https://phabricator.wikimedia.org/T222086) (owner: 10Esanders) [18:50:34] (03CR) 10jenkins-bot: Update VE core submodule to master (36e90285e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507091 (https://phabricator.wikimedia.org/T221716) (owner: 10Jforrester) [20:30:24] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Ordered lists look broken in mobile VE - https://phabricator.wikimedia.org/T216792 (10matmarex) This should be fixed now (see comments and patch on T150377) and can be tested on Beta. [20:31:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/507140 (owner: 10L10n-bot) [20:52:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507187 (owner: 10L10n-bot) [21:28:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "DesktopArticleTarget.prototype.switchToFallbackWikitextEditor arguments need to be updated to match. Otherwise looks good." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) (owner: 10Esanders) [21:54:12] 10VisualEditor: VE should only change editing messages on content models it is for (wikitext) - https://phabricator.wikimedia.org/T222115 (10Isarra) [22:14:36] 10VisualEditor, 10MediaWiki-extensions-CollaborationKit: CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed - https://phabricator.wikimedia.org/T214111 (10Isarra) [22:15:41] 10VisualEditor, 10MediaWiki-extensions-CollaborationKit: CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed - https://phabricator.wikimedia.org/T214111 (10Isarra) So I'm going with 3 for now because doing anything about this from here just so completely infeasible. [22:31:54] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Doing), 10Services (doing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10Pchelolo) After adding the warn logging, there were 15 requests recorded f... [22:40:32] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Doing), 10Services (doing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10mobrovac) Indeed, the calls were for `/en.wikipedia.org/v1/page/html/List_... [22:50:25] 10VisualEditor, 10Uncyclomedia, 10I18n: VisualEditor should use its own message for the "Edit" tab - https://phabricator.wikimedia.org/T219056 (10Isarra) [23:07:14] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, and 5 others: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214 (10mobrovac) a:05mobrovac→03None >>! In T153214#4980104, @Mvolz wrote: > On further examination it looks like there's two ins... [23:43:02] (03PS9) 10Bartosz Dziewoński: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [23:46:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like it. Some minor comments/questions on the code:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [23:54:17] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10UI-Standardization, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): VE's media selector is using old local icons instead of the standardised ones: - https://phabricator.wikimedia.org/T222086 (10matmarex) [23:54:20] 10VisualEditor: Use OOUI icons in media dialog - https://phabricator.wikimedia.org/T222084 (10matmarex) [23:56:17] (03CR) 10jerkins-bot: [V: 04-1] Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders)