[00:28:58] (03CR) 10Esanders: "stylelint validation failing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [00:57:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Oops, sorry." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [01:21:20] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10matmarex) @shenme To be precise, the number of spaces is defined on this page: https://en.wikipedia.org/w/index.php?title=Template:Infobox_television/doc... [01:38:59] 10VisualEditor, 10Parsoid: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10matmarex) I think there might actually be a (more minor) Parsoid issue here. Whitespace around the template parameters that contain the HTML comment "sep... [09:29:46] 10Cite, 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review: CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Pginer-WMF) The issue was mentioned [[ ht... [11:31:57] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10VisualEditor (Current work): Show anon editor warning in mobile VE - https://phabricator.wikimedia.org/T221854 (10Esanders) [13:42:15] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Unrelated linebreak and whitespace changes when editing an infobox in Visual Editor - https://phabricator.wikimedia.org/T220930 (10Esanders) 05Open→03Resolved a:03Esanders The original reported issue was an on-wiki issue and appears to be resolved. If there a... [13:53:36] (03PS7) 10Esanders: Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) [13:53:38] (03PS7) 10Esanders: WIP Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) [14:24:17] (03CR) 10Esanders: "setupToolbarSaveButton and onToolbarSaveButtonClick can safely be removed. attachToolbarSaveButton should probably be renamed as it doesn'" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [14:38:55] (03PS10) 10Esanders: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) [15:14:41] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Make mobile toolbar done/tick tool progressive blue - https://phabricator.wikimedia.org/T222187 (10Esanders) [15:15:58] (03PS1) 10Esanders: Make mobile check icon progressive blue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507346 (https://phabricator.wikimedia.org/T222187) [15:21:36] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Make mobile toolbar done/tick tool progressive blue - https://phabricator.wikimedia.org/T222187 (10iamjessklein) +1 [15:22:37] (03CR) 10Esanders: "+1 from Jess on the task" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507346 (https://phabricator.wikimedia.org/T222187) (owner: 10Esanders) [15:34:12] (03CR) 10Jforrester: [C: 03+2] Make mobile check icon progressive blue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507346 (https://phabricator.wikimedia.org/T222187) (owner: 10Esanders) [15:50:59] (03Merged) 10jenkins-bot: Make mobile check icon progressive blue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507346 (https://phabricator.wikimedia.org/T222187) (owner: 10Esanders) [15:52:28] (03CR) 10jenkins-bot: Make mobile check icon progressive blue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507346 (https://phabricator.wikimedia.org/T222187) (owner: 10Esanders) [15:55:16] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Make mobile toolbar done/tick tool progressive blue - https://phabricator.wikimedia.org/T222187 (10Jdforrester-WMF) [16:28:06] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-protection, 10MobileFrontend, and 3 others: Lack of next steps for new users on mobile devices when attempting to edit a protected page - https://phabricator.wikimedia.org/T206829 (10alexhollender) @JTannerWMF @marcella can you verify if thi... [16:51:50] (03PS1) 10DLynch: TableLineContext: add context for the entire table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507368 (https://phabricator.wikimedia.org/T211240) [16:51:52] (03PS1) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [16:53:51] (03CR) 10jerkins-bot: [V: 04-1] TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [17:03:56] (03PS2) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [17:06:26] (03PS1) 10Esanders: ApiVisualEditor: Return structued block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 [17:08:41] (03CR) 10jerkins-bot: [V: 04-1] ApiVisualEditor: Return structued block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (owner: 10Esanders) [17:18:27] (03PS2) 10Esanders: ApiVisualEditor: Return structued block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 [17:44:33] 10VisualEditor: Inability to unmerge table fields - https://phabricator.wikimedia.org/T222016 (10Urbanecm) Thanks @Esanders for spotting the issue! [18:22:42] (03PS3) 10Esanders: ApiVisualEditor: Return structued block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 [18:31:49] (03PS4) 10Esanders: ApiVisualEditor: Return structued block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 [18:31:51] (03PS1) 10Esanders: API: Use formatversion=2 by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507398 [18:32:47] (03CR) 10Tchanders: [C: 03+1] ApiVisualEditor: Return structued block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (owner: 10Esanders) [18:40:59] (03CR) 10Bartosz Dziewoński: [C: 03+1] Make mobile check icon progressive blue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507346 (https://phabricator.wikimedia.org/T222187) (owner: 10Esanders) [18:51:23] (03CR) 10Esanders: [C: 04-1] "It appears just clicking on the new table context button (the tiny icon) is enough to put the editor into cell selection mode. I don't thi" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [18:52:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10Whatamidoing-WMF) [19:00:49] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10Isarra) [19:01:49] (03CR) 10Jforrester: [C: 03+2] API: Use formatversion=2 by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507398 (owner: 10Esanders) [19:02:22] (03PS5) 10Jforrester: ApiVisualEditor: Return structured block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (owner: 10Esanders) [19:19:44] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) (owner: 10Esanders) [19:30:24] (03Merged) 10jenkins-bot: API: Use formatversion=2 by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507398 (owner: 10Esanders) [19:31:54] (03CR) 10jenkins-bot: API: Use formatversion=2 by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507398 (owner: 10Esanders) [19:32:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [19:32:36] (03PS11) 10Bartosz Dziewoński: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [19:33:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Corrected commit message, the progressive icon change was moved to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/50" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [19:37:05] (03Merged) 10jenkins-bot: Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) (owner: 10Esanders) [19:38:32] (03CR) 10jenkins-bot: Fix switching without changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) (owner: 10Esanders) [19:40:33] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10iamjessklein) I updated Invision with the [[https://wikimedia.invisionapp.com/freehand/document/s1duR... [19:41:12] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10iamjessklein) [19:51:38] (03Merged) 10jenkins-bot: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [19:53:03] (03CR) 10jenkins-bot: Replace the save button with a save tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504214 (https://phabricator.wikimedia.org/T163142) (owner: 10Esanders) [20:09:36] (03PS6) 10Jforrester: Section switch from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [20:10:27] (03PS7) 10Jforrester: Section switch from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [20:15:53] (03CR) 10jerkins-bot: [V: 04-1] Section switch from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [20:35:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/507437 (owner: 10L10n-bot) [20:36:49] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Mobile table editing should default to cell contents - https://phabricator.wikimedia.org/T211240 (10Esanders) a:03DLynch [20:37:13] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Ordered lists look broken in mobile VE - https://phabricator.wikimedia.org/T216792 (10Esanders) a:03matmarex [20:41:05] (03PS6) 10Bartosz Dziewoński: ApiVisualEditor: Return structured block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (https://phabricator.wikimedia.org/T209599) (owner: 10Esanders) [20:42:03] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Seems fine, I'm assuming Thalia looked at the logic more closely, I'm not very familiar with the blocking code." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (https://phabricator.wikimedia.org/T209599) (owner: 10Esanders) [20:53:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507479 (owner: 10L10n-bot) [21:07:54] (03Merged) 10jenkins-bot: ApiVisualEditor: Return structured block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (https://phabricator.wikimedia.org/T209599) (owner: 10Esanders) [21:09:21] (03CR) 10jenkins-bot: ApiVisualEditor: Return structured block info as well as formatted notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507375 (https://phabricator.wikimedia.org/T209599) (owner: 10Esanders) [21:17:04] (03PS8) 10Jforrester: Section switch from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [21:18:42] 10VisualEditor: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Ryasmeen) [21:18:56] 10VisualEditor: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Ryasmeen) p:05Triage→03High [21:34:06] 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10VisualEditor (Current work): Pasting tables from Google sheets pollutes the document with data-sheets- attributes - https://phabricator.wikimedia.org/T221668 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforre... [23:06:47] 10VisualEditor: PageUp and PageDown act as Home and End in Visual editing - https://phabricator.wikimedia.org/T222243 (10JAufrecht) p:05Triage→03Normal