[03:02:10] (03CR) 10DLynch: "> Patch Set 2: Code-Review-1" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [03:02:54] (03PS3) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [03:05:22] (03CR) 10DLynch: "So, point of interest here, this new TableContext for the entire node /completely/ replaces the actual TableNode context item, and so we c" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [03:45:06] 10VisualEditor: "Find" doesn't scroll the viewport - https://phabricator.wikimedia.org/T222247 (10Whatamidoing-WMF) [03:45:29] 10VisualEditor: "Find" doesn't scroll the viewport - https://phabricator.wikimedia.org/T222247 (10Whatamidoing-WMF) [04:14:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Keyboard shortcut is being typed into the page - https://phabricator.wikimedia.org/T222248 (10Whatamidoing-WMF) [04:20:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WTE loses focus after making a link - https://phabricator.wikimedia.org/T222249 (10Whatamidoing-WMF) [04:22:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WTE loses focus after making a link - https://phabricator.wikimedia.org/T222249 (10Whatamidoing-WMF) [04:32:03] 10VisualEditor: Warn user if they set the whole page to a different language - https://phabricator.wikimedia.org/T222251 (10Whatamidoing-WMF) [04:36:45] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Adding language codes wrecks list formatting - https://phabricator.wikimedia.org/T222252 (10Whatamidoing-WMF) [13:09:37] 10VisualEditor: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10Esanders) A side effect of this is if you cursor onto a link from the right, the preview doesn't render: {F28885500} [13:53:35] (03PS1) 10Esanders: ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 [13:56:47] (03CR) 10Esanders: "The unbreaks switching from source to VE when you aren't blocked." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [14:01:24] (03CR) 10jerkins-bot: [V: 04-1] ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [14:17:47] 10VisualEditor-MediaWiki-Mobile, 10OOUI, 10Browser-Support-Apple-Safari, 10VisualEditor (Current work): Scrolling a ProcessDialog scrolls the page behind on iOS Safari - https://phabricator.wikimedia.org/T212159 (10JTannerWMF) [14:24:46] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10JTannerWMF) @Esanders putting this back into In Progress to address what @Ryasmeen raised [14:26:08] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Android-Google-Chrome, 10VisualEditor (Current work): Backspace across paragraphs is broken on mobile VE (Android Chrome) - https://phabricator.wikimedia.org/T202719 (10JTannerWMF) Looks like @dchan is investigating so movin... [14:40:09] (03CR) 10Jforrester: "recheck after timeout" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [14:47:13] (03CR) 10jerkins-bot: [V: 04-1] ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [15:16:52] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:19:15] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:19:39] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:28:25] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:29:10] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:49:09] (03PS2) 10Esanders: ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 [15:57:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [16:16:49] (03Merged) 10jenkins-bot: ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [16:18:20] (03CR) 10jenkins-bot: ArticleTarget: Return dataPromise from #load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507572 (owner: 10Esanders) [17:07:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing, 10Performance-Team (Radar): Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor) - https://phabricator.wikimedia.org/T189821 (10Esanders) Yeah, as James says this is a beta feature so only repre... [17:11:12] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Seems fine. In fact, I would support removing the ->exists() check entirely and always listing all messages – but currently doing so would" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504788 (https://phabricator.wikimedia.org/T221294) (owner: 10Krinkle) [17:12:13] (03CR) 10Bartosz Dziewoński: [C: 03+2] "(I copied my comment to the task)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504788 (https://phabricator.wikimedia.org/T221294) (owner: 10Krinkle) [17:28:02] (03Merged) 10jenkins-bot: DesktopArticleTargetInitModule: Avoid expensive $msg->exists check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504788 (https://phabricator.wikimedia.org/T221294) (owner: 10Krinkle) [17:29:48] (03CR) 10jenkins-bot: DesktopArticleTargetInitModule: Avoid expensive $msg->exists check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504788 (https://phabricator.wikimedia.org/T221294) (owner: 10Krinkle) [17:31:21] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) Will talk about this tomorrow in the meeting wi... [17:55:40] (03CR) 10Esanders: "I think that would be fine (on mobile)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [20:45:10] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507704 (https://phabricator.wikimedia.org/T221289) [20:46:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507694 (owner: 10L10n-bot) [20:55:16] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, 10MobileFrontend, and 4 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10matmarex) [20:55:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: Provide the VE wikitext editing mode as the mobile wikitext editor - https://phabricator.wikimedia.org/T159971 (10matmarex) [20:56:36] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10MinervaNeue (Desktop), 10Patch-For-Review, and 2 others: Improve compatibility of desktop VisualEditor with desktop Minerva skin - https://phabricator.wikimedia.org/T208102 (10matmarex) [20:56:40] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10matmarex) [21:39:01] 10VisualEditor, 10Contributors-Team, 10Contributors-UX-Research, 10MobileFrontend: Rephrase MobileFrontend dialog controls/buttons when pressing the back arrow during an edit - https://phabricator.wikimedia.org/T151112 (10matmarex) Looks like this has already been fixed in {d002e057e912fd2802647dc9d097d48b... [21:39:08] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Readers-Web-Backlog (Tracking), and 2 others: Abort dialog in mobile source editing should feature primary destructive button - https://phabricator.wikimedia.org/T192333 (10matmarex) [21:39:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: Provide the VE wikitext editing mode as the mobile wikitext editor - https://phabricator.wikimedia.org/T159971 (10matmarex) [21:39:20] 10VisualEditor, 10Contributors-Team, 10Contributors-UX-Research, 10MobileFrontend, 10User-Ryasmeen: Rephrase MobileFrontend dialog controls/buttons when pressing the back arrow during an edit - https://phabricator.wikimedia.org/T151112 (10matmarex) [21:39:41] 10VisualEditor, 10Contributors-Team, 10Contributors-UX-Research, 10MobileFrontend, 10User-Ryasmeen: Rephrase MobileFrontend dialog controls/buttons when pressing the back arrow during an edit - https://phabricator.wikimedia.org/T151112 (10matmarex) 05Open→03Resolved [21:46:59] 10VisualEditor: Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10matmarex) [21:47:04] 10VisualEditor: Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10matmarex) a:03matmarex [22:11:13] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTargetLoader: Fix non-RESTBase #requestParsoidData with wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507711 (https://phabricator.wikimedia.org/T222312) [22:26:58] 10VisualEditor: Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10matmarex) [22:27:22] 10VisualEditor: Add "undo" and "redo" functionality to mobile wikitext editor - https://phabricator.wikimedia.org/T222316 (10ppelberg) [22:27:26] 10VisualEditor: Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10matmarex) [22:27:31] 10VisualEditor, 10Patch-For-Review: Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10matmarex) [22:27:38] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, 10MobileFrontend, and 4 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10matmarex) [22:29:22] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, 10MobileFrontend, and 4 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10matmarex) I did some more testing and found a few issues myself, let's fix those before we un... [22:29:34] 10VisualEditor: Add "undo" and "redo" functionality to mobile wikitext editor - https://phabricator.wikimedia.org/T222316 (10ppelberg) [23:37:24] 10VisualEditor, 10Mobile: Add "undo" and "redo" functionality to mobile wikitext editor - https://phabricator.wikimedia.org/T222316 (10Zoranzoki21) [23:57:49] (03CR) 10Esanders: [C: 03+2] ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507704 (https://phabricator.wikimedia.org/T221289) (owner: 10Bartosz Dziewoński)