[07:18:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/508198 (owner: 10L10n-bot) [07:54:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508268 (owner: 10L10n-bot) [11:37:03] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Hackathon-2019, and 2 others: Provide a Lua method mw.templatedata.load() - https://phabricator.wikimedia.org/T107119 (10putnik) [12:23:31] 10VisualEditor, 10VisualEditor-Tables: Visual editor inserts line break between table tags truncating the table - https://phabricator.wikimedia.org/T222607 (10Aklapper) [14:12:58] 10Cite, 10TCB-Team, 10WMDE-Design, 10Design: Find a better way to highligth letters then bold - https://phabricator.wikimedia.org/T210281 (10Lea_WMDE) >>! In T210281#5142045, @Alsee wrote: > I was considering opening a discussion on EnWiki to remove the bolding from our backlinks, so the current feature wo... [15:07:23] 10TemplateData, 10VisualEditor (Current work): In TemplateData param editor, typing a name equal to alias definitely disable Done button - https://phabricator.wikimedia.org/T222543 (10marcella) [15:10:47] (03PS5) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [15:26:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Adding language codes wrecks list formatting - https://phabricator.wikimedia.org/T222252 (10matmarex) [15:26:27] 10VisualEditor, 10Accessibility: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10matmarex) [15:28:36] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): 2017WTE loses focus after making a link - https://phabricator.wikimedia.org/T222249 (10marcella) [15:32:34] 10VisualEditor, 10Accessibility: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10matmarex) [15:35:01] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10marcella) [15:38:17] 10VisualEditor-MediaWiki-Links, 10Editing Design, 10VisualEditor (Current work): Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10marcella) [15:44:16] 10VisualEditor, 10Accessibility: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10matmarex) (I couldn't reproduce either.) [16:01:12] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10matmarex) [16:03:33] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10Jdforrester-WMF) To be clear, it was an intentional design decision to have "open in a source editor" always be labelled "edit source", regardless of which editor (2003/2010/2017/CodeEditor/wha... [16:08:04] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10matmarex) At the time this was written, the only other content models might have been JavaScript and CSS, where "edit source" would be more appropriate than "edit". [16:17:33] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10Jdforrester-WMF) >>! In T222115#5160700, @matmarex wrote: > At the time this was written, the only other content models might have been JavaScript and CSS, where "edit source" would be more app... [16:18:13] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10Jdforrester-WMF) The proper fix for this is of course T28918. [16:22:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508338 (owner: 10L10n-bot) [16:34:38] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 3 others: VisualEditor should request Parsed HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10Pchelolo) [16:34:51] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 3 others: VisualEditor should request Parsoid HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10Pchelolo) [16:39:58] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 3 others: VisualEditor should request Parsoid HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10ssastry) @Pchelolo: this doesn't just affect VE but all Parsoid clients that might fetc... [16:41:29] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 3 others: VisualEditor should request Parsoid HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10Pchelolo) > (a) this should actually be documented in the API docs (swagger?) alongwith... [16:45:54] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 3 others: VisualEditor should request Parsoid HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10ssastry) >>! In T222639#5160906, @Pchelolo wrote: > > (b) so, should we send no data-p... [17:15:20] (03PS1) 10Jforrester: build: Upgrade grunt from 1.0.3 to 1.0.4 and re-up for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508365 [17:41:12] (03PS1) 10Bartosz Dziewoński: Fix diffs in non-section-editing mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508367 (https://phabricator.wikimedia.org/T222489) [17:45:09] 10VisualEditor: An extra blank line added below when editing a paragraph - https://phabricator.wikimedia.org/T212812 (10matmarex) I can't reproduce this problem, or perhaps I'm not understanding what the problem is. (The article has changed since you reported this, which doesn't help.) Can you clarify and add s... [17:48:07] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10matmarex) Thanks for linking that, I was going to say basically the same thing. If we had a way to find out whether a given content model is going to use the generic source editor, or some edit... [17:53:12] (03CR) 10Esanders: [C: 03+2] Fix diffs in non-section-editing mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508367 (https://phabricator.wikimedia.org/T222489) (owner: 10Bartosz Dziewoński) [18:04:36] 10VisualEditor, 10Uncyclomedia, 10I18n: VisualEditor should use its own message for the "Edit" tab - https://phabricator.wikimedia.org/T219056 (10matmarex) So to summarize, the request is: if VisualEditor is available for a given page, then instead of just not changing the "edit" tab text, we should wrap it... [18:06:04] 10VisualEditor: An extra blank line added below when editing a paragraph - https://phabricator.wikimedia.org/T212812 (10Inaki-LL) Hi @mamarex, yes, the article has changed, and I cannot reproduce it now. The bug was consistent enough, but now it did not work, it does not show. It has happened in other articles I... [18:08:00] 10VisualEditor, 10User-DannyS712: Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽ - https://phabricator.wikimedia.org/T222525 (10marcella) [18:10:20] 10VisualEditor, 10User-DannyS712: Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽ - https://phabricator.wikimedia.org/T222525 (10marcella) I've updated this task to be adding user-facing text to give an appropriate error message to the user. @DannyS712, if you're able to reproduce the ste... [18:13:35] 10VisualEditor, 10Uncyclomedia, 10I18n: VisualEditor should use its own message for the "Edit" tab - https://phabricator.wikimedia.org/T219056 (10Isarra) I'm not sure if that's right or not (I honestly lost track of what all this task was/what the comments, including my own, were going for at this point when... [18:13:37] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Visual editor inserts line break between table tags truncating the table - https://phabricator.wikimedia.org/T222607 (10marcella) @matmarex thinks this is likely to be a Parsoid issue. @ssastry please let us know if your team disagrees. [18:13:41] (03Merged) 10jenkins-bot: Fix diffs in non-section-editing mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508367 (https://phabricator.wikimedia.org/T222489) (owner: 10Bartosz Dziewoński) [18:14:03] (03PS1) 10Jforrester: Fix diffs in non-section-editing mode [extensions/VisualEditor] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508374 (https://phabricator.wikimedia.org/T222489) [18:14:18] 10VisualEditor, 10Mobile: Add "undo" and "redo" functionality to mobile wikitext editor - https://phabricator.wikimedia.org/T222316 (10marcella) To revisit for our work considerations in Q1 or Q2 of FY19-20. [18:15:25] (03CR) 10jenkins-bot: Fix diffs in non-section-editing mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508367 (https://phabricator.wikimedia.org/T222489) (owner: 10Bartosz Dziewoński) [18:15:49] 10VisualEditor: PageUp and PageDown act as Home and End in Visual editing - https://phabricator.wikimedia.org/T222243 (10matmarex) For the record, I couldn't reproduce this. I ran into some issues, but not like you described (it seems that the cursor can get "stuck" in a link annotation when navigating using Pag... [18:39:16] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Visual editor inserts line break between table tags truncating the table - https://phabricator.wikimedia.org/T222607 (10ssastry) >>! In T222607#5161193, @marcella wrote: > @matmarex thinks this is likely to be a Parsoid issue. @ssastry please let us know if... [18:48:39] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10Isarra) Why not just set a configuration array of content models to activate/exclude activation on, such that we can then have sysadmins add/remove any that won't apply when installing the exte... [19:08:19] (03PS4) 10Krinkle: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [19:26:57] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10matmarex) I can't reproduce this problem. Looks fine on 10VisualEditor: Page notices hidden behind toolbar dialogs - https://phabricator.wikimedia.org/T222427 (10matmarex) This is basically the same issue as T221705. Looks like the patch for that task did not fix this, because the `z-index: 1;` is overriden to `4` in another place. [19:39:08] (03CR) 10Esanders: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/503651 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [19:53:31] (03PS1) 10Bartosz Dziewoński: Fix some bad math in CSS code comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508395 [19:54:23] (03CR) 10Jforrester: [C: 03+2] "Ha." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508395 (owner: 10Bartosz Dziewoński) [19:58:48] (03PS1) 10Esanders: Fix abandon edit warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508396 (https://phabricator.wikimedia.org/T222525) [20:06:29] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix abandon edit warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508396 (https://phabricator.wikimedia.org/T222525) (owner: 10Esanders) [20:12:56] (03PS2) 10Esanders: Fix abandon edit warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508396 (https://phabricator.wikimedia.org/T222525) [20:12:58] (03PS1) 10Esanders: Fix setting of this.loading so it can be cleared [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508397 [20:13:30] (03Merged) 10jenkins-bot: Fix some bad math in CSS code comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508395 (owner: 10Bartosz Dziewoński) [20:15:03] (03CR) 10jenkins-bot: Fix some bad math in CSS code comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508395 (owner: 10Bartosz Dziewoński) [20:32:08] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508398 (https://phabricator.wikimedia.org/T220036) [20:32:10] (03PS1) 10Jforrester: [DNM] Test JSON file to prove that we're validating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508399 [20:33:30] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508400 (https://phabricator.wikimedia.org/T220036) [20:33:42] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Test JSON file to prove that we're validating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508399 (owner: 10Jforrester) [20:37:05] (03PS6) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [20:38:26] (03CR) 10jerkins-bot: [V: 04-1] TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [20:39:18] (03PS7) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [20:41:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508398 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [20:41:05] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508400 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [20:41:09] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade grunt from 1.0.3 to 1.0.4 and re-up for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508365 (owner: 10Jforrester) [20:42:58] (03Merged) 10jenkins-bot: build: Upgrade grunt from 1.0.3 to 1.0.4 and re-up for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508365 (owner: 10Jforrester) [20:43:43] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508398 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [20:45:21] (03CR) 10jenkins-bot: build: Upgrade grunt from 1.0.3 to 1.0.4 and re-up for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508365 (owner: 10Jforrester) [20:45:21] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508398 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [20:54:50] (03Abandoned) 10Jforrester: [DNM] Test JSON file to prove that we're validating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508399 (owner: 10Jforrester) [20:58:39] (03PS1) 10Bartosz Dziewoński: ve.ui.MWWikitextSurface: Hide UI of extensions that attach to our dummy textbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508410 (https://phabricator.wikimedia.org/T211898) [21:03:19] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508400 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [21:05:02] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508400 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [21:46:38] (03CR) 10Esanders: [C: 03+2] ve.ui.MWWikitextSurface: Hide UI of extensions that attach to our dummy textbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508410 (https://phabricator.wikimedia.org/T211898) (owner: 10Bartosz Dziewoński) [22:03:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) a:03matmarex [22:09:02] (03Merged) 10jenkins-bot: ve.ui.MWWikitextSurface: Hide UI of extensions that attach to our dummy textbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508410 (https://phabricator.wikimedia.org/T211898) (owner: 10Bartosz Dziewoński) [22:10:53] (03CR) 10jenkins-bot: ve.ui.MWWikitextSurface: Hide UI of extensions that attach to our dummy textbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508410 (https://phabricator.wikimedia.org/T211898) (owner: 10Bartosz Dziewoński) [22:25:32] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/508441 [22:46:21] 10Editing-team, 10Gadgets, 10Performance-Team (Radar): Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load) - https://phabricator.wikimedia.org/T171180 (10Krinkle) [23:07:43] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Add 'dragging' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508460 (https://phabricator.wikimedia.org/T96289) [23:07:56] (03PS1) 10Bartosz Dziewoński: ve.init.mw.MobileArticleTarget: Fix the jump when opening the mobile context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508461 (https://phabricator.wikimedia.org/T96289) [23:11:39] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) The above seemed to work great when I tested on desktop. On iOS it has some weird interaction with our scrolling hacks, and som... [23:22:43] 10VisualEditor: VE mobile default: design A/B test - https://phabricator.wikimedia.org/T221195 (10ppelberg) [23:23:04] 10VisualEditor: VE mobile default: design A/B test - https://phabricator.wikimedia.org/T221195 (10ppelberg) [23:27:00] (03CR) 10jerkins-bot: [V: 04-1] ve.init.mw.MobileArticleTarget: Fix the jump when opening the mobile context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508461 (https://phabricator.wikimedia.org/T96289) (owner: 10Bartosz Dziewoński) [23:37:38] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/508441 (owner: 10Jforrester)