[00:00:19] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/508441 (owner: 10Jforrester) [00:01:22] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/508441 (owner: 10Jforrester) [00:09:10] (03CR) 10Jforrester: [C: 03+2] Fix diffs in non-section-editing mode [extensions/VisualEditor] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508374 (https://phabricator.wikimedia.org/T222489) (owner: 10Jforrester) [00:20:54] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix abandon edit warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508396 (https://phabricator.wikimedia.org/T222525) (owner: 10Esanders) [00:21:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix setting of this.loading so it can be cleared [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508397 (owner: 10Esanders) [00:21:50] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-DannyS712, 10VisualEditor (Current work): Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽ - https://phabricator.wikimedia.org/T222525 (10Jdforrester-WMF) [00:26:25] 10VisualEditor: VE should only change editing messages on wikitext pages - https://phabricator.wikimedia.org/T222115 (10matmarex) That seems like a reasonable approach. Rather than rely on sysadmins, you could have the extensions configure it, in the same way as with VisualEditorPluginModules (see e.g. AbuseFilt... [00:31:17] (03Merged) 10jenkins-bot: Fix diffs in non-section-editing mode [extensions/VisualEditor] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508374 (https://phabricator.wikimedia.org/T222489) (owner: 10Jforrester) [00:42:28] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): Visual diffs not showing in mobile VE (when visual section editing is disabled) - https://phabricator.wikimedia.org/T222489 (10Jdforrester-WMF) Back-ported to production. [01:10:06] (03Merged) 10jenkins-bot: Fix setting of this.loading so it can be cleared [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508397 (owner: 10Esanders) [01:12:49] (03CR) 10jenkins-bot: Fix setting of this.loading so it can be cleared [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508397 (owner: 10Esanders) [01:33:31] (03Merged) 10jenkins-bot: Fix abandon edit warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508396 (https://phabricator.wikimedia.org/T222525) (owner: 10Esanders) [01:34:59] (03CR) 10jenkins-bot: Fix abandon edit warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508396 (https://phabricator.wikimedia.org/T222525) (owner: 10Esanders) [06:24:54] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) ##6-May outcomes @Esanders, @iamjessklein and I talked about the [wireframes](https://wikim... [07:04:53] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 3 others: VisualEditor should request Parsoid HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10mobrovac) @ssastry @Arlolra so the TL;DR is: if we have the exact render data-parsoid,... [07:07:06] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 4 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) [07:07:11] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Doing), 10Services (doing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10mobrovac) [07:40:21] 10VisualEditor: An extra blank line added below when editing a paragraph - https://phabricator.wikimedia.org/T212812 (10Inaki-LL) @matmarex 1. Go to the article Foruen amaiera Hego Euskal Herrian and [[ https://eu.wikipedia.org/wiki/Foruen_amaiera_Hego_Euskal_Herrian#Testuingurua | section Testuingurua, here ]]... [07:58:03] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 4 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) [07:58:08] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Kanban (Done with CPT), and 2 others: Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10mobrovac) 05Open→03Resolved p:05Triage→03Normal Deployed, section... [09:04:09] (03PS1) 10Mobrovac: ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) [09:23:21] (03CR) 10Mobrovac: [C: 04-1] "Not ready to go yet" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [13:32:38] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 4 others: VisualEditor should request Parsoid HTML with ?stash=true query parameter - https://phabricator.wikimedia.org/T222639 (10ssastry) >>! In T222639#5163458, @mobrovac wrote: > @ssastry @Arlolra so the TL;DR is:... [14:23:42] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10User-DannyS712, 10VisualEditor (Current work): Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽ - https://phabricator.wikimedia.org/T222525 (10matmarex) > I just got the warning "⧼visualeditor-... [15:14:30] 10Cite, 10VisualEditor, 10Code-Health: Cite: Hardcoded 'mwReference' name makes subclassing difficult - https://phabricator.wikimedia.org/T217009 (10JTannerWMF) Can you look into this @Esanders [15:14:42] 10Cite, 10Code-Health, 10VisualEditor (Current work): Cite: Hardcoded 'mwReference' name makes subclassing difficult - https://phabricator.wikimedia.org/T217009 (10JTannerWMF) [15:17:23] 10VisualEditor, 10Parsoid: Splitting a paragraph duplicated it - https://phabricator.wikimedia.org/T203112 (10JTannerWMF) We need support from Parsoid to know how to proceed. tagging @ssastry [15:21:33] 10VisualEditor, 10RESTBase, 10RESTBase-API, 10Core Platform Team Backlog (Watching / External), 10Services (watching): VE does not provide If-Match for html/to/wikitext transforms sometimes - https://phabricator.wikimedia.org/T206029 (10JTannerWMF) Hey @Pchelolo is this still blocking your work and if so... [15:24:08] 10VisualEditor, 10RESTBase, 10RESTBase-API, 10Core Platform Team Backlog (Watching / External), 10Services (watching): VE does not provide If-Match for html/to/wikitext transforms sometimes - https://phabricator.wikimedia.org/T206029 (10Pchelolo) It's is still the case sometimes. It's not severe, but we... [15:36:24] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Ensure CTRL-V paste works as expected in text editing mode - https://phabricator.wikimedia.org/T218820 (10Alsee) @JTannerWMF or anyone, if you are interested in Discussion/Analysis input from the community then I'd be happ... [15:42:26] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10JTannerWMF) Can someone determine whether or not this is resolved? [15:45:03] 10VisualEditor: [feature request] User scenario to fix old raw references - https://phabricator.wikimedia.org/T179773 (10matmarex) [15:45:12] 10VisualEditor-MediaWiki-References, 10Patch-For-Review, 10VisualEditor (Current work): Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it (converting a re-used basic reference to template citation) - https://phabricator.wikimedia.org/T208981 (... [15:48:03] 10VisualEditor, 10MediaWiki-Uploading, 10Multimedia, 10Wikimedia-production-error: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor" - https://phabricator.wikimedia.org/T187491 (10JTannerWMF) The Editing team does not maintain the upload function. [15:50:41] 10Citoid, 10VisualEditor: Allow arbitrary search strings in citoid from existing footnotes - https://phabricator.wikimedia.org/T208751 (10matmarex) [15:50:44] 10VisualEditor: [feature request] User scenario to fix old raw references - https://phabricator.wikimedia.org/T179773 (10matmarex) [15:51:20] 10VisualEditor: [feature request] User scenario to fix old raw references - https://phabricator.wikimedia.org/T179773 (10matmarex) [15:51:22] 10Citoid, 10VisualEditor: Allow arbitrary search strings in citoid from existing footnotes - https://phabricator.wikimedia.org/T208751 (10matmarex) [15:51:37] 10Citoid, 10VisualEditor: Allow arbitrary search strings in citoid from existing footnotes - https://phabricator.wikimedia.org/T208751 (10matmarex) [15:51:40] 10VisualEditor-MediaWiki-References, 10Patch-For-Review, 10VisualEditor (Current work): Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it (converting a re-used basic reference to template citation) - https://phabricator.wikimedia.org/T208981 (... [15:57:37] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Would it be possible for the cite templates in VE to use the date format specified in the article for date parameters? - https://phabricator.wikimedia.org/T205682 (10JTannerWMF) This may have been fixed, we will discuss to see if it was or if we... [16:10:56] 10Cite, 10Code-Health, 10VisualEditor (Current work): Cite: Hardcoded 'mwReference' name makes subclassing difficult - https://phabricator.wikimedia.org/T217009 (10matmarex) I don't know a lot about CX integration, so I'm sorry if this is a silly idea. But would it be possible to unregister ve.dm.MWReference... [16:18:48] 10VisualEditor, 10MediaWiki-Uploading, 10Multimedia, 10Wikimedia-production-error: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor" - https://phabricator.wikimedia.org/T187491 (10marcella) @MarkTraceur, this looks like a task for your team. If you think that isn't the... [16:52:06] (03CR) 10DLynch: [C: 03+2] TableNode performance: Only change selection when endCell changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507857 (owner: 10Esanders) [16:53:35] (03Merged) 10jenkins-bot: TableNode performance: Only change selection when endCell changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507857 (owner: 10Esanders) [16:55:01] (03CR) 10jenkins-bot: TableNode performance: Only change selection when endCell changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507857 (owner: 10Esanders) [16:56:43] (03PS2) 10DLynch: TableLineContext: add context for the entire table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507368 (https://phabricator.wikimedia.org/T211240) [16:56:45] (03PS8) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [17:27:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-Ryasmeen: VE/etc. tab missing from Special:Undelete - https://phabricator.wikimedia.org/T174748 (10matmarex) 05Open→03Resolved a:03matmarex (This has been fixed by that patch in 2018, I just forgot to close it) [17:50:31] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508651 [18:30:43] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/508670 [19:11:08] (03CR) 10Esanders: [C: 04-1] "I think you'll want to look at ApiVisualEditor(Edit).php too" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [19:25:01] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10Esanders) The Parsoid side is finished, but we still render interwiki links as external in VE. [19:32:40] (03PS5) 10Jforrester: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [19:34:58] (03CR) 10jerkins-bot: [V: 04-1] Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [19:46:58] (03PS1) 10Esanders: Fix initial rendering of interwiki links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508693 (https://phabricator.wikimedia.org/T185083) [20:07:54] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-VisualDiffs, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Verified, 10VisualEditor (Current work): Visual diff showing too much context in section editing mode - https://phabricator.wikimedia.org/T221903 (10Ryasmeen) [20:15:20] (03PS1) 10Bartosz Dziewoński: ve.ce.FocusableNode: Prevent native selection from changing on click [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508700 (https://phabricator.wikimedia.org/T108013) [20:28:23] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: tall popup windows sometimes scroll target out of view - https://phabricator.wikimedia.org/T180242 (10matmarex) > This might be the same issue as T177660, but that report focuses on small screens while the issue reported here does not depend on scre... [20:33:33] 10VisualEditor, 10Discovery-Search, 10MediaWiki-Search: File search only returns word matches - https://phabricator.wikimedia.org/T207875 (10matmarex) See also T212502 for the specific use-case of copy-pasting an entire file name into VE's media search to insert that file. [20:35:09] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide option in media insertion dialog to only show local media - https://phabricator.wikimedia.org/T61862 (10matmarex) [20:35:12] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Support file: local: search limiting in the Media dialog search results - https://phabricator.wikimedia.org/T165630 (10matmarex) [20:35:39] 10VisualEditor, 10Discovery-Search, 10MediaWiki-Search: File search only returns word matches - https://phabricator.wikimedia.org/T207875 (10matmarex) [20:35:44] 10VisualEditor, 10CirrusSearch, 10Discovery, 10Discovery-Search: Available image not offered as type-ahead search result under VisualEditor's "Insert->Media" - https://phabricator.wikimedia.org/T188236 (10matmarex) [20:36:04] 10VisualEditor, 10CirrusSearch, 10Discovery, 10Discovery-Search: Available image not offered as type-ahead search result under VisualEditor's "Insert->Media" (search only returns word matches) - https://phabricator.wikimedia.org/T188236 (10matmarex) [20:42:19] 10VisualEditor: 'insert media' in visual editor should support filenames - https://phabricator.wikimedia.org/T212502 (10matmarex) > Currently, if the prefix is included, no results are found. I can't reproduce this. I just tried searching for "File:JuanGris.Portrait_of_Picasso.jpg" and got that file in the resu... [20:50:13] 10VisualEditor, 10VisualEditor-MediaWiki: Visual editor inserts extraneous blank lines (due to pulled out of paragraph and then disappearing) - https://phabricator.wikimedia.org/T197990 (10matmarex) [20:50:43] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Visual editor inserts extraneous blank lines (due to pulled out of paragraph and then disappearing) - https://phabricator.wikimedia.org/T197990 (10matmarex) [20:53:53] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Visual editor inserts extraneous blank lines (due to pulled out of paragraph and then disappearing) - https://phabricator.wikimedia.org/T197990 (10matmarex) The examples on this task so far have been mostly mistakes in syntax already present on... [22:30:33] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Verified, 10VisualEditor (Current work): Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10Ryasmeen)