[01:30:16] 10VisualEditor: [Epic] Make VE the default mobile editor on 3 wikis - https://phabricator.wikimedia.org/T221185 (10ppelberg) [10:30:50] (03PS1) 10VolkerE: Update OOUI to v0.31.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508802 [10:59:58] edsanders: is there anything left do in https://phabricator.wikimedia.org/T220227? [11:00:26] Jazmin needed? [11:01:10] same with https://phabricator.wikimedia.org/T163142? [11:25:11] (03PS2) 10Mobrovac: ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) [11:26:12] (03CR) 10Mobrovac: "> I think you'll want to look at ApiVisualEditor(Edit).php too" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [11:26:53] (03CR) 10jerkins-bot: [V: 04-1] ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [11:30:14] (03PS3) 10Mobrovac: ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) [11:52:22] (03CR) 10Mobrovac: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [12:00:21] (03PS12) 10Mvolz: [WIP] Remove dependancy on VE, add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) [12:03:39] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Remove dependancy on VE, add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) (owner: 10Mvolz) [14:36:26] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10JTannerWMF) [14:36:35] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, and 2 others: Bits of WikiEditor UI being shown when following red link in WTE2017 - https://phabricator.wikimedia.org/T211898 (10JTannerWMF) [14:39:00] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Verified, 10VisualEditor (Current work): Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10JTannerWMF) [15:37:55] (03CR) 10Jforrester: [C: 03+2] Update OOUI to v0.31.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508802 (owner: 10VolkerE) [15:39:27] (03Merged) 10jenkins-bot: Update OOUI to v0.31.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508802 (owner: 10VolkerE) [15:40:55] (03CR) 10jenkins-bot: Update OOUI to v0.31.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508802 (owner: 10VolkerE) [15:54:07] 10VisualEditor-MediaWiki, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10VisualEditor (Current work): Page notices hidden behind toolbar dialogs - https://phabricator.wikimedia.org/T222427 (10Jdforrester-WMF) [16:11:20] (03PS1) 10DLynch: tdDialog: handle name/alias swaps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) [16:11:59] 10TemplateData, 10Patch-For-Review, 10VisualEditor (Current work): In TemplateData param editor, typing a name equal to alias definitely disable Done button - https://phabricator.wikimedia.org/T222543 (10DLynch) a:03DLynch [16:24:25] (03CR) 10jerkins-bot: [V: 04-1] tdDialog: handle name/alias swaps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) (owner: 10DLynch) [16:25:51] (03PS2) 10DLynch: tdDialog: handle name/alias swaps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) [16:27:47] Trying to install nodejs in heroku based on those instructions. Everything is successful however I get an "access forbidden" error when I visit the heroku app page. I've checked the talk page and more people have this problem. Actually the most recent comment on that thread (user Br shadow) is mine :( Any ideas? I really want to use the visual editor in my wiki [16:27:54] https://www.mediawiki.org/wiki/Talk:VisualEditor/Installation_on_a_shared_host [16:32:37] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10Esanders) "This does not fix the rendering of new or modified interwiki links, which will... [16:36:32] (03CR) 10Esanders: [C: 04-1] tdDialog: handle name/alias swaps (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) (owner: 10DLynch) [16:44:23] (03CR) 10DLynch: tdDialog: handle name/alias swaps (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) (owner: 10DLynch) [16:47:01] (03CR) 10DLynch: tdDialog: handle name/alias swaps (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) (owner: 10DLynch) [16:52:58] (03CR) 10Esanders: [C: 03+2] ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [16:53:13] (03CR) 10Esanders: [C: 03+2] ve.ce.FocusableNode: Prevent native selection from changing on click [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508700 (https://phabricator.wikimedia.org/T108013) (owner: 10Bartosz Dziewoński) [16:54:45] (03Merged) 10jenkins-bot: ve.ce.FocusableNode: Prevent native selection from changing on click [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508700 (https://phabricator.wikimedia.org/T108013) (owner: 10Bartosz Dziewoński) [16:56:07] (03CR) 10jenkins-bot: ve.ce.FocusableNode: Prevent native selection from changing on click [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/508700 (https://phabricator.wikimedia.org/T108013) (owner: 10Bartosz Dziewoński) [17:00:44] (03CR) 10Esanders: [C: 04-1] "When you double click we use 'getOffsetFromEventCoords' to place the cursor at the mouse. We should do the same here for single click inst" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [17:08:01] (03Merged) 10jenkins-bot: ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [17:09:39] (03CR) 10jenkins-bot: ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508518 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [17:11:08] (03PS1) 10Mobrovac: ArticleTargetLoader: Add `stash=true` query param to RB HTML fetching [extensions/VisualEditor] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508867 (https://phabricator.wikimedia.org/T222639) [17:18:00] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Would it be possible for the cite templates in VE to use the date format specified in the article for date parameters? - https://phabricator.wikimedia.org/T205682 (10JTannerWMF) @marcella will follow up on this ticket with @mvolz to determine the... [17:24:31] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Would it be possible for the cite templates in VE to use the date format specified in the article for date parameters? - https://phabricator.wikimedia.org/T205682 (10Mvolz) 05Open→03Declined [17:25:28] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Would it be possible for the cite templates in VE to use the date format specified in the article for date parameters? - https://phabricator.wikimedia.org/T205682 (10Mvolz) The cs1 module on en wiki recently changed to sniff these templates in th... [17:25:59] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Ensure CTRL-V paste works as expected in text editing mode - https://phabricator.wikimedia.org/T218820 (10JTannerWMF) a:03ppelberg [17:28:45] (03CR) 10Mobrovac: "Added to the EU SWAT deployment window for 2019-05-13 (Monday)" [extensions/VisualEditor] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508867 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [17:29:04] (03CR) 10Mobrovac: "recheck" [extensions/VisualEditor] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508867 (https://phabricator.wikimedia.org/T222639) (owner: 10Mobrovac) [17:34:39] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), and 2 others: Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10dom_walden) If I try to load visual editor on a page from which I am blocked, I get: >... [17:39:57] 10VisualEditor: Warn user if they set the whole page to a different language - https://phabricator.wikimedia.org/T222251 (10JTannerWMF) Hey @Whatamidoing-WMF how common is this? [17:40:56] 10VisualEditor: Warn user if they set the whole page to a different language - https://phabricator.wikimedia.org/T222251 (10JTannerWMF) a:03ppelberg [17:41:43] 10Editing-team, 10Performance-Team (Radar): Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook) - https://phabricator.wikimedia.org/T222828 (10Krinkle) [17:41:56] 10VisualEditor: Warn user if they set the whole page to a different language - https://phabricator.wikimedia.org/T222251 (10Esanders) We should probably have some help text given that this is a bit of a unusual tool, but I haven't seen this happen often and the tool is suitably hidden away. [17:42:43] 10Editing-team, 10Performance-Team (Radar): Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook) - https://phabricator.wikimedia.org/T222828 (10Krinkle) [17:44:18] 10Editing-team, 10Performance-Team (Radar): Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook) - https://phabricator.wikimedia.org/T222828 (10Krinkle) [17:50:40] 10Citoid, 10VisualEditor: Sometimes an ISBN turns up wrapped in nowiki-tags - https://phabricator.wikimedia.org/T219627 (10Esanders) @jeblad It is detected by Parsoid because it scans the entire document again. Similarly with links it would anything that might get autolinked by wikitext rules but was... [17:53:10] 10VisualEditor, 10Editing Design, 10Section Editing: Editor wants to quickly move back to whole page editing - https://phabricator.wikimedia.org/T219812 (10JTannerWMF) This ticket needs to be linked to the Section Editing Desktop ticket [17:57:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635 (10JTannerWMF) @ssastry we are moving this to external on our board and tagging parsoid based on the code. [18:03:24] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOUI, 10Patch-For-Review: BookletLayout is unusable on mobile - https://phabricator.wikimedia.org/T209912 (10JTannerWMF) Just want to check in with @Volker_E and @iamjessklein to understand what is blocking the patch above from @matmarex being released? [18:08:09] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10VisualEditor (Current work): [Section Editing] Research Performance Time SPIKE - https://phabricator.wikimedia.org/T217564 (10JTannerWMF) [18:09:10] 10VisualEditor: [EPIC: Focus] Isolate Section Editing - https://phabricator.wikimedia.org/T209955 (10ppelberg) [18:09:15] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10VisualEditor (Current work): [Section Editing] Research Performance Time SPIKE - https://phabricator.wikimedia.org/T217564 (10ppelberg) 05Open→03Resolved We'll continue this conversation in the context of our [QA on mobile discussion](https://docs.goo... [18:16:30] 10VisualEditor: &veaction=edit no longer overrides namespace settings (can't edit global sandbox page using VE) - https://phabricator.wikimedia.org/T221892 (10matmarex) We talked about this within the team during a planning meeting. We're reluctant, but not opposed :), to implementing that whitelist or allowing... [18:16:32] 10VisualEditor, 10Editing Design: [EPIC] Toolbar improvements - https://phabricator.wikimedia.org/T211255 (10ppelberg) [18:16:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing: [Section Editing] New feature request: add sections while editing - https://phabricator.wikimedia.org/T217563 (10ppelberg) [18:22:15] 10VisualEditor, 10MobileFrontend: Consider adding a button to let users edit the whole page in MobileFrontend - https://phabricator.wikimedia.org/T203151 (10matmarex) [18:22:32] 10VisualEditor, 10Editing Design, 10MobileFrontend: Consider adding a button to let users edit the whole page in MobileFrontend - https://phabricator.wikimedia.org/T203151 (10JTannerWMF) Hey @iamjessklein we need your input on this, @DLynch said this would be easy to implement but we just need to figure out... [18:26:01] 10VisualEditor, 10Editing Design, 10MobileFrontend: Consider adding a button to let users edit the whole page in MobileFrontend - https://phabricator.wikimedia.org/T203151 (10matmarex) The same idea is mentioned as a part of T210659: >* Edit >** Clicking edit will open the editing for the entire article S... [18:27:13] 10VisualEditor, 10Editing Design, 10Section Editing: Editor wants to quickly move back to whole page editing - https://phabricator.wikimedia.org/T219812 (10matmarex) >>! In T219812#5168150, @JTannerWMF wrote: > This ticket needs to be linked to the Section Editing Desktop ticket T221908 [18:49:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid-Edit-Support: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead - https://phabricator.wikimedia.org/T103635 (10ssastry) [18:49:37] (03PS1) 10Esanders: Link inspector: Pass new 'showInterwikis' option to title widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508891 (https://phabricator.wikimedia.org/T222831) [18:53:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10OOUI, 10Patch-For-Review: BookletLayout is unusable on mobile - https://phabricator.wikimedia.org/T209912 (10Volker_E) @JTannerWMF I've identified an issue in my last test of the patch, shared at T209911#4999438 [19:21:46] (03CR) 10Jforrester: [C: 03+2] Link inspector: Pass new 'showInterwikis' option to title widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508891 (https://phabricator.wikimedia.org/T222831) (owner: 10Esanders) [19:24:36] (03CR) 10VolkerE: [C: 03+1] Replace usage of deprecated ConfigFactory::getDefaultInstance() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 (owner: 10D3r1ck01) [19:46:38] (03Merged) 10jenkins-bot: Link inspector: Pass new 'showInterwikis' option to title widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508891 (https://phabricator.wikimedia.org/T222831) (owner: 10Esanders) [19:48:33] (03CR) 10jenkins-bot: Link inspector: Pass new 'showInterwikis' option to title widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508891 (https://phabricator.wikimedia.org/T222831) (owner: 10Esanders) [19:58:14] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), and 2 others: Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10matmarex) Looks like this method has been removed in (03PS1) 10Bartosz Dziewoński: ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508915 (https://phabricator.wikimedia.org/T209599) [20:35:44] (03CR) 10Reedy: [C: 04-1] "Needs MW version requirement bumping to >= 1.34.0 in extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508915 (https://phabricator.wikimedia.org/T209599) (owner: 10Bartosz Dziewoński) [20:36:56] (03PS2) 10Bartosz Dziewoński: ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508915 (https://phabricator.wikimedia.org/T209599) [20:37:22] (03CR) 10Reedy: [C: 03+2] ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508915 (https://phabricator.wikimedia.org/T209599) (owner: 10Bartosz Dziewoński) [20:57:09] MatmaRex: That's a train blocker, right? The MW core change landed in wmf.4. [20:58:04] James_F: i want to backport it, yeah [20:58:23] i'm just waiting for the blasted thing to merge so that i get the pretty commit message when cherry-picking [20:58:37] Yeah. [20:58:43] I'll sling it out as soon as it's minted. [21:12:19] (03Merged) 10jenkins-bot: ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508915 (https://phabricator.wikimedia.org/T209599) (owner: 10Bartosz Dziewoński) [21:12:35] (03PS1) 10Jforrester: ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508941 (https://phabricator.wikimedia.org/T209599) [21:12:41] (03CR) 10Jforrester: [C: 03+2] ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508941 (https://phabricator.wikimedia.org/T209599) (owner: 10Jforrester) [21:12:51] There we go. [21:13:57] (03CR) 10jenkins-bot: ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508915 (https://phabricator.wikimedia.org/T209599) (owner: 10Bartosz Dziewoński) [21:33:37] (03Merged) 10jenkins-bot: ApiVisualEditor: Fix use of getBlockInfo() [extensions/VisualEditor] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508941 (https://phabricator.wikimedia.org/T209599) (owner: 10Jforrester) [21:41:34] James_F: thanks :o [21:41:57] James_F: not live yet, is it? [21:42:35] MatmaRex: No, ComTech are trying to deploy something. [21:43:07] okay [22:07:51] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace usage of deprecated ConfigFactory::getDefaultInstance() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 (owner: 10D3r1ck01) [22:19:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: External links look like interwiki links in preview - https://phabricator.wikimedia.org/T187571 (10matmarex) I don't think this was actually a duplicate of T185083. But it seems to be resolved now, thanks to Parsoid changes from T58756. [22:20:45] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10matmarex) > Esanders merged a task: {T187571}. I don't think that was actually a duplica... [22:23:03] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix initial rendering of interwiki links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508693 (https://phabricator.wikimedia.org/T185083) (owner: 10Esanders) [22:27:33] (03Merged) 10jenkins-bot: Replace usage of deprecated ConfigFactory::getDefaultInstance() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 (owner: 10D3r1ck01) [22:29:14] (03CR) 10jenkins-bot: Replace usage of deprecated ConfigFactory::getDefaultInstance() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504901 (owner: 10D3r1ck01) [22:33:34] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10matmarex) [22:42:03] (03Merged) 10jenkins-bot: Fix initial rendering of interwiki links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508693 (https://phabricator.wikimedia.org/T185083) (owner: 10Esanders) [22:43:01] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10matmarex) [22:43:34] (03CR) 10jenkins-bot: Fix initial rendering of interwiki links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/508693 (https://phabricator.wikimedia.org/T185083) (owner: 10Esanders) [22:45:23] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10matmarex) [22:46:46] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10matmarex) I made a pretty table and added a case that covers T187692, since it was merged... [22:49:47] MatmaRex: Ha! I was thinking about re-arranging into a table but I was busy. Nice work. [22:50:57] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10Jdforrester-WMF) [22:51:36] James_F: thanks. phab's table syntax is a travesty [22:51:37] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083 (10matmarex) [22:52:03] MatmaRex: It reminds me of wikitext's. ;-) [22:52:31] James_F: it is so, so much worse. in wikitext at least you can have multi-line content in cells, and you can put each cell on a separate line too. [22:53:23] wikitext encourages big tables, true. I'm not sure that's a benefit, seeing how much it's abused. [22:53:25] James_F: and the syntax for header cells, as crazy as it is, is a lot more sane than phab's [22:53:34] That one I'll give you. [22:55:19] i've had cases where i wanted to put a screenshot and a description for it below in a table cell, and you basically can't [22:55:32] * MatmaRex grumbles [23:07:08] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 2 others: Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10matmarex) @dom_walden Thank you for noticing this! It should be displaying an appropri... [23:13:44] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508651 (owner: 10Jforrester) [23:15:32] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/508670 (owner: 10Jforrester) [23:31:56] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508651 (owner: 10Jforrester) [23:38:43] (03CR) 10Esanders: [C: 03+2] tdDialog: handle name/alias swaps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/508861 (https://phabricator.wikimedia.org/T222543) (owner: 10DLynch)