[07:00:41] 10VisualEditor, 10Parsoid, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), and 5 others: Consider stashing data-parsoid for VE - https://phabricator.wikimedia.org/T215956 (10mobrovac) [10:09:52] (03PS1) 10Esanders: MWEditSummaryWidget: Use showSuggestionsOnFocus flag [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512343 (https://phabricator.wikimedia.org/T169484) [10:11:39] (03PS2) 10Esanders: 'scrollCursorIntoView' -> 'scrollSelectionIntoView' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502197 [10:12:09] (03CR) 10Esanders: "Ready to merge" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502197 (owner: 10Esanders) [10:15:45] (03PS8) 10Esanders: Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) [10:16:41] 10VisualEditor, 10VisualEditor-Media: UploadStashFileException when uploading image in Visual Editor - https://phabricator.wikimedia.org/T224275 (10Czech.Fox) [10:23:09] (03CR) 10Esanders: [C: 03+2] "We should upstream the mobile transition stuff to OOUI, and also remove the scale(0.5) -> scale(1) transition, so it's a simple fade and s" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512248 (owner: 10Bartosz Dziewoński) [10:24:32] (03Merged) 10jenkins-bot: ve.ui.Surface: Remove unneeded code handling mobile dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512248 (owner: 10Bartosz Dziewoński) [10:25:49] (03CR) 10jenkins-bot: ve.ui.Surface: Remove unneeded code handling mobile dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512248 (owner: 10Bartosz Dziewoński) [10:33:18] 10VisualEditor, 10OOUI, 10Design: Evaluate mobile dialog transitions - https://phabricator.wikimedia.org/T224277 (10Esanders) [12:04:37] 10VisualEditor, 10OOUI, 10Design: Evaluate mobile dialog transitions - https://phabricator.wikimedia.org/T224277 (10Esanders) In material design, full screen dialogs grow from the tap point (might be quite fiddly to do that in CSS) and when closed, slide down: https://material.io/design/components/dialogs.ht... [12:25:28] (03PS5) 10Esanders: WIP Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) [12:37:17] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10VisualEditor (Current work): VisualEditor loading indicator should feel more integrated into the mobile interface - https://phabricator.wikimedia.org/T1181 (10Esanders) Looking at the animation again, I see that have... [12:51:20] 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): Page zooms slightly when focusing document on iPhone Chrome - https://phabricator.wikimedia.org/T216446 (10Esanders) The only way to fix the caption issue would be to make the font size larger, either on load or... [12:54:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10Esanders) > ###High priority > - [ ]Scrolling a ProcessDialog scrolls the page behind on iOS Safari T212159 @matmarex in investigating, but every idea we've had so far has sig... [13:26:02] 10VisualEditor-MediaWiki, 10Verified, 10VisualEditor (Current work): Education dots rendering issues - https://phabricator.wikimedia.org/T214203 (10Esanders) You are using a high DPI display (mac) so the rendering is different. I tried 200% zoom in Chrome and they still look round to me. Which browser is thi... [13:32:27] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10VisualEditor (Current work): Mobile table editing should default to cell contents - https://phabricator.wikimedia.org/T211240 (10Esanders) > On mobile we only have this popup now -- I suggested removing the con... [13:38:21] (03PS1) 10Esanders: Don't show mobile table context on desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512364 (https://phabricator.wikimedia.org/T211240) [15:40:14] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile: Selection experiment: Deactivate selection on scroll past viewport - https://phabricator.wikimedia.org/T220634 (10Esanders) The proposal states that we don't deactivate the selection until the entire thing is off screen, which i... [16:22:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (68b031087) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512305 (https://phabricator.wikimedia.org/T224255) (owner: 10Jforrester) [16:22:04] (03CR) 10Bartosz Dziewoński: [C: 03+2] 'scrollCursorIntoView' -> 'scrollSelectionIntoView' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502197 (owner: 10Esanders) [16:23:23] (03CR) 10Bartosz Dziewoński: "Perhaps, I'm not really sure why we have a different transition here…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512248 (owner: 10Bartosz Dziewoński) [16:23:57] (03CR) 10Jforrester: [C: 03+2] Don't show mobile table context on desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512364 (https://phabricator.wikimedia.org/T211240) (owner: 10Esanders) [16:24:44] (03CR) 10Bartosz Dziewoński: "Ah, I see you filed T224277." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512248 (owner: 10Bartosz Dziewoński) [16:25:54] (03Merged) 10jenkins-bot: Don't show mobile table context on desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512364 (https://phabricator.wikimedia.org/T211240) (owner: 10Esanders) [16:27:16] (03CR) 10jenkins-bot: Don't show mobile table context on desktop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512364 (https://phabricator.wikimedia.org/T211240) (owner: 10Esanders) [16:36:15] (03PS7) 10Bartosz Dziewoński: Allow switching from WTE to VE with changes in non-RESTBase mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507711 (https://phabricator.wikimedia.org/T214542) [16:38:10] (03PS8) 10Bartosz Dziewoński: Allow switching from WTE to VE with changes in non-RESTBase mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507711 (https://phabricator.wikimedia.org/T214542) [16:39:13] (03Merged) 10jenkins-bot: Update VE core submodule to master (68b031087) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512305 (https://phabricator.wikimedia.org/T224255) (owner: 10Jforrester) [16:40:34] (03Merged) 10jenkins-bot: 'scrollCursorIntoView' -> 'scrollSelectionIntoView' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502197 (owner: 10Esanders) [16:40:38] (03CR) 10Bartosz Dziewoński: [C: 03+2] MWInternalLinkAnnotation: handle non-internal links that say they're mw:WikiLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510222 (https://phabricator.wikimedia.org/T223322) (owner: 10DLynch) [16:41:13] (03CR) 10jenkins-bot: Update VE core submodule to master (68b031087) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512305 (https://phabricator.wikimedia.org/T224255) (owner: 10Jforrester) [16:41:32] (03CR) 10Bartosz Dziewoński: "Oops, I didn't realize there was a failure, fixed now. This is waiting for reviews." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507711 (https://phabricator.wikimedia.org/T214542) (owner: 10Bartosz Dziewoński) [16:42:21] (03CR) 10jenkins-bot: 'scrollCursorIntoView' -> 'scrollSelectionIntoView' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/502197 (owner: 10Esanders) [16:54:17] (03Merged) 10jenkins-bot: MWInternalLinkAnnotation: handle non-internal links that say they're mw:WikiLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510222 (https://phabricator.wikimedia.org/T223322) (owner: 10DLynch) [16:56:03] (03CR) 10jenkins-bot: MWInternalLinkAnnotation: handle non-internal links that say they're mw:WikiLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510222 (https://phabricator.wikimedia.org/T223322) (owner: 10DLynch) [16:58:23] (03PS1) 10Jforrester: Update VE core submodule to master (3c069c39f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512400 (https://phabricator.wikimedia.org/T211240) [17:10:54] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (3c069c39f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512400 (https://phabricator.wikimedia.org/T211240) (owner: 10Jforrester) [17:24:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (3c069c39f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512400 (https://phabricator.wikimedia.org/T211240) (owner: 10Jforrester) [17:27:01] (03CR) 10jenkins-bot: Update VE core submodule to master (3c069c39f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512400 (https://phabricator.wikimedia.org/T211240) (owner: 10Jforrester) [17:42:42] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Waiting for OOUI update." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512343 (https://phabricator.wikimedia.org/T169484) (owner: 10Esanders) [18:43:40] 10VisualEditor, 10Wikimedia-Site-requests, 10Community-consensus-needed: Enable signature button on meta in main space - https://phabricator.wikimedia.org/T211878 (10Urbanecm) 05Open→03Invalid User is disabled and anyone else is unlikely to provide a community consensus link. Closing as invalid, then. [20:05:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] Special-case redlink URLs to load preferred editor (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/511315 (https://phabricator.wikimedia.org/T223793) (owner: 10Esanders) [20:12:30] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Remove confirm dialogs (prompts) when switching between VE and 2010 wikitext editor with changes - https://phabricator.wikimedia.org/T220007 (10Jdforrester-WMF) a:03Esanders [20:17:22] (03PS6) 10Esanders: Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) (owner: 10Divec) [20:18:18] (03CR) 10Esanders: [C: 03+2] Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) (owner: 10Divec) [20:19:40] (03Merged) 10jenkins-bot: Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) (owner: 10Divec) [20:21:22] (03CR) 10jenkins-bot: Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) (owner: 10Divec) [20:33:56] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-notice, 10VisualEditor (Current work): On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used) - https://phabricator.wikimedia.org/T223793 (10matmarex) We should announce this, the change has b... [21:08:11] 10VisualEditor, 10VisualEditor-MediaWiki: [regression] Editor is read-only after recovering autosaved changes - https://phabricator.wikimedia.org/T224319 (10matmarex) [21:10:20] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): [regression] Editor is read-only after recovering autosaved changes - https://phabricator.wikimedia.org/T224319 (10matmarex) a:03matmarex Caused by {b9835f75d32a30b65729a3d8453b690b2e5b8800} [21:16:04] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): [regression] Editor is read-only after recovering autosaved changes - https://phabricator.wikimedia.org/T224319 (10matmarex) Also, when switching from VE to NWE, it is also read-only. [21:16:26] (03PS1) 10Bartosz Dziewoński: Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512438 (https://phabricator.wikimedia.org/T224319) [21:18:32] (03CR) 10Bartosz Dziewoński: "Looks like 'blockinfo' need not be stored, as the editor will not even open (on mobile) when that is set." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512438 (https://phabricator.wikimedia.org/T224319) (owner: 10Bartosz Dziewoński) [21:19:39] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): [regression] Editor is read-only after recovering autosaved changes or switching VE to NWE - https://phabricator.wikimedia.org/T224319 (10matmarex) [21:19:41] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): [regression] Editor is read-only after recovering autosaved changes or switching VE to NWE - https://phabricator.wikimedia.org/T224319 (10matmarex) Looks like this made it into wmf.6… :/ we should backport on Monday. [21:21:06] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): [regression] Editor is read-only after recovering autosaved changes or switching VE to NWE - https://phabricator.wikimedia.org/T224319 (10matmarex) p:05Triage→03Unbreak! [21:23:51] (03CR) 10Bartosz Dziewoński: "Caused T224319: we need to preserve this when autosaving or switching editors, otherwise the editor will go read-only. Follow-up: https://" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/511047 (https://phabricator.wikimedia.org/T111217) (owner: 10Bartosz Dziewoński) [21:33:54] (03CR) 10Esanders: [C: 03+2] Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512438 (https://phabricator.wikimedia.org/T224319) (owner: 10Bartosz Dziewoński) [21:39:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10ppelberg) >>! In T96289#5162884, @matmarex wrote: > If we're definitely doing ~~T204733~~ T221247, then maybe we should just wait for tha... [21:51:36] (03Merged) 10jenkins-bot: Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512438 (https://phabricator.wikimedia.org/T224319) (owner: 10Bartosz Dziewoński) [21:53:19] (03CR) 10jenkins-bot: Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512438 (https://phabricator.wikimedia.org/T224319) (owner: 10Bartosz Dziewoński) [22:04:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10ppelberg) >>! In T221328#5206882, @matmarex wrote: > (I marked tasks which had patches merged and are now in QA or product review) This is helpful, @matmarex – thank you for... [22:21:03] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Slight flicker in iOS Safari when cursor is placed past the first page of the document - https://phabricator.wikimedia.org/T224322 (10ppelberg) [22:28:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Slight flicker in iOS Safari when cursor is placed past the first page of the document - https://phabricator.wikimedia.org/T224322 (10ppelberg) I have //not// yet been able to reproduce the issue first raised in T196839#5178009 and now represented by this ticket... [22:49:24] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10ppelberg... [23:00:57] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10ppelberg... [23:05:42] 10VisualEditor-MediaWiki, 10Skipped QA, 10VisualEditor (Current work): VE doesn't let you enable it in namespaces whose labels happen to be ints - https://phabricator.wikimedia.org/T219562 (10ppelberg) 05Open→03Resolved [23:07:40] 10VisualEditor-EditingTools, 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): VisualEditor: Image should not change size when going from read to edit - https://phabricator.wikimedia.org/T69047 (10ppelberg) 05Open→03Resolved [23:09:23] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10MinervaNeue (Desktop), 10Verified, 10VisualEditor (Current work): Improve compatibility of desktop VisualEditor with desktop Minerva skin - https://phabricator.wikimedia.org/T208102 (10ppelberg) 05Open→03Resolved [23:11:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Section Editing: [Engineering EPIC]: Isolate Section Editing - https://phabricator.wikimedia.org/T209987 (10ppelberg) [23:11:18] 10VisualEditor-MediaWiki-Mobile, 10Section Editing, 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Restore section hash fragment after section editing in mobile VE - https://phabricator.wikimedia.org/T213120 (10ppelberg) 05Open→03Resolved [23:14:46] 10VisualEditor-ContentEditable, 10Skipped QA, 10VisualEditor (Current work): Deactivated selection out of position when window resized - https://phabricator.wikimedia.org/T219916 (10ppelberg) 05Open→03Resolved [23:43:29] (03PS1) 10Jforrester: Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/512448 (https://phabricator.wikimedia.org/T224319) [23:43:36] (03CR) 10Jforrester: [C: 03+2] Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/512448 (https://phabricator.wikimedia.org/T224319) (owner: 10Jforrester) [23:56:18] (03Merged) 10jenkins-bot: Store 'canEdit' property when auto-saving or switching editors [extensions/VisualEditor] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/512448 (https://phabricator.wikimedia.org/T224319) (owner: 10Jforrester)