[00:38:51] 10Cite, 10CX-out-of-beta, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21): CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Petar.petkovic) a:05Petar.petkovic→03None [01:10:17] 10Citoid: Remove leading PMC from PMC field - https://phabricator.wikimedia.org/T224004 (10Antigng) The cause of this problem has been identified. [[https://github.com/wikimedia/citoid/blob/master/lib/Exporter.js#L127|Given that]] ` const rePMCID = new RegExp('\\bPMC\\d{7}\\b'); ` If [[https://github.com/wikime... [07:00:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512846 (owner: 10L10n-bot) [11:13:03] (03PS11) 10Esanders: Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) [11:13:05] (03PS21) 10Esanders: WIP Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) (owner: 10Jforrester) [11:13:09] (03PS20) 10Esanders: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [11:13:11] (03PS4) 10Esanders: Update to Unicode 11.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/456121 [11:13:13] (03PS1) 10Esanders: build: Update eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/512880 [11:13:15] (03PS1) 10Esanders: Update to Unicode 12.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/512881 [11:13:54] (03CR) 10jerkins-bot: [V: 04-1] Update to Unicode 11.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/456121 (owner: 10Esanders) [11:19:30] (03PS1) 10Esanders: Add official grapheme break tests [unicodejs] - 10https://gerrit.wikimedia.org/r/512882 [11:30:55] (03PS12) 10Esanders: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) [11:30:57] (03PS2) 10Esanders: Add official grapheme break tests [unicodejs] - 10https://gerrit.wikimedia.org/r/512882 [11:30:59] (03PS22) 10Esanders: WIP Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) (owner: 10Jforrester) [11:31:01] (03PS21) 10Esanders: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [11:31:03] (03PS5) 10Esanders: Update to Unicode 11.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/456121 [11:31:05] (03PS2) 10Esanders: Update to Unicode 12.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/512881 [11:31:42] (03CR) 10jerkins-bot: [V: 04-1] WIP Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) (owner: 10Jforrester) [11:31:48] (03CR) 10jerkins-bot: [V: 04-1] Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [11:31:50] (03CR) 10jerkins-bot: [V: 04-1] Update to Unicode 11.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/456121 (owner: 10Esanders) [11:32:02] (03CR) 10jerkins-bot: [V: 04-1] Update to Unicode 12.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/512881 (owner: 10Esanders) [11:42:40] (03CR) 10Esanders: "NB: VisualEditor is already storing data as code units, so this is not a breaking change for VE." [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [11:52:32] (03CR) 10Divec: [C: 03+2] build: Update eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/512880 (owner: 10Esanders) [11:52:59] (03Merged) 10jenkins-bot: build: Update eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/512880 (owner: 10Esanders) [11:53:24] (03CR) 10jenkins-bot: build: Update eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/512880 (owner: 10Esanders) [12:26:40] (03PS13) 10Esanders: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) [12:26:42] (03PS3) 10Esanders: Add official grapheme break tests [unicodejs] - 10https://gerrit.wikimedia.org/r/512882 [12:26:44] (03PS23) 10Esanders: Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) (owner: 10Jforrester) [12:26:46] (03PS22) 10Esanders: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 (owner: 10Jforrester) [12:26:48] (03PS6) 10Esanders: Update to Unicode 11.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/456121 [12:26:50] (03PS3) 10Esanders: Update to Unicode 12.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/512881 [12:36:38] (03PS14) 10Divec: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [12:37:01] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [13:43:05] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-notice, 10VisualEditor (Current work): On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used) - https://phabricator.wikimedia.org/T223793 (10Johan) @matmarex Added to https://meta.wikimedia.or... [14:06:55] (03PS15) 10Divec: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [14:07:34] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [14:08:00] (03PS16) 10Divec: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [14:08:25] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [14:09:17] (03PS17) 10Divec: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [14:13:09] (03CR) 10Divec: [C: 03+1] "+2 to the parts I didn't write" (032 comments) [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [14:19:13] (03CR) 10DLynch: [C: 03+2] Use nullSelectionOnBlur when section=new [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512659 (owner: 10Esanders) [14:27:17] (03PS4) 10Jforrester: Add official grapheme break tests [unicodejs] - 10https://gerrit.wikimedia.org/r/512882 (owner: 10Esanders) [14:28:23] (03PS24) 10Jforrester: Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) [14:28:28] (03PS23) 10Jforrester: Update to Unicode 10.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/390022 [14:28:40] (03PS7) 10Jforrester: Update to Unicode 11.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/456121 (owner: 10Esanders) [14:28:45] (03PS4) 10Jforrester: Update to Unicode 12.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/512881 (owner: 10Esanders) [14:29:08] (03CR) 10Jforrester: "This change is ready for review." [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) (owner: 10Jforrester) [14:37:51] (03Merged) 10jenkins-bot: Use nullSelectionOnBlur when section=new [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512659 (owner: 10Esanders) [14:39:38] (03CR) 10jenkins-bot: Use nullSelectionOnBlur when section=new [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512659 (owner: 10Esanders) [14:48:54] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:14:46] (03CR) 10Divec: [C: 03+1] "Ignore the specific comments above: they were sitting unsent in Gerrit for many months and are no longer relevant." [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [15:18:06] (03CR) 10Jforrester: [C: 03+1] "Let's go?" [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [15:28:43] (03CR) 10Esanders: [C: 03+2] [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [15:29:12] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [15:29:41] (03CR) 10jenkins-bot: [BREAKING CHANGE] Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [15:44:21] 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 10VisualEditor (Current work): Backspacing multiple VE paragraphs in Gboard causes model corruption - https://phabricator.wikimedia.org/T217223 (10Maintenance_bot) [16:48:20] (03CR) 10Jforrester: [C: 03+1] "Leaving to David to merge." [unicodejs] - 10https://gerrit.wikimedia.org/r/512882 (owner: 10Esanders) [17:46:42] (03PS1) 10Jforrester: Update VE core submodule to master (e3715c257) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512938 (https://phabricator.wikimedia.org/T217223) [17:48:35] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (e3715c257) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512938 (https://phabricator.wikimedia.org/T217223) (owner: 10Jforrester) [18:16:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (e3715c257) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512938 (https://phabricator.wikimedia.org/T217223) (owner: 10Jforrester) [18:18:25] (03CR) 10jenkins-bot: Update VE core submodule to master (e3715c257) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512938 (https://phabricator.wikimedia.org/T217223) (owner: 10Jforrester) [18:19:35] 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10VisualEditor (Current work): Page zooms slightly when focusing document on iPhone Chrome - https://phabricator.wikimedia.org/T216446 (10Esanders) Given Peter's video of the issue on an iPhone XS + Safari (https://www.yo... [19:14:42] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Editing timing data incorrect/meaningless when switching editor on mobile - https://phabricator.wikimedia.org/T220697 (10matmarex) [19:53:42] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10matmarex) >>! In T222315#5214568, @Esanders wrote: >> open WTE, switch to VE, make changes, quit... [20:06:49] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10matmarex) Tested everything again using the same method. The patch fixes all of the previous issues, but it breaks one... [20:42:38] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Conduct link label usability testing - https://phabricator.wikimedia.org/T224520 (10ppelberg) [20:42:57] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Conduct link label usability testing - https://phabricator.wikimedia.org/T224520 (10ppelberg) [20:44:50] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Conduct link label usability testing - https://phabricator.wikimedia.org/T224520 (10ppelberg) [20:45:02] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Conduct link label usability testing - https://phabricator.wikimedia.org/T224520 (10ppelberg) [21:07:26] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix find and replace selection handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512655 (https://phabricator.wikimedia.org/T222247) (owner: 10Esanders) [21:08:56] (03Merged) 10jenkins-bot: Fix find and replace selection handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512655 (https://phabricator.wikimedia.org/T222247) (owner: 10Esanders) [21:10:26] (03CR) 10jenkins-bot: Fix find and replace selection handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/512655 (https://phabricator.wikimedia.org/T222247) (owner: 10Esanders) [21:22:20] (03PS2) 10Bartosz Dziewoński: MobileArticleTarget: Prevent page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) [21:34:25] 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10VisualEditor (Current work): Page zooms slightly when focusing document on iPhone Chrome - https://phabricator.wikimedia.org/T216446 (10matmarex) The zoom controls can be changed dynamically, so if that's a problem, we... [22:09:05] 10VisualEditor, 10Wikimedia-Site-requests, 10Wiktionary, 10Patch-For-Review, 10User-Ryasmeen: Show both "edit" and "edit source" tabs/section edit links on the French Wiktionary - https://phabricator.wikimedia.org/T169741 (10matmarex) Could you please file one? I must admit I don't really understand what... [22:52:17] 10VisualEditor-MediaWiki, 10User-notice, 10VisualEditor (Current work): On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used) - https://phabricator.wikimedia.org/T223793 (10Jdforrester-WMF) Deployed. [23:05:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] Special-case redlink URLs to load preferred editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/511315 (https://phabricator.wikimedia.org/T223793) (owner: 10Esanders) [23:06:16] 10VisualEditor-MediaWiki, 10User-notice, 10VisualEditor (Current work): On non-SET wikis (two edit tabs), links to new pages (red links) should open the user's preferred editor (last used) - https://phabricator.wikimedia.org/T223793 (10matmarex) We can merge the code change now, too. [23:21:30] (03Merged) 10jenkins-bot: Special-case redlink URLs to load preferred editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/511315 (https://phabricator.wikimedia.org/T223793) (owner: 10Esanders) [23:23:25] (03CR) 10jenkins-bot: Special-case redlink URLs to load preferred editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/511315 (https://phabricator.wikimedia.org/T223793) (owner: 10Esanders)