[17:30:28] (03PS8) 10Esanders: WIP Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [18:48:03] 10VisualEditor: Getting two save dialogs when editing File pages on commons - https://phabricator.wikimedia.org/T225014 (10Esanders) [18:48:54] 10VisualEditor: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces - https://phabricator.wikimedia.org/T224923 (10DLynch) Alas, it doesn't. That said... possibly it's a useful bit of cleanup. This is actually fallout from the paste target not having a width, which cod... [18:53:17] (03PS1) 10DLynch: Avoid dialogs moving offscreen when pasting long unbroken text strings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514369 (https://phabricator.wikimedia.org/T224923) [18:54:51] (03CR) 10jerkins-bot: [V: 04-1] Avoid dialogs moving offscreen when pasting long unbroken text strings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514369 (https://phabricator.wikimedia.org/T224923) (owner: 10DLynch) [18:57:43] (03PS2) 10DLynch: Avoid dialogs moving offscreen when pasting long unbroken text strings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514369 (https://phabricator.wikimedia.org/T224923) [19:08:33] 10VisualEditor, 10MobileFrontend, 10SpamBlacklist: Spam links trigger unknown error on mobile - https://phabricator.wikimedia.org/T167078 (10matmarex) I tested this again. The behavior in mobile visual editor is still the same as @Deskana found in 2017 (T167078#3319983), and does not exhibit this issue. T... [19:10:55] 10VisualEditor: [Epic] Make VE the default mobile editor on select wikis - https://phabricator.wikimedia.org/T221185 (10matmarex) [19:10:57] 10VisualEditor, 10MobileFrontend, 10SpamBlacklist: Spam links trigger unknown error on mobile - https://phabricator.wikimedia.org/T167078 (10matmarex) [19:11:45] 10VisualEditor, 10MobileFrontend, 10SpamBlacklist: Spam links trigger unknown error on mobile - https://phabricator.wikimedia.org/T167078 (10matmarex) (talked to @ppelberg, removing as a blocker) [20:11:37] 10VisualEditor, 10OOUI: Distinguish "back" from "close" actions in OOUI dialogs - https://phabricator.wikimedia.org/T225021 (10Esanders) [20:13:07] 10VisualEditor, 10Patch-For-Review: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces - https://phabricator.wikimedia.org/T224923 (10DLynch) Bot didn't add the patch: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/514369 [20:13:44] 10VisualEditor, 10OOUI: Distinguish "back" from "close" actions in OOUI dialogs - https://phabricator.wikimedia.org/T225021 (10Esanders) [20:19:04] (03PS1) 10Bartosz Dziewoński: MobileArticleTarget: Remove duplicate way to trigger abandon warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514388 (https://phabricator.wikimedia.org/T222315) [20:19:06] (03PS1) 10Bartosz Dziewoński: MobileArticleTarget: Remove a method that just calls the parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514389 [20:24:09] (03PS3) 10Bartosz Dziewoński: Avoid dialogs moving offscreen when pasting long unbroken text strings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514369 (https://phabricator.wikimedia.org/T224923) (owner: 10DLynch) [20:29:14] (03CR) 10Esanders: [C: 03+2] MobileArticleTarget: Remove duplicate way to trigger abandon warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514388 (https://phabricator.wikimedia.org/T222315) (owner: 10Bartosz Dziewoński) [20:29:51] (03CR) 10Esanders: [C: 03+2] MobileArticleTarget: Remove a method that just calls the parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514389 (owner: 10Bartosz Dziewoński) [20:32:52] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10Patch-For-Review, 10VisualEditor (Current work): Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10matmarex) > (I tested the above by quitting the edi... [22:53:40] (03CR) 10Jforrester: "This change is ready for review." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 (https://phabricator.wikimedia.org/T185706) (owner: 10Divec) [22:53:47] (03CR) 10Jforrester: "Per Ed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 (https://phabricator.wikimedia.org/T185706) (owner: 10Divec) [22:53:59] (03CR) 10Jforrester: [C: 03+2] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 (https://phabricator.wikimedia.org/T185706) (owner: 10Divec) [22:55:32] (03Merged) 10jenkins-bot: Make undo concurrency-aware [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 (https://phabricator.wikimedia.org/T185706) (owner: 10Divec) [22:56:56] (03CR) 10jenkins-bot: Make undo concurrency-aware [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 (https://phabricator.wikimedia.org/T185706) (owner: 10Divec) [22:58:37] (03PS1) 10Jforrester: Update VE core submodule to master (2da36280a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514408 (https://phabricator.wikimedia.org/T185706) [22:59:15] (03PS2) 10Jforrester: CollabTarget: Enable undo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/513757 (owner: 10Esanders) [22:59:26] (03CR) 10Jforrester: [C: 03+2] CollabTarget: Enable undo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/513757 (owner: 10Esanders) [23:03:31] (03Merged) 10jenkins-bot: MobileArticleTarget: Remove duplicate way to trigger abandon warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514388 (https://phabricator.wikimedia.org/T222315) (owner: 10Bartosz Dziewoński) [23:08:00] (03CR) 10jenkins-bot: MobileArticleTarget: Remove duplicate way to trigger abandon warnings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514388 (https://phabricator.wikimedia.org/T222315) (owner: 10Bartosz Dziewoński) [23:19:28] (03Merged) 10jenkins-bot: MobileArticleTarget: Remove a method that just calls the parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514389 (owner: 10Bartosz Dziewoński) [23:24:16] (03CR) 10jenkins-bot: MobileArticleTarget: Remove a method that just calls the parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514389 (owner: 10Bartosz Dziewoński)