[06:31:25] 10VisualEditor, 10MW-1.33-release, 10Patch-For-Review: ConfigException from line 53 of "GlobalVarConfig.php": GlobalVarConfig::get: undefined option: 'EnableBlockNoticeStats' - https://phabricator.wikimedia.org/T225354 (10Kghbln) >>! In T225354#5248372, @matmarex wrote: > We can't currently merge the fixes b... [09:14:34] 10Citoid: Remove leading PMC from PMC field - https://phabricator.wikimedia.org/T224004 (10Mvolz) 05Resolved→03Open [09:22:15] 10Citoid, 10VisualEditor, 10User-Ryasmeen: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152 (10Mvolz) 05Resolved→03Open [11:07:15] (03PS1) 10Bartosz Dziewoński: Wait for window to be scrollable before trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) [13:18:14] (03CR) 10Esanders: Wait for window to be scrollable before trying to scroll to section (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [13:18:29] (03CR) 10Esanders: [C: 04-1] Wait for window to be scrollable before trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [13:18:47] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Design, 10VisualEditor (Current work): VisualEditor loading indicator should feel more integrated into the mobile interface - https://phabricator.wikimedia.org/T1181 (10iamjessklein) @matmarex what's the status of this now? [13:31:06] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Verified, 10VisualEditor (Current work): Ordered lists look broken in mobile VE - https://phabricator.wikimedia.org/T216792 (10ovasileva) [13:35:06] 10VisualEditor, 10Editing Design: Design a Test for prototype - https://phabricator.wikimedia.org/T211787 (10iamjessklein) Since we tested this already, I'm going to remove the editing design label and propose that this ticket gets closed cc/ @ppelberg [13:35:19] 10VisualEditor: Design a Test for prototype - https://phabricator.wikimedia.org/T211787 (10iamjessklein) [13:43:41] (03CR) 10Bartosz Dziewoński: "yes, al" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [13:43:51] (03PS2) 10Bartosz Dziewoński: Reorder calls so that window is scrollable when trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) [13:44:09] 10VisualEditor-MediaWiki-Links, 10VisualEditor (Current work): Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10iamjessklein) @Esanders implemented this as part of the prototype. Here's the screenshot of what it looks like. Note that since it's on the... [13:46:41] 10VisualEditor-MediaWiki-Links, 10VisualEditor (Current work): Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10Esanders) +1 [13:47:41] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [13:54:18] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [13:56:27] 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10iamjessklein) Considering the back and forth I propose that we close this and work directly on the prototype T221309. To push this fo... [14:12:10] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10iamjessklein) [15:20:41] 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) >>! In T220385#5249649, @iamjessklein wrote: > Considering the back and forth I propose that we close this and work directl... [15:22:57] 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) [15:23:04] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [15:23:10] 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) 05Open→03Resolved [15:24:18] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [15:24:42] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [15:27:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-Linter, 10User-Ryasmeen: Linter isn't highlighting text in 2017 WTE anymore - https://phabricator.wikimedia.org/T185279 (10matmarex) a:05Esanders→03matmarex [15:42:55] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10iamjessklein) I reviewed the latest version of what's up on the prototype server. The way that I reviewed it... [15:45:41] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [15:46:26] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [15:47:35] (03PS12) 10Esanders: WIP Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [15:47:36] (03PS6) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [16:12:32] (03PS13) 10Esanders: WIP Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [16:12:37] (03PS7) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [16:15:50] (03PS14) 10Esanders: WIP Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [16:15:55] (03PS8) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [16:16:05] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) > The little hair of the line in the segmented navigation to the left of the first item shouldn't b... [16:22:08] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) [16:22:29] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) [16:24:47] 10Citoid: Zotero/Citoid: various issues with translation in Template compatibility - https://phabricator.wikimedia.org/T225539 (10Arthur2e5) [16:26:13] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) Replying to @ppelberg in the description: 1 & 2 are fixed. 3 I can reproduce. Will investigate. 4 I... [16:27:43] 10Citoid: Zotero/Citoid: various issues with translation in Template compatibility - https://phabricator.wikimedia.org/T225539 (10Arthur2e5) [16:29:34] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) >>! In T221309#5250321, @Esanders wrote: > 3 I can reproduce. Will investigate. This is T221967, a... [16:30:06] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [16:53:20] 10VisualEditor: 'Change label' in link inspector broken when cursor is at end of link - https://phabricator.wikimedia.org/T225541 (10Esanders) [16:57:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: VE's advanced template dialog (transclusion dialog) is unusable on mobile - https://phabricator.wikimedia.org/T209909 (10matmarex) a:05iamjessklein→03None (We talked about this one today and it doesn't seem like we're going to wor... [16:57:13] 10VisualEditor, 10VisualEditor-MediaWiki: Page options dialog (meta dialog) is unavailable in mobile VE - https://phabricator.wikimedia.org/T209911 (10matmarex) a:05iamjessklein→03None (We talked about T209909 today and it doesn't seem like we're going to work on it anytime soon. The same probably applies... [17:07:24] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10iamjessklein) [17:17:08] (03PS15) 10Esanders: WIP Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [17:17:10] (03PS9) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [17:17:12] (03PS1) 10Esanders: Make annotationsAtModelSelection fail in fewer cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/516524 (https://phabricator.wikimedia.org/T225541) [17:19:17] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) 3. Should be fixed on the prototype server [17:38:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WTE up/down cursoring skips multiple empty lines - https://phabricator.wikimedia.org/T225546 (10Jdforrester-WMF) [18:04:41] 10Citoid, 10VisualEditor, 10Security-Team, 10Security-Team-Reviews, 10User-Ryasmeen: Security review of Citoid - https://phabricator.wikimedia.org/T98096 (10sbassett) [18:18:39] 10VisualEditor: Escalating whitespace before a category, increasing with each edit - https://phabricator.wikimedia.org/T225550 (10Catrope) [18:19:56] (03PS1) 10Bartosz Dziewoński: iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 [18:20:34] (03CR) 10Bartosz Dziewoński: "(feel free to merge this into your commit, or whatever is convenient)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 (owner: 10Bartosz Dziewoński) [18:22:00] 10VisualEditor, 10Parsoid: Escalating whitespace before a category, increasing with each edit - https://phabricator.wikimedia.org/T225550 (10matmarex) [18:24:49] (03CR) 10jerkins-bot: [V: 04-1] iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 (owner: 10Bartosz Dziewoński) [18:31:02] (03PS2) 10Bartosz Dziewoński: iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 [18:35:41] (03CR) 10jerkins-bot: [V: 04-1] iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 (owner: 10Bartosz Dziewoński) [19:17:39] 10Citoid, 10VisualEditor, 10Operations, 10Security-Team, and 4 others: http://citoid.wikimedia.org/ should force HTTPS - https://phabricator.wikimedia.org/T108632 (10sbassett) [19:22:37] 10VisualEditor, 10Parsoid, 10Regression: VisualEditor edits no longer preserve formatting of unchanged content - https://phabricator.wikimedia.org/T225559 (10Krinkle) [19:23:47] 10VisualEditor, 10Parsoid, 10Regression: VisualEditor edits no longer preserve formatting of unchanged content - https://phabricator.wikimedia.org/T225559 (10ssastry) [19:23:53] 10VisualEditor, 10Parsoid-Edit-Support, 10Patch-For-Review: VE on officewiki is removing spaces (dirty diffs) - https://phabricator.wikimedia.org/T225217 (10ssastry) [20:02:08] (03CR) 10Bartosz Dziewoński: [C: 03+2] Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [20:08:44] (03CR) 10Bartosz Dziewoński: "Looks like tests are broken on master for this extension?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [20:16:37] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) >>! In T221309#5250321, @Esanders wrote: > Replying to @ppelberg in the description: > 1 & 2 are fi... [20:17:06] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [20:20:11] (03CR) 10jerkins-bot: [V: 04-1] Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/485523 (owner: 10Fomafix) [20:22:22] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [20:35:41] (03CR) 10Bartosz Dziewoński: [C: 04-1] Remove switch confirm dialogs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [20:35:53] (03PS11) 10Bartosz Dziewoński: Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [20:37:27] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Everything seems to work fine for switching back and forth, with lossy/non-lossy switching, and when using mobile/NWE/OWE." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [20:42:03] (03PS2) 10Bartosz Dziewoński: Cleanup mwcore messages and dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516266 (owner: 10Esanders) [20:44:08] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Mobile edit cards: deploy "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [20:52:41] (03Merged) 10jenkins-bot: Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [20:55:08] (03CR) 10jenkins-bot: Remove switch confirm dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/505230 (https://phabricator.wikimedia.org/T220007) (owner: 10Esanders) [21:03:58] (03CR) 10Bartosz Dziewoński: [C: 03+2] Cleanup mwcore messages and dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516266 (owner: 10Esanders) [21:09:39] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10Contributors-Team, 10MobileFrontend, and 3 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10matmarex) (All subtasks are fixed, and in QA or product review) [21:10:17] (03CR) 10Jforrester: Cleanup mwcore messages and dependencies (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516266 (owner: 10Esanders) [21:17:08] (03Merged) 10jenkins-bot: Cleanup mwcore messages and dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516266 (owner: 10Esanders) [21:18:27] (03CR) 10jenkins-bot: Cleanup mwcore messages and dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516266 (owner: 10Esanders) [21:38:10] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' in link inspector broken when cursor is at end of link - https://phabricator.wikimedia.org/T225541 (10matmarex) [21:38:25] 10VisualEditor-MediaWiki, 10MW-1.33-release, 10Patch-For-Review, 10VisualEditor (Current work): ConfigException from line 53 of "GlobalVarConfig.php": GlobalVarConfig::get: undefined option: 'EnableBlockNoticeStats' - https://phabricator.wikimedia.org/T225354 (10matmarex) [21:38:35] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE always opens to the top of the page in non-section mode - https://phabricator.wikimedia.org/T225292 (10matmarex) [21:39:11] 10VisualEditor-CopyPaste, 10Patch-For-Review, 10VisualEditor (Current work): Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces - https://phabricator.wikimedia.org/T224923 (10matmarex) [21:50:39] (03CR) 10Esanders: [C: 04-1] Reorder calls so that window is scrollable when trying to scroll to section (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [21:54:59] 10VisualEditor-MediaWiki, 10Verified, 10VisualEditor (Current work): Remove confirm dialogs (prompts) when switching between VE and 2010 wikitext editor with changes - https://phabricator.wikimedia.org/T220007 (10Ryasmeen) [22:02:46] (03PS3) 10Esanders: Reorder calls so that window is scrollable when trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [22:03:31] (03CR) 10Esanders: [C: 03+2] Reorder calls so that window is scrollable when trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [22:07:17] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Skipped QA, 10VisualEditor (Current work): Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10matmarex) I've tested this extensively and I'm confident... [22:18:16] (03Merged) 10jenkins-bot: Reorder calls so that window is scrollable when trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [22:20:19] (03CR) 10jenkins-bot: Reorder calls so that window is scrollable when trying to scroll to section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516473 (https://phabricator.wikimedia.org/T225292) (owner: 10Bartosz Dziewoński) [22:34:05] 10VisualEditor-CopyPaste, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10Regression, 10Verified, 10VisualEditor (Current work): Drag and drop of focusable nodes no longer works in Visual Editor - https://phabricator.wikimedia.org/T224042 (10Ryasmeen) [22:36:56] 10VisualEditor-CopyPaste, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10Regression, 10Verified, 10VisualEditor (Current work): Drag and drop of focusable nodes no longer works in Visual Editor - https://phabricator.wikimedia.org/T224042 (10Aschmidt) For the record: I could use drag and drop with a footno...