[00:27:13] (03Merged) 10jenkins-bot: trackSubscriber: Migrate away from deprecated 'schema.' modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516694 (https://phabricator.wikimedia.org/T221281) (owner: 10Krinkle) [00:29:16] (03CR) 10jenkins-bot: trackSubscriber: Migrate away from deprecated 'schema.' modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516694 (https://phabricator.wikimedia.org/T221281) (owner: 10Krinkle) [02:21:57] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [02:22:17] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [02:32:10] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [02:32:24] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [02:38:53] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [02:39:10] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [02:46:25] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) == 13 June | Update == - We will address the open design questions we have been talking about in T225629, in... [02:46:53] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [02:52:05] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: pre-deployment QA "adding/modifying links" - https://phabricator.wikimedia.org/T221311 (10ppelberg) == Edit Card cut off == @Ryasmeen, during our initial testing, there was an instance where parts of the Edit Card were cut off.... [02:52:52] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [02:53:48] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [02:53:57] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [02:54:11] 10VisualEditor: [Engineering Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221307 (10ppelberg) [02:54:13] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) 05Open→03Resolved [02:56:18] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [04:55:20] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516946 (owner: 10L10n-bot) [05:08:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516946 (owner: 10L10n-bot) [10:26:40] 10VisualEditor: Template boundaries expanded to include the list of links below - https://phabricator.wikimedia.org/T225788 (10Pginer-WMF) [11:20:25] 10VisualEditor, 10Parsoid: Template boundaries expanded to include the list of links below - https://phabricator.wikimedia.org/T225788 (10Esanders) [11:24:06] 10VisualEditor, 10Parsoid: Template boundaries expanded to include the list of links below - https://phabricator.wikimedia.org/T225788 (10Esanders) I think this is currently correct behaviour from Parsoid's point of view. This is similar to template generated tables. In this case it might be possible to isola... [11:26:45] (03PS8) 10Esanders: Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) [11:26:47] (03PS3) 10Esanders: Link inspector tweaks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514505 [11:33:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Template transclusion of a few list items extends to the entire list in VE, making it impossible to edit visually - https://phabricator.wikimedia.org/T185093 (10Esanders) [11:34:01] (03CR) 10jerkins-bot: [V: 04-1] Link inspector tweaks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514505 (owner: 10Esanders) [11:34:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Template transclusion of a few list items extends to the entire list in VE, making it impossible to edit visually - https://phabricator.wikimedia.org/T185093 (10Esanders) T118110 appears related [11:36:43] (03CR) 10Esanders: "We should be able to merge this now if there is no real change in functionality with the feature flag disabled." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [11:36:57] (03CR) 10Esanders: "We should be able to merge this now if there is no real change in functionality with the feature flag disabled." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [13:23:05] 10Editing-team, 10MediaWiki-Cache, 10MediaWiki-Page-editing: Disable file cache if wgPostEdit is set - https://phabricator.wikimedia.org/T217633 (10Krinkle) [13:24:05] 10Editing-team, 10MediaWiki-Cache, 10MediaWiki-Page-editing: Disable file cache if wgPostEdit is set - https://phabricator.wikimedia.org/T217633 (10Krinkle) We have lots of user-specific interaction with the page output. The HTTP File Cache is not meant to be aware of any of these. I don't recall off hand ho... [13:24:13] 10Editing-team, 10MediaWiki-Cache, 10MediaWiki-Page-editing, 10Performance-Team (Radar): Disable file cache if wgPostEdit is set - https://phabricator.wikimedia.org/T217633 (10Krinkle) [13:32:11] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10iamjessklein) Here is the latest [[ https://wikimedia.invisionapp.com/freehand/document/d3UL6oCs1 | freehand ]] for you to add comments and feedback. High... [13:33:36] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Serbian-Sites, and 2 others: Enable VisualEditor in draft namespace (Нацрт) on sr.wiki - https://phabricator.wikimedia.org/T223024 (10Zoranzoki21) >>! In T223024#5256214, @Acamicamacaraca wrote: > @Zoranzoki21 can you do this? Thanks in advan... [15:00:00] 10VisualEditor-MediaWiki, 10MW-1.33-release, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor/MobileFrontend broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" - https://phabricator.wikimedia.org/T225354 (10Krinkle) [15:00:11] 10VisualEditor-MediaWiki, 10MW-1.33-release, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor/MobileFrontend broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" - https://phabricator.wikimedia.org/T225354 (10Krinkle) [15:01:19] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor/MobileFrontend broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" - https://phabricator.wikimedia.org/T225354 (10Krinkle) [15:54:37] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: pre-deployment QA "adding/modifying links" - https://phabricator.wikimedia.org/T221311 (10ppelberg) [15:55:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Template transclusion of a few list items extends to the entire list in VE, making it impossible to edit visually - https://phabricator.wikimedia.org/T185093 (10cscott) This *might* be related to Parsoid's slightly-incorrect handling of initial newlines in... [16:08:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Edit cards: deploy v2 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T225834 (10ppelberg) [16:09:00] 10VisualEditor: [Engineering Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221307 (10ppelberg) [16:09:02] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Edit cards: deploy v2 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T225834 (10ppelberg) [16:17:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Edit cards: deploy v2 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T225834 (10ppelberg) [16:17:33] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10ppelberg) [16:17:35] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [16:24:33] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Esanders) Is this still only on standalone, or does it affect MediaWiki as well? [16:24:49] (03PS19) 10Esanders: Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [16:24:51] (03PS13) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [16:37:17] (03PS20) 10Esanders: Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [16:37:19] (03PS14) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [16:37:21] (03PS1) 10Esanders: Fix clipping on label preview in link context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 [16:38:19] (03PS3) 10Esanders: iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 (owner: 10Bartosz Dziewoński) [16:38:44] (03CR) 10Divec: [C: 03+2] Make annotationsAtModelSelection fail in fewer cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/516524 (https://phabricator.wikimedia.org/T225541) (owner: 10Esanders) [16:40:11] (03Merged) 10jenkins-bot: Make annotationsAtModelSelection fail in fewer cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/516524 (https://phabricator.wikimedia.org/T225541) (owner: 10Esanders) [16:42:03] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: pre-deployment QA "adding/modifying links" - https://phabricator.wikimedia.org/T221311 (10Esanders) >>! In T221311#5258166, @ppelberg wrote: > == Edit Card cut off == > @Ryasmeen, during our initial testing, there was an instan... [16:42:56] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: deploy v1.0 of "adding/modifying links" to prototype server - https://phabricator.wikimedia.org/T221309 (10Esanders) >>! In T221309#5250100, @iamjessklein wrote: > - I'm on a fancy iphone but parts of the interface get cut off f... [16:43:25] (03CR) 10jerkins-bot: [V: 04-1] iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 (owner: 10Bartosz Dziewoński) [16:45:56] (03CR) 10jenkins-bot: Make annotationsAtModelSelection fail in fewer cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/516524 (https://phabricator.wikimedia.org/T225541) (owner: 10Esanders) [16:45:58] (03CR) 10Esanders: "This fix, along with setting right:0 in the next patch, addresses the issues found in https://phabricator.wikimedia.org/F29457376." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 (owner: 10Esanders) [16:57:07] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Design: Consider using all icons, or all labels, for buttons in the link and other inspectors - https://phabricator.wikimedia.org/T129817 (10Esanders) [16:57:11] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design: Change the action buttons in context menus to be separate buttons, not a button group - https://phabricator.wikimedia.org/T119615 (10Esanders) [17:07:22] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10Esanders) @Volker_E what is the current thinking on "un-" icons, I know we still have a few (unBlock, unFlag, unTrash). Were we trying to move away from th... [17:16:16] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10Esanders) Based on the current template for "un-" icons, "unLink" would look like this: |100%|400% |{F29543454,size=full}|{F29543444,size=full} On the gri... [17:22:00] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10iamjessklein) >Based on the current template for "un-" icons, "unLink" would look like this: +1 - I believe Unlink makes the most sense here. here's the... [17:31:08] (03PS21) 10Esanders: Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) [17:31:10] (03PS15) 10Esanders: Link inspector tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/514503 [17:31:12] (03PS9) 10Esanders: Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) [17:31:14] (03PS4) 10Esanders: Link inspector tweaks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514505 [17:36:49] (03CR) 10jerkins-bot: [V: 04-1] Link inspector tweaks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/514505 (owner: 10Esanders) [18:20:39] (03PS1) 10Bartosz Dziewoński: Avoid setting '§ion' (with no equals or value) when switching to OWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517114 [18:22:32] (03CR) 10Bartosz Dziewoński: Fix switching without changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/504318 (https://phabricator.wikimedia.org/T221981) (owner: 10Esanders) [18:25:44] (03CR) 10Bartosz Dziewoński: "I got a confusing error when pushing this change for review, and originally it seemed like it actually failed to upload (trying to view it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517113 (owner: 10Bartosz Dziewoński) [18:29:48] (03CR) 10Esanders: [C: 03+2] Avoid setting '§ion' (with no equals or value) when switching to OWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517114 (owner: 10Bartosz Dziewoński) [18:35:28] 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests, 10Patch-For-Review, 10VisualEditor (Current work): Turn off section editing A/B test - https://phabricator.wikimedia.org/T225645 (10Esanders) Scheduled for Monday 17th June. [18:41:22] (03Merged) 10jenkins-bot: Avoid setting '§ion' (with no equals or value) when switching to OWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517114 (owner: 10Bartosz Dziewoński) [18:43:12] (03CR) 10jenkins-bot: Avoid setting '§ion' (with no equals or value) when switching to OWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517114 (owner: 10Bartosz Dziewoński) [19:24:52] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Serbian-Sites, and 2 others: Enable VisualEditor in draft namespace (Нацрт) on sr.wiki - https://phabricator.wikimedia.org/T223024 (10DannyS712) I can do this if you want [19:35:01] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Ryasmeen) @Esanders: I checked it on en.wiki [19:50:24] (03CR) 10Bartosz Dziewoński: "Also fixes T199617 :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 (owner: 10Esanders) [19:50:30] (03PS2) 10Bartosz Dziewoński: Fix clipping on label preview in link context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 (https://phabricator.wikimedia.org/T199617) (owner: 10Esanders) [19:51:32] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix clipping on label preview in link context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 (https://phabricator.wikimedia.org/T199617) (owner: 10Esanders) [19:52:37] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Link to edit the label overlaps with the label - https://phabricator.wikimedia.org/T199617 (10matmarex) @esanders rediscovered this issue while working on changes to contexts on mobile: {F29... [19:52:54] (03Merged) 10jenkins-bot: Fix clipping on label preview in link context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 (https://phabricator.wikimedia.org/T199617) (owner: 10Esanders) [19:54:17] (03CR) 10jenkins-bot: Fix clipping on label preview in link context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517099 (https://phabricator.wikimedia.org/T199617) (owner: 10Esanders) [19:55:15] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10VisualEditor (Current work): Link to edit the label overlaps with the label - https://phabricator.wikimedia.org/T199617 (10matmarex) | Before | After | | -- | --| | {F29547495} | {F29547481} [20:00:56] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10matmarex) [20:00:56] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [EPIC] Mobile VE toolbar improvements - https://phabricator.wikimedia.org/T211255 (10matmarex) [20:01:00] 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10matmarex) 05Resolved→03Open a:05ppelberg→03None (still has patches for review, I assume this was accidenta... [20:01:29] 10VisualEditor: [Engineering Epic] Mobile edit cards - https://phabricator.wikimedia.org/T221307 (10matmarex) [20:01:31] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10matmarex) [20:01:34] 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10matmarex) [20:08:46] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Verified, 10VisualEditor (Current work): Link to edit the label overlaps with the label - https://phabricator.wikimedia.org/T199617 (10Ryasmeen) [20:30:20] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10matmarex) Actually I wil... [20:32:04] (03PS1) 10Bartosz Dziewoński: ve.ui.AnnotationInspector: Deactivate surface after closing on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517133 (https://phabricator.wikimedia.org/T220633) [20:32:27] (03CR) 10Bartosz Dziewoński: Move mobile context to bottom of page (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [20:32:40] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Split off from https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/510229 , authored by Ed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517133 (https://phabricator.wikimedia.org/T220633) (owner: 10Bartosz Dziewoński) [20:34:28] (03CR) 10Bartosz Dziewoński: [C: 03+2] ve.ui.AnnotationInspector: Deactivate surface after closing on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517133 (https://phabricator.wikimedia.org/T220633) (owner: 10Bartosz Dziewoński) [20:34:48] (03CR) 10Bartosz Dziewoński: [C: 03+2] ve.ui.AnnotationInspector: Deactivate surface after closing on mobile (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517133 (https://phabricator.wikimedia.org/T220633) (owner: 10Bartosz Dziewoński) [20:35:49] (03Merged) 10jenkins-bot: ve.ui.AnnotationInspector: Deactivate surface after closing on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517133 (https://phabricator.wikimedia.org/T220633) (owner: 10Bartosz Dziewoński) [20:37:13] (03CR) 10jenkins-bot: ve.ui.AnnotationInspector: Deactivate surface after closing on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517133 (https://phabricator.wikimedia.org/T220633) (owner: 10Bartosz Dziewoński) [20:41:29] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10VisualEditor (Current work): Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10matmarex) [20:41:49] (03PS22) 10Bartosz Dziewoński: Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [20:53:48] (03PS1) 10Bartosz Dziewoński: Apply desktop contexts' line-wrapping to new mobile contexts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517136 [20:54:51] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Old contexts seem unchanged, new contexts seem alright – other than some problems with line-wrapping, because some of the styles from desk" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [20:55:05] (03Merged) 10jenkins-bot: Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [20:57:04] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (44556e8fd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517137 (https://phabricator.wikimedia.org/T199617) [20:57:23] (03PS10) 10Bartosz Dziewoński: Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [20:58:25] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (44556e8fd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517137 (https://phabricator.wikimedia.org/T199617) (owner: 10Bartosz Dziewoński) [20:58:34] (03CR) 10Bartosz Dziewoński: [C: 03+2] Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [20:58:40] (03CR) 10Jforrester: [C: 03+2] Update VE core submodule to master (44556e8fd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517137 (https://phabricator.wikimedia.org/T199617) (owner: 10Bartosz Dziewoński) [20:58:49] (03PS4) 10Bartosz Dziewoński: iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 [21:02:58] (03CR) 10jenkins-bot: Move mobile context to bottom of page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510229 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [21:12:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (44556e8fd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517137 (https://phabricator.wikimedia.org/T199617) (owner: 10Bartosz Dziewoński) [21:12:42] (03Merged) 10jenkins-bot: Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [21:14:31] (03CR) 10jenkins-bot: Update VE core submodule to master (44556e8fd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517137 (https://phabricator.wikimedia.org/T199617) (owner: 10Bartosz Dziewoński) [21:14:33] (03CR) 10jenkins-bot: Move mobile context to bottom of page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/510230 (https://phabricator.wikimedia.org/T204733) (owner: 10Esanders) [21:14:52] (03Abandoned) 10Jforrester: Avoid setting '§ion' (with no equals or value) when switching to OWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517113 (owner: 10Bartosz Dziewoński) [21:38:46] 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10matmarex) You can now use the config variable `$wgVisualEditorEnableNewMobileContext = true;` to enable the new ve... [21:39:17] (03CR) 10Esanders: [C: 04-1] "Looks good but the label widget containing the title doesn't appear to be respecting the size and padding of the container .ve-ui-linearCo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517136 (owner: 10Bartosz Dziewoński) [21:40:40] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile edit cards: pre-deployment QA "adding/modifying links" - https://phabricator.wikimedia.org/T221311 (10Ryasmeen) >>! In T221311#5259641, @Esanders wrote: >>>! In T221311#5258166, @ppelberg wrote: >> == Edit Card cut off == >> @Ryasmeen, dur... [21:41:08] 10VisualEditor-DataModel, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' in link inspector broken when cursor is at end of link - https://phabricator.wikimedia.org/T225541 (10matmarex) [21:41:17] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): Mobile edit cards: pre-deployment QA "adding/modifying links" - https://phabricator.wikimedia.org/T221311 (10matmarex) [21:41:19] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10matmarex) [21:41:27] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10matmarex) [21:41:30] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Editing QA, 10Design, and 3 others: Link to edit the label overlaps with the label - https://phabricator.wikimedia.org/T199617 (10matmarex) [21:43:25] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Patch-For-Review, and 2 others: Link to edit the label overlaps with the label - https://phabricator.wikimedia.org/T199617 (10matmarex) (oops, was already marked as #verified) [21:44:03] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10matmarex) a:05Ryasmeen→03Esanders [21:46:07] 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10matmarex) (QA is happening on T221311) [21:49:50] (03PS5) 10Bartosz Dziewoński: iOS browser menu bar tap stealing hack for bottom contexts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/516531 [22:28:00] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Verified, 10VisualEditor (Current work): Link to edit the label overlaps with the label - https://phabricator.wikimedia.org/T199617 (10Volker_E) @iamjessklein The prioritization and organization improves with your current, scheduled work o... [23:02:59] (03CR) 10Esanders: [C: 03+2] "We can come back to that - the label part may be redesigned in the next few months anyway" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517136 (owner: 10Bartosz Dziewoński) [23:04:34] (03Merged) 10jenkins-bot: Apply desktop contexts' line-wrapping to new mobile contexts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517136 (owner: 10Bartosz Dziewoński) [23:18:17] (03CR) 10jenkins-bot: Apply desktop contexts' line-wrapping to new mobile contexts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517136 (owner: 10Bartosz Dziewoński)