[05:44:09] 10VisualEditor, 10Product-Analytics: Re-run metrics from VE on mobile report - https://phabricator.wikimedia.org/T223339 (10ppelberg) Thanks to @Neil_P._Quinn_WMF, we have a draft analysis of the following metrics: 1. **Desktop edit completion rate** 2. **Mobile edit completion rate** 3. **Mobile edit sessions... [10:40:25] (03PS1) 10Esanders: Rename call to deprecated scrollCursorIntoView [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518004 [10:54:52] (03PS1) 10Esanders: Catch errors from getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518009 [10:56:42] (03CR) 10Esanders: "I can't reproduce this locally, but ve.ce.Document.getNodeAndOffset is documented as throwing an error when an offset can't be found, so I" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517570 (https://phabricator.wikimedia.org/T202723) (owner: 10Bartosz Dziewoński) [10:57:00] (03CR) 10Esanders: "Should fix failing tests in I41cf726dad38d4fe6647a1b760d66126fcee393f" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518009 (owner: 10Esanders) [11:23:20] (03CR) 10Divec: [C: 03+2] Catch errors from getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518009 (owner: 10Esanders) [11:24:50] (03Merged) 10jenkins-bot: Catch errors from getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518009 (owner: 10Esanders) [11:26:22] (03CR) 10jenkins-bot: Catch errors from getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518009 (owner: 10Esanders) [12:14:45] (03Abandoned) 10Esanders: Guard against destroyed surface when doing scrollSelectionIntoView [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/517683 (owner: 10Esanders) [12:16:25] (03PS1) 10Esanders: Improve debug bar margins on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518024 [12:43:20] (03PS2) 10Esanders: Update VE core submodule to master (1cf71b3f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517570 (https://phabricator.wikimedia.org/T202723) (owner: 10Bartosz Dziewoński) [13:42:57] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10iamjessklein) Update: This [[ https://wikimedia.invisionapp.com/freehand/document/s1duRw6io | Invision freehand ]]has a proposal for V2 flows that conta... [14:00:32] (03CR) 10Esanders: "Actually, we're applying this to Parsoid HTML, so I think we might just want to copy the logic. In theory the edit HTML could be different" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517751 (https://phabricator.wikimedia.org/T225936) (owner: 10Bartosz Dziewoński) [14:02:18] (03CR) 10Esanders: "Code is in MoveLeadParagraphTransform" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517751 (https://phabricator.wikimedia.org/T225936) (owner: 10Bartosz Dziewoński) [14:05:38] 10Citoid, 10Operations, 10serviceops, 10Patch-For-Review, and 2 others: allow zotero container nodejs server to define the amount of heap used instead of the fixed limit of 1.7Gi - https://phabricator.wikimedia.org/T213414 (10fsero) 05Open→03Resolved [14:55:08] (03PS1) 10Esanders: WIP Move logic for new mobile contexts to mouse down handler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518050 (https://phabricator.wikimedia.org/T226073) [15:08:36] 10VisualEditor: Add a useful call-to-action for citation needed templates while reading - https://phabricator.wikimedia.org/T225750 (10Esanders) For experimentation we may want to limit this to mobile to begin with. There is already some code in MF for red-links that brings up a card asking the user if they actu... [15:09:20] (03PS1) 10Esanders: Remove citefromid alias support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518053 [16:04:40] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Add a useful call-to-action in the context for citation needed templates - https://phabricator.wikimedia.org/T211243 (10ppelberg) >>! In T211243#5257124, @DLynch wrote: > @ppelberg I think your questions are tangentially relevant to... [16:11:54] (03CR) 10Jforrester: [C: 03+2] trackSubscriber: Remove use of 'ext.eventLogging.subscriber' alias [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517952 (https://phabricator.wikimedia.org/T221281) (owner: 10Krinkle) [16:33:59] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (1cf71b3f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517570 (https://phabricator.wikimedia.org/T202723) (owner: 10Bartosz Dziewoński) [16:38:27] (03Merged) 10jenkins-bot: trackSubscriber: Remove use of 'ext.eventLogging.subscriber' alias [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517952 (https://phabricator.wikimedia.org/T221281) (owner: 10Krinkle) [16:42:16] (03CR) 10jenkins-bot: trackSubscriber: Remove use of 'ext.eventLogging.subscriber' alias [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517952 (https://phabricator.wikimedia.org/T221281) (owner: 10Krinkle) [16:54:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (1cf71b3f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517570 (https://phabricator.wikimedia.org/T202723) (owner: 10Bartosz Dziewoński) [16:56:40] (03CR) 10jenkins-bot: Update VE core submodule to master (1cf71b3f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/517570 (https://phabricator.wikimedia.org/T202723) (owner: 10Bartosz Dziewoński) [16:58:09] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Patch-For-Review, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10matmarex) @Ryasmeen Ed's fix for... [17:27:06] 10VisualEditor, 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Performance-Team (Radar), 10Wikimedia-production-error: WARNING: "Failed to find visualeditor-toolbar-savedialog" in message cache - https://phabricator.wikimedia.org/T226202 (10Krinkle) [17:27:33] 10VisualEditor, 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Performance-Team (Radar), 10Wikimedia-production-error: WARNING: "Failed to find visualeditor-toolbar-savedialog" in message cache - https://phabricator.wikimedia.org/T226202 (10Krinkle) [17:28:17] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T221314 (10matmarex) Scheduled for deployment today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190620T1800 [17:30:25] 10VisualEditor, 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Performance-Team (Radar), 10Wikimedia-production-error: WARNING: "Failed to find visualeditor-toolbar-savedialog" in message cache - https://phabricator.wikimedia.org/T226202 (10matmarex) We removed the message from VE in 10VisualEditor, 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Performance-Team (Radar), 10Wikimedia-production-error: WARNING: "Failed to find visualeditor-toolbar-savedialog" in message cache - https://phabricator.wikimedia.org/T226202 (10matmarex) So, we fixed one use of this message: (03PS1) 10Townie: ve.ui.MWMediaDialog.js: Change page title for Content Translation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518101 (https://phabricator.wikimedia.org/T193132) [18:26:40] (03PS1) 10Townie: ve.ui.MWMediaDialog.js: Change page title for Content Translation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518105 (https://phabricator.wikimedia.org/T193132) [18:30:06] (03PS1) 10Bartosz Dziewoński: Prevent text on save/publish button from wrapping on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518106 [18:38:05] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T221314 (10matmarex) We deployed the patch, but when testing, I realized that the production wikis are still running software version w... [18:50:20] (03CR) 10Bartosz Dziewoński: "Causes T225546" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/510186 (owner: 10Esanders) [18:50:28] (03PS1) 10Bartosz Dziewoński: Revert "Source mode performance optimizations" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518107 (https://phabricator.wikimedia.org/T225546) [18:50:39] (03PS2) 10Bartosz Dziewoński: Revert "Source mode performance optimizations" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518107 (https://phabricator.wikimedia.org/T225546) [18:51:19] (03CR) 10Bartosz Dziewoński: [C: 03+1] "(leaving it for David/Ed to approve)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518107 (https://phabricator.wikimedia.org/T225546) (owner: 10Bartosz Dziewoński) [19:06:50] (03CR) 10Jforrester: [C: 03+2] Prevent text on save/publish button from wrapping on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518106 (owner: 10Bartosz Dziewoński) [19:17:23] (03CR) 10Bartosz Dziewoński: "I think there might be an easier way to do this (and that also doesn't explicitly depend on ContentTranslation) – replace the `pageTitle =" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518105 (https://phabricator.wikimedia.org/T193132) (owner: 10Townie) [19:20:53] (03Merged) 10jenkins-bot: Prevent text on save/publish button from wrapping on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518106 (owner: 10Bartosz Dziewoński) [19:23:02] (03CR) 10jenkins-bot: Prevent text on save/publish button from wrapping on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518106 (owner: 10Bartosz Dziewoński) [19:42:00] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10iamjessklein) After conversations with @Esanders @ppelberg @DLynch @dchan @matmarex - we decided the following features are out of scope for V2: - Auto su... [19:45:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518119 (owner: 10L10n-bot) [20:11:46] (03CR) 10Esanders: [C: 04-1] "I'll try and make this more selective - it's probably just the inline slugs on empty paragraphs we need." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518107 (https://phabricator.wikimedia.org/T225546) (owner: 10Bartosz Dziewoński) [20:22:01] (03PS1) 10Esanders: Restore inline slugs in source mode for cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518138 (https://phabricator.wikimedia.org/T225546) [20:22:23] (03Abandoned) 10Esanders: Revert "Source mode performance optimizations" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518107 (https://phabricator.wikimedia.org/T225546) (owner: 10Bartosz Dziewoński) [20:49:55] (03PS1) 10Bartosz Dziewoński: Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518142 (https://phabricator.wikimedia.org/T221314) [20:52:17] (03PS1) 10Bartosz Dziewoński: Revert "MobileArticleTarget: Update loading interface for new design" [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518144 [20:53:49] (03CR) 10Jforrester: [C: 03+2] Revert "MobileArticleTarget: Update loading interface for new design" [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518144 (owner: 10Bartosz Dziewoński) [20:53:54] (03CR) 10Jforrester: [C: 03+2] Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518142 (https://phabricator.wikimedia.org/T221314) (owner: 10Bartosz Dziewoński) [20:56:38] (03CR) 10jerkins-bot: [V: 04-1] Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518142 (https://phabricator.wikimedia.org/T221314) (owner: 10Bartosz Dziewoński) [20:57:26] James_F: oh, bah. i guess we can backport another commit [20:57:40] There's more than on GuidedTour issue? [20:57:56] James_F: i mean https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/516270 [20:58:47] (03CR) 10jerkins-bot: [V: 04-1] Revert "MobileArticleTarget: Update loading interface for new design" [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518144 (owner: 10Bartosz Dziewoński) [21:00:19] (03CR) 10jerkins-bot: [V: 04-1] Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518142 (https://phabricator.wikimedia.org/T221314) (owner: 10Bartosz Dziewoński) [21:00:21] (03CR) 10jerkins-bot: [V: 04-1] Revert "MobileArticleTarget: Update loading interface for new design" [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518144 (owner: 10Bartosz Dziewoński) [21:04:04] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518142 (https://phabricator.wikimedia.org/T221314) (owner: 10Bartosz Dziewoński) [21:11:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [EPIC] Mobile VE toolbar improvements - https://phabricator.wikimedia.org/T211255 (10ppelberg) [21:12:02] 10VisualEditor-MediaWiki-Mobile, 10Design, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10VisualEditor (Current work): Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10ppelberg) 05Open→03Resolved a:03ppelberg [21:17:07] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/wmf/1.34.0-wmf.10' into HEAD [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518142 (https://phabricator.wikimedia.org/T221314) (owner: 10Bartosz Dziewoński) [21:19:30] 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10Mobile: Caps lock remained on when editing wiki text on iOS and "2010 wiki text editor" enabled - https://phabricator.wikimedia.org/T219480 (10Niharika) [21:27:43] (03Merged) 10jenkins-bot: Revert "MobileArticleTarget: Update loading interface for new design" [extensions/VisualEditor] (wmf/1.34.0-wmf.8) - 10https://gerrit.wikimedia.org/r/518144 (owner: 10Bartosz Dziewoński) [21:51:21] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [22:11:02] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10VisualEditor (Current work): Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T221314 (10matmarex) And it's live! (with help from @Jdforrester-WMF) We had to make sure that we didn't make... [22:50:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] Restore inline slugs in source mode for cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518138 (https://phabricator.wikimedia.org/T225546) (owner: 10Esanders) [22:51:55] (03Merged) 10jenkins-bot: Restore inline slugs in source mode for cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518138 (https://phabricator.wikimedia.org/T225546) (owner: 10Esanders) [22:53:21] (03CR) 10jenkins-bot: Restore inline slugs in source mode for cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518138 (https://phabricator.wikimedia.org/T225546) (owner: 10Esanders) [23:01:16] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10VisualEditor (Current work): Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki - https://phabricator.wikimedia.org/T221314 (10ppelberg) [23:08:59] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [23:09:01] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design Edit Cards "v2.0" - https://phabricator.wikimedia.org/T225725 (10ppelberg) [23:13:53] 10VisualEditor: [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [23:24:58] (03CR) 10Esanders: "On iOS the cursor occasionally lands inside the link without firing a mousedown event. Haven't worked out why this is yet.." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/518050 (https://phabricator.wikimedia.org/T226073) (owner: 10Esanders) [23:39:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References, 10User-Ryasmeen: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398 (10ppelberg) [23:40:03] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10ppelberg) [23:40:06] 10VisualEditor-MediaWiki-Mobile, 10MediaWiki-Page-editing, 10Browser-Support-Firefox, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 4 others: Tapping in the editing area of the mobile visual editor causes the page to scroll up in Firefox for Android - https://phabricator.wikimedia.org/T196839 (10ppelberg... [23:40:55] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Regression, 10Verified, 10VisualEditor (Current work): Preview of editing summary missing in VE - https://phabricator.wikimedia.org/T222999 (10ppelberg) 05Open→03Resolved a:03ppelberg [23:46:09] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Design: [Epic] Mobile VE usability improvements - https://phabricator.wikimedia.org/T221328 (10ppelberg) [23:46:14] 10VisualEditor-MediaWiki-Mobile, 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Mobile VE: Consider providing a visible or larger area for CE when editing an empty page/creating a new page - https://phabricator.wikimedia.org/T109508 (10ppelberg) 05Open→03Resolved