[04:56:38] 10VisualEditor, 10OOUI, 10UI-Standardization: Upstream pulsating dot widget - https://phabricator.wikimedia.org/T226719 (10santhosh) In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/511865 , we introduced mw.cx.ui.FeatureDiscoveryWidget.js which tries to achieve a use case of {T2... [05:55:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Revise mobile VE publish flow - https://phabricator.wikimedia.org/T226951 (10ppelberg) [06:16:19] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design "refreshed toolbar" v1.0 - https://phabricator.wikimedia.org/T225634 (10ppelberg) **1) Keeping "Publish" in the navigation bar** @iamjessklein, I share the opinion that keeping the publish action in the navigation bar [1... [07:40:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519960 (owner: 10L10n-bot) [08:33:14] (03PS4) 10Townie: Make page title the target title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518227 (https://phabricator.wikimedia.org/T193132) [10:21:46] (03CR) 10MarcoAurelio: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/519911 (owner: 10L10n-bot) [10:23:06] (03CR) 10Esanders: [C: 04-1] ArticleTarget: saveSuccess wasn't receiving expected arguments (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519738 (https://phabricator.wikimedia.org/T226847) (owner: 10DLynch) [10:31:08] (03PS34) 10Mvolz: Add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) [10:34:53] (03CR) 10jerkins-bot: [V: 04-1] Add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) (owner: 10Mvolz) [10:36:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/519911 (owner: 10L10n-bot) [10:37:01] 10Cite, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21): CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Pginer-WMF) [10:47:20] (03PS35) 10Mvolz: Add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) [10:56:01] 10Citoid, 10Knowledge-Integrity, 10WMF-Legal, 10Wikidata, and 2 others: [2.11] Integrate Citoid in Wikidata - https://phabricator.wikimedia.org/T199197 (10Mvolz) [12:06:24] (03CR) 10Bartosz Dziewoński: MobileArticleTarget: Prevent unwanted page zooming on focus on iOS (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [12:37:22] (03PS5) 10Bartosz Dziewoński: MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) [12:50:23] (03CR) 10jerkins-bot: [V: 04-1] MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [12:51:13] (03CR) 10Esanders: [C: 04-1] Make page title the target title (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/518227 (https://phabricator.wikimedia.org/T193132) (owner: 10Townie) [13:01:16] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (681aa3fbc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519712 (https://phabricator.wikimedia.org/T225021) (owner: 10Jforrester) [13:05:12] (03PS1) 10Bartosz Dziewoński: MWMediaDialog: Use close flag for close action [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520001 (https://phabricator.wikimedia.org/T225021) [13:12:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (681aa3fbc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519712 (https://phabricator.wikimedia.org/T225021) (owner: 10Jforrester) [13:13:37] (03PS1) 10Bartosz Dziewoński: MWSaveDialog: Use close flag for close actions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520004 (https://phabricator.wikimedia.org/T225021) [13:14:15] (03CR) 10jenkins-bot: Update VE core submodule to master (681aa3fbc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519712 (https://phabricator.wikimedia.org/T225021) (owner: 10Jforrester) [13:53:41] (03PS6) 10Bartosz Dziewoński: MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) [14:28:56] (03CR) 10Esanders: [C: 03+2] MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [14:37:40] (03CR) 10Esanders: [C: 04-1] MWSaveDialog: Use close flag for close actions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520004 (https://phabricator.wikimedia.org/T225021) (owner: 10Bartosz Dziewoński) [14:39:01] (03CR) 10Esanders: [C: 04-1] "I think this is an improvement, but we should file a separate task as I don't think it fully falls under T225021." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520004 (https://phabricator.wikimedia.org/T225021) (owner: 10Bartosz Dziewoński) [14:39:36] (03CR) 10jerkins-bot: [V: 04-1] MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [14:43:17] (03Abandoned) 10Esanders: MWMediaDialog: Use close flag for close action [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520001 (https://phabricator.wikimedia.org/T225021) (owner: 10Bartosz Dziewoński) [14:48:44] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) [14:50:12] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) [14:50:36] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) p:05Triage→03High [14:52:10] (03CR) 10Bartosz Dziewoński: "Definitely not a duplicate of that change. Did you link the wrong one?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520001 (https://phabricator.wikimedia.org/T225021) (owner: 10Bartosz Dziewoński) [15:12:32] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) [15:14:11] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile - https://phabricator.wikimedia.org/T220633 (10matmarex) The blue highligh... [15:31:09] 10VisualEditor, 10Product-Analytics: Publish Section Editing A/B test results on-wiki - https://phabricator.wikimedia.org/T226865 (10Neil_P._Quinn_WMF) a:05Neil_P._Quinn_WMF→03mpopov If this needs to be done, it would make sense for @mpopov to do this. However, @ppelberg, is there a reason you can't just... [15:39:19] (03CR) 10Lucas Werkmeister (WMDE): "I tried it out and it seems to work pretty well! I’m excited :)" (0311 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) (owner: 10Mvolz) [16:01:34] (03CR) 10DLynch: ArticleTarget: saveSuccess wasn't receiving expected arguments (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519738 (https://phabricator.wikimedia.org/T226847) (owner: 10DLynch) [16:03:34] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Unrelated failure, retrying…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [16:05:00] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) a:05Ryasmeen→03Neil_P._Quinn_WMF [16:06:34] (03PS3) 10DLynch: ArticleTarget: saveSuccess wasn't receiving expected arguments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519738 (https://phabricator.wikimedia.org/T226847) [16:14:37] (03Merged) 10jenkins-bot: MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [16:16:36] (03CR) 10jenkins-bot: MobileArticleTarget: Prevent unwanted page zooming on focus on iOS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/512748 (https://phabricator.wikimedia.org/T216446) (owner: 10Bartosz Dziewoński) [16:26:16] (03CR) 10DLynch: "The distortion-avoiding relies on Ibafec77b2eabd3b3b3767472b7b5a40e3312bf18 somewhat to let it know when the switch happens, incidentally." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [16:35:14] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Product-Analytics, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10matmarex) [16:35:22] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Section name still appears in edit summary when you switch to full article editing - https://phabricator.wikimedia.org/T191590 (10matmarex) [16:35:24] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Browser-Support-Google-Chrome, 10Patch-For-Review, 10VisualEditor (Current work): Page zooms slightly when focusing document on iPhone Chrome - https://phabricator.wikimedia.org/T216446 (10matmarex) [16:35:26] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing QA, 10MediaWiki-extensions-Linter, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), and 2 others: Linter isn't highlighting text in 2017 WTE anymore - https://phabricator.wikimedia.org/T185279 (10matmarex) [16:40:11] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Editing QA, 10MediaWiki-extensions-Linter, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), and 2 others: Linter isn't highlighting text in 2017 WTE anymore - https://phabricator.wikimedia.org/T185279 (10matmarex) [18:35:33] 10VisualEditor, 10Product-Analytics: Re-run metrics from VE on mobile report - https://phabricator.wikimedia.org/T223339 (10Neil_P._Quinn_WMF) Quick update: I was out sick Monday through Wednesday last week, and since then I have been working primarily on the verifying that the mobile VE experiment has been de... [20:58:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/520106 (owner: 10L10n-bot) [21:00:48] (03PS1) 10DLynch: Pass newRevId through to MobileFrontend [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520119 (https://phabricator.wikimedia.org/T226847) [21:42:26] (03PS1) 10Bartosz Dziewoński: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T225541) [21:42:41] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Product-Analytics, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) QA for the VE as default A/B test will be happening in T221197 [21:42:49] (03PS2) 10Bartosz Dziewoński: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T225541) [21:42:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] Gather annotations from clicked node where possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519377 (https://phabricator.wikimedia.org/T226708) (owner: 10Esanders) [21:43:00] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10Product-Analytics, 10VisualEditor (Current work): Make sure VE is mobile default on select wikis - https://phabricator.wikimedia.org/T227002 (10ppelberg) [21:43:44] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I don't think this is an improvement. This new transition doesn't start until iOS Safari's animation is done (because iOS Safari doesn't g" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519397 (owner: 10Esanders) [21:44:32] (03Merged) 10jenkins-bot: Gather annotations from clicked node where possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519377 (https://phabricator.wikimedia.org/T226708) (owner: 10Esanders) [21:46:38] (03CR) 10jenkins-bot: Gather annotations from clicked node where possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519377 (https://phabricator.wikimedia.org/T226708) (owner: 10Esanders) [21:46:40] 10VisualEditor: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10matmarex) >>! In T221967#5149728, @Esanders wrote: > A side effect of this is if you cursor onto a link from the right, the preview doesn't render: > {F28885500} With the hacks from T22... [22:01:50] (03Restored) 10Bartosz Dziewoński: MWMediaDialog: Use close flag for close action [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520001 (https://phabricator.wikimedia.org/T225021) (owner: 10Bartosz Dziewoński)