[00:01:29] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10VisualEditor (Current work): Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10matmarex) (see subtasks) [00:01:34] 10VisualEditor-Mobile-UsabilityImprovements, 10Browser-Support-Apple-Safari, 10VisualEditor (Current work): iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard - https://phabricator.wikimedia.org/T221723 (10matmarex) >>! In T96289#5303711, @Esanders wrote: > As we have depl... [00:03:43] 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, 10Browser-Support-Apple-Safari, 10VisualEditor (Current work): iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard - https://phabricator.wikimedia.org/T221723 (10matmarex) [00:04:23] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, and 2 others: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome - https://phabricator.wikimedia.org/T136840 (10matmarex) [00:04:24] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, 10VisualEditor (Current work): Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10matmarex) [00:04:28] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, 10Design, 10VisualEditor (Current work): Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) [00:09:03] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (dc0e4650e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:11:52] (03PS3) 10Bartosz Dziewoński: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T226708) [00:12:07] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T226708) (owner: 10Bartosz Dziewoński) [00:12:22] 10VisualEditor, 10Parsoid: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags - https://phabricator.wikimedia.org/T227216 (10ssastry) Instructions from @cscott to reproduce this bug: ` 1. https://en.wikipedia.beta.wmflabs.org/wiki/Martyrs... [00:13:52] (03PS4) 10Bartosz Dziewoński: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) [00:14:06] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) (owner: 10Bartosz Dziewoński) [00:15:50] 10VisualEditor, 10Parsoid: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags - https://phabricator.wikimedia.org/T227216 (10Jdforrester-WMF) Confirmed fixed for me. [00:16:12] 10VisualEditor-DataModel, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10VisualEditor (Current work): 'Change label' in link inspector broken when cursor is at end of link - https://phabricator.wikimedia.org/T225541 (10matmarex) The workaround fixes this for all cases except where the link co... [00:17:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Eh, probably need to add the new file to module definitions too?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:19:09] (03CR) 10Jforrester: "> Patch Set 2: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:20:20] 10VisualEditor, 10Parsoid: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags - https://phabricator.wikimedia.org/T227216 (10ssastry) >>! In T227216#5305441, @ssastry wrote: > > These steps will probably work on any production wiki as wel... [00:24:27] 10VisualEditor, 10Parsoid: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags - https://phabricator.wikimedia.org/T227216 (10ssastry) >>! In T227216#5305502, @ssastry wrote: >>>! In T227216#5305441, @ssastry wrote: >> >> These steps will... [00:25:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looks like it is indeed experimental, but the debug mode function "Test squasher" uses it, and now it fails." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:25:50] (03PS3) 10Bartosz Dziewoński: Update VE core submodule to master (75510a515) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:26:08] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags - https://phabricator.wikimedia.org/T227216 (10Jdforrester-WMF) 05Open→03Resolved a:03c_schmitz [00:26:26] (03CR) 10Bartosz Dziewoński: [C: 03+2] "PS3 updates extension.json, and also pulls in new commits." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:26:34] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags - https://phabricator.wikimedia.org/T227216 (10Jdforrester-WMF) a:05c_schmitz→03cscott [00:27:22] (03PS4) 10Jforrester: Update VE core submodule to master (dc0e4650e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) [00:27:46] (03CR) 10Jforrester: "Oh, sorry." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:28:12] MatmaRex: Want me to revert or add? [00:28:37] James_F: oh, uh, whatever [00:29:23] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (dc0e4650e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:29:51] (03PS5) 10Jforrester: Update VE core submodule to master (dc0e4650e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) [00:31:00] (03CR) 10Jforrester: [C: 03+2] "C+2 on PS3 (with changes) and PS4 (with change to debugScripts) => effectively OK." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:31:59] (03PS6) 10Bartosz Dziewoński: Update VE core submodule to master (75510a515) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:32:15] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Wrong commit reference ;)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:32:20] (03CR) 10Jforrester: [C: 03+2] "Ha." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:32:30] MatmaRex: Between the two of us… [00:32:51] eventually we're gonna get it merged [00:33:17] Shoo, it's 02:30. :-) [00:43:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (75510a515) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:46:05] (03CR) 10jenkins-bot: Update VE core submodule to master (75510a515) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/520500 (https://phabricator.wikimedia.org/T188026) (owner: 10Jforrester) [00:46:21] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): New mobile link context doesn't work on single character links - https://phabricator.wikimedia.org/T226708 (10matmarex) The workaround fixes this, but there are problems within the context when the link consists of just one charact... [00:46:32] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): New mobile link context doesn't work on single character links - https://phabricator.wikimedia.org/T226708 (10matmarex) [00:46:46] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): New mobile link context doesn't work on single character links - https://phabricator.wikimedia.org/T226708 (10matmarex) [00:46:57] 10VisualEditor: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10matmarex) [00:48:33] 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): New mobile link context doesn't work on single character links - https://phabricator.wikimedia.org/T226708 (10matmarex) [00:48:35] 10VisualEditor, 10VisualEditor-DataModel: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10matmarex) [00:48:37] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work on single character links - https://phabricator.wikimedia.org/T227241 (10matmarex) [03:35:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Tested with trackdebug and the wrong data is logged (see inline), otherwise looks good." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [03:38:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Seems good, no logging for switching to/from NWE though? (ve.init.mw.ArticleTarget.prototype.switchToWikitextEditor and switchToWikitextSe" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [03:39:03] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(if that's intentional, I'll +2)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [04:36:29] (03PS3) 10DLynch: Log editor switches to visualeditorfeatureuse [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) [04:58:09] (03CR) 10DLynch: "You're right, I wasn't thinking about it. I'll cover that case as well." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [04:58:38] (03PS2) 10DLynch: Log editor switches to visualeditorfeatureuse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) [10:38:33] 10VisualEditor, 10Product-Analytics: Write query for Editing Team to access contributors makeup - https://phabricator.wikimedia.org/T223499 (10Neil_P._Quinn_WMF) >>! In T223499#5263583, @Nuria wrote: > I came to this ticket cause several devs from editing team were asking for permits for hadoop to look at this... [11:07:54] (03PS2) 10Divec: Explicitly pass store length argument to pushTransaction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520184 [11:09:18] (03CR) 10Esanders: [C: 04-2] "Yep - this will be deployed with edit cards v2, which we aren't feature flagging." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520227 (owner: 10Esanders) [11:30:34] (03CR) 10Esanders: "I would still rather have slide-up + slide-down, than slide-up + snap-down. In my testing this felt smoother, except when scrolling really" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519397 (owner: 10Esanders) [11:33:20] (03PS19) 10Divec: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (https://phabricator.wikimedia.org/T215567) [15:29:10] 10VisualEditor: Something went wrong HTTP 404 when using Visual Editor - https://phabricator.wikimedia.org/T224384 (10Der_Keks) p:05Triage→03High I set a new priority because the risk is moderate but the impact is disastrous. Hours of work gone. [15:41:20] 10VisualEditor, 10Operations: Something went wrong HTTP 404 when using Visual Editor - https://phabricator.wikimedia.org/T224384 (10Der_Keks) [16:11:01] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Eh, whatever. I don't feel very strongly about it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519397 (owner: 10Esanders) [16:12:49] (03Merged) 10jenkins-bot: Add transition to iOS menu bar hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519397 (owner: 10Esanders) [16:15:28] (03CR) 10jenkins-bot: Add transition to iOS menu bar hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/519397 (owner: 10Esanders) [16:51:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) [17:56:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements: Selection can appear on top of toolbar - https://phabricator.wikimedia.org/T217797 (10ppelberg) [17:56:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements: Selection can appear on top of toolbar - https://phabricator.wikimedia.org/T217797 (10ppelberg) >>! In T217797#5266737, @matmarex wrote: > Ed actually had a try at it earlier, documented in the subtask at T220634#52... [19:18:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] Log editor switches to visualeditorfeatureuse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [19:18:56] (03CR) 10Bartosz Dziewoński: [C: 03+2] Log editor switches to visualeditorfeatureuse [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [19:30:46] (03Merged) 10jenkins-bot: Log editor switches to visualeditorfeatureuse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [19:30:49] (03Merged) 10jenkins-bot: Log editor switches to visualeditorfeatureuse [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [19:38:36] (03CR) 10jenkins-bot: Log editor switches to visualeditorfeatureuse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/519529 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [21:43:52] 10Editing-team, 10MediaWiki-Page-editing, 10Patch-For-Review, 10User-DannyS712: Create a Special:NewSection page - https://phabricator.wikimedia.org/T207577 (10DannyS712) @Krinkle noted on the patch that: > This adds a new feature to MW, but it is unclear who would be the steward/owner of this feature. T... [21:49:20] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Etonkovidova) [21:49:49] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Etonkovidova) [21:51:11] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Etonkovidova) [21:59:18] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Daimona) https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/486726/ Added validation, but I... [22:04:28] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Daimona) Ah, actually I got it. The global rows are saved in cache with TTL indefinite (????), and previously... [22:31:22] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Krinkle) @Daimona It looks like it uses the `touch` feature of WANObjectCache to purge when there is a change.... [22:31:45] 10VisualEditor, 10AbuseFilter, 10Editing QA: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Krinkle)