[01:17:17] 10VisualEditor, 10MediaWiki-Page-editing, 10Modern, 10Chinese-Sites: Visual editor is not loaded on zhwikiverisity with modern skin - https://phabricator.wikimedia.org/T227410 (10matmarex) Visual editor is not supposed to be compatible with the Modern skin: https://www.mediawiki.org/wiki/Extension:VisualEd... [02:07:22] 10VisualEditor, 10MediaWiki-Page-editing, 10Modern, 10Chinese-Sites: Visual editor is not loaded on zhwikiverisity with modern skin - https://phabricator.wikimedia.org/T227410 (10Hamishcn) >>! In T227410#5315860, @matmarex wrote: > Visual editor is not supposed to be compatible with the Modern skin: https:... [02:07:55] 10VisualEditor: Is support of "cross-domain requests" an intentional prerequisite to SSO integration for enterprise use cases? - https://phabricator.wikimedia.org/T227329 (10matmarex) I am having trouble piecing together what actually happens here. Please understand that we're not familiar with your configuratio... [06:23:55] (03CR) 10saper: "Hi, this is one of the possible approaches to fix T203850. Small bug, big refactor :) The extension should be a bit less MySQL-only now..." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/521193 (https://phabricator.wikimedia.org/T203850) (owner: 10saper) [07:09:34] 10VisualEditor, 10AbuseFilter, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-Ryasmeen: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Daimona) 05Open→03Resolved [08:08:36] (03PS1) 10Bartosz Dziewoński: MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521424 [08:09:56] (03CR) 10Bartosz Dziewoński: "https://phabricator.wikimedia.org/F29719718" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521424 (owner: 10Bartosz Dziewoński) [10:03:37] (03CR) 10Bartosz Dziewoński: [C: 03+2] Extra tracking for VisualEditor's feature use [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/521317 (https://phabricator.wikimedia.org/T221305) (owner: 10DLynch) [10:09:07] (03PS2) 10Bartosz Dziewoński: Extra logging for link inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521296 (https://phabricator.wikimedia.org/T221249) (owner: 10DLynch) [10:12:34] (03PS3) 10Bartosz Dziewoński: Extra logging for link inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521296 (https://phabricator.wikimedia.org/T221249) (owner: 10DLynch) [10:12:43] (03CR) 10Bartosz Dziewoński: [C: 03+2] Extra logging for link inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521296 (https://phabricator.wikimedia.org/T221249) (owner: 10DLynch) [10:13:54] (03CR) 10Bartosz Dziewoński: [C: 03+2] "(Sorry for the rebase noise, I rebased on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/521424 (because the broken " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521296 (https://phabricator.wikimedia.org/T221249) (owner: 10DLynch) [10:20:40] (03Merged) 10jenkins-bot: Extra tracking for VisualEditor's feature use [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/521317 (https://phabricator.wikimedia.org/T221305) (owner: 10DLynch) [10:24:39] (03Merged) 10jenkins-bot: Extra logging for link inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521296 (https://phabricator.wikimedia.org/T221249) (owner: 10DLynch) [10:26:22] (03CR) 10jenkins-bot: Extra logging for link inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521296 (https://phabricator.wikimedia.org/T221249) (owner: 10DLynch) [10:43:10] 10VisualEditor, 10Design, 10Patch-For-Review: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10Amire80) I agree that this is problematic. Especially the part of auto-selecting the whole text link. It seems more sensible to me to put the... [13:02:08] (03PS5) 10Esanders: Remove ve.newMobileContext feature flag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520227 [13:02:10] (03PS10) 10Esanders: WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 [13:02:12] (03PS1) 10Esanders: Edit cards: Don't show keyboard when going from focusable to link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/521486 [13:02:14] (03PS1) 10Esanders: Refactor mobile context logic into ve.ui.MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/521487 [13:04:00] (03CR) 10jerkins-bot: [V: 04-1] WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 (owner: 10Esanders) [13:49:07] 10TemplateData, 10VisualEditor, 10ContentTranslation, 10RESTBase-API, 10Language-Team (Language-2019-July-September): CX2: Better support for Wikidata-based templates - https://phabricator.wikimedia.org/T199310 (10Pginer-WMF) [13:49:27] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-Team (Language-2019-July-September): Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049 (10Pginer-WMF) [13:49:47] 10VisualEditor, 10ContentTranslation, 10Language-Team (Language-2019-July-September): Inspecting a template in the source language wrongly leads to the target wiki template documentation - https://phabricator.wikimedia.org/T217410 (10Pginer-WMF) [14:29:09] 10VisualEditor: Is support of "cross-domain requests" an intentional prerequisite to SSO integration for enterprise use cases? - https://phabricator.wikimedia.org/T227329 (10Revansx) Normally, with simpleSAMLphp SSO integration, when the client's session expires, the very next request the client makes from the b... [15:24:34] (03CR) 10Divec: [C: 03+2] 12.1.0 data update [unicodejs] - 10https://gerrit.wikimedia.org/r/520892 (owner: 10Esanders) [15:25:53] (03Merged) 10jenkins-bot: 12.1.0 data update [unicodejs] - 10https://gerrit.wikimedia.org/r/520892 (owner: 10Esanders) [15:26:59] (03CR) 10jenkins-bot: 12.1.0 data update [unicodejs] - 10https://gerrit.wikimedia.org/r/520892 (owner: 10Esanders) [15:36:11] (03PS2) 10Esanders: Refactor mobile context logic into ve.ui.MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/521487 (https://phabricator.wikimedia.org/T227532) [15:36:14] (03PS11) 10Esanders: WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 [15:38:14] (03CR) 10jerkins-bot: [V: 04-1] WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 (owner: 10Esanders) [15:40:13] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): New edit cards obscure content at the bottom of the page - https://phabricator.wikimedia.org/T227532 (10Esanders) [15:40:24] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): New edit cards obscure content at the bottom of the page - https://phabricator.wikimedia.org/T227532 (10Esanders) a:03Esanders [16:24:43] 10VisualEditor, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-Ryasmeen: Mobile editor updates browser URL incorrectly if you click back with unsaved edits - https://phabricator.wikimedia.org/T218809 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson Back b... [16:48:50] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10MediaWiki-Page-protection, 10MobileFrontend, and 4 others: Lack of next steps for new users on mobile devices when attempting to edit a semi-protected page - https://phabricator.wikimedia.org/T206829 (10Esanders) > The tricky p... [16:58:27] (03CR) 10Esanders: [C: 03+2] "I don't like hacking code for gerrit, but seeing as it makes it generically more readable, that's fine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521424 (owner: 10Bartosz Dziewoński) [17:09:41] (03Merged) 10jenkins-bot: MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521424 (owner: 10Bartosz Dziewoński) [17:11:56] (03CR) 10jenkins-bot: MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521424 (owner: 10Bartosz Dziewoński) [18:30:58] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): New edit cards obscure content at the bottom of the page - https://phabricator.wikimedia.org/T227532 (10matmarex) >>! In T227532#5315414, @Esanders wrote: > Cc @matmarex, we used to do something like this on iOS? Yes, we sti... [18:41:31] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki: Handle load.php failures better in VisualEditor - https://phabricator.wikimedia.org/T89395 (10matmarex) [18:46:27] 10Editing-team, 10Performance-Team (Radar): Avoid MagicWord/LCStore cost from WikiEditor in startup module (resourceLoaderGetConfigVars hook) - https://phabricator.wikimedia.org/T222828 (10Krinkle) Moving this would be fairly simple by using the packageFiles and data-provider callback feature it provides. Tha... [19:36:55] (03PS1) 10Bartosz Dziewoński: Break up our massive load.php request to work around network issues [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) [19:42:41] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Enhance instrumentation for context items and inspectors - https://phabricator.wikimedia.org/T221252 (10ppelberg) [19:46:23] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Enhance instrumentation for context items and inspectors - https://phabricator.wikimedia.org/T221252 (10matmarex) I think the generic part is done – some of the logging has to be implemented individually for... [19:48:12] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Enhance instrumentation for context items and inspectors - https://phabricator.wikimedia.org/T221252 (10matmarex) (I suppose that for QA, we should ask Neil to verify that the data being logged actually allo... [19:50:22] 10VisualEditor-MediaWiki, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Enhance instrumentation for context items and inspectors - https://phabricator.wikimedia.org/T221252 (10ppelberg) >>! In T221252#5318876, @matmarex wrote: > I think the generic part is done – some of the log... [20:01:18] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.0 to 2.0.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521579 [20:19:49] 10VisualEditor, 10Security-Team-Reviews, 10User-Ryasmeen: Add edges to Phabricator task data dump transaction history - https://phabricator.wikimedia.org/T104920 (10sbassett) [20:33:32] 10VisualEditor: Edit cards: usability testing - https://phabricator.wikimedia.org/T221298 (10ppelberg) [20:35:01] (03PS3) 10Esanders: Refactor mobile context logic into ve.ui.MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/521487 (https://phabricator.wikimedia.org/T227532) [20:35:03] (03PS12) 10Esanders: WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 [20:36:49] (03CR) 10jerkins-bot: [V: 04-1] WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 (owner: 10Esanders) [21:01:24] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/521608 [21:13:23] 10VisualEditor: Edit cards: usability testing - https://phabricator.wikimedia.org/T221298 (10ppelberg) [21:16:25] 10VisualEditor: Edit cards: usability testing - https://phabricator.wikimedia.org/T221298 (10ppelberg) [21:17:03] 10VisualEditor: Edit cards: usability testing - https://phabricator.wikimedia.org/T221298 (10ppelberg) [21:18:20] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/521729 [21:20:53] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/521608 (owner: 10Jforrester) [21:21:14] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.0 to 2.0.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521579 (owner: 10Jforrester) [21:21:16] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/521749 [21:40:46] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/521608 (owner: 10Jforrester) [21:57:57] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.0 to 2.0.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521579 (owner: 10Jforrester) [22:35:47] 10VisualEditor: [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view - https://phabricator.wikimedia.org/T227627 (10Ryasmeen) [22:45:00] 10VisualEditor, 10AbuseFilter, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-Ryasmeen: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Ladsgroup) 05Resolved→03Open This needs... [22:47:02] 10VisualEditor, 10AbuseFilter, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-Ryasmeen: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Jdforrester-WMF) >>! In T227299#5319781, @La... [22:48:07] 10VisualEditor, 10AbuseFilter, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-Ryasmeen: [betalabs-regression] Any edit throws "AbuseFilter.php: The specified row must be a full abuse_filter row" - https://phabricator.wikimedia.org/T227299 (10Ladsgroup) 05Open→03Resolved Oh sorry fo... [22:56:00] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.0 to 2.0.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521579 (owner: 10Jforrester) [23:09:52] 10VisualEditor: [Pre-deployment bug] Scrolling the page when a link is selected resizes the edit card itself it seems. - https://phabricator.wikimedia.org/T227628 (10Ryasmeen) [23:12:35] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/521749 (owner: 10Jforrester) [23:14:06] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/521729 (owner: 10Jforrester) [23:26:36] 10VisualEditor: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience - https://phabricator.wikimedia.org/T227630 (10Ryasmeen) [23:44:50] 10VisualEditor: Pre-deployment QA Edit Cards v2.0 - https://phabricator.wikimedia.org/T221312 (10Ryasmeen) @ppelberg: I am done doing Pre-deployment QA on Edit Cards v2.0. Have found couple of UX issues and I am going make them as subtasks here for tracking. Apart from the ones reported I have another observat... [23:46:58] 10VisualEditor: Pre-deployment QA Edit Cards v2.0 - https://phabricator.wikimedia.org/T221312 (10Ryasmeen) [23:47:00] 10VisualEditor: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience - https://phabricator.wikimedia.org/T227630 (10Ryasmeen) [23:47:02] 10VisualEditor: [Pre-deployment bug] Scrolling the page when a link is selected resizes the edit card itself it seems. - https://phabricator.wikimedia.org/T227628 (10Ryasmeen) [23:47:05] 10VisualEditor: [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view - https://phabricator.wikimedia.org/T227627 (10Ryasmeen)