[00:05:35] (03CR) 10Esanders: "See my comments on the bug. this patch fixes a common case, which is user not logged in and message <400 chars." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/523714 (https://phabricator.wikimedia.org/T228165) (owner: 10Esanders) [00:07:08] (03CR) 10Esanders: "this does not depend on the new mobile context code as it checks for the existence of this.$foot" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/523174 (owner: 10Esanders) [00:07:38] (03CR) 10Esanders: [C: 04-2] Barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) (owner: 10Esanders) [00:07:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (3d0cc9eac) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/523824 (owner: 10Jforrester) [00:08:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Consider expanding wikilink search results - https://phabricator.wikimedia.org/T228353 (10ppelberg) [00:08:54] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Consider expanding wikilink search results - https://phabricator.wikimedia.org/T228353 (10ppelberg) [00:08:58] 10VisualEditor, 10VisualEditor-Edit Cards : [Epic] Mobile context items - https://phabricator.wikimedia.org/T221247 (10ppelberg) [00:10:21] (03CR) 10jenkins-bot: Update VE core submodule to master (3d0cc9eac) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/523824 (owner: 10Jforrester) [00:13:40] (03PS1) 10Bartosz Dziewoński: MobileArticleTarget: Compat for OOUI scrolling fix on iOS Safari [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/524063 (https://phabricator.wikimedia.org/T212159) [00:31:59] 10VisualEditor, 10MobileFrontend, 10I18n, 10Patch-For-Review, and 2 others: MobileFrontend should not use moment.js for a single line - https://phabricator.wikimedia.org/T224635 (10matmarex) Also, we could go back to rendering the relative expiry time in PHP – this could happen in ApiBlockInfoTrait (in MW... [00:50:54] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Visual Editor chops long links to TABernacle - https://phabricator.wikimedia.org/T228240 (10matmarex) Simplified steps to reproduce: * Copy this link: https://tools.wmflabs.org/tabernacle/?#/tab/sparql/SELECT%20%3Fitem%20WHERE%20%7B%0A... [01:21:27] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 2 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10Jdlrobson) The first thing to do is T195795: Use a clearly intended heig... [02:19:25] 10Editing-team, 10MediaWiki-Page-editing, 10Patch-For-Review, 10User-DannyS712: Create a Special:NewSection page - https://phabricator.wikimedia.org/T207577 (10Krinkle) The statement I made is not intended to be uniquely aimed at volunteers. While product approval or intent to maintain is often assumed on... [04:32:17] 10VisualEditor, 10VisualEditor-Edit Cards : Consider improving the workflow for adding label for link on mobile - https://phabricator.wikimedia.org/T228220 (10Ryasmeen) [09:51:28] 10VisualEditor-Edit Cards , 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Edit Cards: Fix transition from link search dialog back to document/Edit Card after changing the target of an existing link. - https://phabricator.wikimedia.org/T228229 (10Esanders) [10:11:14] 10VisualEditor, 10VisualEditor-Edit Cards , 10VisualEditor-MediaWiki-Mobile: Editing an existing link's label has no effect if label < 3 characters long - https://phabricator.wikimedia.org/T227673 (10Esanders) [10:11:21] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work on single character links - https://phabricator.wikimedia.org/T227241 (10Esanders) [10:11:42] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work on 1 or 2 character links - https://phabricator.wikimedia.org/T227241 (10Esanders) [10:13:55] (03PS5) 10Esanders: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) (owner: 10Bartosz Dziewoński) [10:21:43] (03PS6) 10Esanders: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) (owner: 10Bartosz Dziewoński) [10:21:45] (03PS2) 10Esanders: Use collapsed selection for "set label" button on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523904 (https://phabricator.wikimedia.org/T228227) [10:21:48] (03PS9) 10Esanders: Remove ve.newMobileContext feature flag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520227 [10:21:49] (03PS8) 10Esanders: Refactor mobile context logic into ve.ui.MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/521487 (https://phabricator.wikimedia.org/T227532) [10:21:51] (03PS4) 10Esanders: Don't hide the context when opening an inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523906 (https://phabricator.wikimedia.org/T228229) [10:21:54] (03PS19) 10Esanders: WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 [10:23:10] (03CR) 10Esanders: [C: 03+2] "Let's do this. It's still imperfect but it fixes a big issue in mobile completely." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) (owner: 10Bartosz Dziewoński) [10:24:21] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links - https://phabricator.wikimedia.org/T227241 (10Esanders) [10:24:41] (03Merged) 10jenkins-bot: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) (owner: 10Bartosz Dziewoński) [10:25:03] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links - https://phabricator.wikimedia.org/T227241 (10Esanders) I'll file a separate task for cursoring onto a link, but that will mostly... [10:25:09] (03CR) 10jerkins-bot: [V: 04-1] WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 (owner: 10Esanders) [10:26:19] 10VisualEditor: 'Change label' and label preview in link context don't work after keyboard navigating on 1 or 2 character links - https://phabricator.wikimedia.org/T228396 (10Esanders) [10:26:44] 10VisualEditor: 'Change label' and label preview in link context don't work after keyboard navigating on 1 or 2 character links - https://phabricator.wikimedia.org/T228396 (10Esanders) [10:26:46] 10VisualEditor, 10VisualEditor-DataModel: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10Esanders) [10:27:30] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links - https://phabricator.wikimedia.org/T227241 (10Esanders) [10:27:32] 10VisualEditor, 10VisualEditor-DataModel: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10Esanders) [10:27:43] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links - https://phabricator.wikimedia.org/T227241 (10Esanders) [10:27:46] 10VisualEditor, 10VisualEditor-DataModel: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10Esanders) [10:28:37] (03CR) 10jenkins-bot: ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520127 (https://phabricator.wikimedia.org/T227241) (owner: 10Bartosz Dziewoński) [12:11:36] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration to Beta Wikidata - https://phabricator.wikimedia.org/T228411 (10Lucas_Werkmeister_WMDE) [12:11:40] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration to Test Wikidata - https://phabricator.wikimedia.org/T228412 (10Lucas_Werkmeister_WMDE) [12:11:44] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration to Wikidata - https://phabricator.wikimedia.org/T228413 (10Lucas_Werkmeister_WMDE) [12:14:45] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration - https://phabricator.wikimedia.org/T228414 (10Lucas_Werkmeister_WMDE) [12:14:57] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration to Beta Wikidata - https://phabricator.wikimedia.org/T228411 (10Lucas_Werkmeister_WMDE) [12:14:59] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration - https://phabricator.wikimedia.org/T228414 (10Lucas_Werkmeister_WMDE) [12:15:02] 10Citoid, 10VisualEditor, 10Wikidata, 10Wikidocumentaries, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Add citoid support for WikiBase to the Citoid extension - https://phabricator.wikimedia.org/T196353 (10Lucas_Werkmeister_WMDE) [12:15:05] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration to Test Wikidata - https://phabricator.wikimedia.org/T228412 (10Lucas_Werkmeister_WMDE) [12:15:09] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration - https://phabricator.wikimedia.org/T228414 (10Lucas_Werkmeister_WMDE) [12:15:13] 10Citoid, 10VisualEditor, 10Wikidata, 10Wikidocumentaries, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Add citoid support for WikiBase to the Citoid extension - https://phabricator.wikimedia.org/T196353 (10Lucas_Werkmeister_WMDE) [12:15:16] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration to Wikidata - https://phabricator.wikimedia.org/T228413 (10Lucas_Werkmeister_WMDE) [12:15:18] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration - https://phabricator.wikimedia.org/T228414 (10Lucas_Werkmeister_WMDE) [12:15:21] 10Citoid, 10VisualEditor, 10Wikidata, 10Wikidocumentaries, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Add citoid support for WikiBase to the Citoid extension - https://phabricator.wikimedia.org/T196353 (10Lucas_Werkmeister_WMDE) [12:19:29] 10Citoid, 10Wikidata, 10Patch-For-Review: Deploy Citoid Wikibase integration to Beta Wikidata - https://phabricator.wikimedia.org/T228411 (10Lucas_Werkmeister_WMDE) I’ll try to get this done in today’s Evening SWAT, then we can hopefully get T228412 and T228413 done next week (unless someone wants more time... [12:19:36] 10Citoid, 10Wikidata, 10Patch-For-Review: Deploy Citoid Wikibase integration to Beta Wikidata - https://phabricator.wikimedia.org/T228411 (10Lucas_Werkmeister_WMDE) a:03Lucas_Werkmeister_WMDE [13:06:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10Neil_P._Quinn_WMF) @ppelberg what do you need from me here? If you're looking for a listing of which events we need to check, that should be in the [VE featu... [13:14:12] 10VisualEditor-Edit Cards , 10Editing Design, 10VisualEditor (Current work): [Pre-deployment bug] Scrolling the page when a link is selected resizes the edit card itself it seems. - https://phabricator.wikimedia.org/T227628 (10Esanders) > What can we do about it? We could also style the fake padding differe... [13:31:11] (03PS19) 10Esanders: Barcode scanning [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/493494 (https://phabricator.wikimedia.org/T216775) [14:10:37] (03PS3) 10Divec: Revert "Call handleInsertion on beforeinput" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523770 (https://phabricator.wikimedia.org/T227852) (owner: 10Esanders) [14:11:33] (03PS4) 10Divec: Revert "Call handleInsertion on beforeinput" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523770 (https://phabricator.wikimedia.org/T227852) (owner: 10Esanders) [14:13:28] (03PS5) 10Divec: Revert "Call handleInsertion on beforeinput" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523770 (https://phabricator.wikimedia.org/T227852) (owner: 10Esanders) [14:26:51] (03CR) 10Divec: [C: 03+2] Revert "Call handleInsertion on beforeinput" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523770 (https://phabricator.wikimedia.org/T227852) (owner: 10Esanders) [14:29:27] (03Merged) 10jenkins-bot: Revert "Call handleInsertion on beforeinput" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523770 (https://phabricator.wikimedia.org/T227852) (owner: 10Esanders) [14:30:59] (03CR) 10jenkins-bot: Revert "Call handleInsertion on beforeinput" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523770 (https://phabricator.wikimedia.org/T227852) (owner: 10Esanders) [14:37:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/524231 (owner: 10L10n-bot) [14:43:36] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Create Design Doc for V1 of Toolbar - https://phabricator.wikimedia.org/T227090 (10iamjessklein) @JTannerWMF I'm not blocked on this, waiting for @ppelberg to thumbsup so I that we can close the ticket. [15:00:00] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE loading performance - https://phabricator.wikimedia.org/T227930 (10ppelberg) This is great, @esanders. You've shared some other metrics you were able to pulled that have not yet been posted here – can you add those here? In the meantime, combi... [15:04:06] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE loading performance - https://phabricator.wikimedia.org/T227930 (10ppelberg) [15:04:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE loading performance - https://phabricator.wikimedia.org/T227930 (10ppelberg) [15:25:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE loading performance - https://phabricator.wikimedia.org/T227930 (10Esanders) > What percent of contributors who tap "edit" actually want to edit? (@marcella phrased this well) > What drop-off rate should we expect/be satisfied with? I think if... [15:27:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE loading performance - https://phabricator.wikimedia.org/T227930 (10ppelberg) [15:46:11] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10ppelberg) >>! In T227933#5345580, @Neil_P._Quinn_WMF wrote: > @ppelberg what do you need from me here? This wasn't explicit in the ticket. Let me try again. A... [15:51:33] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10Neil_P._Quinn_WMF) a:05Neil_P._Quinn_WMF→03None >>! In T227933#5346374, @ppelberg wrote: > **Needed from Neil:** > - [ ] A list of steps Rummana will need... [16:13:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10DLynch) I believe that document is up to date. [16:54:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Epic] Mobile VE loading performance - https://phabricator.wikimedia.org/T227930 (10ppelberg) [17:17:48] 10VisualEditor-Edit Cards , 10Editing Design, 10VisualEditor (Current work): [EPIC] User Testing Outcomes - https://phabricator.wikimedia.org/T227894 (10ppelberg) [18:24:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10Ryasmeen) >>! In T227933#5346374, @ppelberg wrote: >>>! In T227933#5345580, @Neil_P._Quinn_WMF wrote: >> @ppelberg what do you need from me here? > This wasn'... [18:56:17] 10VisualEditor, 10On Wiki Communication : Investigate mapping PHP HTML to Parsoid HTML for talk page features - https://phabricator.wikimedia.org/T227686 (10Esanders) We can also just find the path within the section, as Parsoid has already done the work of mapping the section numbers. I note that the ReplyLi... [19:54:48] 10VisualEditor-Edit Cards , 10VisualEditor (Current work): [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view - https://phabricator.wikimedia.org/T227627 (10Esanders) https://analytics.wikimedia.org/dashboards/browsers/#mobile-site-by... [19:58:55] 10VisualEditor-Edit Cards , 10VisualEditor (Current work): [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience - https://phabricator.wikimedia.org/T227630 (10Esanders) Oh, I see, you inserted an exte... [20:04:56] 10VisualEditor-Edit Cards , 10VisualEditor (Current work): [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view - https://phabricator.wikimedia.org/T227627 (10Esanders) @Ryasmeen We just changed the label selection to be collapsed for a... [20:43:52] (03CR) 10Jforrester: [C: 03+2] Use collapsed selection for "set label" button on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523904 (https://phabricator.wikimedia.org/T228227) (owner: 10Esanders) [20:45:39] 10VisualEditor, 10Core Platform Team, 10Mobile-Content-Service, 10RESTBase, and 3 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116 (10WDoranWMF) [21:17:48] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10ppelberg) a:03Ryasmeen [21:42:12] (03PS3) 10Esanders: Use collapsed selection for "set label" button on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523904 (https://phabricator.wikimedia.org/T228227) [21:42:32] (03PS10) 10Esanders: Remove ve.newMobileContext feature flag [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520227 [21:42:38] (03PS9) 10Esanders: Refactor mobile context logic into ve.ui.MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/521487 (https://phabricator.wikimedia.org/T227532) [21:42:43] (03PS5) 10Esanders: Don't hide the context when opening an inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/523906 (https://phabricator.wikimedia.org/T228229) [21:42:48] (03PS20) 10Esanders: WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 [21:45:02] (03CR) 10jerkins-bot: [V: 04-1] WIP Edit cards v2 design [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/520228 (owner: 10Esanders) [22:21:29] 10VisualEditor-Edit Cards , 10VisualEditor (Current work): [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view - https://phabricator.wikimedia.org/T227627 (10Ryasmeen) @Esanders: I am still getting this issue on iOS11. [22:30:24] 10VisualEditor, 10Design, 10Patch-For-Review: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10ppelberg) >>! In T201232#5343770, @Esanders wrote: > This change (T228227) will apply to mobile only. Desktop functionality will be unchanged... [23:24:45] 10Citoid, 10Wikidata, 10Patch-For-Review: Deploy Citoid Wikibase integration to Beta Wikidata - https://phabricator.wikimedia.org/T228411 (10Lucas_Werkmeister_WMDE) 05Open→03Resolved Seems to be working – I used it to [add this reference](https://wikidata.beta.wmflabs.org/wiki/Special:Diff/1138462). [23:24:52] 10Citoid, 10Wikidata: Deploy Citoid Wikibase integration - https://phabricator.wikimedia.org/T228414 (10Lucas_Werkmeister_WMDE)