[01:06:27] (03PS1) 10Bartosz Dziewoński: ApiVisualEditorEdit: Remove special handling for SpamBlacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526817 (https://phabricator.wikimedia.org/T211443) [01:07:31] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): Remove SpamBlacklist error handling from ApiVisualEditorEdit.php - https://phabricator.wikimedia.org/T211443 (10matmarex) [01:07:50] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): Remove SpamBlacklist error handling from ApiVisualEditorEdit.php - https://phabricator.wikimedia.org/T211443 (10matmarex) a:03matmarex [01:40:01] (03PS1) 10Jforrester: build: Bump lodash for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526820 [01:41:17] (03CR) 10Catrope: [C: 03+2] build: Bump lodash for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526820 (owner: 10Jforrester) [01:43:11] (03Merged) 10jenkins-bot: build: Bump lodash for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526820 (owner: 10Jforrester) [01:45:00] (03CR) 10jenkins-bot: build: Bump lodash for npm audit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526820 (owner: 10Jforrester) [01:49:28] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 [01:50:17] (03PS2) 10Jforrester: Update VE core submodule to master (a7d95c35b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526462 [02:06:19] 10VisualEditor: Revise edit flow transitions in mobile VE - https://phabricator.wikimedia.org/T229503 (10ppelberg) [02:35:03] 10WikiEditor, 10Wikimedia-General-or-Unknown: Raw "apierror-permissiondenied" displayed instead of "You don't have permission to $1." in WikiEditor on zhwiki - https://phabricator.wikimedia.org/T203058 (10matmarex) This no longer affects zhwiki, since the upload dialog has been disabled via wiki configuration,... [02:44:52] (03CR) 10Jforrester: "Shall we just do this?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/521575 (https://phabricator.wikimedia.org/T213214) (owner: 10Bartosz Dziewoński) [02:52:27] 10VisualEditor: VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones - https://phabricator.wikimedia.org/T229532 (10matmarex) [03:07:44] 10VisualEditor-MediaWiki, 10AbuseFilter, 10Patch-For-Review, 10VisualEditor (Current work): Distinguish AbuseFilter warnings and errors in VE - https://phabricator.wikimedia.org/T211241 (10matmarex) [03:11:15] 10VisualEditor-MediaWiki, 10Skipped QA, 10Technical-Debt, 10VisualEditor (Current work): Allow VE plugins to handle save errors generated by extensions - https://phabricator.wikimedia.org/T211157 (10matmarex) I've been doing some work in related code (T211241, T211443) and I can confirm that this still wor... [03:23:04] 10VisualEditor: VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones - https://phabricator.wikimedia.org/T229532 (10matmarex) [03:26:32] (03CR) 10Bartosz Dziewoński: ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526551 (https://phabricator.wikimedia.org/T227630) (owner: 10Bartosz Dziewoński) [03:33:21] (03PS1) 10Bartosz Dziewoński: [WIP] ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) [04:51:15] (03PS23) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [04:52:35] (03CR) 10Happy5214: [C: 04-1] "This was a rebase. I'll still need to make the fixes requested in the last version." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [05:05:39] (03PS24) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [05:07:42] (03CR) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [05:25:47] (03CR) 10jerkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [05:34:17] (03PS25) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [07:17:28] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Browser-Support-Firefox, 10Upstream: Reference numbers wrong in Firefox when following a list - https://phabricator.wikimedia.org/T229307 (10Schnark) And now I found https://bugzilla.mozilla.org/show_bug.cgi?id=1545746, which already is closed as invalid. [09:26:19] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10PerfektesChaos) It is a bit strange to discuss Commons categories outside of Commons. Usually the talk page is... [12:14:48] (03PS13) 10Esanders: LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [12:19:00] 10VisualEditor, 10Editing Design: Tweak the mockups legal message placement to account for keyboard being up - https://phabricator.wikimedia.org/T229428 (10iamjessklein) I mocked up a few different options for discussion purposes (on [[ https://wikimedia.invisionapp.com/freehand/document/u73rMI8Nu | Invision... [12:27:13] 10VisualEditor, 10Editing Design, 10User-Ryasmeen: Tweak the mockups to reflect the change of the < button to close for this iteration - https://phabricator.wikimedia.org/T229427 (10iamjessklein) 05Open→03Resolved Updated [[ https://wikimedia.invisionapp.com/freehand/document/u73rMI8Nu | freehand ]] Upda... [12:32:00] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design "refreshed toolbar" v1.0 - https://phabricator.wikimedia.org/T225634 (10iamjessklein) [12:32:31] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design "refreshed toolbar" v1.0 - https://phabricator.wikimedia.org/T225634 (10iamjessklein) [12:35:05] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10VisualEditor (Current work): Design "refreshed toolbar" v1.0 - https://phabricator.wikimedia.org/T225634 (10iamjessklein) >When we introduced the "publish" wording a few years ago, we clearly missed this message. "Save >changes" should be "Publish changes"... [12:55:08] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), 10VisualEditor (Current work): Hide "options" bar under edit summary input when hidden - https://phabricator.wikimedia.org/T228165 (10iamjessklein) >>! In T228165#5337106, @Esanders wrote: > In... [13:44:59] (03PS1) 10Esanders: MediaSizeWidget: Make methods chainable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527101 [13:55:58] (03CR) 10Jforrester: [C: 03+2] MediaSizeWidget: Make methods chainable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527101 (owner: 10Esanders) [13:57:58] (03Merged) 10jenkins-bot: MediaSizeWidget: Make methods chainable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527101 (owner: 10Esanders) [13:59:48] (03CR) 10jenkins-bot: MediaSizeWidget: Make methods chainable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527101 (owner: 10Esanders) [14:00:26] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 2 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10Esanders) > I do also support the suggestion to reduce to 48px on scroll... [14:37:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Use simplified mobilefrontend copyright messages on mobile VE - https://phabricator.wikimedia.org/T229579 (10Esanders) [14:47:27] (03PS1) 10Esanders: Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) [14:47:45] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Use simplified mobilefrontend copyright messages on mobile VE - https://phabricator.wikimedia.org/T229579 (10Esanders) a:03Esanders [14:49:18] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 2 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10cmadeo) Another thing to keep in mind on iOS devices is that there is a... [14:53:37] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10VisualEditor (Current work): Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10ppelberg) Got it – thanks for looking these over, @DLynch. [14:53:59] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10VisualEditor (Current work): Context items: verify logging events are firing properly - https://phabricator.wikimedia.org/T227933 (10ppelberg) [14:54:35] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Use simplified mobilefrontend copyright messages on mobile VE - https://phabricator.wikimedia.org/T229579 (10Esanders) After: {F29931075,width=300} [15:05:08] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 2 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10cmadeo) @Esanders, Ah sorry to clarify this came up in a design review o... [15:11:29] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Use simplified mobilefrontend copyright messages on mobile VE - https://phabricator.wikimedia.org/T229579 (10iamjessklein) 👏nice job @Esanders - it was bugging me! [15:47:12] 10Editing-team, 10Analytics: Deletion of limn-edit-data repository - https://phabricator.wikimedia.org/T228982 (10Milimetric) @Neil_P._Quinn_WMF they weren't migrated, they only exist in the old repo: https://github.com/wikimedia/analytics-limn-edit-data [15:52:40] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10Iniquity) >>! In T229046#5383767, @PerfektesChaos wrote: > It is a bit strange to discuss Commons categories o... [16:06:38] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10Volker_E) >>! In T229046#5384690, @Iniquity wrote: > >> * ##OOjs UI icon listNumbered-ltr apex.svg## is an ap... [16:31:49] 10Editing-team, 10Advanced Mobile Contributions, 10Discovery, 10MobileFrontend, 10Readers-Web-Backlog: Add redlink experience to empty search results on Mobile (JS version) - https://phabricator.wikimedia.org/T211006 (10alexhollender) @MMiller_WMF @ppelberg any interest in this task? I think it could be... [16:41:01] 10Citoid, 10VisualEditor: citoid dosen't work at Hindi Wikipedia - https://phabricator.wikimedia.org/T229592 (10Force_Radical) [16:54:51] 10VisualEditor, 10Editing Design, 10MinervaNeue, 10MobileFrontend, and 2 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10RHo) >>! In T215426#5384376, @Esanders wrote: >> I do also support the s... [17:24:07] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10PerfektesChaos) The naming is from 2017, and all icons received meaningful and systematic names when the files... [17:50:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527144 (owner: 10L10n-bot) [18:21:16] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10Iniquity) I'm sorry, but why do you think CommonsDelinker's work is bad? It helps the community and individual... [18:59:55] 10Citoid, 10VisualEditor: citoid dosen't work at Hindi Wikipedia - https://phabricator.wikimedia.org/T229592 (10Aklapper) 05Open→03Stalled Hi @Force_Radical, thanks for taking the time to report this. Unfortunately this report lacks some information. If you have time and can still reproduce the problem: P... [20:24:24] 10WikiEditor: Userprefs for edit options should be set by radiobuttons not checkboxes - https://phabricator.wikimedia.org/T45519 (10matmarex) [20:27:37] 10WikiEditor: Userprefs for edit options should be set by radiobuttons not checkboxes - https://phabricator.wikimedia.org/T45519 (10matmarex) 05Open→03Invalid There is no longer a "Enable dialogs for inserting links, tables and more" preference, it has been merged into "Enable enhanced editing toolbar" (http... [20:50:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Improve loading progress appearance when loading MF, or switching from MF to VE - https://phabricator.wikimedia.org/T228159 (10matmarex) Ed suggested only changing the mobile wikitext header size to match mobile visual, and leaving everything else un... [20:51:15] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, 10Browser-Support-Apple-Safari, and 4 others: Scrolling a ProcessDialog scrolls the page behind on iOS Safari - https://phabricator.wikimedia.org/T212159 (10matmarex) [21:08:53] 10VisualEditor: Send Editing Team 2019 newsletter #2 - https://phabricator.wikimedia.org/T229623 (10ppelberg) [21:15:14] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10PerfektesChaos) It is disturbing the watching users (who are supervising bot flag edits) and is blowing up the... [21:30:07] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10Iniquity) > It is disturbing the watching users (who are supervising bot flag edits) and is blowing up the ver...