[00:21:39] (03CR) 10Esanders: [C: 03+2] ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526551 (https://phabricator.wikimedia.org/T227630) (owner: 10Bartosz Dziewoński) [00:23:08] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (a7d95c35b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526462 (owner: 10Jforrester) [00:23:44] (03Merged) 10jenkins-bot: ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526551 (https://phabricator.wikimedia.org/T227630) (owner: 10Bartosz Dziewoński) [00:25:34] (03CR) 10jenkins-bot: ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/526551 (https://phabricator.wikimedia.org/T227630) (owner: 10Bartosz Dziewoński) [00:28:09] (03CR) 10Esanders: [C: 04-1] build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.0 (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 (owner: 10Jforrester) [00:32:59] (03CR) 10Esanders: [C: 04-1] build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.0 (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 (owner: 10Jforrester) [00:39:10] (03CR) 10DLynch: [C: 04-1] Use MobileFrontend license message on mobile when available (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [00:44:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (a7d95c35b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526462 (owner: 10Jforrester) [00:46:45] (03CR) 10jenkins-bot: Update VE core submodule to master (a7d95c35b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526462 (owner: 10Jforrester) [08:11:17] (03PS1) 10DLynch: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) [10:50:12] (03PS1) 10Divec: Do not propagate exceptions thrown in OO.EventEmitter#emit listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527510 (https://phabricator.wikimedia.org/T185546) [10:57:41] (03PS2) 10Divec: Do not propagate exceptions thrown in OO.EventEmitter#emit listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527510 (https://phabricator.wikimedia.org/T185546) [11:46:56] (03PS1) 10Divec: Document ve.dm.TransactionProcessor#process better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527519 [12:31:05] 10Citoid, 10VisualEditor, 10User-Ryasmeen: citoid dosen't work at Hindi Wikipedia - https://phabricator.wikimedia.org/T229592 (10Force_Radical) Per https://hi.m.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%B6%E0%A5%87%E0%A4%B7:MobileDiff/4266401 , it works. Thanks for the fix :) [14:03:08] (03PS1) 10Divec: Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527559 [15:20:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: v3: Implement form-based approach to editing a link's label - https://phabricator.wikimedia.org/T229431 (10iamjessklein) Thanks @Esanders As you can see in this screenshot, the user has absolutely no instructions or context about what they are supposed to be d... [15:20:27] 10VisualEditor, 10VisualEditor-LanguageTool, 10Contributors-Team, 10Language-Team, and 2 others: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107 (10Aklapper) This task has been open and assigned for a long time. All its subtasks are resolved. Could someone e... [15:20:30] 10VisualEditor, 10VisualEditor-LanguageTool: Upgrade the LanguageTool server in the labs - https://phabricator.wikimedia.org/T105144 (10Aklapper) @Ankita-ks: Hi! This issue has been assigned to you a while ago. Could you maybe share a status update? Are you still working (or still plan to work) on this issue?... [15:23:10] (03CR) 10Esanders: [C: 04-1] "documentation and tests?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527559 (owner: 10Divec) [15:40:00] (03PS14) 10Esanders: LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [15:48:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: v3: Implement form-based approach to editing a link's label - https://phabricator.wikimedia.org/T229431 (10Esanders) This is basically the same level of guidance as we provide on the link target page: A title describing the purpose of the form, a single input pr... [16:03:09] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design, 10Patch-For-Review: Improve loading progress appearance when loading MF, or switching from MF to VE - https://phabricator.wikimedia.org/T228159 (10Niedzielski) Adding @alexhollender and @volker_e in case they want to make adjustments to other parts... [16:07:59] 10VisualEditor, 10Apex, 10OOUI, 10Wikimedia Design Style Guide: Naming and categorization of OOUI, VisualEditor, Apex and OOUI based icons on Commons - https://phabricator.wikimedia.org/T229046 (10Perhelion) I guess PerfektesChaos is just right, I also don't see the real problem here. @Iniquity so your req... [16:08:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: v3: Implement form-based approach to editing a link's label - https://phabricator.wikimedia.org/T229431 (10iamjessklein) A few thoughts: 1. Putting everything in context is a good idea and we can test how confusing it actually is (and combining could potentiall... [16:24:13] (03PS2) 10Esanders: Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527559 (owner: 10Divec) [16:24:23] (03CR) 10Esanders: [C: 03+2] Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527559 (owner: 10Divec) [16:28:31] (03Merged) 10jenkins-bot: Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527559 (owner: 10Divec) [16:33:46] (03CR) 10jenkins-bot: Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527559 (owner: 10Divec) [16:48:30] 10VisualEditor, 10Growth-Team: When a user wants to create an article, offer to publish it as a draft - https://phabricator.wikimedia.org/T229115 (10JTannerWMF) Hey @Trizek-WMF we are planning to put this in Revisit to consider for our work next year. However, if you feel we should work on this sooner, feel fr... [16:49:46] (03PS1) 10Jforrester: Update VE core submodule to master (6f2206ee2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527600 (https://phabricator.wikimedia.org/T227630) [16:51:14] (03PS2) 10Jforrester: build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 [16:51:22] 10VisualEditor, 10Growth-Team: When a user wants to create an article, offer to publish it as a draft - https://phabricator.wikimedia.org/T229115 (10Trizek-WMF) I think it is not urgent, but it would be a must-have if we encourage people to try to create articles. [16:51:27] (03CR) 10Jforrester: build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 (owner: 10Jforrester) [17:14:06] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Confirm changes to edit flow comply with legal requirements - https://phabricator.wikimedia.org/T229462 (10JTannerWMF) a:03JTannerWMF I will reach out to legal about this [17:17:05] (03CR) 10Jforrester: [C: 03+2] Document ve.dm.TransactionProcessor#process better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527519 (owner: 10Divec) [17:19:05] (03Merged) 10jenkins-bot: Document ve.dm.TransactionProcessor#process better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527519 (owner: 10Divec) [17:21:19] (03CR) 10jenkins-bot: Document ve.dm.TransactionProcessor#process better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527519 (owner: 10Divec) [17:27:02] (03PS2) 10Jforrester: Update VE core submodule to master (0de28ce64) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527600 (https://phabricator.wikimedia.org/T227630) [18:18:53] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (0de28ce64) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527600 (https://phabricator.wikimedia.org/T227630) (owner: 10Jforrester) [18:19:24] (03CR) 10Esanders: [C: 03+2] build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 (owner: 10Jforrester) [18:26:18] (03PS1) 10Esanders: Document that toJSON takes a key argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527610 [18:33:35] (03PS2) 10Esanders: Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) [18:33:48] (03CR) 10Esanders: Use MobileFrontend license message on mobile when available (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [18:38:08] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Confirm changes to edit flow comply with legal requirements - https://phabricator.wikimedia.org/T229462 (10ppelberg) [18:38:54] (03Merged) 10jenkins-bot: Update VE core submodule to master (0de28ce64) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527600 (https://phabricator.wikimedia.org/T227630) (owner: 10Jforrester) [18:38:58] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 (owner: 10Jforrester) [18:39:12] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Confirm changes to edit flow comply with legal requirements - https://phabricator.wikimedia.org/T229462 (10ppelberg) [18:39:43] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Confirm changes to edit flow comply with legal requirements - https://phabricator.wikimedia.org/T229462 (10ppelberg) [18:40:51] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526822 (owner: 10Jforrester) [18:41:05] (03CR) 10jenkins-bot: Update VE core submodule to master (0de28ce64) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527600 (https://phabricator.wikimedia.org/T227630) (owner: 10Jforrester) [18:44:29] 10VisualEditor, 10VisualEditor-DataModel, 10OOjs, 10Patch-For-Review: EventEmitters must behave appropriately if a handler raises an exception - https://phabricator.wikimedia.org/T185546 (10Esanders) Modifying OO.EventEmitter.prototype.emit is not going to work as it will change the behaviour for everythin... [18:51:48] (03CR) 10jerkins-bot: [V: 04-1] Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [18:52:49] (03CR) 10Jforrester: [C: 03+2] Document that toJSON takes a key argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527610 (owner: 10Esanders) [18:55:42] (03Merged) 10jenkins-bot: Document that toJSON takes a key argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527610 (owner: 10Esanders) [18:57:34] (03CR) 10jenkins-bot: Document that toJSON takes a key argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/527610 (owner: 10Esanders) [20:19:46] 10Citoid, 10VisualEditor: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled. - https://phabricator.wikimedia.org/T229654 (10Esanders) [20:24:22] 10Citoid, 10VisualEditor, 10good first bug: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled. - https://phabricator.wikimedia.org/T229654 (10Esanders) [20:29:20] 10Citoid, 10VisualEditor, 10good first bug: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled. - https://phabricator.wikimedia.org/T229654 (10Esanders) This should be fixable in `ve.ui.Citoid.init.js` in the Citoi... [21:16:43] (03PS2) 10DLynch: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) [21:25:59] (03CR) 10jerkins-bot: [V: 04-1] MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [21:27:06] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [21:30:01] (03PS3) 10DLynch: Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [21:54:31] (03CR) 10DLynch: [C: 03+2] Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [22:12:14] (03Merged) 10jenkins-bot: Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [22:13:52] (03CR) 10jenkins-bot: Use MobileFrontend license message on mobile when available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527118 (https://phabricator.wikimedia.org/T229579) (owner: 10Esanders) [22:17:17] 10VisualEditor, 10VisualEditor-DataModel, 10OOjs, 10Patch-For-Review: EventEmitters must behave appropriately if a handler raises an exception - https://phabricator.wikimedia.org/T185546 (10dchan) Hmm, can we perhaps modify the prototype on loading VE? I think when VE is running the chances of anything (VE...