[08:48:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531418 (owner: 10L10n-bot) [11:23:09] (03PS1) 10Divec: Prevent RangeState tests from hanging QUnit via a huge diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) [11:28:35] (03PS2) 10Divec: Prevent RangeState tests from hanging QUnit via a huge diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) [11:30:28] (03PS4) 10Divec: WIP: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) [11:32:05] (03CR) 10jerkins-bot: [V: 04-1] WIP: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) (owner: 10Divec) [11:45:31] 10VisualEditor, 10WikiEditor, 10Browser-Support-Google-Chrome: Minoredit accesskey conflicts (not working) on Chrome - https://phabricator.wikimedia.org/T230097 (10Aklapper) @Perhelion: What is "bug report (window)"? No, nobody "is working against" so no need for accusation. One can also talk without being W... [11:46:57] 10VisualEditor, 10MediaWiki-Page-editing: Alt-Shift-V is used for two different things on sr.wp - https://phabricator.wikimedia.org/T230854 (10Aklapper) Hi @MiljanSimonovic, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Could you please provide clear steps to reproduce the p... [11:52:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: v2 toolbar shows disabled edit tools on first load, then never again - https://phabricator.wikimedia.org/T230807 (10Esanders) >>! In T230807#5425175, @DLynch wrote: > That screenshot does also remind me that we should, perhaps, hide the too... [12:00:25] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): v2 toolbar shows disabled edit tools on first load, then never again - https://phabricator.wikimedia.org/T230807 (10Esanders) a:03DLynch [12:03:08] (03CR) 10Esanders: [C: 04-1] MobileArticleTarget: v1 of toolbar refresh (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [12:05:05] 10VisualEditor, 10MediaWiki-Page-editing: Alt-Shift-V is used for two different things on sr.wp - https://phabricator.wikimedia.org/T230854 (10Lejonel) [12:05:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing: Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox - https://phabricator.wikimedia.org/T54701 (10Lejonel) [12:06:18] 10VisualEditor, 10MediaWiki-Page-editing: Alt-Shift-V is used for two different things on sr.wp - https://phabricator.wikimedia.org/T230854 (10MiljanSimonovic) Thanks for a quick answer, @Aklapper. The problem occurs when both code editing and Visual editor are turned on (when there are options Edit and Edit s... [12:07:21] (03CR) 10Esanders: [C: 04-1] Prevent RangeState tests from hanging QUnit via a huge diff (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) (owner: 10Divec) [12:07:57] (03CR) 10Esanders: [C: 04-1] Prevent RangeState tests from hanging QUnit via a huge diff (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) (owner: 10Divec) [12:16:39] (03CR) 10Divec: Prevent RangeState tests from hanging QUnit via a huge diff (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) (owner: 10Divec) [12:17:06] (03PS3) 10Divec: Prevent RangeState tests from hanging QUnit via a huge diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) [12:22:20] (03CR) 10Esanders: [C: 03+2] Prevent RangeState tests from hanging QUnit via a huge diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) (owner: 10Divec) [12:25:30] 10VisualEditor, 10WikiEditor, 10Browser-Support-Google-Chrome: Minoredit accesskey conflicts (not working) on Chrome - https://phabricator.wikimedia.org/T230097 (10Perhelion) Hey @Aklapper, there is no open bug report because Chrome seems not to have one (only Chromium). As suggested (from this feedback wind... [12:35:18] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Regression: Excessive paragraph padding in MF editor save dialog - https://phabricator.wikimedia.org/T230274 (10Esanders) In both this and T217102, it looks like the desired behaviour is to have a panel with fixed padding all the way around, in which... [12:43:24] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Regression: Excessive paragraph padding in MF editor save dialog - https://phabricator.wikimedia.org/T230274 (10Esanders) Indeed in the example given in T217102 (the talk page add-topic form), the whole panel would have padding of 12px, were it not fo... [12:47:49] (03PS5) 10Divec: WIP: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) [12:48:32] (03PS6) 10Divec: WIP: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) [12:57:58] 10VisualEditor, 10MobileFrontend, 10Patch-For-Review, 10Regression: Excessive paragraph padding in MF editor save dialog - https://phabricator.wikimedia.org/T230274 (10Esanders) Here is the form in question: {F30052315} The alignment form is a result of some inconsistently targeted selectors: * The three... [13:09:15] (03CR) 10Esanders: [C: 03+2] Consider focus, not anchor, in ve.ce.RangeState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529957 (owner: 10Divec) [13:11:22] (03Merged) 10jenkins-bot: Consider focus, not anchor, in ve.ce.RangeState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529957 (owner: 10Divec) [13:12:18] (03Merged) 10jenkins-bot: Prevent RangeState tests from hanging QUnit via a huge diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) (owner: 10Divec) [13:13:21] (03CR) 10jenkins-bot: Consider focus, not anchor, in ve.ce.RangeState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529957 (owner: 10Divec) [13:14:13] (03CR) 10jenkins-bot: Prevent RangeState tests from hanging QUnit via a huge diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531468 (https://phabricator.wikimedia.org/T230814) (owner: 10Divec) [13:33:25] (03PS1) 10Jforrester: Update VE core submodule to master (3a7bad9c0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531488 (https://phabricator.wikimedia.org/T230814) [15:08:35] (03PS1) 10Divec: Fix issue URL typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531512 [15:27:42] (03CR) 10Jforrester: [C: 03+2] MobileArticleTarget: Tweak styling for editor switcher [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/529131 (owner: 10Bartosz Dziewoński) [16:05:26] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (3a7bad9c0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531488 (https://phabricator.wikimedia.org/T230814) (owner: 10Jforrester) [16:06:40] 10Editing-team, 10Analytics: Deletion of limn-edit-data repository - https://phabricator.wikimedia.org/T228982 (10Neil_P._Quinn_WMF) @fdans I checked it over and we can archive/delete it—there's nothing we need to keep. [16:07:33] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Regression, 10VisualEditor (Current work): Long link descriptions abruptly truncated in link context - https://phabricator.wikimedia.org/T230267 (10matmarex) [16:07:35] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10VisualEditor (Current work): Change back action icon in toolbar to "<" from "x" - https://phabricator.wikimedia.org/T230058 (10matmarex) [16:07:37] 10VisualEditor-MediaWiki, 10Editing QA, 10VisualEditor (Current work): Scroll animation when loading the visual editor no longer scrolls to the right place - https://phabricator.wikimedia.org/T230237 (10matmarex) [16:07:40] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10VisualEditor (Current work): HTML entities in section headings show on a separate line in mobile visual editor - https://phabricator.wikimedia.org/T229744 (10matmarex) [16:17:15] 10Editing-team, 10Analytics: Deletion of limn-edit-data repository - https://phabricator.wikimedia.org/T228982 (10Nuria) Repo can be archived then, tagging #release-engineering-team to archive this repo [16:43:13] (03PS8) 10DLynch: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) [16:55:15] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review: Split TreeModifier into a tree diff generator and tree diff applier - https://phabricator.wikimedia.org/T215567 (10JTannerWMF) [16:55:49] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review: Split TreeModifier into a tree diff generator and tree diff applier - https://phabricator.wikimedia.org/T215567 (10JTannerWMF) This will go out on Sept 10th but merged on the 4th of Sept for Testing [16:58:57] (03CR) 10DLynch: MobileArticleTarget: v1 of toolbar refresh (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [17:00:45] (03Merged) 10jenkins-bot: MobileArticleTarget: Tweak styling for editor switcher [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/529131 (owner: 10Bartosz Dziewoński) [17:03:30] 10VisualEditor, 10Parsoid-Edit-Support: New paragraph before section heading becomes line break - https://phabricator.wikimedia.org/T215002 (10JTannerWMF) Moving this to External due to Parsing working on it whenever they lift the feature freeze [17:04:40] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10Whatamidoing-WMF) I can reproduce this, in plain vanilla Chrome Version 75.0.3770.142... [17:14:12] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): When creating a "New section", the text for the body is not properly aligned with the rest of the page - https://phabricator.wikimedia.org/T222217 (10Whatamidoing-WMF) Also in a Chrome incognito window while logged in to https://en.wik... [17:20:51] 10VisualEditor-Edit Cards , 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Skipped QA, 10VisualEditor (Current work): Implement additional instrumentation for Edit Cards v2 - https://phabricator.wikimedia.org/T222396 (10matmarex) [17:21:20] 10VisualEditor-Edit Cards , 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Skipped QA, 10VisualEditor (Current work): Instrument revised *citation* edit workflows - https://phabricator.wikimedia.org/T221305 (10matmarex) [17:22:30] (03CR) 10jenkins-bot: MobileArticleTarget: Tweak styling for editor switcher [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/529131 (owner: 10Bartosz Dziewoński) [17:29:10] (03Merged) 10jenkins-bot: Update VE core submodule to master (3a7bad9c0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531488 (https://phabricator.wikimedia.org/T230814) (owner: 10Jforrester) [17:30:33] 10VisualEditor-Edit Cards , 10Product-Analytics, 10VisualEditor (Current work): Edit Cards v2: instrumentation post-deployment data checks - https://phabricator.wikimedia.org/T227354 (10JTannerWMF) Just moving this to the proper column on the VE workboard [17:31:32] (03CR) 10jenkins-bot: Update VE core submodule to master (3a7bad9c0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531488 (https://phabricator.wikimedia.org/T230814) (owner: 10Jforrester) [17:50:20] 10VisualEditor-DataModel, 10OOjs, 10Patch-For-Review, 10VisualEditor (Current work): EventEmitters must behave appropriately if a handler raises an exception - https://phabricator.wikimedia.org/T185546 (10Krinkle) >>! In T185546#5405246, @dchan wrote: > Ok, the VE engineers have now examined many different... [17:52:43] 10VisualEditor, 10GrowthExperiments, 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint): Help panel: "Get help with editing" button hides other components of the visual editor - https://phabricator.wikimedia.org/T219966 (10JTannerWMF) a:05Catrope→03Tgr [18:11:48] (03CR) 10Eranroz: [C: 04-1] "Thank you for working on this. I tested it manually (it doesn't have unitest) and it is just broken due to a minor issue." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [20:03:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MinervaNeue, 10Readers-Web-Backlog, and 2 others: [Bug] impossible to navigate back to article if start from hash fragment link - https://phabricator.wikimedia.org/T201852 (10matmarex) Okay, I took a shot. It works! Turns out we also need to do this when... [20:07:42] (03PS2) 10Bartosz Dziewoński: [WIP] ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) [21:30:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MinervaNeue, 10Readers-Web-Backlog, and 2 others: [Bug] impossible to navigate back to article if start from hash fragment link - https://phabricator.wikimedia.org/T201852 (10Jdlrobson) 8 points is a bit outdated and from a time when we thought this would... [21:34:02] (03PS1) 10Bartosz Dziewoński: Remove redundant @method annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531569 [21:34:06] (03PS1) 10Bartosz Dziewoński: Remove redundant @method annotations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531570 [22:18:34] 10VisualEditor-Edit Cards , 10Product-Analytics, 10VisualEditor (Current work): Edit Cards v2: instrumentation post-deployment data checks - https://phabricator.wikimedia.org/T227354 (10MNeisler) Paired with @Neil_P._Quinn_WMF to confirm that the additional logging events are being logged correctly. We see t... [22:59:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MinervaNeue, 10Readers-Web-Backlog, and 3 others: [Bug] impossible to navigate back to article if start from hash fragment link - https://phabricator.wikimedia.org/T201852 (10matmarex) 05Open→03Resolved a:03matmarex \o/ [23:09:39] (03CR) 10Esanders: [C: 03+2] Remove redundant @method annotations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531570 (owner: 10Bartosz Dziewoński) [23:11:09] (03CR) 10Esanders: [C: 03+2] Remove redundant @method annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531569 (owner: 10Bartosz Dziewoński) [23:13:23] (03Merged) 10jenkins-bot: Remove redundant @method annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531569 (owner: 10Bartosz Dziewoński) [23:15:51] (03CR) 10jenkins-bot: Remove redundant @method annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531569 (owner: 10Bartosz Dziewoński) [23:27:58] (03Merged) 10jenkins-bot: Remove redundant @method annotations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531570 (owner: 10Bartosz Dziewoński) [23:30:29] (03CR) 10jenkins-bot: Remove redundant @method annotations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531570 (owner: 10Bartosz Dziewoński)