[00:33:55] (03PS3) 10Bartosz Dziewoński: [WIP] ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) [00:34:11] (03PS4) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) [00:36:42] (03PS5) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) [00:37:16] (03PS6) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Use errorformat=html when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526831 (https://phabricator.wikimedia.org/T229532) [07:47:30] 10VisualEditor-Edit Cards , 10Product-Analytics, 10VisualEditor (Current work): Edit Cards v2: instrumentation post-deployment data checks - https://phabricator.wikimedia.org/T227354 (10JTannerWMF) Thanks for getting on this so quickly @MNeisler and @Neil_P._Quinn_WMF ! [08:15:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531647 (owner: 10L10n-bot) [14:12:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) [14:39:55] 10Editing-team, 10Analytics, 10Cleanup: Deletion of limn-edit-data repository - https://phabricator.wikimedia.org/T228982 (10fdans) [15:12:44] (03PS20) 10Esanders: LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [15:41:05] 10VisualEditor, 10Product-Analytics: Some save success events do not contain a new revision ID - https://phabricator.wikimedia.org/T231024 (10Neil_P._Quinn_WMF) p:05Triage→03Low [15:42:30] 10VisualEditor, 10Product-Analytics: Some save success events do not contain a new revision ID - https://phabricator.wikimedia.org/T231024 (10Neil_P._Quinn_WMF) [15:42:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) [16:54:15] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10VisualEditor (Current work): Oversampling changes edit completion rate - https://phabricator.wikimedia.org/T227931 (10Neil_P._Quinn_WMF) [16:54:38] 10VisualEditor-MediaWiki-Mobile, 10Product-Analytics, 10VisualEditor (Current work): Oversampling changes edit completion rate - https://phabricator.wikimedia.org/T227931 (10Neil_P._Quinn_WMF) [16:54:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10Product-Analytics, 10Epic: Clean up the EditAttemptStep schema and its implementations - https://phabricator.wikimedia.org/T118063 (10Neil_P._Quinn_WMF) [17:14:34] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10DLynch) [17:56:55] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10Esanders) Stages we could instrument: * Click on the scanner button * Get a successful read OR close the dialog without a read As successful ISBN read automatically submits the Citoid search form,... [17:57:42] (03PS7) 10Divec: WIP: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) [17:58:19] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10Esanders) > what sort of things they scan (presumably: 99.9% books, but let's confirm that) The tool only reads ISBNs, which stands for International Standard **Book** Number[0], so... 0. https:/... [18:01:25] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10DLynch) Educational DVDs can get them too! Though I admit I didn’t bother to look up whether there’s any distinguishing characteristic in the code. [18:02:31] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10Esanders) Oh, interesting. Found this too https://www.isbn.org/faqs_isbn_eligibility [18:03:22] (03PS20) 10Divec: Split TreeModifier into a tree diff generator and tree diff applier [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/473380 (https://phabricator.wikimedia.org/T215567) [18:03:30] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10Esanders) I suppose we could log the ISBN itself for later analysis, but that may require some privacy considerations? [18:16:21] 10VisualEditor, 10Product-Analytics: Some save success events do not contain a new revision ID - https://phabricator.wikimedia.org/T231024 (10matmarex) Could these be null edits? Or are they already reported in some other way? [18:29:31] (03CR) 10Bartosz Dziewoński: [C: 03+2] Fix issue URL typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531512 (owner: 10Divec) [18:31:46] (03CR) 10Bartosz Dziewoński: "Can you clarify what this does?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/528197 (owner: 10Esanders) [18:31:51] (03Merged) 10jenkins-bot: Fix issue URL typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531512 (owner: 10Divec) [18:33:47] (03CR) 10jenkins-bot: Fix issue URL typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531512 (owner: 10Divec) [18:42:48] (03PS8) 10Divec: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/529739 (https://phabricator.wikimedia.org/T230325) [19:23:07] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (663b34056) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531740 [19:23:18] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (663b34056) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531740 (owner: 10Bartosz Dziewoński) [19:51:16] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Verified, 10VisualEditor (Current work): Keyboard and Edit Card show simultaneously when double-tapping link - https://phabricator.wikimedia.org/T229879 (10Ryasmeen) [19:54:03] (03Merged) 10jenkins-bot: Update VE core submodule to master (663b34056) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531740 (owner: 10Bartosz Dziewoński) [19:57:23] (03CR) 10jenkins-bot: Update VE core submodule to master (663b34056) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531740 (owner: 10Bartosz Dziewoński) [20:05:23] 10VisualEditor-MediaWiki, 10Editing QA, 10VisualEditor (Current work): Scroll animation when loading the visual editor no longer scrolls to the right place - https://phabricator.wikimedia.org/T230237 (10Ryasmeen) This seems to be not yet fixed on Beta, assuming it's about the alignment of the heading before... [20:18:11] 10VisualEditor-Edit Cards , 10Editing Design, 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Verified, 10VisualEditor (Current work): Edit Cards: Fix transition from link search dialog back to document/Edit Card after changing the target of an existing link. - https://phabricator.wikimedia.org/T228229 (10... [20:20:42] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10Verified, 10VisualEditor (Current work): New edit cards obscure content at the bottom of the page - https://phabricator.wikimedia.org/T227532 (10Ryasmeen) [20:26:05] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Editing QA, 10Design, 10VisualEditor (Current work): Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10Ryasmeen) @matmarex: If I understand correctly this issue is now obsolete with th... [20:27:56] 10VisualEditor-Edit Cards , 10Editing Design, 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Verified, 10VisualEditor (Current work): Edit Cards: Edit link label: default to cursor vs. whole text highlight - https://phabricator.wikimedia.org/T228227 (10Ryasmeen) [20:32:10] 10VisualEditor-DataModel, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Verified, 10VisualEditor (Current work): 'Change label' in link inspector broken when cursor is at end of link - https://phabricator.wikimedia.org/T225541 (10Ryasmeen) [20:38:51] 10VisualEditor-DataModel, 10Verified, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links - https://phabricator.wikimedia.org/T227241 (10Ryasmeen) [21:02:31] 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Verified, 10VisualEditor (Current work): New mobile link context doesn't work on single character links - https://phabricator.wikimedia.org/T226708 (10Ryasmeen) [22:12:04] (03PS21) 10Bartosz Dziewoński: LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [22:12:32] (03PS8) 10Bartosz Dziewoński: [PULL THROUGH] Mobile link label editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526232 (https://phabricator.wikimedia.org/T229431) (owner: 10Esanders) [22:13:58] (03CR) 10Bartosz Dziewoński: "I made some minor fixes for problems I noticed while testing:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526232 (https://phabricator.wikimedia.org/T229431) (owner: 10Esanders) [22:14:09] (03CR) 10Bartosz Dziewoński: [C: 03+2] LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [22:16:07] (03Merged) 10jenkins-bot: LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [22:18:02] (03CR) 10jenkins-bot: LinkAnnotationInspector: add a "label" field on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [22:28:42] (03PS9) 10Bartosz Dziewoński: Update VE core submodule to master (07687721b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526232 (https://phabricator.wikimedia.org/T229431) (owner: 10Esanders) [22:28:53] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (07687721b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526232 (https://phabricator.wikimedia.org/T229431) (owner: 10Esanders) [22:48:30] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Design, 10Skipped QA, 10VisualEditor (Current work): Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) @ryasmeen Indeed I'm not sure. There is definitely no "jump" anymore wh... [22:50:45] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 2 others: Show block notices on mobile visual editor - https://phabricator.wikimedia.org/T209599 (10matmarex) a:05Ryasmeen→03None This has been in prod... [22:51:03] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10Skipped QA, 10VisualEditor (Current work): Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors - https://phabricator.wikimedia.org/T220011 (10matmarex) a:03matmarex This has been in producti...