[00:49:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (07687721b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526232 (https://phabricator.wikimedia.org/T229431) (owner: 10Esanders) [00:51:52] (03CR) 10jenkins-bot: Update VE core submodule to master (07687721b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/526232 (https://phabricator.wikimedia.org/T229431) (owner: 10Esanders) [00:59:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile page goes blank briefly when loading VE the second time. - https://phabricator.wikimedia.org/T230552 (10matmarex) I tested again on master and I can reproduce it when looking more closely. It doesn't quite go blank, //but// the read mode content flashes f... [01:07:10] 10VisualEditor-MediaWiki, 10Editing QA, 10VisualEditor (Current work): Scroll animation when loading the visual editor no longer scrolls to the right place - https://phabricator.wikimedia.org/T230237 (10matmarex) @Ryasmeen I think that's a separate issue, probably the same as Ed reported in T230552. I slowe... [01:17:00] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile page goes blank briefly when loading VE the second time. - https://phabricator.wikimedia.org/T230552 (10matmarex) This is because in VisualEditorOverlay, we initialize the target after the parent show() method is called – so the overlay is shown with no c... [01:23:27] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Test edit cards v3 at Wikimania - https://phabricator.wikimedia.org/T230213 (10matmarex) [01:23:29] 10VisualEditor: Link inspector shows duplicate results for single word articles - https://phabricator.wikimedia.org/T230819 (10matmarex) [01:23:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: On slower mobile devices, pressing 'next' in the VE toolbar doesn't visually respond immediately so users double tap which causes a publish - https://phabricator.wikimedia.org/T230816 (10matmarex) [01:23:33] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Showing the v2 toolbar with anon edit warning could be confusing - https://phabricator.wikimedia.org/T230806 (10matmarex) [01:23:35] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Link dialog: change "Label" field title to "Text" - https://phabricator.wikimedia.org/T230794 (10matmarex) [01:23:49] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Link dialog: change "Label" field title to "Text" - https://phabricator.wikimedia.org/T230794 (10matmarex) [01:23:51] 10VisualEditor-Mobile-UsabilityImprovements, 10VisualEditor (Current work): Implement Edit Cards v3 - https://phabricator.wikimedia.org/T229831 (10matmarex) [01:26:06] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Test edit cards v3 at Wikimania - https://phabricator.wikimedia.org/T230213 (10matmarex) Peter and Ed shared the results internally: https://docs.google.com/document/d/15witi5hSalAoGTwzPz3EeQBDICQbT4kTFA_eMRPyOVM/edit (I wasn't involved, just lin... [01:30:46] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Regression, 10VisualEditor (Current work): Long link descriptions abruptly truncated in link context - https://phabricator.wikimedia.org/T230267 (10matmarex) [01:30:46] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix link label ellipses on iOS - https://phabricator.wikimedia.org/T230493 (10matmarex) [01:31:06] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Regression, 10VisualEditor (Current work): Long link descriptions abruptly truncated in link context - https://phabricator.wikimedia.org/T230267 (10matmarex) [01:31:23] 10VisualEditor-Mobile-UsabilityImprovements, 10VisualEditor (Current work): Implement Edit Cards v3 - https://phabricator.wikimedia.org/T229831 (10matmarex) [01:31:26] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix link label ellipses on iOS - https://phabricator.wikimedia.org/T230493 (10matmarex) [01:31:28] 10VisualEditor-MediaWiki, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Regression, 10VisualEditor (Current work): Long link descriptions abruptly truncated in link context - https://phabricator.wikimedia.org/T230267 (10matmarex) [01:39:02] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): Do not autofocus any field in link dialog on Android - https://phabricator.wikimedia.org/T230216 (10matmarex) [01:39:05] 10VisualEditor-MediaWiki-Mobile, 10Editing QA, 10VisualEditor (Current work): Remove link label edit pencil from edit cards v3 - https://phabricator.wikimedia.org/T230214 (10matmarex) [01:39:07] 10VisualEditor-MediaWiki-Mobile, 10Editing Design, 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10VisualEditor (Current work): v3: Implement form-based approach to editing a link's label - https://phabricator.wikimedia.org/T229431 (10matmarex) [04:44:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531792 (owner: 10L10n-bot) [06:48:44] (03CR) 10jenkins-bot: build: Updating eslint-utils to 1.4.2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/531813 (owner: 10Libraryupgrader) [07:05:09] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10Schnark) >>! In T231031#5432337, @Esanders wrote: >> what sort of things they scan (presumably: 99.9% books, but let's confirm that) > > The tool only reads ISBNs, which stands for International S... [07:55:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531857 (owner: 10L10n-bot) [09:36:56] (03CR) 10jenkins-bot: build: Updating eslint-utils to 1.4.2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531881 (owner: 10Libraryupgrader) [10:13:25] 10Citoid, 10VisualEditor: Instrument usage of ISBN barcode scanner - https://phabricator.wikimedia.org/T231031 (10Esanders) >>! In T231031#5433203, @Schnark wrote: > The scanner reads all EANs, so you could log all stuff before the `/^97[89]/` filter to see whether there are users trying to cite something from... [10:18:14] 10WikiEditor, 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10Regression: WikiEditor insert file dialog broken - https://phabricator.wikimedia.org/T230078 (10eranroz) I see somewhat similar issue in hewiki It have exception on access to whitespace which is undefined ("pre: whitespace[ 0 ] + '[[',") when pre... [10:22:49] (03CR) 10Esanders: [C: 04-2] "Replacing WIP status with -2 because WIP removes it from a bunch of listings :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [10:22:57] (03PS9) 10Esanders: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [10:42:12] 10WikiEditor, 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10Regression: WikiEditor insert file dialog broken - https://phabricator.wikimedia.org/T230078 (10eranroz) Root cause the issue - some wikis have gadgets to override the open function of file dialog... https://he.wikipedia.org/w/index.php?title=%D7%... [10:44:24] (03CR) 10jerkins-bot: [V: 04-1] MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) (owner: 10DLynch) [13:09:08] (03PS4) 10Esanders: [POC] Server side model->DOM conversion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462178 [13:09:10] (03PS1) 10Esanders: Utils: Move ve.supportSelectionExtend to client-only utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531926 [13:09:12] (03PS1) 10Esanders: ve.dm.Change: Remove no-longer used doc argument from #deserialize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531927 [13:09:14] (03PS1) 10Esanders: ve.dm.Change: Fix serialize to be recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531928 [13:09:54] (03CR) 10Divec: [C: 03+2] Utils: Move ve.supportSelectionExtend to client-only utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531926 (owner: 10Esanders) [13:10:44] (03CR) 10Divec: [C: 03+2] ve.dm.Change: Remove no-longer used doc argument from #deserialize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531927 (owner: 10Esanders) [13:12:00] (03Merged) 10jenkins-bot: Utils: Move ve.supportSelectionExtend to client-only utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531926 (owner: 10Esanders) [13:12:02] (03CR) 10Divec: [C: 03+2] ve.dm.Change: Fix serialize to be recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531928 (owner: 10Esanders) [13:12:42] (03Merged) 10jenkins-bot: ve.dm.Change: Remove no-longer used doc argument from #deserialize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531927 (owner: 10Esanders) [13:13:52] (03Merged) 10jenkins-bot: ve.dm.Change: Fix serialize to be recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531928 (owner: 10Esanders) [13:16:02] (03CR) 10jenkins-bot: Utils: Move ve.supportSelectionExtend to client-only utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531926 (owner: 10Esanders) [13:16:12] (03CR) 10jenkins-bot: ve.dm.Change: Fix serialize to be recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531928 (owner: 10Esanders) [13:16:14] (03CR) 10jenkins-bot: ve.dm.Change: Remove no-longer used doc argument from #deserialize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531927 (owner: 10Esanders) [13:33:01] (03PS1) 10Jforrester: Update VE core submodule to master (7c1d4680d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531932 [14:01:14] (03PS1) 10Esanders: ve.ce.Document: Throw more errors in getNodeAndOffset and catch in surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) [14:04:46] (03CR) 10Esanders: [C: 04-1] ve.ce.Document: Throw more errors in getNodeAndOffset and catch in surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) (owner: 10Esanders) [14:07:54] (03PS2) 10Esanders: ve.ce.Surface: Don't request offsets that are out of bounds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) [14:11:26] (03PS3) 10Esanders: ve.ce.Surface: Don't request offsets that are out of bounds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531933 (https://phabricator.wikimedia.org/T231085) [14:45:53] 10TemplateData, 10VisualEditor, 10TemplateStyles: Submitting an edit request for the Selman Akbulut article creates a template that does not exist - https://phabricator.wikimedia.org/T231088 (10Ylevental) [16:12:57] 10VisualEditor, 10VisualEditor-ContentEditable: Changing the number of child nodes in a template rendering moves the cursor - https://phabricator.wikimedia.org/T231094 (10Esanders) [16:24:18] (03PS1) 10Esanders: GeneratedContentNode: Re-apply model selection if DOM node count changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/531945 (https://phabricator.wikimedia.org/T231094) [16:25:50] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Changing the number of child nodes in a template rendering moves the cursor - https://phabricator.wikimedia.org/T231094 (10Esanders) [16:26:33] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Changing the number of child nodes in a template rendering moves the cursor - https://phabricator.wikimedia.org/T231094 (10Esanders) [16:55:13] 10VisualEditor, 10Growth-Team, 10StructuredDiscussions, 10User-Ryasmeen: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109 (10Esanders) 05Open→03Resolved a:03Esanders Appears fixed. [16:59:42] (03PS10) 10DLynch: MobileArticleTarget: v1 of toolbar refresh [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/527452 (https://phabricator.wikimedia.org/T211789) [17:15:42] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review: Changing the number of child nodes in a template rendering moves the cursor - https://phabricator.wikimedia.org/T231094 (10Esanders) [20:49:08] 10VisualEditor, 10Continuous-Integration-Config, 10User-Ryasmeen: VisualEditor-MediaWiki: Don't be "smart" about only running jsduck on JS file changes - https://phabricator.wikimedia.org/T155862 (10hashar) 05Open→03Resolved a:03Jdforrester-WMF Got solved somehow at some point. We no more run jsduck an... [22:48:07] (03CR) 10Bartosz Dziewoński: [C: 03+2] Update VE core submodule to master (7c1d4680d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/531932 (owner: 10Jforrester) [23:27:25] 10VisualEditor: No edit pencil on edit card for links - https://phabricator.wikimedia.org/T231125 (10Ryasmeen) [23:41:20] 10VisualEditor: No edit pencil on edit cards when tapping on that node for the second time - https://phabricator.wikimedia.org/T231125 (10Ryasmeen) [23:42:41] 10VisualEditor: No edit pencil on edit cards when tapping on that node for the second time - https://phabricator.wikimedia.org/T231125 (10Ryasmeen) This actually happens for all cases when you close the edit card and tap again to reopen it and also immediately after adding a link.